Antoine du Hamel
78962d1ca1
doc: mark readline promise implementation as experimental
...
Refs: https://github.com/nodejs/node/pull/37947#issuecomment-921538713
PR-URL: https://github.com/nodejs/node/pull/40211
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-09-27 17:53:15 +00:00
Gary Ho
8037d1749a
doc: fix example of crypto.generateKeySync
...
doc: fix the example of crypto.generateKeySync
The "options" argument must be an object.
PR-URL: https://github.com/nodejs/node/pull/40225
Reviewed-By: Qingyu Deng <i@ayase-lab.com >
Reviewed-By: Harshitha K P <harshitha014@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2021-09-27 15:58:08 +02:00
dr-js
4b030d0573
doc: deprecate (doc-only) http abort related
...
Refs: https://github.com/nodejs/node/pull/36641
Refs: https://github.com/nodejs/node/issues/36617#issuecomment-751443964
Documentation-only deprecate `.aborted` property and `'abort'`,
`'aborted'` event in `http`, and suggest using the corresponding
Stream API instead.
Co-authored-by: Michaël Zasso <targos@protonmail.com >
Co-authored-by: Rich Trott <rtrott@gmail.com >
Co-authored-by: Robert Nagy <ronagy@icloud.com >
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/36670
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2021-09-27 12:43:58 +02:00
Artur K
44b173e013
http: use 0 as default for requests limit
...
PR-URL: https://github.com/nodejs/node/pull/40192
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
2021-09-27 11:45:24 +02:00
XadillaX
0ee0ed12c1
benchmark: add util.toUSVString()'s benchmark
...
PR-URL: https://github.com/nodejs/node/pull/40203
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
2021-09-27 17:24:19 +08:00
thunder-coding
43291b98ed
deps: update nghttp2 to v1.45.1
...
PR-URL: https://github.com/nodejs/node/pull/40206
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
2021-09-27 02:34:00 +00:00
Jiawen Geng
35d9222f30
build: limit update authors CI scope
...
PR-URL: https://github.com/nodejs/node/pull/40219
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: Qingyu Deng <i@ayase-lab.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-09-27 00:28:16 +00:00
MrBBot
b381bed10c
events: allow dispatch many times without listener
...
Fast path for EventTarget dispatch with no listeners didn't reset
kIsBeingDispatched flag, meaning same event couldn't be dispatched
multiple times.
PR-URL: https://github.com/nodejs/node/pull/39772
Refs: https://github.com/nodejs/node/pull/39395
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2021-09-26 21:09:06 +02:00
Darshan Sen
95d16564f0
src: remove usage of AllocatedBuffer from udp_wrap.cc
...
Signed-off-by: Darshan Sen <darshan.sen@postman.com >
PR-URL: https://github.com/nodejs/node/pull/40151
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2021-09-26 14:47:38 +00:00
Voltrex
256fe21045
lib: use validateArray
...
The `validateArray()` validator could be used to cleanup validation
and keep consistency.
PR-URL: https://github.com/nodejs/node/pull/39774
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
Reviewed-By: Qingyu Deng <i@ayase-lab.com >
2021-09-26 11:46:14 +00:00
Christian Clauss
b25a73f26a
build: pass a tuple of alternatives to str.endswith()
...
https://docs.python.org/3/library/stdtypes.html#str.endswith
One function call should be faster than three function calls per file.
PR-URL: https://github.com/nodejs/node/pull/40017
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Shingo Inoue <leko.noor@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-09-26 10:59:21 +02:00
XadillaX
0e561de643
src: move ToUSVString() to node_util.cc
...
Since `toUSVString()` was exposed in `util` as a public API, not only
for internal `url` any more.
PR-URL: https://github.com/nodejs/node/pull/40204
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
2021-09-26 16:57:47 +08:00
Michaël Zasso
281607d453
typings: define types for symbols binding
...
PR-URL: https://github.com/nodejs/node/pull/40143
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-09-26 10:42:11 +02:00
Michaël Zasso
0eb3420feb
typings: define types for worker and messaging bindings
...
PR-URL: https://github.com/nodejs/node/pull/40143
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-09-26 10:42:07 +02:00
Clément Nardi
2b02d2f844
doc: update fs.watchFile doc
...
The current wording suggests to compare Date objects, which won't work.
PR-URL: https://github.com/nodejs/node/pull/40134
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2021-09-26 08:36:22 +00:00
Rich Trott
a2ed30b636
meta: add .mailmap entry for kunalspathak
...
Use mailmap entry to consolidate duplicate entries in AUTHORS.
PR-URL: https://github.com/nodejs/node/pull/40202
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2021-09-26 06:56:40 +00:00
Rich Trott
85811d1ade
tools: fix lint-md autolinking
...
Update a transitive dependency in lint-md to fix an autolink bug in the
formatter that causes a lot of our files (particularly changelogs) to be
misformatted when run through the automatic formatter.
Refs: 7555d45f9a
PR-URL: https://github.com/nodejs/node/pull/40181
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
2021-09-25 10:23:30 -07:00
Rich Trott
6077473111
tools: implement markdown formatting
...
Markdown formatter is now available via `mark format-md` (or
`vcbuild format-md` on Windows).
PR-URL: https://github.com/nodejs/node/pull/40181
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
2021-09-25 10:23:20 -07:00
Gerhard Stöbich
b0ef0807e0
doc: add version when diagnostics_channel APIs were added
...
Add a yaml section to document when diagnostics_channel APIs were
introduced.
PR-URL: https://github.com/nodejs/node/pull/40208
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2021-09-25 16:11:27 +00:00
Michaël Zasso
ae876d420c
doc: update minimum supported FreeBSD to 12.2
...
FreeBSD 11 goes out of support on 2021-09-30.
FreeBSD 12.1 is not supported since 2021-01-31.
PR-URL: https://github.com/nodejs/node/pull/40179
Refs: https://en.wikipedia.org/wiki/FreeBSD_version_history#Version_history
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-09-25 08:14:55 -07:00
Antoine du Hamel
026bd82e30
fs: add stream utilities to FileHandle
...
PR-URL: https://github.com/nodejs/node/pull/40009
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-09-25 07:57:31 -07:00
Shelley Vohr
17bb7b2936
crypto: handle initEDRaw pkey failure
...
PR-URL: https://github.com/nodejs/node/pull/40188
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-09-25 07:50:12 -07:00
Darshan Sen
5ba7fbb731
src,crypto: eliminate code duplication between StatelessDiffieHellman*
...
Signed-off-by: Darshan Sen <darshan.sen@postman.com >
PR-URL: https://github.com/nodejs/node/pull/40084
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
2021-09-25 07:46:06 -07:00
Rebhi Alfa
25ffd39f33
doc: fix typo in 'maxHeaderSize'
...
PR-URL: https://github.com/nodejs/node/pull/40164
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-09-25 07:41:20 -07:00
Voltrex
4157317f4c
console: use validators for consistency
...
The usage of more validators could clean up validation and keep
consistency.
PR-URL: https://github.com/nodejs/node/pull/39812
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-09-25 07:38:24 -07:00
m3m0ry
5134b0e05c
doc: fix buffer api example code's token error
...
Buffer's Blob api example code has some token error
PR-URL: https://github.com/nodejs/node/pull/40125
Reviewed-By: Qingyu Deng <i@ayase-lab.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-09-25 07:30:40 -07:00
Rich Trott
8d83c47029
tools: re-implement lint-md without unified-args
...
`unified-args` ignores settings in the preset, expecting them to be in
remarkrc files or passed on the command line instead. Realizing that
we always send the same configuration options via the command-line
anyway, this removes `unified-args`. This means the preset settings are
now respected and it removes nearly 30000 lines of code in the resulting
rollup file.
I wasn't sure I was going to want to keep rollup so I started
re-implementing this without it, but ended up putting a minimal rollup
back as it still saves about 90000 lines of code vs. checking in
`node_modules`.
PR-URL: https://github.com/nodejs/node/pull/40180
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-09-25 03:51:52 +00:00
Pancake
80065865be
console: avoid unnecessary variables
...
By using destruction re-naming useless variables were eliminated.
PR-URL: https://github.com/nodejs/node/pull/40183
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Khaidi Chu <i@2333.moe >
2021-09-24 08:47:07 +00:00
xuchaobei
5f3c1b68d3
doc: fix typo in async_hooks.md
...
PR-URL: https://github.com/nodejs/node/pull/40187
Reviewed-By: Qingyu Deng <i@ayase-lab.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-09-24 10:43:17 +02:00
Daniel Bevenius
3f619407fe
src: allow CAP_NET_BIND_SERVICE in SafeGetenv
...
This commit updates SafeGetenv to check if the current process has the
effective capability cap_net_bind_service set, and if so allows
environment variables to be read.
The motivation for this change is a use-case where Node is run in a
container, and the is a requirement to be able to listen to ports
below 1024. This is done by setting the capability of
cap_net_bind_service. In addition there is a need to set the
environment variable `NODE_EXTRA_CA_CERTS`. But currently this
environment variable will not be read when the capability has been set
on the executable.
PR-URL: https://github.com/nodejs/node/pull/37727
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2021-09-24 05:56:43 +02:00
Rich Trott
8e84d566ea
meta: add mailmap entry for ralphtheninja
...
PR-URL: https://github.com/nodejs/node/pull/40153
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com >
2021-09-23 20:27:17 -07:00
Rich Trott
fd86dad5a0
meta: update mailmap for LakshmiSwethaG
...
LakshmiSwethaG's name appears twice in AUTHORS. Use .mailmap to map the
various email addresses to a single one.
PR-URL: https://github.com/nodejs/node/pull/40172
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-09-23 14:09:43 +00:00
Rich Trott
18e527c32f
build: add --no-user for pip commands in Makefile
...
I ran into "Cannot combine --user and --target" in an environment and
adding --no-user seemed to fix it.
Refs: https://stackoverflow.com/a/67259534/436641
PR-URL: https://github.com/nodejs/node/pull/40169
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Christian Clauss <cclauss@me.com >
2021-09-23 14:09:35 +00:00
SURYAPRATAP SINGH SURYAVANSHI
c7da13c7c4
build: fix "test-internet.yml" workflows
...
PR-URL: https://github.com/nodejs/node/pull/40177
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-09-22 15:30:57 -07:00
Rich Trott
51d2623034
tools: update remark-preset-lint-node to 3.1.0
...
Update remark-preset-lint-node from 3.0.1 to 3.1.0. This is a necessary
step before we can use the lint preset to format markdown files.
PR-URL: https://github.com/nodejs/node/pull/40166
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-09-22 22:28:46 +00:00
Evan Lucas
c89d519528
doc: make version picker usable on mobile
...
This makes the version picker usable on mobile devices.
Previously, the version picker was difficult to select from. This
change makes the #gtoc > ul > li elements have a display
of `block` instead of `inline`.
PR-URL: https://github.com/nodejs/node/pull/39958
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is >
2021-09-22 22:08:33 +00:00
Rich Trott
24cc239cad
tools: fix find-inactive-collaborators for recent README change
...
I missed this change in 420cdc7cf9 .
PR-URL: https://github.com/nodejs/node/pull/40163
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-09-22 21:24:28 +00:00
Beth Griggs
8d5675e3fe
2021-09-22, Version 16.10.0 (Current)
...
Notable changes:
crypto:
* (SEMVER-MINOR) add rsa-pss keygen parameters (Filip Skokan) https://github.com/nodejs/node/pull/39927
doc:
* add Ayase-252 to collaborators (Qingyu Deng) https://github.com/nodejs/node/pull/40078
fs:
* (SEMVER-MINOR) make `open` and `close` stream override optional when unused (Antoine du Hamel) https://github.com/nodejs/node/pull/40013
http:
* (SEMVER-MINOR) limit requests per connection (Artur K) https://github.com/nodejs/node/pull/40082
src:
* (SEMVER-MINOR) add --no-global-search-paths cli option (Cheng Zhao) https://github.com/nodejs/node/pull/39754
* (SEMVER-MINOR) add option to disable global search paths (Cheng Zhao) https://github.com/nodejs/node/pull/39754
* (SEMVER-MINOR) make napi_create_reference accept symbol (JckXia) https://github.com/nodejs/node/pull/39926
stream:
* (SEMVER-MINOR) add signal support to pipeline generators (Robert Nagy) https://github.com/nodejs/node/pull/39067
PR-URL: https://github.com/nodejs/node/pull/40175
2021-09-22 21:38:17 +01:00
Luigi Pinca
e1bca102a7
doc: fix typos in http.md
...
PR-URL: https://github.com/nodejs/node/pull/40161
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2021-09-22 20:10:26 +02:00
Guilherme Bernal
61df3d88a7
crypto: don't call callback twice in case crypto.randomBytes fails
...
PR-URL: https://github.com/nodejs/node/pull/40157
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
2021-09-22 10:01:12 +02:00
Guy Bedford
36e2ffe6dc
module: subpath folder mappings EOL
...
PR-URL: https://github.com/nodejs/node/pull/40121
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2021-09-21 23:15:02 -07:00
Rich Trott
0991dfcece
doc: add blank line between comments
...
Upcoming remark-based formatting/linting will add a blank line between
comments in markdown. This is in preparation for that change.
PR-URL: https://github.com/nodejs/node/pull/40160
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-09-21 18:40:04 -07:00
Rich Trott
5ca5499c87
doc: update markdown files in src for upcoming linting/formatting
...
PR-URL: https://github.com/nodejs/node/pull/40159
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Harshitha K P <harshitha014@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-09-21 17:04:06 -07:00
Rich Trott
a6a5d4bda0
doc: update benchmarks README.md for upcoming linting/formatting
...
PR-URL: https://github.com/nodejs/node/pull/40158
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-09-21 17:02:07 -07:00
Rich Trott
f4a350da85
doc: prepare markdown file for upcoming formatting/linting
...
PR-URL: https://github.com/nodejs/node/pull/40156
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-09-21 17:00:23 -07:00
Rich Trott
0c95dead55
doc: update tools .md files for upcoming lint/formatting
...
Looks like only one .md file in `tools` needs to be changed.
PR-URL: https://github.com/nodejs/node/pull/40155
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-09-21 16:58:58 -07:00
Michaël Zasso
f367af4434
tools: extend default yamllint config
...
PR-URL: https://github.com/nodejs/node/pull/40150
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-09-21 17:03:51 +00:00
Rich Trott
549f96889a
doc: update markdown formatting for *.md files
...
Fix formatting that will change when run through upcoming remark preset.
PR-URL: https://github.com/nodejs/node/pull/40154
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2021-09-21 15:37:19 +00:00
Node.js GitHub Bot
d05cca94ea
meta: update AUTHORS
...
PR-URL: https://github.com/nodejs/node/pull/40148
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2021-09-21 05:55:28 -07:00
RISHABH BUDHIRAJA
479658ba98
doc: changes default values for fs.read fns
...
PR-URL: https://github.com/nodejs/node/pull/39163
Fixes: https://github.com/nodejs/node/issues/39034
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com >
Reviewed-By: Qingyu Deng <i@ayase-lab.com >
2021-09-21 08:43:45 +00:00