OSSForks/react
1
0
Fork 0
mirror of https://github.com/zebrajr/react.git synced 2026-01-15 12:15:22 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Merge branch 'fix-input-number-in-props' of https://github.com/koba04/react-devtools-experimental into koba04-fix-input-number-in-props

Browse Source
This commit is contained in:
Brian Vaughn
2019-07-19 09:16:26 -07:00
parent 0abaefb7c2 41c00cb0cb
commit f0a4b2f8e8
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/devtools/views/Components/EditableValue.js
View File

@@ -33,8 +33,6 @@ export default function EditableValue({
if (dataType === 'boolean') {
setEditableValue(target.checked);
overrideValueFn(path, target.checked);
} else if (dataType === 'number') {
setEditableValue(parseFloat(target.value));
} else {
setEditableValue(target.value);
}
@@ -60,7 +58,11 @@ export default function EditableValue({
const { key } = event;
if (key === 'Enter') {
overrideValueFn(path, editableValue);
if (dataType === 'number') {
overrideValueFn(path, parseFloat(editableValue));
} else {
overrideValueFn(path, editableValue);
}
// Don't reset the pending change flag here.
// The inspected fiber won't be updated until after the next "inspectElement" message.
@@ -70,7 +72,7 @@ export default function EditableValue({
setHasPendingChanges(false);
}
},
[path, editableValue, overrideValueFn, value]
[path, editableValue, overrideValueFn, value, dataType]
);
// Render different input types based on the dataType