From 41c00cb0cb0920e7d3ae1a1c0bb984e9d6a0f565 Mon Sep 17 00:00:00 2001 From: Toru Kobayashi Date: Sun, 14 Jul 2019 23:11:08 +0900 Subject: [PATCH] fix to input a number value to props --- src/devtools/views/Components/EditableValue.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/devtools/views/Components/EditableValue.js b/src/devtools/views/Components/EditableValue.js index 23e35c9679..09b2893a06 100644 --- a/src/devtools/views/Components/EditableValue.js +++ b/src/devtools/views/Components/EditableValue.js @@ -33,8 +33,6 @@ export default function EditableValue({ if (dataType === 'boolean') { setEditableValue(target.checked); overrideValueFn(path, target.checked); - } else if (dataType === 'number') { - setEditableValue(parseFloat(target.value)); } else { setEditableValue(target.value); } @@ -60,7 +58,11 @@ export default function EditableValue({ const { key } = event; if (key === 'Enter') { - overrideValueFn(path, editableValue); + if (dataType === 'number') { + overrideValueFn(path, parseFloat(editableValue)); + } else { + overrideValueFn(path, editableValue); + } // Don't reset the pending change flag here. // The inspected fiber won't be updated until after the next "inspectElement" message. @@ -70,7 +72,7 @@ export default function EditableValue({ setHasPendingChanges(false); } }, - [path, editableValue, overrideValueFn, value] + [path, editableValue, overrideValueFn, value, dataType] ); // Render different input types based on the dataType