OSSForks/react
1
0
Fork 0
mirror of https://github.com/zebrajr/react.git synced 2026-01-15 12:15:22 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Slight tweak to avoid setting an invalid numeric value in props editor

Browse Source
This commit is contained in:
Brian Vaughn
2019-07-19 09:19:03 -07:00
parent f0a4b2f8e8
commit abe75b0e39
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/devtools/views/Components/EditableValue.js
View File

@@ -59,7 +59,10 @@ export default function EditableValue({
if (key === 'Enter') {
if (dataType === 'number') {
overrideValueFn(path, parseFloat(editableValue));
const parsedValue = parseFloat(editableValue);
if (!Number.isNaN(parsedValue)) {
overrideValueFn(path, parsedValue);
}
} else {
overrideValueFn(path, editableValue);
}
@@ -72,7 +75,7 @@ export default function EditableValue({
setHasPendingChanges(false);
}
},
[path, editableValue, overrideValueFn, value, dataType]
[editableValue, dataType, overrideValueFn, path, value]
);
// Render different input types based on the dataType