OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
26,783 Commits 30 Branches 683 Tags
ece507394a563bd7e3555a840a3d6980ffbb01ac
Commit Graph

26783 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Daniel Beckert
ece507394a src: do not reuse async resource in http parsers 
Change resource being used, previously HTTParser was being reused.
We are now using IncomingMessage and ClientRequest objects.  The goal
here is to make the async resource unique for each async operatio

Refs: https://github.com/nodejs/node/pull/24330
Refs: https://github.com/nodejs/diagnostics/issues/248
Refs: https://github.com/nodejs/node/pull/21313

Co-authored-by: Matheus Marchini <mat@mmarchini.me>

PR-URL: https://github.com/nodejs/node/pull/25094
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benedikt Meurer <benedikt.meurer@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2019-04-22 11:51:46 -07:00
Refael Ackermann
5aaf666b3b build: improve embedded code-cache detection 
PR-URL: https://github.com/nodejs/node/pull/27311
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2019-04-22 14:48:50 -04:00
Joyee Cheung
49d3d11ba7 inspector: split --cpu-prof-path to --cpu-prof-dir and --cpu-prof-name 
To improve the integration of `--cpu-prof` with workers, this patch
splits `--cpu-prof-path` into `--cpu-prof-dir` and `--cpu-prof-name`,
so when a worker is launched from a thread that enables
`--cpu-prof`, if the parent thread sets `--cpu-prof-dir`, then the
profile of both thread would be generated to the specified directory.
If they end up specifying the same `--cpu-prof-name` the behavior
is undefined the last profile will overwritten the first one.

PR-URL: https://github.com/nodejs/node/pull/27306
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2019-04-23 01:48:46 +08:00
cjihrig
a3d1922958 test: unskip copyfile permission test 
This is no longer a flakey test, and should run everywhere.

PR-URL: https://github.com/nodejs/node/pull/27241
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2019-04-22 12:04:35 -04:00
cjihrig
b368571fba test: move known issue test to parallel 
As of libuv 1.28.0, this bug is fixed, and the test can be
moved to parallel. This commit also updates an error code
check to work on Windows.

PR-URL: https://github.com/nodejs/node/pull/27241
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2019-04-22 12:04:35 -04:00
cjihrig
aec2ce4ee1 deps: upgrade to libuv 1.28.0 
Notable changes:

- uv_gettimeofday() has been added.
- Streaming readdir() via the uv_fs_{open,read,close}dir() methods.
- A macOS copyfile() permissions bug has been fixed.
- A bug in uv_interface_addresses() on machines with multiple
  interfaces has been fixed.

Fixes: https://github.com/nodejs/node/issues/27273
PR-URL: https://github.com/nodejs/node/pull/27241
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2019-04-22 12:04:35 -04:00
gengjiawen
2161690024 deps: update nghttp2 to 1.38.0 
PR-URL: https://github.com/nodejs/node/pull/27295
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
 2019-04-22 22:44:15 +08:00
gengjiawen
8eaf31181a src: apply modernize-use-nullptr in node_win32_etw_provider.cc 
PR-URL: https://github.com/nodejs/node/pull/27263
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-04-22 08:45:25 -04:00
Joyee Cheung
94adfe9831 lib: replace --diagnostic-report-* with --report-* 
In the code base the word `report` is almost only used to refer to
the diagnostic report when it's a noun, and it's programmable
interface `process.report()` it not prefixed, so `report` should be
unambiguous enough to use without `diagnostic`.

PR-URL: https://github.com/nodejs/node/pull/27312
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-04-22 19:09:52 +08:00
Joyee Cheung
19e3e02a2d src: move SIGINT watchdog utils to the contextify binding 
These are used when evaluating scripts so it makes more sense
to put them in the contextify binding whose other methods are
going to be used together.

PR-URL: https://github.com/nodejs/node/pull/27290
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-04-22 18:43:40 +08:00
Joyee Cheung
7c816b7588 module: explicitly initialize CJS loader 
Explicitly initialize the CJS loader with `module._initPaths()`
instead of making it a side-effect of requiring
`internal/modules/cjs/loader` - that makes it harder to reason about
when it's safe to load `internal/modules/cjs/loader`.

PR-URL: https://github.com/nodejs/node/pull/27313
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2019-04-22 17:30:09 +08:00
Refael Ackermann
528d100394 test: mark some known flakes 
PR-URL: https://github.com/nodejs/node/pull/27225
Refs: https://github.com/nodejs/node/issues/26910
Refs: https://github.com/nodejs/node/issues/27219
Refs: https://github.com/nodejs/node/issues/26938
Refs: https://github.com/nodejs/node/issues/23089
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2019-04-21 09:19:54 -04:00
Rich Trott
e37eee2b1e test: remove flaky designation for test-cli-node-options 
The test failure is not platform-specific and is the result of
manual/human error. Some improvements may be possible, but there is
nothing fundamentally unsound about the test insofar as when it fails in
CI, there is a problem on the host that needs to be addressed and not an
inherent issue with the test.

Refs: https://github.com/nodejs/node/issues/25028#issuecomment-479554080
Closes: https://github.com/nodejs/node/issues/25028

PR-URL: https://github.com/nodejs/node/pull/27305
Fixes: https://github.com/nodejs/node/issues/25028
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-04-21 04:00:24 -07:00
freestraws
e9fb92dc42 vm: remove require('util') from lib/vm/source_text_module.js 
PR-URL: https://github.com/nodejs/node/pull/27285
Refs: https://github.com/nodejs/node/issues/26546
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2019-04-21 12:47:16 +08:00
Rich Trott
7167eb2f12 test: increase coverage for dns.promises.lookup() 
Add coverage for uv_getaddrinfo() returning an error.

PR-URL: https://github.com/nodejs/node/pull/27299
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-04-20 19:05:39 -07:00
Refael Ackermann
0fc27f6bc0 build,win: bail vcbuild if mklink fails 
PR-URL: https://github.com/nodejs/node/pull/27216
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2019-04-20 11:05:12 -04:00
himself65
290faec0e7 doc: fix extname with the correct description 
PR-URL: https://github.com/nodejs/node/pull/27303
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2019-04-20 17:01:09 +03:00
Joyee Cheung
5356b4a675 src: split per-process initialization and teardown routines 
This patch makes it possible to instantiate NodeMainInstance in
a separate target and use it to e.g. create snapshot.

PR-URL: https://github.com/nodejs/node/pull/27276
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2019-04-20 21:14:01 +08:00
Gerson Niño
964174e339 tools,doc: fix 404 broken links in docs 
Change the `linkManPages()` function to catch the `uname` and `curl`
correct websites on the docs page.

PR-URL: https://github.com/nodejs/node/pull/27168
Fixes: https://github.com/nodejs/node/issues/26074
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2019-04-20 14:52:14 +03:00
Joyee Cheung
8d901bb44e src: move guessHandleType in the util binding 
It does not make too much sense to have modules unrelated to TTY
load the TTY binding just to use this method. Put this in the
util binding instead.

PR-URL: https://github.com/nodejs/node/pull/27289
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-04-20 13:25:41 +08:00
Rod Vagg
b581d59655 doc: update supported platforms for Node.js 12 
PR-URL: https://github.com/nodejs/node/pull/26714
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2019-04-20 10:25:26 +10:00
Rich Trott
d4dae5e1ca doc: simplify bullet points in GOVERNANCE.md 
Simplify the nominee-contributions bullet points in GOVERNANCE.md.

PR-URL: https://github.com/nodejs/node/pull/27284
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
 2019-04-19 14:31:49 -07:00
Refael Ackermann
88beaf01f1 build,win: rename node.lib to libnode.lib 
eliminate the need for `rename_node_bin_win`

PR-URL: https://github.com/nodejs/node/pull/27150
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2019-04-19 14:17:33 -04:00
Joyee Cheung
2e4ceb5747 util: access process states lazily in debuglog 
`debuglog()` depends on `process.pid` and `process.env.NODE_DEBUG`,
so it needs to be called lazily in top scopes of internal modules
that may be loaded before these run time states are allowed to
be accessed. This patch makes its implementation lazy by default,
the process states are only accessed when the returned debug
function is called for the first time.

PR-URL: https://github.com/nodejs/node/pull/27281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2019-04-20 00:30:38 +08:00
Joyee Cheung
49ee010005 lib: use getOptionValue instead of process underscore aliases 
This patch reduce usage of `process._breakFirstLine` and
`process._eval` in the internals and use
`getOptionValue('--inspect-brk')` and `getOptionValue('--eval')`
instead wherever possible.

PR-URL: https://github.com/nodejs/node/pull/27278
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2019-04-20 00:20:37 +08:00
Joyee Cheung
b66f01d903 test: skip test-cpu-prof in debug builds with code cache 
The CPU profiler crashes in debug builds when code cache is
enabled. Skip the test temporarily until it's fixed.

PR-URL: https://github.com/nodejs/node/pull/27308
Refs: https://github.com/nodejs/node/issues/27307
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
 2019-04-19 21:15:01 +08:00
Joyee Cheung
e0e3084482 inspector: implement --cpu-prof[-path] 
This patch introduces a CLI flag --cpu-prof that starts the V8
CPU profiler on start up, and ends the profiler then writes the
CPU profile before the Node.js instance (on the main thread or
the worker thread) exits. By default the profile is written to
`${cwd}/CPU.${yyyymmdd}.${hhmmss}.${pid}.${tid}.${seq}.cpuprofile`.
The patch also introduces a --cpu-prof-path flag for the user
to specify the path the profile will be written to.

Refs: https://github.com/nodejs/node/issues/26878
PR-URL: https://github.com/nodejs/node/pull/27147
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2019-04-19 15:38:23 +08:00
cjihrig
57ab3b56fc test: allow leaked global check to be skipped 
This simplifies the process of running tests on different
versions of Node, which might have a different set of
global variables.

PR-URL: https://github.com/nodejs/node/pull/27239
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-04-19 05:45:04 +02:00
gengjiawen
758191033f src: fix performance-faster-string-find in node_report.cc 
PR-URL: https://github.com/nodejs/node/pull/27262
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2019-04-19 11:10:55 +08:00
Anna Henningsen
02885dad5a test: add ability to skip common flag checks 
Currently, `common/index.js` checks that our test files are
spawned with the flags specified in `// Flags:`, and re-spawns
with them if they are not found.

This can be *very* annoying, for example when debugging using
debuggers that attach to the parent process, or when intentionally
testing with flags that are different from the specified ones.

This adds a `NODE_SKIP_FLAG_CHECK` environment variable check.
Setting it to a non-empty value will skip the flag checks altogether.

PR-URL: https://github.com/nodejs/node/pull/27254
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
 2019-04-19 10:56:41 +08:00
Ruben Bridgewater
ed893111b9 test: do not strip left whitespace in pseudo-tty tests 
PR-URL: https://github.com/nodejs/node/pull/27244
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
 2019-04-19 10:44:02 +08:00
Matheus Marchini
8712edf53a test: fix postmortem metadata test 
Recent changes to spawnSync (https://github.com/nodejs/node/pull/23027)
broke our V8 postmortem tests since the output from nm was larger than
the new default maxBuffer for spawnSync. Changing the maxBuffer to
Infinity fixes the issue.

PR-URL: https://github.com/nodejs/node/pull/27265
Refs: https://github.com/v8/v8/compare/7.4.288.18...7.4.288.21
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-04-18 16:57:23 -07:00
Matheus Marchini
7f29117de3 deps: patch V8 to 7.4.288.21 
Refs: https://github.com/v8/v8/compare/7.4.288.18...7.4.288.21

PR-URL: https://github.com/nodejs/node/pull/27265
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-04-18 16:57:19 -07:00
Rod Vagg
a7d7d4dfb7 build: increase MACOS_DEPLOYMENT_TARGET to 10.10 
PR-URL: https://github.com/nodejs/node/pull/27275
Refs: https://github.com/nodejs/node/pull/26714
Refs: https://github.com/nodejs/build/issues/1768
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-04-19 09:33:28 +10:00
Rich Trott
d5bb500d0f test: fix test-benchmark-buffer 
Using `len=2` in test-benchmark-buffer was resulting in a `RangeError`
in buffer-base64-encode.js. Change to `len=256` which works in all
buffer benchmarks.

PR-URL: https://github.com/nodejs/node/pull/27260
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-04-18 10:25:59 -07:00
Rich Trott
3973354951 benchmark: fix buffer-base64-decode.js 
693401d0dd added stricter range checking
for buffer operations and that apparently seems to have uncovered the
fact that one of our benchmarks was overflowing a buffer. Increase the
buffer size so the benchmark doesn't throw an error anymore.

PR-URL: https://github.com/nodejs/node/pull/27260
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2019-04-18 10:25:52 -07:00
Rich Trott
f98679f3b2 benchmark: add benchmark for dns.promises.lookup() 
Adding this benchmark will let us check the performance implications of
https://github.com/nodejs/node/pull/27081.

PR-URL: https://github.com/nodejs/node/pull/27249
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2019-04-18 10:24:07 -07:00
Simon Zünd
2948e96afd util: fix wrong usage of Error.prepareStackTrace 
The return value of Error.prepareStackTrace will become the result
of Error.stack accesses. Setting Error.stack inside this callback
relies on the fact that the magic get accessor detects the change in
the middle of formatting, and is unnecessary in this instance.

Refs: https://github.com/v8/node/pull/96

PR-URL: https://github.com/nodejs/node/pull/27250
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
 2019-04-18 13:04:50 +02:00
Anna Henningsen
dc8b57fdc1 src: use ArrayBufferAllocator::Create in node_worker.cc 
Refs: https://github.com/nodejs/node/pull/27220

PR-URL: https://github.com/nodejs/node/pull/27251
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-04-18 13:03:26 +02:00
Anna Henningsen
f9da3f0cce src: enable non-nestable V8 platform tasks 
We never execute tasks in a nested fashion, so enabling them should
be as simple as forwarding tasks to the existing `Post*` methods.

PR-URL: https://github.com/nodejs/node/pull/27252
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
 2019-04-18 12:50:52 +02:00
Richard Lau
d17dfc7bb1 build: remove redundant pyenv call in Travis build 
PR-URL: https://github.com/nodejs/node/pull/27247
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2019-04-18 00:24:14 -04:00
Ruben Bridgewater
9946c59707 path: simplify normalizeString 
This improves the `path.normalize()` and `path.resolve()` performance a
tiny bit.
One statement could never be truthy, another check could be simplified
and `code` is now monomorphic.

PR-URL: https://github.com/nodejs/node/pull/27240
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2019-04-18 05:32:10 +02:00
Refael Ackermann
4f8b497991 test: try to stabalize test-child-process-fork-exec-path.js 
PR-URL: https://github.com/nodejs/node/pull/27277
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2019-04-18 05:24:19 +02:00
Anna Henningsen
002dacb7f7 worker: handle exception when creating execArgv errors 
Handle possible JS exceptions that can occur by returning to JS land
immediately.

The motivation for this change is that `USE(….FromJust());` is an
anti-pattern, and `.FromJust()` with an unused return value is
superseded by `.Check()`. However, in this case, checking that the
operation succeeded is not necessary.

Refs: https://github.com/nodejs/node/pull/27162

PR-URL: https://github.com/nodejs/node/pull/27245
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-04-17 23:36:37 +02:00
kohta ito
652877e3a9 child_process: change the defaults maxBuffer size 
PR-URL: https://github.com/nodejs/node/pull/27179
Refs: https://github.com/nodejs/node/pull/23027
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
 2019-04-17 14:05:15 -07:00
Sam Roberts
69140bc7f8 crypto: do not abort when setting throws 
PR-URL: https://github.com/nodejs/node/pull/27157
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-04-17 11:15:04 -07:00
Maël Nison
3ef1512f9e src: allows escaping NODE_OPTIONS with backslashes 
The characters specified within NODE_OPTIONS can now be escaped, which
is handy especially in conjunction with `--require` (where the file path
might happen to contain spaces that shouldn't cause the option to be
split into two).

Fixes: https://github.com/nodejs/node/issues/12971

PR-URL: https://github.com/nodejs/node/pull/24065
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2019-04-17 19:46:00 +02:00
Rich Trott
ba74e42000 doc: revise Collaborator Nominations introduction 
Revise the introductory paragraphs for Collaborator Nominations in
GOVERNANCE.md. This change splits long and unnecessarily complex
sentences into multiple simple statements.

PR-URL: https://github.com/nodejs/node/pull/27237
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2019-04-17 09:38:33 -07:00
Ruben Bridgewater
d070f5d965 worker: improve coverage 
This improves the worker coverage by using `internal/assert` instead
of relying on `assert` in case a faulty worker message type is
received.

PR-URL: https://github.com/nodejs/node/pull/27230
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
 2019-04-17 18:58:44 +08:00
Ruben Bridgewater
5450e48f69 worker: simplify filename checks 
Replace a couple of checks with a single regular expression.

PR-URL: https://github.com/nodejs/node/pull/27233
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2019-04-17 18:46:54 +08:00