OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

test: fix postmortem metadata test

Browse Source 
Recent changes to spawnSync (https://github.com/nodejs/node/pull/23027)
broke our V8 postmortem tests since the output from nm was larger than
the new default maxBuffer for spawnSync. Changing the maxBuffer to
Infinity fixes the issue.

PR-URL: https://github.com/nodejs/node/pull/27265
Refs: https://github.com/v8/v8/compare/7.4.288.18...7.4.288.21
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Matheus Marchini
2019-04-16 16:27:28 -07:00
parent 7f29117de3
commit 8712edf53a
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/v8-updates/test-postmortem-metadata.js
View File

@@ -21,7 +21,7 @@ if (common.isAIX)
if (common.isOpenBSD)
common.skip('no v8 debug symbols on OpenBSD');
const nm = spawnSync('nm', args);
const nm = spawnSync('nm', args, { maxBuffer: Infinity });
if (nm.error && nm.error.errno === 'ENOENT')
common.skip('nm not found on system');