OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity
36,518 Commits 30 Branches 683 Tags
736a7d8d60acdcf3274ae160fadefbbbbe4e4311
Commit Graph

36518 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Paolo Insogna
736a7d8d60 http: do not leak error listeners 
PR-URL: https://github.com/nodejs/node/pull/43587
Fixes: https://github.com/nodejs/node/issues/43548
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2022-07-01 08:17:26 +02:00
Rafael Gonzaga
56c15f1c95 doc: include CVSS mention 
PR-URL: https://github.com/nodejs/node/pull/43602
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2022-06-30 18:05:54 +01:00
Feng Yu
2dccda26f9 url: update WHATWG URL parser to align with latest spec 
PR-URL: https://github.com/nodejs/node/pull/43190
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
 2022-06-30 18:51:11 +02:00
Michael Dawson
bbab209721 doc: fix icu-small example 
Running the same in the icu doc shows that for
icu-small the output is January instead of M01. Update
the example in the doc to match.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/43591
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2022-06-30 09:34:10 -04:00
Darshan Sen
08c8e85905 src,bootstrap: remove NodeMainInstance::registry_ 
All uses of NodeMainInstance::registry_ were removed in
43d2e247c7,
so this change removes the variable completely.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/43392
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-06-30 09:31:11 +01:00
Ray
c15a605d8b module: also enable subpath imports in REPL 
PR-URL: https://github.com/nodejs/node/pull/43450
Fixes: https://github.com/nodejs/node/issues/43410
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-06-30 09:31:02 +01:00
Livia Medeiros
e0705be41c fs: refactor realpath with Map and Set 
PR-URL: https://github.com/nodejs/node/pull/43569
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-06-30 09:30:53 +01:00
Daeyeon Jeong
3b0995e6ec src: remove a stale comment in async_hooks 
This removes a comment relevant to runtime checks for `async_hooks`.

Even if `async_hooks` is experimental, the check pointed by the comment
is performed as default unless `--no-force-async-hooks-checks` is given
from CLI arguments.

Refs: https://github.com/nodejs/node/pull/16318
Refs: https://github.com/nodejs/node/pull/15454#issuecomment-337840053

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: https://github.com/nodejs/node/pull/43317
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2022-06-30 10:17:12 +02:00
Rafael Gonzaga
350a6a8d59 perf_hooks: add initiatorType getter 
PR-URL: https://github.com/nodejs/node/pull/43593
Refs: https://w3c.github.io/resource-timing/#dfn-initiator-type
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
 2022-06-30 01:24:39 +01:00
Livia Medeiros
a0440c9174 doc: add backport-open-vN.x step to backporting guide 
PR-URL: https://github.com/nodejs/node/pull/43590
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-06-29 20:35:41 +01:00
Node.js GitHub Bot
dc3e5408aa tools: update lint-md-dependencies 
Update to @rollup/plugin-commonjs@22.0.1 and rollup@2.75.7.

PR-URL: https://github.com/nodejs/node/pull/43572
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2022-06-29 19:11:30 +01:00
Darshan Sen
49a5e81887 src: fix compiler warning in src/heap_utils.cc 
Fixes: https://github.com/nodejs/node/issues/43577
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/43579
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2022-06-29 15:09:04 +01:00
Daeyeon Jeong
ed1e9ae402 events: improve EventListener validation 
This fixes validating `EventListener` given to `add/removeEventListener`
to improve the Web API compatibility.

According to the WPT test failure with the current validation,
`addEventListener` should not require `handleEvent` to be defined on
an `EventListener`".  IIUC, the same can be applied to
`removeEventListener` also.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: https://github.com/nodejs/node/pull/43491
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-06-29 12:26:18 +01:00
Paolo Insogna
4267b92604 http: use Keep-Alive by default in global agents 
PR-URL: https://github.com/nodejs/node/pull/43522
Fixes: https://github.com/nodejs/node/issues/37184
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-06-29 12:48:52 +02:00
theanarkh
8e19dab677 net: fix net keepalive and noDelay 
1. support setKeepAlive again
2. set keepalive and nodelay to socket which is created by server

PR-URL: https://github.com/nodejs/node/pull/43561
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-06-29 10:58:35 +01:00
Moshe Atlow
e2225ba8e1 test_runner: expose describe and it 
PR-URL: https://github.com/nodejs/node/pull/43420
Refs: https://github.com/nodejs/node/issues/43415
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2022-06-29 12:31:47 +03:00
Paolo Insogna
d636fee319 benchmark: fix fork detection 
PR-URL: https://github.com/nodejs/node/pull/43601
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2022-06-29 08:36:20 +02:00
Feng Yu
ea99431586 test: mark flaky tests on smartos 
PR-URL: https://github.com/nodejs/node/pull/43596
Refs: https://github.com/nodejs/node/issues/43457
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-06-28 18:06:48 +01:00
italo jose
6c1aa01874 test: improve code coverage for SourceMap class 
Cover malformed mappings scenario.

PR-URL: https://github.com/nodejs/node/pull/43285
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-06-28 18:38:29 +02:00
F3n67u
bc5f9e1a35 test: mark test-http-server-request-timeouts-mixed flaky on macOS 
PR-URL: https://github.com/nodejs/node/pull/43597
Refs: https://github.com/nodejs/node/issues/43465
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
 2022-06-28 13:03:19 +02:00
Kohei Ueno
593de05c5a readline: fix to not access a property on an undefined value 
PR-URL: https://github.com/nodejs/node/pull/43543
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-06-28 11:10:50 +01:00
Giacomo Gregoletto
51beb26a5f stream: pass error on legacy destroy 
PR-URL: https://github.com/nodejs/node/pull/43519
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-06-28 09:59:24 +01:00
Antoine du Hamel
7cbcc4fc43 tools: fix CJS/ESM toggle on small screens 
PR-URL: https://github.com/nodejs/node/pull/43506
Co-authored-by: Moshe Atlow <moshe@atlow.co.il>
Fixes: https://github.com/nodejs/node/issues/43468
Reviewed-By: LiviaMedeiros <livia@cirno.name>
 2022-06-27 18:31:44 +02:00
Antoine du Hamel
bb30e2da7a lib: use null-prototype objects for property descriptors 
PR-URL: https://github.com/nodejs/node/pull/43473
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-06-27 16:29:10 +01:00
Antoine du Hamel
a055337a02 lib: refactor to avoid unsafe regex primordials 
PR-URL: https://github.com/nodejs/node/pull/43475
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
 2022-06-27 17:16:06 +02:00
Antoine du Hamel
411fb21723 lib: fix TODO in freeze_intrinsics 
PR-URL: https://github.com/nodejs/node/pull/43472
Reviewed-By: Guy Bedford <guybedford@gmail.com>
 2022-06-27 16:15:16 +01:00
Paolo Insogna
684e107965 benchmark: forcefully close processes 
PR-URL: https://github.com/nodejs/node/pull/43557
Fixes: https://github.com/nodejs/build/issues/2968
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2022-06-27 12:29:47 +02:00
Adam Majer
9cde7a033e crypto: don't disable TLS 1.3 without suites 
In the manual page, there is a statement that ciphersuites contain
explicit default settings - all TLS 1.3 ciphersuites enabled.
In node, we assume that an empty setting mean no ciphersuites and
we disable TLS 1.3. A correct approach to disabling TLS 1.3 is to
disable TLS 1.3 and by not override the default ciphersuits
with an empty string.

So, only override OpenSSL's TLS 1.3 ciphersuites with an explicit
list of ciphers. If none are acceptable, the correct approach is
to disable TLS 1.3 instead elsewhere.

Fixes: https://github.com/nodejs/node/issues/43419

PR-URL: https://github.com/nodejs/node/pull/43427
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-06-27 09:47:13 +01:00
Node.js GitHub Bot
4ecc6a400f meta: update AUTHORS 
PR-URL: https://github.com/nodejs/node/pull/43573
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-06-26 19:17:29 +01:00
Tobias Nießen
42ad967d68 crypto: use ByteSource::Builder in To*Copy 
Avoid manual calls to MallocOpenSSL in ArrayBufferOrViewContents and
use the new ByteSource::Builder instead.

Refs: https://github.com/nodejs/node/pull/43202

PR-URL: https://github.com/nodejs/node/pull/43477
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-06-25 22:40:26 +01:00
Tobias Nießen
c7a0b141b6 src: improve and update ByteSource description 
Clarify that external data must not be destroyed before the ByteSource
that points to it, and that allocated data must have been allocated
using OpenSSL's allocator (because it will be freed automatically, using
OpenSSL's memory management functions).

Also add a brief description of the new ByteSource::Builder class.

PR-URL: https://github.com/nodejs/node/pull/43478
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-06-25 22:40:14 +01:00
snek
f8bb0b183c wasi: use WasmMemoryObject handle for perf (#43544) 
PR-URL: #43544
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2022-06-25 11:02:32 -07:00
supriyo-biswas
b6bc44f8bc net: prevent /32 ipv4 mask from matching all ips 
Fixes: https://github.com/nodejs/node/issues/43360

PR-URL: https://github.com/nodejs/node/pull/43381
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-06-25 13:47:27 +01:00
theanarkh
d96a2ea615 http: add perf_hooks detail for http request and client 
PR-URL: https://github.com/nodejs/node/pull/43361
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2022-06-25 11:37:20 +01:00
Filip Skokan
84db3e7b06 crypto: handle webcrypto generateKey() usages edge case 
PR-URL: https://github.com/nodejs/node/pull/43454
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2022-06-25 06:22:35 +01:00
npm CLI robot
687e50aded deps: upgrade npm to 8.13.1 
PR-URL: https://github.com/nodejs/node/pull/43552
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2022-06-25 02:21:50 +01:00
Meek Simbule
3507b3f9a9 test: refactor to top-level await 
PR-URL: https://github.com/nodejs/node/pull/43500
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-06-23 21:52:05 +01:00
Feng Yu
6f924ac691 build: update main branch name in GH workflow 
PR-URL: https://github.com/nodejs/node/pull/43481
Refs: https://github.com/nodejs/node/issues/33864
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2022-06-23 05:57:51 +01:00
Richard Lau
d81d426f99 test: skip test-v8-serialize-leak on IBM i 
On IBM i rss memory information is not available and always returns `0`.

PR-URL: https://github.com/nodejs/node/pull/43511
Refs: https://github.com/nodejs/node/issues/43509
Refs: https://github.com/libuv/libuv/pull/2732
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-06-22 21:55:53 +01:00
Ben Noordhuis
a7c9130e02 test: use unique file names in fs trace test 
Should fix test flakiness that is presumably caused by the asynchronous
nature of the unlink operation on Windows.

It's been observed that sub-tests randomly fail with "permission denied"
errors when trying to create a new file in a directory with appropriate
permissions.

The DeleteFile() NT API call makes a file inaccessible and marks it for
deletion but doesn't actually delete it until the last open handle has
been closed. Accessing such a file fails with ERROR_ACCESS_DENIED.

Processes can close handles manually or wait for the operating system to
close them asynchronously after process termination. I speculate it's
the latter that's causing the test to turn flaky.

Fixes: https://github.com/nodejs/node/issues/43502

PR-URL: https://github.com/nodejs/node/pull/43504
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-06-22 20:46:47 +01:00
Myles Borins
f00258720b doc: move MylesBorins to TSC Emeritus 
My availability has become smaller and smaller and I think for now the
best thing to do is to move to TSC Emeritus. Perhaps I'll have more
time to focus on Node.js Leadership again in the future, but for now
I think it's best to officially step back a bit.

So long, and thanks for all the modules o/

PR-URL: https://github.com/nodejs/node/pull/43524
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-06-22 15:46:21 -04:00
Michael Dawson
23b38e7109 doc: add Juan as a security steward 
Ran through onboaring with Juan today. Add him
to the rotation for security stewards.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/43512
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-06-22 15:43:06 -04:00
Richard Lau
3b8f3e647a test: allow EOVERFLOW errors in fs position tests 
Some platforms may return `EOVERFLOW` errors instead of `EFBIG`.

PR-URL: https://github.com/nodejs/node/pull/43510
Refs: https://github.com/nodejs/node/pull/42999
Refs: https://github.com/nodejs/node/issues/43509
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-06-22 19:23:01 +01:00
James Scott-Brown
986307ba11 doc: update link to MDN page about dynamic imports 
This was split into a separate page 2 days ago: d2b50123d4

PR-URL: https://github.com/nodejs/node/pull/43530
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2022-06-22 16:57:53 +01:00
theanarkh
dbe5874c7e net: fix net.Server keepalive and noDelay 
PR-URL: https://github.com/nodejs/node/pull/43497
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2022-06-22 15:10:18 +01:00
Paolo Insogna
b970634cfe http: defer reentrant execution of Parser::Execute 
PR-URL: https://github.com/nodejs/node/pull/43369
Fixes: https://github.com/nodejs/node/issues/39671
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2022-06-22 10:55:18 +02:00
Daiki Nishikawa
8dce6ad7a5 test: add WPT tests for dom/events 
PR-URL: https://github.com/nodejs/node/pull/43151
Refs: https://github.com/nodejs/node/issues/40678
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-06-22 09:28:59 +01:00
Jacob Smith
3c040348fe Revert "esm: convert resolve hook to synchronous" 
This reverts commit 90b634a5a5.

PR-URL: https://github.com/nodejs/node/pull/43526
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2022-06-22 08:13:36 +01:00
Tobias Nießen
f5ce6b1ebf test: replace gc(true) with gc({ type: 'minor' }) 
V8 considers gc(true) legacy, and the new signature is much more
expressive.

PR-URL: https://github.com/nodejs/node/pull/43493
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2022-06-21 22:54:09 +01:00
Tobias Nießen
800cff1e24 doc,test: clarify timingSafeEqual semantics 
PR-URL: https://github.com/nodejs/node/pull/43228
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-06-21 12:43:09 +01:00