stream: pass error on legacy destroy

PR-URL: https://github.com/nodejs/node/pull/43519
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Giacomo Gregoletto
2022-06-28 10:59:24 +02:00
committed by GitHub
parent 7cbcc4fc43
commit 51beb26a5f
2 changed files with 31 additions and 1 deletions

View File

@@ -319,7 +319,7 @@ function destroyer(stream, err) {
// TODO: Don't lose err?
stream.close();
} else if (err) {
process.nextTick(emitErrorCloseLegacy, stream);
process.nextTick(emitErrorCloseLegacy, stream, err);
} else {
process.nextTick(emitCloseLegacy, stream);
}

View File

@@ -1526,3 +1526,33 @@ const tsp = require('timers/promises');
assert.strictEqual(val, null);
}));
}
{
// Mimics a legacy stream without the .destroy method
class LegacyWritable extends Stream {
write(chunk, encoding, callback) {
callback();
}
}
const writable = new LegacyWritable();
writable.on('error', common.mustCall((err) => {
assert.deepStrictEqual(err, new Error('stop'));
}));
pipeline(
Readable.from({
[Symbol.asyncIterator]() {
return {
next() {
return Promise.reject(new Error('stop'));
}
};
}
}),
writable,
common.mustCall((err) => {
assert.deepStrictEqual(err, new Error('stop'));
})
);
}