Dima Demakov
62fc950e96
doc: make theme consistent across api and other docs
...
Since website based on 2 different repos, there was an inconsistency
in theme selection, so we had 2 independant theme props.
Now only one stored in local storage is a single source of truth
PR-URL: https://github.com/nodejs/node/pull/50877
Reviewed-By: Claudio Wunder <cwunder@gnome.org >
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io >
2023-11-27 09:03:27 +00:00
CanadaHonk
4466deeb34
fs: add c++ fast path for writeFileSync utf8
...
PR-URL: https://github.com/nodejs/node/pull/49884
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io >
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-11-27 00:01:39 +00:00
CanadaHonk
f11b2061ea
fs: improve error performance for rmdirSync
...
PR-URL: https://github.com/nodejs/node/pull/49846
Refs: https://github.com/nodejs/performance/issues/106
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br >
2023-11-26 19:23:41 +00:00
Matteo Collina
5f8ec99104
meta: clarify nomination process according to Node.js charter
...
Signed-off-by: Matteo Collina <hello@matteocollina.com >
PR-URL: https://github.com/nodejs/node/pull/50834
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ruy Adorno <ruyadorno@google.com >
2023-11-26 17:14:19 +00:00
Liu Jia
f8c27e6176
benchmark: update iterations in benchmark/util/splice-one.js
...
Increase the number of iterations from 1e5 to 5e6
to avoid the test performance gap caused by inactive
V8 optimization caused by insufficient number of iterations
Refs: https://github.com/nodejs/node/issues/50571
PR-URL: https://github.com/nodejs/node/pull/50698
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br >
2023-11-26 13:42:55 +00:00
Moshe Atlow
f28839b5f3
fs: fix glob returning duplicates
...
PR-URL: https://github.com/nodejs/node/pull/50881
Fixes: https://github.com/nodejs/node/issues/50875
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2023-11-26 07:31:58 +00:00
Tobias Nießen
ed5cb37ccb
src: assert return value of BN_bn2binpad
...
Every other invocation of BN_bn2binpad checks the return value. For
safety and consistency, do so in RandomPrimeTraits::EncodeOutput()
as well.
PR-URL: https://github.com/nodejs/node/pull/50860
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-11-25 19:57:53 +00:00
Antoine du Hamel
7981e2ee64
meta: clarify recommendation for bug reproductions
...
Sometimes reporters link to a repo for their repro, which
not only likely takes them more time to setup, but also is less
convenient for maintainers. Setting up a repo goes against the idea of a
minimal repro, as if it was actually minimal, they would not have
bothered creating a repo.
PR-URL: https://github.com/nodejs/node/pull/50882
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Ruy Adorno <ruyadorno@google.com >
2023-11-25 16:32:15 +00:00
Antoine du Hamel
b0443690f8
doc: add a section regarding instanceof in primordials.md
...
PR-URL: https://github.com/nodejs/node/pull/50874
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2023-11-25 09:15:58 +00:00
Cheng Zhao
0bb5d88871
v8,tools: expose necessary V8 defines
...
PR-URL: https://github.com/nodejs/node/pull/50820
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-11-25 04:30:50 +00:00
Yagiz Nizipli
41e225cac4
doc: update email to reflect affiliation
...
PR-URL: https://github.com/nodejs/node/pull/50856
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ruy Adorno <ruyadorno@google.com >
2023-11-24 19:13:14 +00:00
Node.js GitHub Bot
f4c915c006
deps: update zlib to 1.2.13.1-motley-5daffc7
...
PR-URL: https://github.com/nodejs/node/pull/50803
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-11-24 17:48:08 +00:00
Jungku Lee
ec79232938
fs: fix to not return for void function
...
PR-URL: https://github.com/nodejs/node/pull/50769
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Qingyu Deng <i@ayase-lab.com >
2023-11-24 17:47:59 +00:00
Michael Dawson
6dbf678ae5
src: fix coverity warning
...
- reduce copying by using std::move
Signed-off-by: Michael Dawson <midawson@redhat.com >
PR-URL: https://github.com/nodejs/node/pull/50846
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-11-24 17:39:39 +00:00
Colin Ihrig
cf45a62ece
meta: move cjihrig to TSC regular member
...
PR-URL: https://github.com/nodejs/node/pull/50816
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2023-11-24 15:06:29 +00:00
Brad House
345d16cc50
test: fix dns test case failures after c-ares update to 1.21.0+
...
c-ares has made intentional changes to the behavior of TXT records
to comply with RFC 7208, which concatenates multiple strings for
the same TXT record into a single string. Multiple TXT records
are not concatenated.
Also, response handling has changed, such that a response which is
completely invalid in formatting is thrown away as a malicious
forged/spoofed packet rather than returning EBADRESP. This is one
step toward RFC 9018 (EDNS COOKIES) which will require the message
to at least be structurally valid to validate against spoofed
records.
Fix By: Brad House (@bradh352)
PR-URL: https://github.com/nodejs/node/pull/50743
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Fixes: https://github.com/nodejs/node/issues/50741
Refs: https://github.com/nodejs/node/issues/50444
2023-11-24 15:59:39 +01:00
Conor Watson
303654c501
test: replace forEach with for of
...
PR-URL: https://github.com/nodejs/node/pull/50594
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-11-24 14:11:34 +00:00
Alessandro Di Nisio
8c72210457
test: replace forEach to for at test-webcrypto-sign-verify-ecdsa.js
...
PR-URL: https://github.com/nodejs/node/pull/50795
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-11-24 13:52:32 +00:00
Chengzhong Wu
fbfa77b712
deps: V8: cherry-pick 0f9ebbc672c7
...
Original commit message:
[flags] Remove --harmony-string-is-well-formed
The String.prototype.isWellFormed and toWellFormed have shipped
since M111.
Bug: v8:13557
Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
Reviewed-by: Shu-yu Guo <syg@chromium.org >
Commit-Queue: Chengzhong Wu (legendecas) <legendecas@gmail.com >
Cr-Commit-Position: refs/heads/main@{#90398}
Refs: 0f9ebbc672
PR-URL: https://github.com/nodejs/node/pull/50867
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2023-11-24 03:38:54 +00:00
CanadaHonk
dd338e3429
fs: replace deprecated path._makeLong in copyFile
...
PR-URL: https://github.com/nodejs/node/pull/50844
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-11-23 22:47:36 +00:00
Ulises Gascón
83df02c180
tools: add macOS notarization verification step
...
PR-URL: https://github.com/nodejs/node/pull/50833
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2023-11-23 13:51:51 -05:00
Shikha Mehta
4e713a3930
test: replace foreach with for in test-https-simple.js
...
Fixes: https://github.com/nodejs/node/issues/50818
PR-URL: https://github.com/nodejs/node/pull/49793
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Jithil P Ponnan <jithil@outlook.com >
2023-11-23 16:34:46 +00:00
Pulkit Gupta
f9675e104e
doc: shard not supported with watch mode
...
PR-URL: https://github.com/nodejs/node/pull/50640
Reviewed-By: Raz Luvaton <rluvaton@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2023-11-23 13:33:29 +00:00
CanadaHonk
ea88a3e1f2
fs: improve error perf of sync lstat+fstat
...
PR-URL: https://github.com/nodejs/node/pull/49868
Refs: https://github.com/nodejs/performance/issues/106
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-11-23 00:25:15 +00:00
Antoine du Hamel
5dd7ba66ad
doc: get rid of unnecessary eslint-skip comments
...
PR-URL: https://github.com/nodejs/node/pull/50829
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2023-11-22 19:03:33 +00:00
Tobias Nießen
041d435be9
permission: do not create symlinks if target is relative
...
The permission model's security guarantees fall apart in the presence of
relative symbolic links. When an application attempts to create a
relative symlink, the permission model currently resolves the relative
path into an absolute path based on the process's current working
directory, checks whether the process has the relevant permissions, and
then creates the symlink using the absolute target path. This behavior
is plainly incorrect for two reasons:
1. The target path should never be resolved relative to the current
working directory. If anything, it should be resolved relative to the
symlink's location. (Of course, there is one insane exception to this
rule: on Windows, each process has a current working directory per
drive, and symlinks can be created with a target path relative to the
current working directory of a specific drive. In that case, the
relative path will be resolved relative to the current working
directory for the respective drive, and the symlink will be created
on disk with the resulting absolute path. Other relative symlinks
will be stored as-is.)
2. Silently creating an absolute symlink when the user requested a
relative symlink is wrong. The user may (or may not) rely on the
symlink being relative. For example, npm heavily relies on relative
symbolic links such that node_modules directories can be moved around
without breaking.
Because we don't know the user's intentions, we don't know if creating
an absolute symlink instead of a relative symlink is acceptable. This
patch prevents the faulty behavior by not (incorrectly) resolving
relative symlink targets when the permission model is enabled, and by
instead simply refusing the create any relative symlinks.
The fs APIs accept Uint8Array objects for paths to be able to handle
arbitrary file name charsets, however, checking whether such an object
represents a relative part in a reliable and portable manner is tricky.
Other parts of the permission model incorrectly convert such objects to
strings and then back to an Uint8Array (see 1f64147eb6 ),
however, for now, this bug fix will simply throw on non-string symlink
targets when the permission model is enabled. (The permission model
already breaks existing applications in various ways, so this shouldn't
be too dramatic.)
PR-URL: https://github.com/nodejs/node/pull/49156
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-11-22 17:30:36 +00:00
Marco Ippolito
37820062c5
doc: create deprecation code for isWebAssemblyCompiledModule
...
PR-URL: https://github.com/nodejs/node/pull/50486
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2023-11-22 17:20:46 +00:00
Ulises Gascón
5f973d1dfd
tools: use macOS keychain to notarize the releases
...
PR-URL: https://github.com/nodejs/node/pull/50715
Reviewed-By: Michael Dawson <midawson@redhat.com >
2023-11-22 10:33:12 -05:00
Cheng Zhao
d50eb3760c
src: fix compatility with upcoming V8 12.1 APIs
...
PR-URL: https://github.com/nodejs/node/pull/50709
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-11-22 15:12:52 +00:00
Michaël Zasso
a9bd735adf
2023-11-22, Version 20.10.0 'Iron' (LTS)
...
Notable changes:
deps:
* (SEMVER-MINOR) update uvwasi to 0.0.19 (Node.js GitHub Bot) https://github.com/nodejs/node/pull/49908
doc:
* add H4ad to collaborators (Vinícius Lourenço) https://github.com/nodejs/node/pull/50217
esm:
* (SEMVER-MINOR) detect ESM syntax in ambiguous JavaScript (Geoffrey Booth) https://github.com/nodejs/node/pull/50096
* use import attributes instead of import assertions (Antoine du Hamel) https://github.com/nodejs/node/pull/50140
* --experimental-default-type flag to flip module defaults (Geoffrey Booth) https://github.com/nodejs/node/pull/49869
fs:
* (SEMVER-MINOR) add flush option to appendFile() functions (Colin Ihrig) https://github.com/nodejs/node/pull/50095
* add flush option to writeFile() functions (Colin Ihrig) https://github.com/nodejs/node/pull/50009
lib:
* (SEMVER-MINOR) add WebSocket client (Matthew Aitken) https://github.com/nodejs/node/pull/49830
stream:
* (SEMVER-MINOR) allow pass stream class to `stream.compose` (Alex Yang) https://github.com/nodejs/node/pull/50187
* call helper function from push and unshift (Raz Luvaton) https://github.com/nodejs/node/pull/50173
* optimize Writable (Robert Nagy) https://github.com/nodejs/node/pull/50012
test_runner, cli:
* (SEMVER-MINOR) add --test-concurrency flag (Colin Ihrig) https://github.com/nodejs/node/pull/49996
vm:
* (SEMVER-MINOR) use import attributes instead of import assertions (Antoine du Hamel) https://github.com/nodejs/node/pull/50141
* use default HDO when importModuleDynamically is not set (Joyee Cheung) https://github.com/nodejs/node/pull/49950
wasi:
PR-URL: https://github.com/nodejs/node/pull/50682
2023-11-22 16:03:13 +01:00
CanadaHonk
081474b910
doc: add CanadaHonk to triagers
...
PR-URL: https://github.com/nodejs/node/pull/50848
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Qingyu Deng <i@ayase-lab.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Xuguang Mei <meixuguang@gmail.com >
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2023-11-22 20:10:06 +05:30
Tobias Nießen
78beea735c
doc: fix typos in --allow-fs-*
...
Refs: https://github.com/nodejs/node/pull/49047
PR-URL: https://github.com/nodejs/node/pull/50845
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br >
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com >
2023-11-22 14:36:00 +00:00
Cheng Zhao
1858341377
build: add GN configurations for simdjson
...
PR-URL: https://github.com/nodejs/node/pull/50831
Reviewed-By: Keyhan Vakil <kvakil@sylph.kvakil.me >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2023-11-21 22:39:02 +00:00
Node.js GitHub Bot
7c726f742a
deps: update icu to 74.1
...
PR-URL: https://github.com/nodejs/node/pull/50515
Reviewed-By: Steven R Loomis <srl295@gmail.com >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
2023-11-21 16:55:15 -05:00
Luigi Pinca
053f36855a
dns: call handle.setServers() with a valid array
...
`handle.setServers()` takes an array, not a string.
PR-URL: https://github.com/nodejs/node/pull/50811
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2023-11-21 20:56:02 +00:00
Node.js GitHub Bot
8c04b45247
crypto: update root certificates to NSS 3.95
...
This is the certdata.txt[0] from NSS 3.95, released on 2023-11-16.
This is the version of NSS that will ship in Firefox 121 on
2023-12-19.
Certificates added:
- TrustAsia Global Root CA G3
- TrustAsia Global Root CA G4
- CommScope Public Trust ECC Root-01
- CommScope Public Trust ECC Root-02
- CommScope Public Trust RSA Root-01
- CommScope Public Trust RSA Root-02
Certificates removed:
- Autoridad de Certificacion Firmaprofesional CIF A62634068
[0] https://hg.mozilla.org/projects/nss/raw-file/NSS_3_95_RTM/lib/ckfw/builtins/certdata.txt
PR-URL: https://github.com/nodejs/node/pull/50805
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-11-21 20:55:50 +00:00
Ethan Arrowood
a0b66383f1
src: add --disable-warning option
...
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com >
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/50661
Fixes: https://github.com/nodejs/node/issues/30810
Fixes: https://github.com/nodejs/node/issues/47478
Fixes: https://github.com/nodejs/node/issues/46862
Fixes: https://github.com/nodejs/node/issues/40940
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2023-11-21 20:30:02 +00:00
Node.js GitHub Bot
a76f3913a5
deps: update ada to 2.7.4
...
PR-URL: https://github.com/nodejs/node/pull/50815
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2023-11-21 18:58:32 +00:00
Mattias Buelens
177cfc88b9
test: add note about unresolved spec issue
...
PR-URL: https://github.com/nodejs/node/pull/50779
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2023-11-21 14:42:43 +00:00
Mattias Buelens
0a6a8d2b2f
test: add note about readable streams with type owning
...
PR-URL: https://github.com/nodejs/node/pull/50779
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2023-11-21 14:42:42 +00:00
Mattias Buelens
1829c49d34
stream: fix enumerability of ReadableStream.from
...
PR-URL: https://github.com/nodejs/node/pull/50779
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2023-11-21 14:42:42 +00:00
Mattias Buelens
1729bacd6a
stream: fix enumerability of ReadableStream.prototype.values
...
PR-URL: https://github.com/nodejs/node/pull/50779
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2023-11-21 14:42:41 +00:00
vitosorriso
f425710f13
test: replace forEach with for-of in test-url-relative
...
PR-URL: https://github.com/nodejs/node/pull/50788
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2023-11-21 12:53:32 +00:00
Steve Goode
f22ba46007
test: replace forEach() with for ... of in test-tls-getprotocol.js
...
PR-URL: https://github.com/nodejs/node/pull/50600
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2023-11-21 12:53:22 +00:00
theanarkh
51abedecc5
net: check pipe mode and path
...
PR-URL: https://github.com/nodejs/node/pull/50770
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-11-21 12:21:57 +00:00
Node.js GitHub Bot
2c7d23311c
deps: update undici to 5.27.2
...
PR-URL: https://github.com/nodejs/node/pull/50813
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-11-21 11:22:51 +00:00
Filip Skokan
2e33b16ba6
test: use requires instead of flaky in console WPT status
...
PR-URL: https://github.com/nodejs/node/pull/50812
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-11-21 09:21:47 +00:00
Node.js GitHub Bot
b6b05d92f0
tools: update eslint to 8.54.0
...
PR-URL: https://github.com/nodejs/node/pull/50809
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-11-21 00:49:30 +00:00
Node.js GitHub Bot
fa274693ca
tools: update lint-md-dependencies to rollup@4.5.0
...
PR-URL: https://github.com/nodejs/node/pull/50807
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2023-11-21 00:49:22 +00:00
Node.js GitHub Bot
53347445af
deps: update minimatch to 9.0.3
...
PR-URL: https://github.com/nodejs/node/pull/50806
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2023-11-21 00:49:13 +00:00