OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity

deps: V8: cherry-pick 0f9ebbc672c7

Browse Source 
Original commit message:

    [flags] Remove --harmony-string-is-well-formed

    The String.prototype.isWellFormed and toWellFormed have shipped
    since M111.

    Bug: v8:13557
    Change-Id: I27e332d2fde0f9ea8ad649c016a84d2d3e0bf592
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4931269
    Reviewed-by: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Chengzhong Wu (legendecas) <legendecas@gmail.com>
    Cr-Commit-Position: refs/heads/main@{#90398}

Refs: 0f9ebbc672
PR-URL: https://github.com/nodejs/node/pull/50867
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
This commit is contained in:
Chengzhong Wu
2023-11-24 11:38:54 +08:00
committed by GitHub
parent dd338e3429
commit fbfa77b712
3 changed files with 5 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
common.gypi
View File

@@ -36,7 +36,7 @@
# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.16',
'v8_embedder_string': '-node.17',
##### V8 defaults for Node.js #####

1
deps/v8/src/flags/flag-definitions.h vendored
View File

@@ -298,7 +298,6 @@ DEFINE_WEAK_IMPLICATION(harmony_rab_gsab_transfer, harmony_rab_gsab)
#define HARMONY_SHIPPING_BASE(V) \
V(harmony_import_assertions, "harmony import assertions") \
V(harmony_change_array_by_copy, "harmony change-Array-by-copy") \
V(harmony_string_is_well_formed, "harmony String#{is,to}WellFormed") \
V(harmony_rab_gsab, \
"harmony ResizableArrayBuffer / GrowableSharedArrayBuffer") \
V(harmony_regexp_unicode_sets, "harmony RegExp Unicode Sets") \

16
deps/v8/src/init/bootstrapper.cc vendored
View File

@@ -2158,6 +2158,8 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
Builtin::kStringPrototypeIncludes, 1, false);
SimpleInstallFunction(isolate_, prototype, "indexOf",
Builtin::kStringPrototypeIndexOf, 1, false);
SimpleInstallFunction(isolate(), prototype, "isWellFormed",
Builtin::kStringPrototypeIsWellFormed, 0, false);
SimpleInstallFunction(isolate_, prototype, "italics",
Builtin::kStringPrototypeItalics, 0, false);
SimpleInstallFunction(isolate_, prototype, "lastIndexOf",
@@ -2214,6 +2216,8 @@ void Genesis::InitializeGlobal(Handle<JSGlobalObject> global_object,
Builtin::kStringPrototypeStartsWith, 1, false);
SimpleInstallFunction(isolate_, prototype, "toString",
Builtin::kStringPrototypeToString, 0, true);
SimpleInstallFunction(isolate(), prototype, "toWellFormed",
Builtin::kStringPrototypeToWellFormed, 0, false);
SimpleInstallFunction(isolate_, prototype, "trim",
Builtin::kStringPrototypeTrim, 0, false);
@@ -5062,18 +5066,6 @@ void Genesis::InitializeGlobal_harmony_rab_gsab() {
Builtin::kSharedArrayBufferPrototypeGrow, 1, true);
}
void Genesis::InitializeGlobal_harmony_string_is_well_formed() {
if (!v8_flags.harmony_string_is_well_formed) return;
Handle<JSFunction> string_function(native_context()->string_function(),
isolate());
Handle<JSObject> string_prototype(
JSObject::cast(string_function->initial_map()->prototype()), isolate());
SimpleInstallFunction(isolate(), string_prototype, "isWellFormed",
Builtin::kStringPrototypeIsWellFormed, 0, false);
SimpleInstallFunction(isolate(), string_prototype, "toWellFormed",
Builtin::kStringPrototypeToWellFormed, 0, false);
}
void Genesis::InitializeGlobal_harmony_temporal() {
if (!v8_flags.harmony_temporal) return;
// -- T e m p o r a l