Commit Graph

5162 Commits

Author SHA1 Message Date
Ben Alpert
25fec05ab4 Add linting pre-commit hook
Anyone who wants it will have to do

```
ln -s scripts/git/pre-commit .git/hooks/pre-commit
```

or similar.
2015-09-01 14:29:52 -07:00
Jim
0ff65cc892 Merge pull request #4635 from edvinerikson/event-pooling-warning
Added warning when calling methods on a released event.
2015-08-31 10:49:01 -07:00
Ben Alpert
f641f29db0 Merge pull request #4737 from oliviertassinari/patch-1
[adler32] fix wrong name
2015-08-29 11:18:18 -07:00
Olivier Tassinari
0304051591 [adler32] fix wrong name 2015-08-29 19:07:36 +01:00
Ben Alpert
a7230de902 Merge pull request #4727 from spicyj/gh-4233
Make findDOMNode error clearer
2015-08-28 12:52:18 -07:00
Paul O’Shannessy
e53cee9af6 Merge pull request #4734 from zpao/reverse-logic
Reverse condition of a ternary for readability
2015-08-28 11:39:48 -07:00
Paul O’Shannessy
2e5b047f04 Reverse condition of a ternary for readability 2015-08-28 11:34:50 -07:00
Ben Alpert
024f71535c Merge pull request #4720 from spicyj/destructor
Add destructors to pooled classes in ReactChildren
2015-08-27 19:06:11 -07:00
Ben Alpert
16d8f20576 Add destructors to pooled classes in ReactChildren
And make destructors mandatory so we're less likely to forget again.
2015-08-27 19:05:56 -07:00
Paul O’Shannessy
bdc7ce9f01 Merge pull request #4482 from niole/issue4168
Add additional contextual information to invalid-style-prop warning
2015-08-27 18:13:29 -07:00
Niole Nelson
70c07c67b7 resolves issue #4168, style prop error now names React class that erroring element is a child of. 2015-08-27 18:10:51 -07:00
Ben Alpert
8b967052d8 Merge pull request #4732 from spicyj/eslint-undef
Enable no-undef for eslint
2015-08-27 18:07:51 -07:00
Ben Alpert
75873707f9 Enable no-undef for eslint 2015-08-27 18:03:14 -07:00
Ben Alpert
72d5b8f116 Merge pull request #4700 from spicyj/frag-array
Make createFragment return an array, disallow objects as children
2015-08-26 11:12:06 -07:00
Ben Alpert
127917d454 Merge pull request #4701 from spicyj/gh-4525
Add deprecation notice for React.addons.batchedUpdates
2015-08-25 11:40:33 -07:00
Ben Alpert
d4f38933f2 Merge pull request #4703 from spicyj/rarr
Clarify use of arrow functions
2015-08-25 11:38:13 -07:00
Ben Alpert
66881ae083 Fix formatting in test utils docs 2015-08-25 09:47:38 -07:00
Edvin Erikson
34af8f8597 Added warning when calling methods on a released event. 2015-08-25 14:45:56 +02:00
Ben Alpert
d15938cd92 Clarify use of arrow functions
Per 1db20999f0 (commitcomment-12865588).
2015-08-24 17:21:10 -07:00
Ben Alpert
e64b402df9 Add deprecation notice for React.addons.batchedUpdates
Fixes #4525.
2015-08-24 16:20:56 -07:00
Ben Alpert
6a2cdd58a4 Make findDOMNode error clearer
Fixes #4233.
2015-08-24 16:15:44 -07:00
Ben Alpert
6abf025d46 Make createFragment return an array, disallow objects as children 2015-08-24 16:09:08 -07:00
Paul O’Shannessy
10c8166043 Merge pull request #4682 from lyip1992/patch-2
Update Gruntfile.js
2015-08-22 16:11:04 -07:00
Paul O’Shannessy
27e5a563db Merge pull request #4684 from lyip1992/patch-3
Update 10.1-animation.md
2015-08-22 16:10:05 -07:00
Paul O’Shannessy
d5e5261e38 Merge pull request #4686 from lyip1992/patch-5
Update 06-transferring-props.md
2015-08-22 16:09:02 -07:00
Paul O’Shannessy
7dbcff2df4 Merge pull request #4687 from lyip1992/patch-6
Update 04-multiple-components.md
2015-08-22 16:08:27 -07:00
Paul O’Shannessy
cca1065183 Merge pull request #4688 from lyip1992/patch-7
Update 02.3-jsx-gotchas.md
2015-08-22 16:08:02 -07:00
Paul O’Shannessy
adfbc64d4b Merge pull request #4685 from lyip1992/patch-4
Update 08.1-more-about-refs.md
2015-08-22 16:07:20 -07:00
Leon Yip
71454365f2 Update 02.3-jsx-gotchas.md
Fix typo.
2015-08-22 00:57:51 -07:00
Leon Yip
2f4ea60571 Update 04-multiple-components.md
Added an extra word to make the sentence read a little easier.
2015-08-22 00:56:23 -07:00
Leon Yip
f8fe717ea2 Update 06-transferring-props.md
"This ensures that" sounds a better than "That ensures that." This change is just my personal opinion, so I totally understand my change doesn't get merged.
2015-08-22 00:51:38 -07:00
Leon Yip
3849710d8b Update 08.1-more-about-refs.md
Change render to `render()` for consistency within the paragraph.
2015-08-22 00:46:18 -07:00
Leon Yip
c0e21d1b85 Update 10.1-animation.md
Changed "if" to "even when" for clarity.
2015-08-22 00:42:25 -07:00
Leon Yip
e99e8b66b2 Update Gruntfile.js
Added punctuation to make the comment consistent with other comments.
2015-08-21 18:06:55 -07:00
Paul O’Shannessy
6508b1ad27 Merge pull request #4678 from ning-github/patch-1
Remove redundancy regarding 'latest React news'
2015-08-21 17:48:57 -07:00
Ning Xia
b629289cea Fix repetition by editing second sentence
edited based on paul's input
2015-08-21 16:33:20 -07:00
Jim
b36ee449cb Merge pull request #4679 from ning-github/patch-2
Fix typo
2015-08-21 13:28:33 -07:00
Ning Xia
3232a59743 Fix typo
Can not should be a single word: 'cannot'
2015-08-21 13:26:58 -07:00
Ning Xia
5ba1831d76 Remove redundancy regarding 'latest React news'
Previously, it repeated 'latest React news' when the first sentence already begins with the same words.
2015-08-21 13:00:24 -07:00
Ben Alpert
80b7391d64 Merge pull request #2081 from rexxars/search-input-attributes
Allow `results` and `autosave` attributes (WebKit/Blink)
2015-08-21 09:27:06 -07:00
Espen Hovlandsdal
75805e4835 Allow results and autosave attributes (WebKit/Blink) 2015-08-21 10:10:32 +02:00
Paul O’Shannessy
b38509cade Merge pull request #4540 from scottburch/ie8-fix
removed dangling comma that messes up loading in IE8
2015-08-20 14:37:20 -07:00
Paul O’Shannessy
0f963bb478 Merge pull request #4654 from zpao/checkversionsoninstall
Check for compatible node,npm versions on install
2015-08-20 14:36:09 -07:00
Ben Alpert
61962c1751 Capitalize Babel 2015-08-20 13:34:04 -07:00
Ben Alpert
cd268fdfcd Merge pull request #4546 from rgbkrk/patch-1
Update tooling docs to suggest babel
2015-08-20 13:16:11 -07:00
Kyle Kelley
009902bcd0 Update tooling docs to suggest babel
`react-tools` is deprecated, `babel` is our future

* https://facebook.github.io/react/blog/2015/06/12/deprecating-jstransform-and-react-tools.html
* https://babeljs.io/docs/usage/jsx/
2015-08-20 14:24:20 -05:00
Ben Alpert
5fa72c2659 Merge pull request #4666 from spicyj/prod
Add a simple production-mode sanity check test
2015-08-20 11:03:09 -07:00
Ben Alpert
102fafce7f Add a simple production-mode sanity check test 2015-08-19 22:26:42 -07:00
Ben Alpert
ea827eb39d Merge pull request #4561 from djrodgerspryor/css_transition_group_robust_cleanup
Robust animation-end handling in ReactCSSTransitionGroup
2015-08-19 19:15:51 -07:00
Daniel Rodgers-Pryor
6bd6ef208b ReactCSSTransitionGroup timeouts
As discussed in issue 1326
(https://github.com/facebook/react/issues/1326) transitionend events are
unreliable; they may not fire because the element is no longer painted,
the browser tab is no longer focused or for a range of other reasons.
This is particularly harmful during leave transitions since the leaving
element will be permanently stuck in the DOM (and possibly visible).

The ReactCSSTransitionGroup now requires timeouts to be passed in
explicitly for each type of animation. Omitting the timeout duration
for a transition now triggers a PropTypes warning with a link to the
updated documentation.
2015-08-20 11:38:27 +10:00