OSSForks/react
1
0
Fork 0
mirror of https://github.com/zebrajr/react.git synced 2026-01-15 12:15:22 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Remove "unstable" warning from ReactDOM (#10017)

Browse Source 
* Remove "unstable" warning from ReactDOM

* Remove assertion about the warning

* There's more!
This commit is contained in:
Dan Abramov
2017-06-21 19:06:25 +01:00
committed by GitHub
parent e68e95284b
commit df10073f7d
2 changed files with 0 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/renderers/__tests__/refs-test.js
View File

@@ -316,7 +316,6 @@ describe('string refs between fiber and stack', () => {
});
it('attaches, detaches from fiber component with stack layer', () => {
spyOn(console, 'error');
const ReactCurrentOwner = require('ReactCurrentOwner');
const ReactDOMStack = require('ReactDOMStackEntry');
@@ -353,18 +352,9 @@ describe('string refs between fiber and stack', () => {
ReactDOMFiber.unmountComponentAtNode(container);
expect(a.refs.span).toBe(undefined);
expect(layerMounted).toBe(true);
if (!ReactDOMFeatureFlags.useFiber) {
expectDev(console.error.calls.count()).toBe(1);
expectDev(console.error.calls.argsFor(0)[0]).toBe(
'Warning: You are using React DOM Fiber which is an experimental ' +
'renderer. It is likely to have bugs, breaking changes and is ' +
'unsupported.',
);
}
});
it('attaches, detaches from stack component with fiber layer', () => {
spyOn(console, 'error');
const ReactCurrentOwner = require('ReactCurrentOwner');
const ReactDOM = require('ReactDOMStackEntry');
const ReactDOMFiber = require('ReactDOMFiberEntry');
@@ -400,14 +390,6 @@ describe('string refs between fiber and stack', () => {
ReactDOM.unmountComponentAtNode(container);
expect(a.refs.span).toBe(undefined);
expect(layerMounted).toBe(true);
if (!ReactDOMFeatureFlags.useFiber) {
expectDev(console.error.calls.count()).toBe(1);
expectDev(console.error.calls.argsFor(0)[0]).toBe(
'Warning: You are using React DOM Fiber which is an experimental ' +
'renderer. It is likely to have bugs, breaking changes and is ' +
'unsupported.',
);
}
});
});

13
src/renderers/dom/fiber/ReactDOMFiberEntry.js
View File

@@ -454,18 +454,6 @@ ReactGenericBatching.injection.injectFiberBatchedUpdates(
DOMRenderer.batchedUpdates,
);
var warned = false;
function warnAboutUnstableUse() {
// Ignore this warning is the feature flag is turned on. E.g. for tests.
warning(
warned || ReactDOMFeatureFlags.useFiber,
'You are using React DOM Fiber which is an experimental renderer. ' +
'It is likely to have bugs, breaking changes and is unsupported.',
);
warned = true;
}
function renderSubtreeIntoContainer(
parentComponent: ?ReactComponent<any, any, any>,
children: ReactNodeList,
@@ -588,7 +576,6 @@ var ReactDOMFiber = {
isValidContainer(container),
'unmountComponentAtNode(...): Target container is not a DOM element.',
);
warnAboutUnstableUse();
if (container._reactRootContainer) {
if (__DEV__) {