OSSForks/react
1
0
Fork 0
mirror of https://github.com/zebrajr/react.git synced 2026-01-15 12:15:22 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

prevent removing attributes on custom component tags (#12702)

Browse Source
This commit is contained in:
Airam
2018-04-28 21:52:30 +02:00
committed by Dan Abramov
parent 045d4f166d
commit dcc854bcc3
2 changed files with 9 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
packages/react-dom/src/__tests__/DOMPropertyOperations-test.js vendored
View File

@@ -155,5 +155,11 @@ describe('DOMPropertyOperations', () => {
expect(container.firstChild.getAttribute('value')).toBe('foo');
expect(container.firstChild.value).toBe('foo');
});
it('should not remove attributes for custom component tag', () => {
const container = document.createElement('div');
ReactDOM.render(<my-icon size="5px" />, container);
expect(container.firstChild.getAttribute('size')).toBe('5px');
});
});
});

3
packages/react-dom/src/shared/DOMProperty.js vendored
View File

@@ -157,6 +157,9 @@ export function shouldRemoveAttribute(
) {
return true;
}
if (isCustomComponentTag) {
return false;
}
if (propertyInfo !== null) {
switch (propertyInfo.type) {
case BOOLEAN: