OSSForks/react
1
0
Fork 0
mirror of https://github.com/zebrajr/react.git synced 2026-01-15 12:15:22 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Fix ReactFreshIntegration-test not running all tests as assumed (#28033)

Browse Source 
Fix ReactFreshIntegration-test not running all tests as assumed

`testCommon` was executed twice without setting `compileDestructuring`
ever to true.
This fixes this and removes one layer of abstraction in this test by
using `describe.each`.
This commit is contained in:
Jan Kassens
2024-01-23 09:59:14 -05:00
committed by GitHub
parent bf32989264
commit cb9899955b
1 changed files with 33 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

64
packages/react-refresh/src/__tests__/ReactFreshIntegration-test.js vendored
View File

@@ -47,7 +47,7 @@ describe('ReactFreshIntegration', () => {
}
});
function executeCommon(source, compileDestructuring) {
function executeJavaScript(source, compileDestructuring) {
const compiled = babel.transform(source, {
babelrc: false,
presets: ['@babel/react'],
@@ -60,6 +60,22 @@ describe('ReactFreshIntegration', () => {
return executeCompiled(compiled);
}
function executeTypescript(source) {
const typescriptSource = babel.transform(source, {
babelrc: false,
configFile: false,
presets: ['@babel/react'],
plugins: [
[freshPlugin, {skipEnvCheck: true}],
['@babel/plugin-syntax-typescript', {isTSX: true}],
],
}).code;
const compiled = ts.transpileModule(typescriptSource, {
module: ts.ModuleKind.CommonJS,
}).outputText;
return executeCompiled(compiled);
}
function executeCompiled(compiled) {
exportsObj = {};
// eslint-disable-next-line no-new-func
@@ -86,33 +102,19 @@ describe('ReactFreshIntegration', () => {
return ReactFreshRuntime.createSignatureFunctionForTransform();
}
describe('with compiled destructuring', () => {
runTests(executeCommon, testCommon);
});
describe('without compiled destructuring', () => {
runTests(executeCommon, testCommon);
});
describe('with typescript syntax', () => {
runTests(function (source) {
const typescriptSource = babel.transform(source, {
babelrc: false,
configFile: false,
presets: ['@babel/react'],
plugins: [
[freshPlugin, {skipEnvCheck: true}],
['@babel/plugin-syntax-typescript', {isTSX: true}],
],
}).code;
const compiled = ts.transpileModule(typescriptSource, {
module: ts.ModuleKind.CommonJS,
}).outputText;
return executeCompiled(compiled);
}, testTypescript);
});
function runTests(execute, test) {
describe.each([
[
'JavaScript syntax with destructuring enabled',
source => executeJavaScript(source, true),
testJavaScript,
],
[
'JavaScript syntax with destructuring disabled',
source => executeJavaScript(source, false),
testJavaScript,
],
['TypeScript syntax', executeTypescript, testTypeScript],
])('%s', (language, execute, test) => {
function render(source) {
const Component = execute(source);
act(() => {
@@ -159,9 +161,9 @@ describe('ReactFreshIntegration', () => {
}
test(render, patch);
}
});
function testCommon(render, patch) {
function testJavaScript(render, patch) {
it('reloads function declarations', () => {
if (__DEV__) {
render(`
@@ -1975,7 +1977,7 @@ describe('ReactFreshIntegration', () => {
});
}
function testTypescript(render, patch) {
function testTypeScript(render, patch) {
it('reloads component exported in typescript namespace', () => {
if (__DEV__) {
render(`