OSSForks/react
1
0
Fork 0
mirror of https://github.com/zebrajr/react.git synced 2026-01-15 12:15:22 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Update DOM warning wording and link (#10819)

Browse Source 
* Update DOM warning wording and link

* Consistently use "Invalid" for known misspellings
This commit is contained in:
Dan Abramov
2017-09-26 00:28:28 +01:00
committed by GitHub
parent 6e8c09c363
commit b24d23d3e8
3 changed files with 21 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/renderers/dom/shared/__tests__/ReactDOMAttribute-test.js
View File

@@ -112,9 +112,9 @@ describe('ReactDOM unknown attribute', () => {
testUnknownAttributeRemoval(Symbol('foo'));
expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toBe(
'Warning: Invalid prop `unknown` on <div> tag. Either remove this ' +
'prop from the element, or pass a string or number value to keep it ' +
'in the DOM. For details, see https://fb.me/react-unknown-prop\n' +
'Warning: Invalid value for prop `unknown` on <div> tag. Either remove it ' +
'from the element, or pass a string or number value to keep it ' +
'in the DOM. For details, see https://fb.me/react-attribute-behavior\n' +
' in div (at **)',
);
expectDev(console.error.calls.count()).toBe(1);
@@ -125,10 +125,10 @@ describe('ReactDOM unknown attribute', () => {
testUnknownAttributeRemoval(function someFunction() {});
expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toBe(
'Warning: Invalid prop `unknown` on <div> tag. Either remove this ' +
'prop from the element, or pass a string or number value to ' +
'Warning: Invalid value for prop `unknown` on <div> tag. Either remove ' +
'it from the element, or pass a string or number value to ' +
'keep it in the DOM. For details, see ' +
'https://fb.me/react-unknown-prop\n' +
'https://fb.me/react-attribute-behavior\n' +
' in div (at **)',
);
expectDev(console.error.calls.count()).toBe(1);

20
src/renderers/dom/shared/__tests__/ReactDOMComponent-test.js
View File

@@ -148,9 +148,9 @@ describe('ReactDOMComponent', () => {
ReactDOM.render(<div foo={() => {}} />, container);
expectDev(console.error.calls.count(0)).toBe(1);
expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toBe(
'Warning: Invalid prop `foo` on <div> tag. Either remove this prop ' +
'Warning: Invalid value for prop `foo` on <div> tag. Either remove it ' +
'from the element, or pass a string or number value to keep ' +
'it in the DOM. For details, see https://fb.me/react-unknown-prop' +
'it in the DOM. For details, see https://fb.me/react-attribute-behavior' +
'\n in div (at **)',
);
});
@@ -161,9 +161,9 @@ describe('ReactDOMComponent', () => {
ReactDOM.render(<div foo={() => {}} baz={() => {}} />, container);
expectDev(console.error.calls.count(0)).toBe(1);
expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toBe(
'Warning: Invalid props `foo`, `baz` on <div> tag. Either remove these ' +
'props from the element, or pass a string or number value to keep ' +
'them in the DOM. For details, see https://fb.me/react-unknown-prop' +
'Warning: Invalid values for props `foo`, `baz` on <div> tag. Either remove ' +
'them from the element, or pass a string or number value to keep ' +
'them in the DOM. For details, see https://fb.me/react-attribute-behavior' +
'\n in div (at **)',
);
});
@@ -174,7 +174,7 @@ describe('ReactDOMComponent', () => {
ReactDOM.render(<div onDblClick={() => {}} />, container);
expectDev(console.error.calls.count(0)).toBe(1);
expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(0)[0])).toBe(
'Warning: Unknown event handler property `onDblClick`. Did you mean `onDoubleClick`?\n in div (at **)',
'Warning: Invalid event handler property `onDblClick`. Did you mean `onDoubleClick`?\n in div (at **)',
);
});
@@ -1732,7 +1732,7 @@ describe('ReactDOMComponent', () => {
'Warning: Invalid DOM property `class`. Did you mean `className`?\n in div (at **)',
);
expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(1)[0])).toBe(
'Warning: Unknown event handler property `onclick`. Did you mean ' +
'Warning: Invalid event handler property `onclick`. Did you mean ' +
'`onClick`?\n in input (at **)',
);
});
@@ -1746,7 +1746,7 @@ describe('ReactDOMComponent', () => {
'Warning: Invalid DOM property `class`. Did you mean `className`?\n in div (at **)',
);
expectDev(normalizeCodeLocInfo(console.error.calls.argsFor(1)[0])).toBe(
'Warning: Unknown event handler property `onclick`. Did you mean ' +
'Warning: Invalid event handler property `onclick`. Did you mean ' +
'`onClick`?\n in input (at **)',
);
});
@@ -2115,7 +2115,7 @@ describe('ReactDOMComponent', () => {
expect(el.hasAttribute('whatever')).toBe(false);
expectDev(console.error.calls.argsFor(0)[0]).toContain(
'Warning: Invalid prop `whatever` on <div> tag',
'Warning: Invalid value for prop `whatever` on <div> tag',
);
});
@@ -2186,7 +2186,7 @@ describe('ReactDOMComponent', () => {
expect(el.hasAttribute('whatever')).toBe(false);
expectDev(console.error.calls.argsFor(0)[0]).toContain(
'Warning: Invalid prop `whatever` on <div> tag.',
'Warning: Invalid value for prop `whatever` on <div> tag.',
);
});

10
src/renderers/dom/shared/hooks/ReactDOMUnknownPropertyHook.js
View File

@@ -73,7 +73,7 @@ if (__DEV__) {
if (registrationName != null) {
warning(
false,
'Unknown event handler property `%s`. Did you mean `%s`?%s',
'Invalid event handler property `%s`. Did you mean `%s`?%s',
name,
registrationName,
getStackAddendum(debugID),
@@ -234,9 +234,9 @@ var warnUnknownProperties = function(type, props, debugID) {
if (unknownProps.length === 1) {
warning(
false,
'Invalid prop %s on <%s> tag. Either remove this prop from the element, ' +
'Invalid value for prop %s on <%s> tag. Either remove it from the element, ' +
'or pass a string or number value to keep it in the DOM. ' +
'For details, see https://fb.me/react-unknown-prop%s',
'For details, see https://fb.me/react-attribute-behavior%s',
unknownPropString,
type,
getStackAddendum(debugID),
@@ -244,9 +244,9 @@ var warnUnknownProperties = function(type, props, debugID) {
} else if (unknownProps.length > 1) {
warning(
false,
'Invalid props %s on <%s> tag. Either remove these props from the element, ' +
'Invalid values for props %s on <%s> tag. Either remove them from the element, ' +
'or pass a string or number value to keep them in the DOM. ' +
'For details, see https://fb.me/react-unknown-prop%s',
'For details, see https://fb.me/react-attribute-behavior%s',
unknownPropString,
type,
getStackAddendum(debugID),