Overly eager update-notifier usage in react-devtools (#20078)

Co-authored-by: abhyuday <abhyuday@miqdigital.com>
This commit is contained in:
Abhyuday Bharat
2020-10-22 18:22:14 +05:30
committed by GitHub
parent eaaf4cbce7
commit 3314115cb4

View File

@@ -15,8 +15,19 @@ const argv = process.argv.slice(2);
const pkg = require('./package.json');
const updateNotifier = require('update-notifier');
// notify if there's an update
updateNotifier({pkg}).notify({defer: false});
// Notify if there's an update in 7 days' interval
const notifier = updateNotifier({
pkg,
updateCheckInterval: 1000 * 60 * 60 * 24 * 7,
});
if (notifier.update) {
const updateMsg =
`Update available ${notifier.update.current} -> ${notifier.update.latest}` +
'\nTo update:' +
'\n"npm i [-g] react-devtools" or "yarn add react-devtools"';
notifier.notify({defer: false, message: updateMsg});
}
const result = spawn.sync(electron, [require.resolve('./app')].concat(argv), {
stdio: 'ignore',