OSSForks/react
1
0
Fork 0
mirror of https://github.com/zebrajr/react.git synced 2026-01-15 12:15:22 +00:00
Code Issues Actions 6 Packages Projects Releases Wiki Activity

[DevTools] Avoid uncached Promise when symbolicating sources in environments without file fetching (#34224)

Browse Source
This commit is contained in:
Sebastian "Sebbie" Silbermann
2025-08-18 12:46:19 +02:00
committed by GitHub
parent b58a8e3c40
commit 01ed0e9642
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
packages/react-devtools-shared/src/devtools/views/Components/InspectedElement.js vendored
View File

@@ -34,6 +34,8 @@ export type Props = {};
// TODO Make edits and deletes also use transition API!
const noSourcePromise = Promise.resolve(null);
export default function InspectedElementWrapper(_: Props): React.Node {
const {inspectedElementID} = useContext(TreeStateContext);
const bridge = useContext(BridgeContext);
@@ -59,11 +61,11 @@ export default function InspectedElementWrapper(_: Props): React.Node {
? inspectedElement.stack[0]
: null;
const symbolicatedSourcePromise: null | Promise<ReactFunctionLocation | null> =
const symbolicatedSourcePromise: Promise<ReactFunctionLocation | null> =
React.useMemo(() => {
if (fetchFileWithCaching == null) return Promise.resolve(null);
if (fetchFileWithCaching == null) return noSourcePromise;
if (source == null) return Promise.resolve(null);
if (source == null) return noSourcePromise;
const [, sourceURL, line, column] = source;
return symbolicateSourceWithCache(
@@ -291,7 +293,7 @@ export default function InspectedElementWrapper(_: Props): React.Node {
<div className={styles.Loading}>Loading...</div>
)}
{inspectedElement !== null && symbolicatedSourcePromise != null && (
{inspectedElement !== null && (
<InspectedElementView
element={element}
hookNames={hookNames}