OSSForks/pytorch
1
0
Fork 0
mirror of https://github.com/zebrajr/pytorch.git synced 2026-01-15 12:15:51 +00:00
Code Issues Actions 51 Packages Projects Releases Wiki Activity

Fix inline_container_test on Windows (#109754)

Browse Source 
Fix the failure mentioned in https://github.com/pytorch/pytorch/pull/109393. The reason is that IO streams were not opened in binary mode while binary data was written and read. Interestingly, the test passed on Linux.

Pull Request resolved: https://github.com/pytorch/pytorch/pull/109754
Approved by: https://github.com/malfet
This commit is contained in:
cyy
2023-09-21 07:46:21 +00:00
committed by PyTorch MergeBot
parent b780b246eb
commit f5b753bab1
1 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
caffe2/serialize/inline_container_test.cc
View File

@@ -347,10 +347,6 @@ INSTANTIATE_TEST_SUITE_P(
testing::Values(100, 150, 1010));
TEST_P(ChunkRecordIteratorTest, ChunkRead) {
#ifdef _WIN32
GTEST_SKIP() << "Failing on windows";
return;
#endif
auto chunkSize = GetParam();
std::string zipFileName = "output_chunk_" + std::to_string(chunkSize) + ".zip";
const char* fileName = zipFileName.c_str();
@@ -358,7 +354,7 @@ TEST_P(ChunkRecordIteratorTest, ChunkRead) {
const size_t tensorDataSizeInBytes = 1000;
// write records through writers
std::ostringstream oss;
std::ostringstream oss(std::ios::binary);
PyTorchStreamWriter writer([&](const void* b, size_t n) -> size_t {
oss.write(static_cast<const char*>(b), n);
return oss ? n : 0;
@@ -375,7 +371,7 @@ TEST_P(ChunkRecordIteratorTest, ChunkRead) {
ASSERT_EQ(written_records.count(kSerializationIdRecordName), 1);
std::string the_file = oss.str();
std::ofstream foo(fileName);
std::ofstream foo(fileName, std::ios::binary);
foo.write(the_file.c_str(), the_file.size());
foo.close();
LOG(INFO) << "Finished saving tensor into zip file " << fileName;