OSSForks/postgres
1
0
Fork 0
mirror of https://github.com/zebrajr/postgres.git synced 2026-01-15 12:15:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix a strict aliasing violation

Browse Source 
This one is almost a textbook example of an aliasing violation, and it
is straightforward to fix, so clean it up.  (The warning only shows up
if you remove the -fno-strict-aliasing option.)  Also, move the code
after the error checking.  Doesn't make a difference technically, but
it seems strange to do actions before errors are checked.

Reported-by: Tatsuo Ishii <ishii@postgresql.org>
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/20240724.155525.366150353176322967.ishii%40postgresql.org
This commit is contained in:
Peter Eisentraut
2025-12-01 16:34:19 +01:00
parent a87987cafc
commit 2fcc5a7151
1 changed files with 7 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/backend/replication/logical/origin.c
View File

@@ -789,14 +789,6 @@ StartupReplicationOrigin(void)
readBytes = read(fd, &disk_state, sizeof(disk_state));
/* no further data */
if (readBytes == sizeof(crc))
{
/* not pretty, but simple ... */
file_crc = *(pg_crc32c *) &disk_state;
break;
}
if (readBytes < 0)
{
ereport(PANIC,
@@ -805,6 +797,13 @@ StartupReplicationOrigin(void)
path)));
}
/* no further data */
if (readBytes == sizeof(crc))
{
memcpy(&file_crc, &disk_state, sizeof(file_crc));
break;
}
if (readBytes != sizeof(disk_state))
{
ereport(PANIC,