Denys Otrishko 78ca61e2cf net: check args in net.connect() and socket.connect() calls ...

Previously Node.js would handle empty `net.connect()` and
`socket.connect()` call as if the user passed empty options object which
doesn't really make sense. This was due to the fact that it uses the
same `normalizeArgs` function as `.listen()` call where such call is
perfectly fine.

This will make it clear what is the problem with such call and how it
can be resolved. It now throws `ERR_MISSING_ARGS` if no arguments were
passed or neither `path` nor `port` is specified.

Fixes: https://github.com/nodejs/node/issues/33930

PR-URL: https://github.com/nodejs/node/pull/34022
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>

2020-06-24 14:45:10 -07:00

..

dns

dns: add dns/promises alias

2020-05-24 03:26:21 +02:00

fs

fs: add fs/promises alias module

2020-02-18 22:15:50 -08:00

internal

lib: handle one of args case in ERR_MISSING_ARGS

2020-06-24 14:45:08 -07:00

timers

timers: introduce timers/promises

2020-06-22 14:29:49 -07:00

_http_agent.js

http: add maxTotalSockets to agent class

2020-06-21 18:20:05 +02:00

_http_client.js

http: expose host and protocol on ClientRequest

2020-06-22 16:52:29 +02:00

_http_common.js

lib: improve debuglog() performance

2020-05-30 17:24:43 -04:00

_http_incoming.js

tools: enable no-else-return lint rule

2020-05-16 06:42:16 +02:00

_http_outgoing.js

http: don't emit error after close

2020-06-21 17:21:12 +02:00

_http_server.js

http: don't emit error after close

2020-06-21 17:21:12 +02:00

_stream_duplex.js

stream: fix the spellings

2020-06-07 12:14:49 +02:00

_stream_passthrough.js

lib: flatten access to primordials

2019-11-25 10:28:15 +01:00

_stream_readable.js

lib: improve debuglog() performance

2020-05-30 17:24:43 -04:00

_stream_transform.js

stream: fix _final and 'prefinish' timing

2020-04-22 09:40:03 +02:00

_stream_wrap.js

…

_stream_writable.js

stream: construct

2020-05-27 10:24:05 +02:00

_tls_common.js

tls: for...of in _tls_common.js

2019-12-17 08:11:13 -05:00

_tls_wrap.js

tls: emit session after verifying certificate

2020-06-02 20:35:51 +02:00

.eslintrc.yaml

lib: add Int16Array primordials

2020-06-02 15:38:59 +02:00

assert.js

assert: port common.mustCall() to assert

2020-04-23 10:11:47 -07:00

async_hooks.js

async_hooks: move PromiseHook handler to JS

2020-05-09 07:52:22 +02:00

buffer.js

buffer: remove hoisted variable

2020-05-23 20:47:02 +02:00

child_process.js

lib: improve debuglog() performance

2020-05-30 17:24:43 -04:00

cluster.js

…

console.js

…

constants.js

lib: flatten access to primordials

2019-11-25 10:28:15 +01:00

crypto.js

tls: provide default cipher list from command line

2020-04-13 18:48:23 +02:00

dgram.js

dgram: allow typed arrays in .send()

2020-06-19 07:40:11 -07:00

dns.js

tools: enable no-else-return lint rule

2020-05-16 06:42:16 +02:00

domain.js

domain: remove native domain code

2020-06-19 17:37:26 +02:00

events.js

events: fix EventTarget support

2020-06-23 17:08:09 -07:00

fs.js

fs: implement lutimes

2020-06-23 09:14:28 +00:00

http2.js

…

http.js

http: tidy up exposure of header validation

2020-05-25 19:21:57 +02:00

https.js

lib: improve debuglog() performance

2020-05-30 17:24:43 -04:00

inspector.js

inspector: throw error when activating an already active inspector

2020-05-24 03:43:05 +02:00

module.js

module: add API for interacting with source maps

2020-01-14 12:39:06 -08:00

net.js

net: check args in net.connect() and socket.connect() calls

2020-06-24 14:45:10 -07:00

os.js

src: create a getter for kernel version

2020-03-09 12:44:16 +01:00

path.js

path: fix comment grammar

2020-04-28 19:10:26 +02:00

perf_hooks.js

perf_hooks: fix error message for invalid entryTypes

2020-05-10 13:53:15 +02:00

process.js

…

punycode.js

lib: use strict equality comparison

2019-12-14 08:57:36 -05:00

querystring.js

querystring: improve stringify() performance

2020-06-12 18:21:44 -04:00

readline.js

lib: update TODO comments

2020-05-20 17:05:06 +02:00

repl.js

lib: improve debuglog() performance

2020-05-30 17:24:43 -04:00

stream.js

stream: simplify uint8ArrayToBuffer helper

2019-10-22 13:37:59 -05:00

string_decoder.js

lib: replace Symbol global by the primordials Symbol

2019-12-08 13:38:58 +01:00

sys.js

…

timers.js

timers: introduce timers/promises

2020-06-22 14:29:49 -07:00

tls.js

tls: provide default cipher list from command line

2020-04-13 18:48:23 +02:00

trace_events.js

lib: replace Set global by the primordials

2020-01-04 12:41:09 -08:00

tty.js

lib: use static Number properties from primordials

2019-11-30 13:45:38 +01:00

url.js

url: declare iterator inside loop

2019-12-11 16:38:06 -06:00

util.js

lib: replace use of Error with primordials

2020-01-04 14:50:18 -08:00

v8.js

tools: enable no-else-return lint rule

2020-05-16 06:42:16 +02:00

vm.js

tools: enable no-else-return lint rule

2020-05-16 06:42:16 +02:00

wasi.js

wasi: allow WASI stdio to be configured

2020-05-30 04:28:02 +02:00

worker_threads.js

worker: allow specifying resource limits

2019-11-05 19:57:13 +01:00

zlib.js

zlib: add maxOutputLength option

2020-06-09 17:26:10 +02:00