Commit Graph

16 Commits

Author SHA1 Message Date
Antoine du Hamel
feb3aa205b repl: use SafePromiseAll and SafePromiseRace
PR-URL: https://github.com/nodejs/node/pull/43758
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2022-07-12 22:50:35 +01:00
Antoine du Hamel
a055337a02 lib: refactor to avoid unsafe regex primordials
PR-URL: https://github.com/nodejs/node/pull/43475
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
2022-06-27 17:16:06 +02:00
Antoine du Hamel
358008f473 tools,doc: add guards against prototype pollution when creating proxies
PR-URL: https://github.com/nodejs/node/pull/43391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
2022-06-16 00:26:48 +02:00
Antoine du Hamel
06d8606960 lib: use null-prototype objects for property descriptors
Refs: https://github.com/nodejs/node/pull/42921

PR-URL: https://github.com/nodejs/node/pull/43270
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
2022-06-03 09:23:58 +01:00
Kohei Ueno
cbb92b0dde debugger: throw a more useful error when the frame is missing
PR-URL: https://github.com/nodejs/node/pull/42776
Fixes: https://github.com/nodejs/node/issues/42775
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2022-05-22 15:09:14 +02:00
Kohei Ueno
f890ef5306 debugger: fix inconsistent inspector output of exec new Map()
PR-URL: https://github.com/nodejs/node/pull/42423
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2022-05-08 20:51:38 +01:00
Kohei Ueno
1f638376c7 debugger: correct typo in inspect_repl.js
PR-URL: https://github.com/nodejs/node/pull/42267
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
2022-03-09 19:34:39 +00:00
Xuguang Mei
7d75e3f542 debugger: add debugger alias for exec(expr)
https://github.com/nodejs/node/issues/41794

PR-URL: https://github.com/nodejs/node/pull/41907
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2022-02-17 19:23:20 +00:00
Balakrishna Avulapati
937288aeab debugger: remove duplicate setPauseOnException call
Removes the duplicate call of setPauseOnException() inside
initAfterStart().

Fixes: https://github.com/nodejs/node/issues/41795

PR-URL: https://github.com/nodejs/node/pull/41838
Reviewed-By: Jan Krems <jan.krems@gmail.com>
2022-02-11 11:47:20 +00:00
gdccwxx
ac4f5e2437 lib: refactor to use let
move variable into each for loop

PR-URL: https://github.com/nodejs/node/pull/40364
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2021-10-09 17:22:56 +00:00
Rich Trott
16a9ab142c debugger: prevent simultaneous heap snapshots
Fixes: https://github.com/nodejs/node/issues/39555

PR-URL: https://github.com/nodejs/node/pull/39638
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2021-08-05 11:52:55 +00:00
Rich Trott
1c6f26d347 debugger: remove undefined parameter
The data parameter of unpackError() is typically undefined.

PR-URL: https://github.com/nodejs/node/pull/39570
Refs: https://github.com/nodejs/node-inspect/issues/101
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2021-08-01 14:24:35 +00:00
Chris Opperwall
f52da9484d debugger: validate sec-websocket-accept response header
This addresses a TODO to validate that the sec-websocket-accept header
in the WebSocket handshake response is valid. To do this we need to
append the WebSocket GUID to the original key sent in sec-websocket-key,
sha1 hash it, and then compare the base64 encoding with the value sent
in the sec-websocket-accept response header.

If they don't match, an error is thrown.

PR-URL: https://github.com/nodejs/node/pull/39357
Refs: https://github.com/nodejs/node-inspect/pull/93
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2021-07-18 14:53:23 -07:00
Rich Trott
c12db606ee debugger: rename internal module
All other files in `lib/internal` do not start with `_`. For
consistency, move `lib/internal/debugger/_inspect.js` to
`lib/internal/debugger/inspect.js`.

PR-URL: https://github.com/nodejs/node/pull/39378
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-07-15 17:19:07 -07:00
Rich Trott
3c099874aa debugger: remove final lint exceptions in inspect_repl.js
Adding a return when it's not really a getter is kind of misleading, but
so is using a getter for something that doesn't return anything, so
¯\_(ツ)_/¯.

PR-URL: https://github.com/nodejs/node/pull/39078
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2021-06-25 22:05:18 -07:00
Rich Trott
4330fb757f debugger: rename internal library for clarity
When I moved these files from node-inspect to Node.js core, I put them
in lib/internal/inspector. That was a mistake. They should be in
lib/internal/debugger.

PR-URL: https://github.com/nodejs/node/pull/39080
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2021-06-20 22:33:32 -07:00