debugger: add debugger alias for exec(expr)

https://github.com/nodejs/node/issues/41794

PR-URL: https://github.com/nodejs/node/pull/41907
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
This commit is contained in:
Xuguang Mei
2022-02-18 03:23:20 +08:00
committed by GitHub
parent 4829f85233
commit 7d75e3f542
3 changed files with 22 additions and 3 deletions

View File

@@ -197,7 +197,8 @@ debug>
* `watchers`: List all watchers and their values (automatically listed on each
breakpoint)
* `repl`: Open debugger's repl for evaluation in debugging script's context
* `exec expr`: Execute an expression in debugging script's context
* `exec expr`, `p expr`: Execute an expression in debugging script's context and
print its value
### Execution control

View File

@@ -68,6 +68,7 @@ const SHORTCUTS = {
setBreakpoint: 'sb',
clearBreakpoint: 'cb',
run: 'r',
exec: 'p'
};
const HELP = StringPrototypeTrim(`
@@ -93,7 +94,8 @@ watch(expr) Start watching the given expression
unwatch(expr) Stop watching an expression
watchers Print all watched expressions and their current values
exec(expr) Evaluate the expression and print the value
exec(expr), p(expr), exec expr, p expr
Evaluate the expression and print the value
repl Enter a debug repl that works like exec
scripts List application scripts that are currently loaded
@@ -530,7 +532,7 @@ function createRepl(inspector) {
function prepareControlCode(input) {
if (input === '\n') return lastCommand;
// Add parentheses: exec process.title => exec("process.title");
const match = RegExpPrototypeSymbolMatch(/^\s*exec\s+([^\n]*)/, input);
const match = RegExpPrototypeSymbolMatch(/^\s*(?:exec|p)\s+([^\n]*)/, input);
if (match) {
lastCommand = `exec(${JSONStringify(match[1])})`;
} else {

View File

@@ -27,6 +27,14 @@ const assert = require('assert');
'works w/o paren'
);
})
.then(() => cli.command('p [typeof heartbeat, typeof process.exit]'))
.then(() => {
assert.match(
cli.output,
/\[ 'function', 'function' \]/,
'works w/o paren, short'
);
})
.then(() => cli.command('repl'))
.then(() => {
assert.match(
@@ -54,6 +62,14 @@ const assert = require('assert');
'works w/ paren'
);
})
.then(() => cli.command('p("[typeof heartbeat, typeof process.exit]")'))
.then(() => {
assert.match(
cli.output,
/\[ 'function', 'function' \]/,
'works w/ paren, short'
);
})
.then(() => cli.command('cont'))
.then(() => cli.command('exec [typeof heartbeat, typeof process.exit]'))
.then(() => {