OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
37,987 Commits 30 Branches 683 Tags
d896f5befdf4dd9c3782a0d79940fbf5ca06ed01
Commit Graph

37987 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Anna Henningsen
d896f5befd src: make BuiltinLoader threadsafe and non-global 
As discussed in https://github.com/nodejs/node/pull/45888, using a
global `BuiltinLoader` instance is probably undesirable in a world
in which embedders are able to create Node.js Environments with
different sources and therefore mutually incompatible code
caching properties.

This PR makes it so that `BuiltinLoader` is no longer a global
singleton and instead only shared between `Environment`s that
have a direct relation to each other, and addresses a few
thread safety issues along with that.

PR-URL: https://github.com/nodejs/node/pull/45942
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2023-01-18 22:03:00 +00:00
Juan José
5d560978ff test: improve test coverage for WHATWG TextDecoder 
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/45241
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-18 19:32:36 +00:00
Deokjin Kim
4b737c3557 doc: update events API example to have runnable code 
Fixes: https://github.com/nodejs/node/issues/45755
PR-URL: https://github.com/nodejs/node/pull/45760
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-18 19:25:11 +00:00
Filip Skokan
13f518f6e3 crypto: add CryptoKey Symbol.toStringTag 
closes #45987

PR-URL: https://github.com/nodejs/node/pull/46042
Fixes: https://github.com/nodejs/node/issues/45987
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2023-01-18 18:07:26 +00:00
npm CLI robot
ad16a75941 deps: upgrade npm to 9.3.1 
PR-URL: https://github.com/nodejs/node/pull/46242
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-01-18 14:48:47 +00:00
Deokjin Kim
dc06df31b6 readline: refactor to use validateNumber 
`validateNumber` throws more proper error code and
error name.

PR-URL: https://github.com/nodejs/node/pull/45801
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-01-18 15:32:57 +01:00
Deokjin Kim
671ffd7825 buffer: use min/max of validateNumber 
Instead of additional `if` statement, use min/max
of `validateNumber`.

PR-URL: https://github.com/nodejs/node/pull/45796
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-01-18 10:36:27 +00:00
Debadree Chatterjee
32254988ba stream: implement finished() for ReadableStream and WritableStream 
Refs: https://github.com/nodejs/node/issues/39316
PR-URL: https://github.com/nodejs/node/pull/46205
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-18 07:56:49 +00:00
Suyash Nayan
60cc1baec1 test: add fix so that test exits if port 42 is unprivileged 
PR-URL: https://github.com/nodejs/node/pull/45904
Fixes: https://github.com/nodejs/node/issues/45838
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-01-18 07:10:48 +00:00
Tim Gerk
6ecbd57f59 doc: add note to tls docs about secureContext availability 
tls.createServer() and new tls.Server() ignore secureContext option.

PR-URL: https://github.com/nodejs/node/pull/46224
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2023-01-18 01:53:41 +00:00
vitpavlenko
5a7d4a774d crypto: add cipher update/final methods encoding validation 
Refs #45189

PR-URL: https://github.com/nodejs/node/pull/45990
Refs: https://github.com/nodejs/node/issues/45189
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2023-01-17 17:39:14 +00:00
Michael Dawson
c62a8601b5 doc: add text around collaborative expectations 
- add text discussed by the TSC

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/46121
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joe Sepi <sepi@joesepi.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-01-17 09:19:07 -05:00
Deokjin Kim
f461a4c5fc http: refactor to use validateHeaderName 
Remove duplicate implementation by using validateHeaderName.

PR-URL: https://github.com/nodejs/node/pull/46143
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-01-17 13:40:39 +00:00
Tobias Nießen
15d673dfbe src: replace unreachable code with static_assert 
This function base64-decodes a given JavaScript string to obtain the
secret key, whose length must not exceed INT_MAX. However, because
JavaScript strings are limited to v8::String::kMaxLength chars and
because base64 decoding never yields more bytes than input chars, the
size of the decoded key must be strictly less than
v8::String::kMaxLength bytes. Therefore, it is sufficient to statically
assert that String::kMaxLength <= INT_MAX (which is always true because
String::kMaxLength itself is an int).

Aside from being unreachable, Coverity considers the current code
"suspicious" because it indicates that buffers larger than INT_MAX might
actually be allocated.

PR-URL: https://github.com/nodejs/node/pull/46209
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2023-01-17 10:01:26 +00:00
Marco Ippolito
6e375b389b http: writeHead if statusmessage is undefined dont override headers 
PR-URL: https://github.com/nodejs/node/pull/46173
Fixes: https://github.com/nodejs/node/issues/32395
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2023-01-17 09:05:53 +00:00
Filip Skokan
3ef38c4bd7 crypto: use WebIDL converters in WebCryptoAPI 
WebCryptoAPI functions' arguments are now coersed and validated as per
their WebIDL definitions like in other Web Crypto API implementations.
This further improves interoperability with other implementations of
Web Crypto API.

PR-URL: https://github.com/nodejs/node/pull/46067
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2023-01-17 08:57:58 +00:00
npm CLI robot
66b1356ebc deps: upgrade npm to 9.3.0 
PR-URL: https://github.com/nodejs/node/pull/46193
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2023-01-17 03:38:23 +00:00
Jiawen Geng
17aa1958e5 deps: cherrypick simdutf patch 
PR-URL: https://github.com/nodejs/node/pull/46194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-01-17 01:26:45 +00:00
Jiawen Geng
3e7043a19e build: add extra semi check 
PR-URL: https://github.com/nodejs/node/pull/46194
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-01-17 01:26:44 +00:00
Mordy Tikotzky
8986bf8d76 doc: update to match changed --dns-result-order default 
Update documentation to match the changed `--dns-result-order` default
value in Node.js 17.0.0.

PR-URL: https://github.com/nodejs/node/pull/46148
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2023-01-17 00:56:07 +01:00
theanarkh
78954846c3 src,lib: the handle keeps loop alive in cluster rr mode 
PR-URL: https://github.com/nodejs/node/pull/46161
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2023-01-16 13:57:39 +00:00
Tobias Nießen
bcc2d583a7 src: hide kMaxDigestMultiplier outside HKDF impl 
There is no reason to expose this constant outside of the HKDF
implementation, especially with such a generic name.

PR-URL: https://github.com/nodejs/node/pull/46206
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-01-16 02:44:00 +00:00
Deokjin Kim
44595b48f0 lib: use kEmptyObject and update JSDoc in webstreams 
Use kEmptyObject as default value of strategy.
Plus, make reason and chunk as optional.
And refactor to use validateBuffer.

Refs: https://github.com/nodejs/node/blob/main/doc/api/webstreams.md#transformstreamdefaultcontrollerenqueuechunk
Refs: https://github.com/nodejs/node/blob/main/doc/api/webstreams.md#transformstreamdefaultcontrollererrorreason
Refs: https://github.com/nodejs/node/blob/main/doc/api/webstreams.md#writablestreamdefaultwriterabortreason
Refs: https://github.com/nodejs/node/blob/main/doc/api/webstreams.md#writablestreamdefaultwriterwritechunk
PR-URL: https://github.com/nodejs/node/pull/46183
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2023-01-15 22:10:42 +00:00
Kevin Eady
09aed324b1 doc: add Node-API media link 
PR-URL: https://github.com/nodejs/node/pull/46189
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-01-15 21:08:45 +00:00
Node.js GitHub Bot
00ff23cbb0 meta: update AUTHORS 
PR-URL: https://github.com/nodejs/node/pull/46215
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2023-01-15 20:24:24 +00:00
Node.js GitHub Bot
010d9c29d7 tools: update lint-md-dependencies 
Update to remark-preset-lint-node@3.4.0 rollup@3.10.0.

PR-URL: https://github.com/nodejs/node/pull/46214
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2023-01-15 15:30:36 +00:00
Almeida
f8b80a6c5b tools: fix macro name in update-undici 
PR-URL: https://github.com/nodejs/node/pull/46217
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2023-01-15 13:12:12 +00:00
Jiawen Geng
d094f1b804 deps: bump googletest to 2023.01.13 
commit hash: 356fc301251378e0f6fa6aa794d73714202887ac

PR-URL: https://github.com/nodejs/node/pull/46198
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-01-15 12:23:42 +00:00
Debadree Chatterjee
67a9ed3f7f doc: update http.setMaxIdleHTTPParsers arguments 
Fixes: https://github.com/nodejs/node/issues/46160
PR-URL: https://github.com/nodejs/node/pull/46168
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-01-14 22:00:15 +00:00
Geoffrey Booth
1022c6f424 doc: add experimental stages 
PR-URL: https://github.com/nodejs/node/pull/46100
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
 2023-01-14 14:25:08 +00:00
Ben Noordhuis
3803d09308 crypto: ensure auth tag set for chacha20-poly1305 
Because OpenSSL v1.x doesn't do that by itself (OpenSSL v3.x does.)

Fixes: https://github.com/nodejs/node/issues/45874
PR-URL: https://github.com/nodejs/node/pull/46185
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-14 14:16:29 +00:00
Chengzhong Wu
bb40507f3e src: distinguish env stopping flags 
`Environment::FreeEnvironment` creates a
`DisallowJavascriptExecutionScope`, so the flag
`Environment::can_call_into_js()` should also be set as `false`. As
`Environment::can_call_into_js_` is a simple boolean flag, it should not
be accessed off-threads.

PR-URL: https://github.com/nodejs/node/pull/45907
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2023-01-14 09:59:17 +00:00
Deokjin Kim
be93b7a582 lib: refactor to use validate function 
Throwing error after checking type is repeated. So replace
it with validate function.

PR-URL: https://github.com/nodejs/node/pull/46101
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2023-01-14 09:52:26 +00:00
Darshan Sen
d7d9811407 tools: add automation for updating postject dependency 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/46157
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-01-14 07:49:36 +00:00
Rich Trott
5117c6c9e7 doc: use "file system" instead of "filesystem" 
https://github.com/nodejs/node/pull/44004#discussion_r1067599238
PR-URL: https://github.com/nodejs/node/pull/46178
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
 2023-01-14 01:10:38 +00:00
Deokjin Kim
36d54dc6e0 vm: refactor to use validate function 
Throwing error after checking type is repeated.
So replace it with validate function.

PR-URL: https://github.com/nodejs/node/pull/46176
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-14 00:21:54 +00:00
Deokjin Kim
a691002f1e http: refactor to use min of validateNumber for maxTotalSockets 
Remove duplicate implementation by using min of validateNumber.

PR-URL: https://github.com/nodejs/node/pull/46115
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-13 14:39:54 +00:00
Shelley Vohr
f5dc92cff3 src: remove return after abort 
PR-URL: https://github.com/nodejs/node/pull/46172
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-13 12:31:53 +00:00
Michaël Zasso
1a56004827 tools: update create-or-update-pull-request-action 
Fixes GitHub's `set-output` deprecation.

PR-URL: https://github.com/nodejs/node/pull/46169
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-13 08:55:46 +00:00
Marco Ippolito
1f31eb2aa9 doc: https update default request timeout 
PR-URL: https://github.com/nodejs/node/pull/46184
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-01-13 08:32:19 +00:00
Deokjin Kim
96605796ef doc: make options of readableStream.pipeTo as optional 
Refs: https://github.com/nodejs/node/blob/main/lib/internal/webstreams/readablestream.js#L380
PR-URL: https://github.com/nodejs/node/pull/46180
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-13 07:53:05 +00:00
Shelley Vohr
cf105c4db5 src: remove unnecessary semicolons 
PR-URL: https://github.com/nodejs/node/pull/46171
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-01-13 07:52:56 +00:00
Rafael Gonzaga
5d50b8435c lib: reuse invalid state errors on webstreams 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/46086
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2023-01-13 03:33:29 +00:00
Antoine du Hamel
31ea7be98d esm: mark importAssertions as required 
We already always specify a value, and failing to do so would likely be
a bug.

PR-URL: https://github.com/nodejs/node/pull/46164
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-01-12 21:11:11 +00:00
Geoffrey Booth
91ca2d4041 esm: allow resolve to return import assertions 
PR-URL: https://github.com/nodejs/node/pull/46153
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-01-12 01:57:45 +00:00
Deokjin Kim
a9bc3cf39b benchmark,tools: use os.availableParallelism() 
Refs: https://github.com/nodejs/node/pull/45895
PR-URL: https://github.com/nodejs/node/pull/46003
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-01-11 20:07:57 +00:00
Deokjin Kim
d8014f6aa9 test: use os.availableParallelism() 
Refs: https://github.com/nodejs/node/pull/45895
PR-URL: https://github.com/nodejs/node/pull/46003
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-01-11 20:07:56 +00:00
theanarkh
b39c3f6fbe doc: add PerformanceObserver.supportedEntryTypes to doc 
PR-URL: https://github.com/nodejs/node/pull/45962
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-01-11 19:58:41 +00:00
Luigi Pinca
20359cc563 deps: add /deps/**/.github/ to .gitignore 
- Ignore `.github` directories in the `deps` directory.
- Remove `deps/base64/base64/.github/`.

PR-URL: https://github.com/nodejs/node/pull/46091
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-01-11 19:29:33 +00:00
Deokjin Kim
c226783aa9 events: change status of event.cancelBubble to legacy 
`event.cancelBubble` is described as legacy in spec.

Refs: https://dom.spec.whatwg.org/#interface-event
PR-URL: https://github.com/nodejs/node/pull/46146
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2023-01-11 16:29:53 +00:00