OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
34,268 Commits 30 Branches 683 Tags
cf8a235fd1d9225f826220bc38c2c2832ddf0f4e
Commit Graph

34268 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Rich Trott
cf8a235fd1 meta: simplify mailmap 
Remove unnecessary name specificity in mailmap entries. AUTHORS is
unchanged after running update-authors.js with these changes.

PR-URL: https://github.com/nodejs/node/pull/39612
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2021-08-03 04:54:46 +00:00
Rich Trott
132a37e38b meta: consolidate emails for tadhgcreedon 
PR-URL: https://github.com/nodejs/node/pull/39611
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-03 04:54:39 +00:00
Rich Trott
0765cf4013 meta: consolidate emails for timcosta 
PR-URL: https://github.com/nodejs/node/pull/39611
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-03 04:54:38 +00:00
Rich Trott
2a3a5c3582 meta: consolidate emails for timruffles 
PR-URL: https://github.com/nodejs/node/pull/39611
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-03 04:54:37 +00:00
Rich Trott
d4cd856f4d meta: update AUTHORS 
PR-URL: https://github.com/nodejs/node/pull/39629
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-02 23:38:40 +00:00
Luigi Pinca
296354950c tools: update ESLint to 7.32.0 
PR-URL: https://github.com/nodejs/node/pull/39602
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
 2021-08-02 18:44:23 +02:00
Luigi Pinca
0f9434af4d test: deflake test-http2-buffersize 
This is basically a revert of
c452632d34.

The problem with that commit is that the promises returned by
`once(server, 'stream')` are all resolved with the same stream when the
first `'stream'` event is emitted.

Refs: https://github.com/nodejs/node/pull/39525#issuecomment-889080913

PR-URL: https://github.com/nodejs/node/pull/39591
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2021-08-02 18:42:44 +02:00
Rich Trott
f2d02ab81a meta: add mailmap entry for ryzokuken 
This consolidates two email addresses/entries in AUTHORS into one.

PR-URL: https://github.com/nodejs/node/pull/39596
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-02 13:33:30 +00:00
Rich Trott
537a4aa146 meta: add mailmap entry for uttampawar 
This consolidates two email addresses/entries in AUTHORS into one.

PR-URL: https://github.com/nodejs/node/pull/39596
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-02 13:33:29 +00:00
Rich Trott
ffcf1b25bf meta: add mailmap entry for dmabupt 
This consolidates two email addresses/entries in AUTHORS into one.

PR-URL: https://github.com/nodejs/node/pull/39596
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-02 13:33:29 +00:00
Himadri Ganguly
fcc3910dd4 test: convert anonymous function to arrow function 
PR-URL: https://github.com/nodejs/node/pull/39604
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-08-02 13:22:00 +00:00
Robert Nagy
ac621ff5e7 stream: add readableDidRead if has been read from 
Adds did read accessor used to determine whether a readable has been
read from.

PR-URL: https://github.com/nodejs/node/pull/39589
Refs: https://github.com/nodejs/undici/pull/907
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2021-08-02 05:59:18 -07:00
Antoine du Hamel
45f98fc60d module: add some typings to internal/modules/esm/resolve 
PR-URL: https://github.com/nodejs/node/pull/39504
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-08-02 10:21:30 +02:00
James M Snell
afabd145d1 perf_hooks: fix PerformanceObserver gc crash 
Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: https://github.com/nodejs/node/issues/39548

PR-URL: https://github.com/nodejs/node/pull/39550
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2021-08-02 12:39:21 +08:00
Anna Henningsen
ba7368a1a9 repl: do not include legacy getter/setter methods in completion 
For every object that inherits from `Object.prototype`, the REPL
includes the `Object.prototype` methods in its autocompletion.

This is already a little noisy, but in particular, this also
includes the legacy `__defineGetter__` family of methods;
since those are deprecated and not in practical use anymore,
it helps reduce noise a bit to remove them.

This commit does not remove `__proto__` as it is a little
more popular and, despite its downsides, a slightly more convenient
way to access the prototype of an object in the REPL than
`Object.getPrototypeOf(...)`.

PR-URL: https://github.com/nodejs/node/pull/39576
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-08-01 16:43:46 +02:00
Rich Trott
42d31447d5 test: add test-debugger-breakpoint-exists 
This adds test coverage to `unpackError()` in
`lib/internal/debugger/inspect_client.js`. That function previously was
untested.

PR-URL: https://github.com/nodejs/node/pull/39570
Refs: https://github.com/nodejs/node-inspect/issues/101
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-08-01 14:24:36 +00:00
Rich Trott
1c6f26d347 debugger: remove undefined parameter 
The data parameter of unpackError() is typically undefined.

PR-URL: https://github.com/nodejs/node/pull/39570
Refs: https://github.com/nodejs/node-inspect/issues/101
Reviewed-By: Jan Krems <jan.krems@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-08-01 14:24:35 +00:00
Mestery
2913211ba8 lib: use ERR_ILLEGAL_CONSTRUCTOR 
Use ERR_ILLEGAL_CONSTRUCTOR error instead of `illegal constructor` or
`Illegal constructor` TypeError.

PR-URL: https://github.com/nodejs/node/pull/39556
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-08-01 14:24:26 +00:00
Rich Trott
7db86e7cce test: add known issues test for debugger heap snapshot race 
Refs: https://github.com/nodejs/node/issues/39555

PR-URL: https://github.com/nodejs/node/pull/39557
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-08-01 13:09:47 +00:00
Ash Cripps
4d60ee8d1c doc: update min mac ver + move mac arm64 to tier 1 
Update the minimum macos version that can compile to match the
xcode requirements.

Also move mac arm64 to tier 1.

refs: https://github.com/nodejs/node/issues/39584#issuecomment-889701855

PR-URL: https://github.com/nodejs/node/pull/39586
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-08-01 12:59:28 +00:00
Richard Lau
4f9fd8d244 doc: add missing introduced_in metadata 
Fixes doc build warnings:
```
Failed to add alternative version links to webstreams
Failed to add alternative version links to async_context
```

PR-URL: https://github.com/nodejs/node/pull/39575
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-07-31 22:51:26 +00:00
Rich Trott
1a1793e8a9 meta: align README/.mailmap/AUTHORS email entries 
The email address for Weijia Wang in the AUTHORS and .mailmap files is
different from the email address in the README.md file. Based on their
GitHub profile and commit metadata, the one in the README.md file is the
preferred email. Updating .mailmap and AUTHORS to reflect it.

PR-URL: https://github.com/nodejs/node/pull/39505
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Weijia Wang <starkwang@126.com>
 2021-07-31 16:43:36 +00:00
Rich Trott
8be3b91b00 build: exclude markdown files from some GitHub Actions 
Ignore all markdown files when determining if test-asan, coverage-*, and
test-macos need to run.

Refs: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#patterns-to-match-file-paths

PR-URL: https://github.com/nodejs/node/pull/39565
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-07-31 03:47:24 +00:00
Guy Bedford
b0a6ade3bd module: fix ERR_REQUIRE_ESM error for null frames 
PR-URL: https://github.com/nodejs/node/pull/39593
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-07-31 02:32:19 +00:00
Rich Trott
46e6c649ec meta: add mailmap entry for garygsc 
Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate
entry.

PR-URL: https://github.com/nodejs/node/pull/39588
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-07-30 18:50:08 +00:00
Rich Trott
72f3fc16f1 meta: add mailmap entry for ttzztztz 
Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate
entry.

PR-URL: https://github.com/nodejs/node/pull/39588
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-07-30 18:50:07 +00:00
Rich Trott
b4ae7026d5 meta: update AUTHORS 
PR-URL: https://github.com/nodejs/node/pull/39587
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-07-30 18:49:55 +00:00
Juan José Arboleda
89adc16ff0 doc: add code examples to Writable.destroy() and Writable.destroyed 
PR-URL: https://github.com/nodejs/node/pull/39491
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-30 07:33:55 -07:00
legendecas
a27d245698 perf_hooks: fix performance timeline wpt failures 
PR-URL: https://github.com/nodejs/node/pull/39532
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
 2021-07-30 07:29:44 -07:00
npm team
317e71b142 deps: upgrade npm to 7.20.3 
PR-URL: https://github.com/nodejs/node/pull/39579
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
 2021-07-30 12:35:22 +00:00
Jordan Harband
08ef0ae998 doc: add String.prototype.at and %TypedArray%.prototype.at 
PR-URL: https://github.com/nodejs/node/pull/39583
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
 2021-07-30 10:52:42 +00:00
Rich Trott
e99ba64553 meta: update .mailmap to remove duplication in AUTHORS 
PR-URL: https://github.com/nodejs/node/pull/39561
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-07-30 10:12:38 +00:00
Rich Trott
1556ab2029 meta: add .mailmap entries to remove AUTHORS duplicates 
PR-URL: https://github.com/nodejs/node/pull/39560
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-07-30 10:12:29 +00:00
Beth Griggs
0e22fa0f3d 2021-07-29, Version 16.6.0 (Current) 
This is a security release.

Notable Changes:

- CVE-2021-22930: Use after free on close http2 on stream canceling
  (High) [#39423](https://github.com/nodejs/node/pull/39423)
- (SEMVER-MINOR) deps: update V8 to 9.2.230.21 (Michaël Zasso)
  [#39470](https://github.com/nodejs/node/pull/39470)
- inspector: mark as stable (Gireesh Punathil)
  [#37748](https://github.com/nodejs/node/pull/37748)
- punycode: add pending deprecation (Antoine du Hamel)
  [#38444](https://github.com/nodejs/node/pull/38444)
- (SEMVER-MINOR) repl: enable --experimental-repl-await /w opt-out
  (hemanth.hm) [#34733](https://github.com/nodejs/node/pull/34733)

PR-URL: https://github.com/nodejs/node/pull/39534
 2021-07-29 23:52:55 +01:00
Richard Lau
43502622f5 doc: move NODE_MODULE_VERSION in release guide 
Move the section on `NODE_MODULE_VERSION` into the section for
major releases as it should only be updated for a major release.
Add a note to remove the `-pre` suffix from the registry for the
release commit.

PR-URL: https://github.com/nodejs/node/pull/39544
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-29 15:18:01 -04:00
Richard Lau
7fa032b96b doc: remove outdated ARM information from release guide 
We no longer produced ARMv6 builds, and the ARMv7 builds are now
cross compiled and are as quick as builds on the other platforms.

PR-URL: https://github.com/nodejs/node/pull/39544
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-29 15:17:59 -04:00
Richard Lau
a5bc5f7617 doc: fence command examples in release guide 
Put the command examples for finding and replacing the `REPLACEME`
tags into code fences so that they are more easily copiable when
viewing the guide in the GitHub web UI.

PR-URL: https://github.com/nodejs/node/pull/39544
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-29 15:17:57 -04:00
Richard Lau
96cd561e09 doc: update backport labels in release guide 
Add `backport-open-v1.x,backported-to-v1.x` labels to `branch-diff`
commands as these indicate pull requests that are being manually
backported and should not be cherry-picked.

PR-URL: https://github.com/nodejs/node/pull/39544
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-29 15:17:54 -04:00
legendecas
9b5aa8d99e build: override python executable path on configure 
PR-URL: https://github.com/nodejs/node/pull/39465
Fixes: https://github.com/nodejs/node/issues/39408
Fixes: https://github.com/nodejs/node/issues/39456
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2021-07-30 01:20:00 +08:00
Richard Lau
bd33fdfadf 2021-07-29, Version 14.17.4 'Fermium' (LTS) 
This is a security release.

Notable Changes:

- CVE-2021-22930: Use after free on close http2 on stream canceling (High)

This releases fixes some regressions with internationalization
introduced by the ICU updates in Node.js 14.17.0 and 14.17.1.

PR-URL: https://github.com/nodejs/node/pull/39466
 2021-07-29 12:40:58 -04:00
Richard Lau
9b4199450e 2021-07-29, Version 12.22.4 'Erbium' (LTS) 
This is a security release.

Notable changes:

- CVE-2021-22930: Use after free on close http2 on stream canceling (High)

PR-URL: https://github.com/nodejs/node/pull/39500
 2021-07-29 12:32:23 -04:00
Rich Trott
2b350789ea meta: add .mailmap entry to remove duplication in AUTHORS 
PR-URL: https://github.com/nodejs/node/pull/39559
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-07-29 12:40:37 +00:00
Rich Trott
d6bb7ed6c8 build: use lts shorthand in GitHub Actions 
Rather than hard-coding GitHub Actions to use Node.js 14.x, use the
`lts/*` shorthand for "most recent LTS version".

PR-URL: https://github.com/nodejs/node/pull/39538
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-07-29 04:57:11 +00:00
npm team
3a10a37f28 deps: upgrade npm to 7.20.2 
PR-URL: https://github.com/nodejs/node/pull/39549
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
 2021-07-28 17:16:31 -04:00
Juan José Arboleda
fea3357b7f src: add cosmetic space character to async_wrap.h file 
PR-URL: https://github.com/nodejs/node/pull/39459
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-07-28 13:44:16 -07:00
Darshan Sen
7ca2f13039 async_hooks: merge resource_symbol with owner_symbol 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: https://github.com/nodejs/node/pull/38468
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2021-07-28 13:41:24 -07:00
Lew Gordon
fce53031e5 http: decodes url.username and url.password for authorization header 
This change properly decodes the url.username and url.password for
the authorization header constructed from the URL object for
http(s) requests.

Fixes: https://github.com/nodejs/node/issues/31439

PR-URL: https://github.com/nodejs/node/pull/39310
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-28 13:39:33 -07:00
Juan José Arboleda
7f167f49dd doc: add code example to fs.truncate method 
PR-URL: https://github.com/nodejs/node/pull/39454
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-28 13:36:45 -07:00
Juan José Arboleda
984f7a0bf3 doc: add code example to http.createServer method 
PR-URL: https://github.com/nodejs/node/pull/39455
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-28 13:35:40 -07:00
Robert Nagy
3f0b62375b stream: convert premature close to AbortError 
AbortError is a more "web" align alternative to
ERR_STREAM_PREMATURE_CLOSE.

PR-URL: https://github.com/nodejs/node/pull/39524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-07-28 10:12:04 +02:00