João Reis
c9e670ea2a
win,msi: fix inclusion of translations
...
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com >
PR-URL: https://github.com/nodejs/node/pull/7798
2016-08-03 12:45:32 +01:00
Ben Noordhuis
05c15a057f
build: fix dependency on missing header file
...
Depend on include/ares_rules.h, src/ares_rules.h does not exist.
The typo didn't break the build but it made some of the gyp-based
tooling complain.
PR-URL: https://github.com/nodejs/node/pull/7945
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
2016-08-03 11:12:53 +02:00
Ben Noordhuis
c0676f3f0f
build: fix typo in non-essential source file name
...
Depend on src/inspector_agent.h, src/inspector-agent.h does not exist.
The typo didn't break the build but it made some of the gyp-based
tooling complain.
PR-URL: https://github.com/nodejs/node/pull/7945
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
2016-08-03 11:11:57 +02:00
Franziska Hinkelmann
60d46b4e70
deps: cherry-pick a51f429 from V8 upstream
...
Original commit message:
[regexp] Fix case-insensitive matching for one-byte subjects.
The bug occurs because we do not canonicalize character class ranges
before adding case equivalents. While adding case equivalents, we abort
early for one-byte subject strings, assuming that the ranges are sorted.
Which they are not.
R=marja@chromium.org
BUG=v8:5199
Review-Url: https://codereview.chromium.org/2159683002
Cr-Commit-Position: refs/heads/master@{#37833}
Fixes: https://github.com/nodejs/node/issues/7708
PR-URL: https://github.com/nodejs/node/pull/7833
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com >
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com >
2016-08-02 23:16:55 -07:00
Rich Trott
b4258bba11
test: improve chained property readability
...
A new version of ESLint flags chained properties on multiple lines that
were not flagged by the previous version of ESLint. In preparation for
turning that feature on, adjust alignment to that expected by the
linter.
This change happened to be predominantly around assertions using
`assert()` and `assert.equal()`. These were changed to
`assert.strictEqual()` where possible.
PR-URL: https://github.com/nodejs/node/pull/7920
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2016-08-02 09:52:50 -07:00
Santiago Gimeno
93ac2ea36e
test: fix test-vm-sigint flakiness
...
Set the `SIGUSR2` handler before spawning the child process to make sure
the signal is always handled.
Fixes: https://github.com/nodejs/node/issues/7767
PR-URL: https://github.com/nodejs/node/pull/7854
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-02 15:40:04 +02:00
Anna Henningsen
1b24b37299
util: fix formatting of objects with SIMD enabled
...
When SIMD is enabled, `util.format` couldn’t display objects
(with at least 1 key) because the formatter function got
overridden.
PR-URL: https://github.com/nodejs/node/pull/7864
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
2016-08-02 15:00:59 +02:00
Ben Noordhuis
80b10b4fe2
src: fix use-after-free in inspector agent
...
uv_close() is an asynchronous operation. Calling it on a data member
inside the destructor is unsound because its memory is about to be
reclaimed but libuv is not done with it yet.
PR-URL: https://github.com/nodejs/node/pull/7907
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com >
Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-02 08:34:33 +02:00
cjihrig
75c6d9dd95
cluster: support stdio option for workers
...
This commit allows setupMaster() to configure the stdio channels
for worker processes.
Refs: https://github.com/nodejs/node-v0.x-archive/issues/5727
Refs: https://github.com/nodejs/node/pull/7811
PR-URL: https://github.com/nodejs/node/pull/7838
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-01 15:08:42 -04:00
Josh Gavant
6d9a500064
doc: add CTC meeting minutes 2016-06-22
...
closes #7366
PR-URL: https://github.com/nodejs/node/pull/7390
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
Reviewed-By: Rod Vagg <rod@vagg.org >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-01 12:01:38 -07:00
Josh Gavant
681736183c
doc: add CTC meeting minutes 2016-07-06
...
PR-URL: https://github.com/nodejs/node/pull/7570
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
2016-08-01 11:43:47 -07:00
Josh Gavant
59fd48e5b3
doc: add CTC meeting minutes 2016-06-29
...
PR-URL: https://github.com/nodejs/node/pull/7571
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
2016-08-01 11:43:15 -07:00
Rich Trott
1495053046
meta: include a minimal CTC removal policy
...
Add language identifying a request for voluntary resignation as the
typical mechanism for addressing inactive CTC members.
PR-URL: https://github.com/nodejs/node/pull/7720
Reviewed-By: Rod Vagg <rod@vagg.org >
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: Julien Gilli <jgilli@nodejs.org >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-01 11:33:38 -07:00
Daniel Bevenius
eeaff74af2
build: adding config.gypi dep to addons/.buildstamp
...
Currently the build-addons target is called as part of the
test target, and it has test/addons/.buildstamp as a dependency.
When running ./configure --debug and later switching/
updating branches you can be in a situation where the config.gypi
files in the addons build directories are using an incorrect
value for default_configuration. Currently this can happen and you
will get test errors as there are a few test that depend on the
value of default_configuration to be Release.
Ben Noordhuis provided the solution for this by adding a dependency to
config.gypi, which is generated when running ./configure, and will
correct this situation.
This commit is related to #7860 . Please see the dicussion in that
issue regarding the test using hard-coded paths.
PR-URL: https://github.com/nodejs/node/pull/7893
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-08-01 10:57:44 -07:00
William Kapke
8ae227c971
doc: add CTC meeting minutes 2016-07-27
...
PR-URL: https://github.com/nodejs/node/pull/7900
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-01 10:50:25 -07:00
Prince J Wesley
c52a9730b8
test: don't hard code deprecation count
...
PR-URL: https://github.com/nodejs/node/pull/7927
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2016-08-01 10:42:29 -07:00
Joey Cozza
65a42ab892
doc: fix path markdown formatting
...
Single quotes in two of the examples were throwing off the
formatting of the path documentation on the Node.js website. This
commit expands two contractions to remove the offending quotes.
PR-URL: https://github.com/nodejs/node/pull/7817
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-01 11:21:17 -04:00
Ben Noordhuis
6945aa7085
build: don't link against liblog on host system
...
Don't link binaries that run on the host system against liblog, it
breaks cross-compiling for android.
Fixes: https://github.com/nodejs/node/issues/7731
PR-URL: https://github.com/nodejs/node/pull/7762
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-08-01 16:22:48 +02:00
Ben Noordhuis
c8c1f96abe
src: avoid manual memory management in inspector
...
Make the inspector code easier to reason about by restructuring it
to avoid manual memory allocation and copying as much as possible.
An amusing side effect is that it reduces the total amount of memory
used in the test suite.
Before:
$ valgrind ./out/Release/cctest 2>&1 | grep 'total heap' | cut -c31-
1,017 allocs, 1,017 frees, 21,695,456 allocated
After:
$ valgrind ./out/Release/cctest 2>&1 | grep 'total heap' | cut -c31-
869 allocs, 869 frees, 14,484,641 bytes allocated
PR-URL: https://github.com/nodejs/node/pull/7906
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-01 16:17:24 +02:00
Ben Noordhuis
0190db44ac
test: fix memory leaks in inspector tests
...
The inspector tests weren't closing open libuv handles properly,
making valgrind complain. Strengthen the uv_loop_close() check
while here.
With this commit applied:
$ valgrind ./out/Release/cctest 2>&1 | grep 'total heap' | cut -c31-
1,017 allocs, 1,017 frees, 21,695,456 bytes allocated
PR-URL: https://github.com/nodejs/node/pull/7906
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-01 16:16:48 +02:00
Ravindra barthwal
1658297f47
doc: add missing semicolon
...
PR-URL: https://github.com/nodejs/node/pull/7915
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-01 09:14:28 -04:00
Vse Mozhet Byt
0de55d864d
test: decrease inconsistency in the common.js
...
1. `process.env['PROCESSOR_ARCHITEW6432']` ->
`process.env.PROCESSOR_ARCHITEW6432`.
2. `path.dirname(__filename)` -> `__dirname`.
3. `path.resolve(__dirname)` -> `__dirname`.
PR-URL: https://github.com/nodejs/node/pull/7758
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
2016-08-01 14:17:20 +02:00
Santiago Gimeno
df4ef63aa5
tools,test: show signal code when test crashes
...
On every platform but `Windows`. Also, print the crash information when
using the tap reporter.
PR-URL: https://github.com/nodejs/node/pull/7859
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-07-31 23:05:59 +02:00
Rich Trott
bc464a8a3b
test: fix flaky test-tls-wrap-timeout
...
Competing timers were causing a race condition and thus the test was
flaky. Instead, we check an object property on process exit.
Fixes: https://github.com/nodejs/node/issues/7650
PR-URL: https://github.com/nodejs/node/pull/7857
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com >
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com >
2016-07-31 13:31:40 -07:00
Eugene Ostroukhov
f789eb3106
inspector: Do not crash if the port is n/a
...
Node process will no longer terminate with an assertion if the
inspector port is not available.
PR-URL: https://github.com/nodejs/node/pull/7874
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com >
2016-07-29 10:59:32 -07:00
Erin Spiceland
7d75338c0e
timers: fix cleanup of nested same-timeout timers
...
For nested timers with the same timeout, we can get into a situation
where we have recreated a timer list immediately before we need to
clean up an old timer list with the same key. Fix: make sure the list
to be deleted is the same instance as the list whose reference was used
to determine that a cleanup is necessary. If it's not the same instance,
a new list with the same key has been created, and it should not be
deleted.
Fixes: https://github.com/nodejs/node/issues/7722
PR-URL: https://github.com/nodejs/node/pull/7827
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Julien Gilli <jgilli@fastmail.fm >
2016-07-29 09:48:45 -07:00
Timothy Gu
1896ca9e8e
doc: fill in missing V8 version
...
PR-URL: https://github.com/nodejs/node/pull/7878
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-07-29 09:17:20 -07:00
Joe Esposito
6ea8c669df
doc: remove extra spaces and concats in examples
...
PR-URL: https://github.com/nodejs/node/pull/7885
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com >
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-07-29 09:12:17 -07:00
Rich Trott
8fbdfb9c4e
test: speed up test-net-reconnect-error
...
The test takes 50 seconds on some of the project's Windows CI
infrastructure. Reducing the test repetitions from 50 to 20 trims that
to about 20 seconds. Tests will timeout at 60 seconds, so this helps
keep the test reliable. (There was a timeout on CI today when testing an
unrelated code change.)
Refs: https://github.com/nodejs/node/pull/7827#issuecomment-235476222
PR-URL: https://github.com/nodejs/node/pull/7886
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: JungMinu - Minwoo Jung <jmwsoft@gmail.com >
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
2016-07-28 22:50:49 -07:00
Rich Trott
99e2d43801
meta: provide example activities
...
Provide example activities to better distinguish Collaborator activities
from CTC member activities.
PR-URL: https://github.com/nodejs/node/pull/7744
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Julien Gilli <jgilli@nodejs.org >
2016-07-28 14:46:57 -07:00
Rich Trott
96611d097a
doc: add information about CTC quorum rules
...
CTC quorum rules were not in writing. There was an informal
understanding between CTC members. Document the rules to avoid
differences in interpretation.
PR-URL: https://github.com/nodejs/node/pull/7813
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com >
Reviewed-By: Julien Gilli <jgilli@nodejs.org >
2016-07-28 14:30:54 -07:00
Daniel Bevenius
b896057109
src: unifying PipeConnectWrap and TCPConnectWrap
...
This commit attempts to address one of the items in #4641 which is
related to src/pipe_wrap.cc and src/tcp_wrap.cc. Currently both
pipe_wrap.cc and tcp_wrap.cc contain a class that are almost
identical. This commit extracts these parts into a separate class
that both can share.
PR-URL: https://github.com/nodejs/node/pull/7501
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-07-28 18:00:00 +02:00
Prince J Wesley
c948877688
doc: align breakEvalOnSigint - repl option
...
PR-URL: https://github.com/nodejs/node/pull/7849
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: JungMinu - Minwoo Jung <jmwsoft@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2016-07-28 08:56:20 +05:30
Bethany N Griggs
868638b903
doc: remove platform assumption from CONTRIBUTING
...
- Specify that the ‘make test’ commands are Unix/OS X specific.
- Link to BUILDING.md for other platform commands.
Fixes: https://github.com/nodejs/node/issues/7646
PR-URL: https://github.com/nodejs/node/pull/7783
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-07-27 23:35:59 +02:00
Prince J Wesley
68ac0d0d7d
repl: Use displayErrors for SyntaxError
...
```js
node 🙈 ₹ git:(upstream ⚡ display-error-repl) ./node
> var 4;
var 4;
^
SyntaxError: Unexpected number
>
```
PR-URL: https://github.com/nodejs/node/pull/7589
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rod Vagg <rod@vagg.org >
2016-07-27 21:26:06 +05:30
Ali Ijaz Sheikh
2554549ab5
deps: v8_inspector: remove jinja2 tests
...
PR-URL: https://github.com/nodejs/node/pull/7796
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com >
2016-07-27 07:29:54 -07:00
Ali Ijaz Sheikh
7db495ab6d
doc: update licenses
...
Created using `tools/license-builder.sh`.
PR-URL: https://github.com/nodejs/node/pull/7796
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com >
2016-07-27 07:29:49 -07:00
Ali Ijaz Sheikh
3534600185
tools: update license-builder.sh for v8_inspector
...
Start including the license from v8_inspector and its build time
dependencies: jinja2 and markupsafe.
PR-URL: https://github.com/nodejs/node/pull/7796
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com >
2016-07-27 07:29:42 -07:00
Ali Ijaz Sheikh
4be6271c43
deps: remove jinja.el from deps/v8_inspector
...
jinja.el is not shipped as part of the distribution, and neither is
it used in the build. While not strictly necessary, removing it
simplifies life from a licensing point of view.
PR-URL: https://github.com/nodejs/node/pull/7796
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com >
2016-07-27 07:29:35 -07:00
Ali Ijaz Sheikh
b9445bfecd
deps: update v8_inspector
...
To add a LICENSE file along with the v8_inspector code, we need to
pick up v8_inspector from an intermediate repository:
https://github.com/pavelfeldman/v8_inspector . This repo still tracks
upstream code in Blink.
This roll also picks up the latest v8_inspector from upstream fixing
a few issues.
* Pickup commit id bc60957 from pavelfeldman/v8_inspector
* Update node.gyp to adapt to the new file paths
* Update the DevTools hash for the devtools frontend.
Fixes: https://github.com/nodejs/node/issues/7123
Fixes: https://github.com/nodejs/node/issues/7736
Fixes: https://github.com/nodejs/node/issues/7734
PR-URL: https://github.com/nodejs/node/pull/7796
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com >
2016-07-27 07:28:44 -07:00
Vse Mozhet Byt
ea725eda42
test: ensure stream preprocessing order
...
Sometimes it is necessary to preprocess some initial bit
of a stream data before giving the entire stream
to the main processing function. Sometimes this bit should be extracted
from the stream before the main processing; sometimes it should be
returned to the stream. This test checks an order of stream
modes, methods and events for a possible preprocessing algorithm.
Stream BOM stripping is selected as a use case.
See https://github.com/nodejs/help/issues/221 as the prehistory.
PR-URL: https://github.com/nodejs/node/pull/7741
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-07-27 13:56:55 +02:00
Alex Perkins
1d83013d19
doc: minor typo fixes in stream docs
...
PR-URL: https://github.com/nodejs/node/pull/7763
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
2016-07-27 13:42:58 +02:00
Ehsan Akhgari
34d58ce334
src: Only use TR1 type_traits on OSX<10.9
...
Mac OSX 10.9 has switched to using libc++ by default. libc++
provides a C++11 <type_traits> implementation, so we only need
to use the TR1 version when targetting OSX 10.8 or 10.7.
PR-URL: https://github.com/nodejs/node/pull/7778
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-07-27 13:27:08 +02:00
Santiago Gimeno
dee0e3a333
test: use common platform helpers everywhere
...
Use the common.isWindows, common.isFreeBSD and common.isSunOS where
possible.
Add common.isOSX and common.isLinux.
Fix `test-fs-read-file-sync-hostname` as in its current form was not
being run anywhere.
PR-URL: https://github.com/nodejs/node/pull/7845
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-07-27 08:25:26 +02:00
Matt Loring
e22ffefff2
deps: cherry-pick a76d133 from v8 upstream
...
Original commit message:
Fix incorrect parameter to HasSufficientCapacity
It takes the number of additional elements, not the total target
capacity.
Also, avoid right-shifting a negative integer as this is undefined in
general
BUG=v8:4909
R=verwaest@chromium.org
Review-Url: https://codereview.chromium.org/2162333002
Cr-Commit-Position: refs/heads/master@{#37901}
Fixes: https://github.com/nodejs/node/issues/6180
PR-URL: https://github.com/nodejs/node/pull/7689
Reviewed-By: Matt Loring <mattloring@google.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-07-26 10:42:54 -07:00
Matt Loring
a3d62bdbaa
deps: cherry-pick b93c80a from v8 upstream
...
Original commit message:
If we can't rehash the backing store for weak sets & maps, do a last
resort GC
BUG=v8:4909
R=hpayer@chromium.org
Committed: https://crrev.com/b93c80a6039c757723e70420ae73375b5d277814
Cr-Commit-Position: refs/heads/master@{#37591}
Fixes: https://github.com/nodejs/node/issues/6180
PR-URL: https://github.com/nodejs/node/pull/7689
Reviewed-By: Matt Loring <mattloring@google.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-07-26 10:42:48 -07:00
Evan Lucas
392c70a827
repl: prevent undefined ref in completion
...
Fixes: https://github.com/nodejs/node/issues/7716
PR-URL: https://github.com/nodejs/node/pull/7718
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-07-26 09:14:43 -05:00
Andreas Madsen
d525e6c92a
benchmark: remove broken string-creation.js
...
Strings where never mutable, it is not clear what this benchmarks
attempts to do. This did work at some point, but only because the
benchmark wasn't using strict mode.
PR-URL: https://github.com/nodejs/node/pull/7094
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-07-26 13:22:01 +02:00
Andreas Madsen
6edef1deb9
benchmark: update docs after refactor
...
PR-URL: https://github.com/nodejs/node/pull/7094
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-07-26 13:21:59 +02:00
Andreas Madsen
0c0f34e2fe
benchmark: add script for creating scatter plot
...
Previously this a tool in `plot.R`. It is now are more complete tool
which executes the benchmarks many times and creates a boxplot.
PR-URL: https://github.com/nodejs/node/pull/7094
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-07-26 13:21:57 +02:00