Antoine du Hamel
c6dabe3083
doc: add lint rule to enforce trailing commas
...
PR-URL: https://github.com/nodejs/node/pull/45471
Reviewed-By: Jacob Smith <jacob@frende.me >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
2022-11-17 13:19:12 +00:00
Antoine du Hamel
bd462ad81b
test: add lint rule to enforce trailing commas
...
Only activated on some subfolders to minimize the diff, ideally this
rule would be applied gradually to the entire codebase in follow-up
commits.
PR-URL: https://github.com/nodejs/node/pull/45468
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
2022-11-17 13:02:11 +00:00
MURAKAMI Masahiko
6638f09fe1
build: add --v8-disable-object-print flag
...
--v8-enable-object-print flag is set by default true.
so, no way of disable this flag.
add a --v8-disable-object-print flag instead that defaults to false.
Fixes: https://github.com/nodejs/node/issues/45433
PR-URL: https://github.com/nodejs/node/pull/45458
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2022-11-17 00:28:48 +00:00
Node.js GitHub Bot
6869d98e41
deps: update timezone to 2022f
...
PR-URL: https://github.com/nodejs/node/pull/45289
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-11-16 23:39:46 +00:00
Anna Henningsen
26991f795d
deps: fix zlib compilation for CPUs without SIMD features
...
Fix the compile flags so that zlib can run on CPUs that do
not have SSSE3/SSE4.2/etc. Do not compile zlib with flags that
indicate that those features are available, and instead enable
them selectively for functions that use them.
There are probably better way to do this, e.g. through gyp file
modifications as suggested in the issue. However, this patch
should do just fine until that happens.
Fixes: https://github.com/nodejs/node/issues/32553
PR-URL: https://github.com/nodejs/node/pull/32627
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/45387
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2022-11-16 19:59:12 +00:00
Luigi Pinca
b6c108f092
deps: update zlib to upstream 8bbd6c31
...
Updated as described in doc/contributing/maintaining-zlib.md.
PR-URL: https://github.com/nodejs/node/pull/45387
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2022-11-16 19:59:11 +00:00
Michaël Zasso
8f9dc2732e
deps: patch V8 to 10.7.193.22
...
Refs: https://github.com/v8/v8/compare/10.7.193.20...10.7.193.22
PR-URL: https://github.com/nodejs/node/pull/45460
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2022-11-16 16:56:12 +00:00
cjihrig
767574938d
test: update uses of _jabber._tcp.google.com
...
_jabber._tcp.google.com seems to have stopped working. This
commit changes the host to _caldav._tcp.google.com.
Refs: https://github.com/denoland/deno_std/pull/2881
PR-URL: https://github.com/nodejs/node/pull/45451
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-11-15 20:03:45 +00:00
Stephen Belanger
2f3da6c5c4
diagnostics_channel: built-in channels should remain experimental
...
PR-URL: https://github.com/nodejs/node/pull/45423
Reviewed-By: theanarkh <theratliter@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2022-11-15 19:35:10 +00:00
Richard Lau
cf523c659f
test: add test to validate changelogs for releases
...
Add a new test to check that the changelog files have been correctly
updated for releases.
PR-URL: https://github.com/nodejs/node/pull/45325
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2022-11-15 16:58:03 +00:00
Emanuel Hoogeveen
0d8a782b4d
src: add --max-semi-space-size to the options allowed in NODE_OPTIONS
...
PR-URL: https://github.com/nodejs/node/pull/44436
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Evan Lucas <evanlucas@me.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-11-15 13:27:54 +00:00
Gerhard Stöbich
67d1831e9b
async_hooks: add hook to stop propagation
...
Add hook to AsyncLocalStorage to allow user to stop propagation.
This is needed to avoid leaking a store if e.g. the store indicates
that its operations are finished or it reached its time to live.
PR-URL: https://github.com/nodejs/node/pull/45386
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2022-11-15 12:27:03 +00:00
Rafael Gonzaga
0a592e48a0
doc: include v19.1.0 in CHANGELOG.md
...
It was missed in the last release.
Refs: 3770d3a450
PR-URL: https://github.com/nodejs/node/pull/45462
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Ruy Adorno <ruyadorno@google.com >
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Harshitha K P <harshitha014@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-11-15 10:50:42 +00:00
Node.js GitHub Bot
0ddf9116eb
deps: update acorn to 8.8.1
...
PR-URL: https://github.com/nodejs/node/pull/45441
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-11-15 00:29:26 +00:00
Antoine du Hamel
f2ee81839a
tools: include current release in the list of released versions
...
PR-URL: https://github.com/nodejs/node/pull/45463
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-11-14 22:58:58 +00:00
Rich Trott
badc631d77
test: remove flaky designation for test-worker-http2-stream-terminate
...
Closes: https://github.com/nodejs/node/issues/43084
PR-URL: https://github.com/nodejs/node/pull/45438
Fixes: https://github.com/nodejs/node/issues/43084
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-11-14 17:19:48 +00:00
Aidan Temple
bbbf97b6da
http: add debug log for ERR_UNESCAPED_CHARACTERS
...
When encountering ERR_UNESCAPED_CHARACTERS on large applications it can
be unclear which request has caused this error. Even when setting
NODE_DEBUG=http there is no information about this error since it's
thrown before any debug logs. This patch adds a debug log that contains
the invalid path.
PR-URL: https://github.com/nodejs/node/pull/45420
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-11-14 17:19:37 +00:00
RafaelGSS
3770d3a450
2022-11-14, Version 19.1.0 (Current)
...
Notable changes:
* deps:
* update ICU to 72.1 (Michaël Zasso) [#45068 ](https://github.com/nodejs/node/pull/45068 )
* doc:
* add lukekarrys to collaborators (Luke Karrys) [#45180 ](https://github.com/nodejs/node/pull/45180 )
* add anonrig to collaborators (Yagiz Nizipli) [#45002 ](https://github.com/nodejs/node/pull/45002 )
* fs:
* (SEMVER-MINOR) fs: add recursive watch to linux (Yagiz Nizipli) [#45098 ](https://github.com/nodejs/node/pull/45098 )
* lib:
* drop fetch experimental warning (Matteo Collina) [#45287 ](https://github.com/nodejs/node/pull/45287 )
* test_runner:
* support function mocking (Colin Ihrig) [#45326 ](https://github.com/nodejs/node/pull/45326 )
* util
* (SEMVER-MINOR) add MIME utilities (Bradley Farias) [#21128 ](https://github.com/nodejs/node/pull/21128 )
* improve textdecoder decode performance (Yagiz Nizipli) [#45294 ](https://github.com/nodejs/node/pull/45294 )
PR-URL: https://github.com/nodejs/node/pull/45269
2022-11-14 10:44:49 -03:00
Jiawen Geng
dbce478109
build: make scripts in gyp run with right python
...
PR-URL: https://github.com/nodejs/node/pull/45435
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org >
2022-11-14 16:36:22 +08:00
Moshe Atlow
97355c74e8
test_runner: support watch mode
...
PR-URL: https://github.com/nodejs/node/pull/45214
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-11-13 21:40:26 +00:00
Node.js GitHub Bot
c5ec87c44b
meta: update AUTHORS
...
PR-URL: https://github.com/nodejs/node/pull/45443
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2022-11-13 20:31:22 +00:00
Konv
c4d75ea104
doc: adjust wording to eliminate awkward typography
...
PR-URL: https://github.com/nodejs/node/pull/45398
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Jacob Smith <jacob@frende.me >
2022-11-13 17:01:41 +00:00
Moshe Atlow
ce16bf553f
watch: watch for missing dependencies
...
PR-URL: https://github.com/nodejs/node/pull/45348
Reviewed-By: Ruy Adorno <ruyadorno@google.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com >
2022-11-13 15:13:26 +00:00
Node.js GitHub Bot
0f2cde0785
tools: update lint-md-dependencies to rollup@3.3.0
...
PR-URL: https://github.com/nodejs/node/pull/45442
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2022-11-13 04:45:57 +00:00
Rich Trott
1255db7624
src: condense experimental warning message
...
PR-URL: https://github.com/nodejs/node/pull/45424
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2022-11-13 04:11:13 +00:00
Rich Trott
6a22b77bba
test: fix flaky test-repl-sigint-nested-eval
...
There is a race condition where process.kill can be sent before the
target is ready to receive the signal.
Fixes: https://github.com/nodejs/node/issues/41123
PR-URL: https://github.com/nodejs/node/pull/45354
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-11-13 02:56:08 +00:00
Yagiz Nizipli
4ac830effd
util: add fast path for utf8 encoding
...
Co-authored-by: Anna Henningsen <anna@addaleax.net >
PR-URL: https://github.com/nodejs/node/pull/45412
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
2022-11-12 21:31:44 +00:00
Tobias Nießen
3439eb9475
doc: fix typo in maintaining-dependencies.md
...
PR-URL: https://github.com/nodejs/node/pull/45428
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-11-12 17:22:05 +00:00
Moshe Atlow
119559a361
tools: do not run CQ on non-fast-tracked PRs open for less than 2 days
...
PR-URL: https://github.com/nodejs/node/pull/45407
Fixes: https://github.com/nodejs/node/issues/45405
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2022-11-12 16:22:02 +00:00
Rich Trott
9baf748ee8
tools: simplify .eslintrc.js
...
Remove explicit setting of configuration options in rules when those
options are the defaults.
PR-URL: https://github.com/nodejs/node/pull/45397
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-11-12 15:13:05 +00:00
Rich Trott
16a25afebb
tools: simplify regex in ESLint config
...
PR-URL: https://github.com/nodejs/node/pull/45399
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-11-12 14:48:52 +00:00
Rich Trott
917987cc58
tools: enable jsdoc/require-property-description rule
...
PR-URL: https://github.com/nodejs/node/pull/45370
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Jacob Smith <jacob@frende.me >
2022-11-12 04:09:57 +00:00
Rich Trott
fac0d415fe
esm: add JSDoc property descriptions for loader
...
PR-URL: https://github.com/nodejs/node/pull/45370
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Jacob Smith <jacob@frende.me >
2022-11-12 04:09:56 +00:00
Rich Trott
67a30223b9
esm: add JSDoc property descriptions for fetch
...
PR-URL: https://github.com/nodejs/node/pull/45370
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Jacob Smith <jacob@frende.me >
2022-11-12 04:09:55 +00:00
Rich Trott
42c8f099ff
http: add JSDoc property descriptions
...
PR-URL: https://github.com/nodejs/node/pull/45370
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Jacob Smith <jacob@frende.me >
2022-11-12 04:09:54 +00:00
Yagiz Nizipli
ca3ed363ff
util: improve text decoder performance
...
PR-URL: https://github.com/nodejs/node/pull/45388
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-11-11 17:48:29 -08:00
Michaël Zasso
4107ce0dad
deps: V8: cherry-pick 031b98b25cba
...
Original commit message:
[runtime] Clear array join stack when throwing uncatchable
... exception.
Array#join depends array_join_stack to avoid infinite loop
and ensures symmetric pushes/pops through catch blocks to
correctly maintain the elements in the join stack.
However, the stack does not pop the elements and leaves in
an invalid state when throwing the uncatchable termination
exception. And the invalid join stack state will affect
subsequent Array#join calls. Because all the terminate
exception will be handled by Isolate::UnwindAndFindHandler,
we could clear the array join stack when unwinding the terminate
exception.
Bug: v8:13259
Change-Id: I23823e823c5fe0b089528c5cf654864cea78ebeb
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3878451
Reviewed-by: Jakob Linke <jgruber@chromium.org >
Commit-Queue: 王澳 <wangao.james@bytedance.com >
Cr-Commit-Position: refs/heads/main@{#83465}
Refs: 031b98b25c
Closes: https://github.com/nodejs/node/issues/44417
PR-URL: https://github.com/nodejs/node/pull/45375
Fixes: https://github.com/nodejs/node/issues/44417
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com >
2022-11-11 07:20:17 +00:00
Khafra
916af4ef2d
buffer: introduce File
...
PR-URL: https://github.com/nodejs/node/pull/45139
Fixes: https://github.com/nodejs/node/issues/39015
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-11-10 20:52:45 +00:00
Rich Trott
e9a9e1ea5b
tools: dynamically determine parallelism on GitHub Actions macOS
...
Refs: https://github.com/nodejs/node/pull/45340#discussion_r1014859250
PR-URL: https://github.com/nodejs/node/pull/45350
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2022-11-10 17:04:00 +00:00
Rich Trott
fb5cf43c20
meta: be more proactive about removing from teams
...
PR-URL: https://github.com/nodejs/node/pull/45352
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2022-11-10 17:03:50 +00:00
Darshan Sen
d55a7c3435
test: add a test to ensure the correctness of timezone upgrades
...
Currently, there's no way to know if a timezone upgrade PR is correct
without building and testing the change locally. This change provides a
solution for that.
Tested in https://github.com/RaisinTen/node/pull/4 .
Signed-off-by: Darshan Sen <raisinten@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/45299
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-11-10 13:08:30 +00:00
Facundo Tuesca
f313b39d8f
tools: add automation for updating acorn dependency
...
Add a Github Action that checks for new versions of the `acorn` and
`acorn-walk` dependencies, and creates PRs to update them if newer
versions than the ones present in the repo are found.
Refs: https://github.com/nodejs/security-wg/issues/828
PR-URL: https://github.com/nodejs/node/pull/45357
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
2022-11-10 09:27:45 +00:00
Gerhard Stöbich
81ab00d913
doc, async_hooks: improve and add migration hints
...
Add hints to migrate away from async hooks.
Change docs at various places to be more clear that resources are
internals and may change at any time.
PR-URL: https://github.com/nodejs/node/pull/45369
Refs: https://github.com/nodejs/node/pull/45335
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2022-11-10 09:04:56 +00:00
Daeyeon Jeong
7b1e153530
src: simplify exit code accesses
...
This simplifies getting the exit code which is set through
`process.exitCode` by removing manually reading the JS property
from the native side.
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/45125
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2022-11-10 01:09:18 +00:00
Michael Dawson
09ae62b9a8
node-api: handle no support for external buffers
...
Refs: https://github.com/electron/electron/issues/35801
Refs: https://github.com/nodejs/abi-stable-node/issues/441
Electron recently dropped support for external
buffers. Provide a way for addon authors to:
- hide the methods to create external buffers so they can
avoid using them if they want the broadest compatibility.
- call the methods that create external buffers at runtime
to check if external buffers are supported and either
use them or not based on the return code.
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/45181
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
2022-11-09 13:30:43 -05:00
Claudio Wunder
bf28da8617
tools: add documentation regarding our api tooling
...
Introduces a proper imperative description of how the
current API documentation build system works.
Refs: https://github.com/nodejs/next-10/issues/169
PR-URL: https://github.com/nodejs/node/pull/45270
Reviewed-By: Michael Dawson <midawson@redhat.com >
2022-11-09 13:18:46 -05:00
Luigi Pinca
01e673c7f6
tools: allow scripts to run from anywhere
...
Make the `update-cares.sh`, `update-llhttp.sh`, `update-nghttp2.sh`,
and `update-npm.sh` scripts work even if they are run outside of the
`tools` directory.
PR-URL: https://github.com/nodejs/node/pull/45361
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-11-09 14:17:44 +00:00
Yagiz Nizipli
aed55df74b
util: improve text-decoder performance
...
PR-URL: https://github.com/nodejs/node/pull/45363
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-11-09 14:17:31 +00:00
Yagiz Nizipli
86a5b71dc9
benchmark: add parameters to text-decoder benchmark
...
PR-URL: https://github.com/nodejs/node/pull/45363
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-11-09 14:17:30 +00:00
Yagiz Nizipli
e3b3c4697c
benchmark: fix text-decoder benchmark
...
PR-URL: https://github.com/nodejs/node/pull/45363
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-11-09 14:17:29 +00:00