James M Snell
baa0ffdab3
test: refactor/cleanup a number of cluster tests
...
* Move shared code into common
* Favor use of strictEqual
* Add some missing common.mustCalls
* Other general cleanup
PR-URL: https://github.com/nodejs/node/pull/8261
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
2016-09-01 07:13:47 -07:00
Johan Bergström
2168432c36
build: don't require processing docs for nightlies
...
Opt-out `nightly` and `next-nightly` from the documentation
requirement since these docs aren't meant to be published.
This fixes our nightly jobs in CI.
PR-URL: https://github.com/nodejs/node/pull/8325
Fixes: https://github.com/nodejs/build/issues/478
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James Snell <jasnell@gmail.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-09-01 08:58:54 -03:00
Hubert Mine
f7dd3bc19f
doc: fix typo in stream doc
...
PR-URL: https://github.com/nodejs/node/pull/8326
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Brian White <mscdex@mscdex.net >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2016-09-01 07:22:03 +02:00
Ali Ijaz Sheikh
870faeef95
deps: workaround clang-3.4 ICE
...
PR-URL: https://github.com/nodejs/node/pull/8343
Fixes: https://github.com/nodejs/node/issues/8323
Reviewed-By: rvagg - Rod Vagg <rod@vagg.org >
2016-08-31 15:14:45 -07:00
Rich Trott
266270e618
test: refactor parallel/test-process-env.js
...
* Remove disabling of lint rule
* == -> ===
* var -> const
PR-URL: https://github.com/nodejs/node/pull/8324
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com >
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com >
2016-08-31 12:31:35 -07:00
Daniel Bevenius
56414b54d9
doc: adding danbev to collaborators
...
PR-URL: https://github.com/nodejs/node/pull/8359
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com >
2016-08-31 18:38:56 +02:00
Ali Ijaz Sheikh
becbcc7981
src: avoid duplicate AtExit functions
...
node.cc had two functions with the name AtExit with entirely different
purposes:
* node::AtExit(): file static; used to register the atexit(3) handler
for the Node process.
* node::AtExit(void (*)(void*), void*): publicly exported symbol that
addons can use to request callbacks upon exit.
For code readability it is better to avoid the unintentional overload.
PR-URL: https://github.com/nodejs/node/pull/8273
Reviewed-By: addaleax - Anna Henningsen <anna@addaleax.net >
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com >
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl >
2016-08-31 09:27:51 -07:00
Eugene Ostroukhov
27fd2d7e61
inspector: make sure all messages are dispatched
...
This fixes a race condition when messages are coming while V8 is still
dispatching the previous batch.
PR-URL: https://github.com/nodejs/node/pull/8264
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl >
2016-08-31 09:19:24 -07:00
Eugene Ostroukhov
b6db963915
inspector: simplify buffer management
...
This change simplifies buffer management to address a number of issues
that original implementation had.
Original implementation was trying to reduce the number of allocations
by providing regions of the internal buffer to libuv IO code. This
introduced some potential use after free issues if the buffer grows
(or shrinks) while there's a pending read. It also had some confusing
math that resulted in issues on Windows version of the libuv.
PR-URL: https://github.com/nodejs/node/pull/8257
Fixes: https://github.com/nodejs/node/issues/8155
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl >
2016-08-31 09:01:46 -07:00
Bartosz Sosnowski
b1bbc68fb1
benchmark: support for multiple http benchmarkers
...
This adds support for multiple HTTP benchmarkers. Adds autocannon
as the secondary benchmarker.
PR-URL: https://github.com/nodejs/node/pull/8140
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2016-08-31 17:49:26 +02:00
Rich Trott
f6e33ef8bc
test: add test for zlib.create*Raw()
...
Currently, there are no tests that exercise `zlib.createInflateRaw()` or
`zlib.createDeflateRaw()`.
This adds minimal tests that invoke the functions and confirm that they
return `zlib.InflateRaw`/`zlib.DeflateRaw` objects.
PR-URL: https://github.com/nodejs/node/pull/8306
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-30 19:28:24 -07:00
Paul Grock
eca74a9d91
test: cleanup test require symlink
...
* Changed `==` to `includes` for clarity.
* Switched to `assert.strictEqual` from `assert.equal`
* Changed some `var` to `const`
* Test cleanup with `common.refreshTmpDir`
PR-URL: https://github.com/nodejs/node/pull/8305
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-30 13:42:36 -07:00
yorkie
a3c5567eb4
src,win: use correct exit code in old versions
...
If `IsWindows7OrGreater()` returns `false`, the Node.js program should
exit with a more specific code ERROR_EXE_MACHINE_TYPE_MISMATCH instead
the code 0x1(ERROR_INVALID_FUNCTION)
PR-URL: https://github.com/nodejs/node/pull/8204
Reviewed-By: João Reis <reis@janeasystems.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-08-31 04:22:43 +08:00
James M Snell
86067f0129
doc: clarify that path on windows accepts / and \
...
Fixes: https://github.com/nodejs/node/issues/6520
PR-URL: https://github.com/nodejs/node/pull/8291
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-08-30 12:29:47 -07:00
Rich Trott
5a7a6d9b01
tools: enable caching for jslint task
...
PR-URL: https://github.com/nodejs/node/pull/8296
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
2016-08-30 10:42:25 -07:00
Rich Trott
201115812e
tools: update ESLint to 3.4.0
...
PR-URL: https://github.com/nodejs/node/pull/8296
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Roman Reiss <me@silverwind.io >
2016-08-30 10:40:45 -07:00
Anna Henningsen
932c824c60
events: make memory leak warning more accessible
...
This makes the famous `EventEmitter memory leak` warnings occurring
when the listener count for a given event exceeds a specified number
more programatically accessible, by giving them properties referring
to the event emitter instance and the event itself.
This can be useful for debugging the origins of such a warning when
the stack itself doesn’t reveal enough information about the event
emitter instance itself, e.g. when manual inspection of the
already-registered listeners is expected to be useful.
PR-URL: https://github.com/nodejs/node/pull/8298
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Jeremiah Senkpiel <Fishrock123@rocketmail.com >
2016-08-30 17:02:51 +02:00
Eugene Ostroukhov
1b8accfdd6
inspector: use new inspector headers
...
PR-URL: https://github.com/nodejs/node/pull/8150
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl >
2016-08-30 06:37:39 -07:00
Eugene Ostroukhov
61faabd938
deps: v8_inspector update
...
Pick up latest from [1] corresponding to the Blink commit 60cd6e859b.
[1]: https://github.com/pavelfeldman/v8_inspector/commit/55f21a5611
PR-URL: https://github.com/nodejs/node/pull/8150
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl >
2016-08-30 06:37:23 -07:00
Luigi Pinca
1e0bfacc28
doc: add lpinca to collaborators
...
PR-URL: https://github.com/nodejs/node/pull/8331
Reviewed-By: Rich Trott <rtrott@gmail.com >
2016-08-30 08:10:21 +02:00
Rich Trott
e192825de0
test: refactor test-debug-signal-cluster
...
Notable changes include removing one (but not all) hard-coded ports,
using `common.fail()`, and tidying conditionals and assertions.
PR-URL: https://github.com/nodejs/node/pull/8289
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-29 18:53:29 -07:00
Brian White
2cc7fa5e7d
http: remove deprecated Client interface
...
PR-URL: https://github.com/nodejs/node/pull/8104
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2016-08-29 21:44:58 -04:00
James M Snell
07dbf7313d
promise: hard deprecation for unhandled promise rejection
...
PR-URL: https://github.com/nodejs/node/pull/8217
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
2016-08-29 16:27:58 -07:00
Benjamin Gruenbaum
ecf474ceba
promise: warn on unhandled rejections
...
Log unhandled promise rejections with a guid and emit
a process warning. When rejection is eventually handled,
emit a secondary warning.
PR-URL: https://github.com/nodejs/node/pull/8217
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com >
2016-08-29 16:27:38 -07:00
James M Snell
488d37b3dc
doc: doc that listen can be called multiple times
...
Fixes: https://github.com/nodejs/node/issues/4646
PR-URL: https://github.com/nodejs/node/pull/8294
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2016-08-29 15:32:32 -07:00
James M Snell
61fa50d298
doc: readline write() is processed as input
...
Fixes: https://github.com/nodejs/node/issues/4402
PR-URL: https://github.com/nodejs/node/pull/8295
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2016-08-29 15:29:59 -07:00
James M Snell
4537cf2377
test: additional refactoring/cleanup of buffer tests
...
* Favor use of strictEqual where possible
* Use const as appropriate
* Other miscellaneous cleanups
PR-URL: https://github.com/nodejs/node/pull/8283
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
2016-08-29 15:24:03 -07:00
James M Snell
f10e1ed455
doc: 'ipc' is required with fork stdio option
...
Fixes: https://github.com/nodejs/node/issues/8167
PR-URL: https://github.com/nodejs/node/pull/8290
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2016-08-29 15:20:35 -07:00
James M Snell
407069a29d
test: add known issue test for path parse issue #6229
...
Refs: https://github.com/nodejs/node/issues/6229
PR-URL: https://github.com/nodejs/node/pull/8293
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2016-08-29 15:15:18 -07:00
James M Snell
49ef3ae90a
Revert "fs: add a temporary fix for re-evaluation support"
...
As planned, This reverts commit 1d79787e2e .
Fixes: https://github.com/nodejs/node/issues/5213
PR-URL: https://github.com/nodejs/node/pull/6413
Reviewed-By: Ben Noordhuis <info@noordhuis.nl >
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com >
Reviewed-By: JungMinu - Minwoo Jung <jmwsoft@gmail.com >
Reviewed-By: Rod Vagg <rod@vagg.org >
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2016-08-29 15:11:00 -07:00
Michael Dawson
1657f12f75
build: fix dependencies on AIX
...
Addon tests were still starting to run before the node exp file
creation was complete.
- remove process_outputs_as_sources as it did not fix the
problem
- update create_expfile.sh so that exp file is created in a
temporary file and then renamed to final name so that
file is only visible once it is complete
- update target used in building Addons so that for
AIX it depends on the exp file being available
PR-URL: https://github.com/nodejs/node/pull/8285
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
2016-08-29 16:20:18 -04:00
Sakthipriyan Vairamani
c8619ea3c3
doc: improve fs.truncate functions' documentation
...
The default value of the `len` parameter is zero and it is included in
the documenetation.
This patch also has examples of how `ftruncate` can be used.
PR-URL: https://github.com/nodejs/node/pull/7648
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-27 19:51:20 +05:30
Sakthipriyan Vairamani
82c7a9c40c
test: make sure over truncation of file zero fills
...
If the file is over truncated, then the rest of the file should be
filled with null bytes. These tests ensure the same.
PR-URL: https://github.com/nodejs/node/pull/7648
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-27 19:51:16 +05:30
Luigi Pinca
df4880de55
doc: add added: information for modules
...
PR-URL: https://github.com/nodejs/node/pull/8250
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Bryan English <bryan@bryanenglish.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-27 16:19:26 +02:00
Anna Henningsen
4863f6a121
net: make holding the buffer in memory more robust
...
Set the `req.buffer` property, which serves as a way of keeping
a `Buffer` alive that is being written to a stream, on the C++
side instead of the JS side.
This closes a hole where buffers that were temporarily created
in order to write strings with uncommon encodings (e.g. `hex`)
were passed to the native side without being set as `req.buffer`.
Fixes: https://github.com/nodejs/node/issues/8251
PR-URL: https://github.com/nodejs/node/pull/8252
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
2016-08-27 16:11:46 +02:00
Prince J Wesley
5bef38b627
repl: Auto alignment for .editor mode
...
When in `.editor` mode, current line whitespace prefixes
are preserved in the subsequent line. User can hit backspace
to clean the whitespace
```js
node 🙈 ₹ node
> .editor
// Entering editor mode (^D to finish, ^C to cancel)
function test() {
console.log('tested!'); //On enter, cursor will be after 2 spaces
_
```
PR-URL: https://github.com/nodejs/node/pull/8241
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-27 16:53:59 +05:30
Sakthipriyan Vairamani
f8f283b8f3
fs: warn if no callback is passed to async calls
...
This patch issues a deprecation warning, if an asynchronous function
is called without a callback function.
PR-URL: https://github.com/nodejs/node/pull/7897
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2016-08-27 12:43:43 +05:30
Zwb
a72a331536
doc: fix onReadable reentry after unshift called
...
In example parseHeader, stream listen **readable** event,
if call stream.unshift(buf) before stream.removeListener('readable',
onReadable), readable event will be emited before removeListener,
so callback will not been called correctlly.
After change to
```js
stream.removeListener('error', callback);
stream.removeListener('readable', onReadable);
if (buf.length)
stream.unshift(buf);
```
It solves this problem.
PR-URL: https://github.com/nodejs/node/pull/8200
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2016-08-26 21:59:55 -07:00
Adam Langley
f4aa2c2c93
crypto: remove POINT_CONVERSION_HYBRID from documentation.
...
Compressed points are already rare and, as far as I know, nobody has used
the 'hybrid' format anywhere, ever. It's prohibited in X.509
certificates too[1].
This change removes mentions of it from the documentation in the
interests of trying to pare-down the complexity of cryptography.
[1] https://tools.ietf.org/html/rfc5480#section-2.2
PR-URL: https://github.com/nodejs/node/pull/4956
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com >
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-26 21:45:26 -07:00
Rich Trott
a6d53c6779
test: add check in test-signal-handler
...
* Check that the removed listener is not called.
* Opportunistic `==` -> `===` change.
PR-URL: https://github.com/nodejs/node/pull/8248
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2016-08-26 09:34:12 -07:00
Evan Lucas
0482d6d592
2016-08-26, Version 6.5.0 (Current)
...
Notable changes:
* **buffer**: Fix regression introduced in v6.4.0 that prevented .write() at buffer end (Anna Henningsen) https://github.com/nodejs/node/pull/8154
* **deps**: update V8 to 5.1.281.75 (Ali Ijaz Sheikh) https://github.com/nodejs/node/pull/8054
* **inspector**:
* fix inspector hang while disconnecting (Aleksei Koziatinskii) https://github.com/nodejs/node/pull/8021
* add support for uncaught exception (Aleksei Koziatinskii) https://github.com/nodejs/node/pull/8043
* **repl**: Fix saving editor mode text in `.save` (Prince J Wesley) https://github.com/nodejs/node/pull/8145
* ***Revert*** "**repl,util**: insert carriage returns in output" (Evan Lucas) https://github.com/nodejs/node/pull/8143
PR-URL: https://github.com/nodejs/node/pull/8253
2016-08-26 11:22:58 -05:00
Brian White
1050594c86
http: fix connection upgrade checks
...
This commit fixes connection upgrade checks, specifically when headers
are passed as an array instead of a plain object to http.request()
Fixes: https://github.com/nodejs/node/issues/8235
PR-URL: https://github.com/nodejs/node/pull/8238
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-26 10:17:34 -04:00
James M Snell
7053922c1a
test: clean up / refactor buffer tests, remove duplication
...
Remove duplication of buffer tests, separate out into separate
files, update and cleanup code, move to using strictEqual where
possible.
PR-URL: https://github.com/nodejs/node/pull/8256
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
2016-08-26 07:15:31 -07:00
Sakthipriyan Vairamani
b3e7ac2605
util: improve function signature of util._extend
...
The function signature of `util._extend` is not intuitive and the
documentation doesn't specify the necessary second parameter. This
patch changes the parameter names in the code and the function params
in doc.
PR-URL: https://github.com/nodejs/node/pull/8187
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <mic.besace@gmail.com >
Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com >
Reviewed-By: Brian White <mscdex@mscdex.net >
2016-08-26 18:53:39 +05:30
Michael Dawson
02ed21aa5c
test: mark test-child-process-fork-dgram as flaky
...
PR-URL: https://github.com/nodejs/node/pull/8274
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2016-08-26 08:49:19 -04:00
Michael Dawson
063d14e496
build: fix dependencies on AIX
...
Addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to avoid
this.
Fixes: https://github.com/nodejs/node/issues/8239
PR-URL: https://github.com/nodejs/node/pull/8272
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Johan Bergström <bugs@bergstroem.nu >
2016-08-25 18:28:58 -04:00
Richard Lau
18017d675b
build: add missing files to zip and 7z packages
...
Add nodevars.bat, node_etw_provider.man and node_perfctr_provider.man
to the zip and 7z packages.
PR-URL: https://github.com/nodejs/node/pull/8069
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com >
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com >
2016-08-25 17:37:16 -04:00
yorkie
10b3f131c2
async_wrap: add a missing case to test-async-wrap-throw-no-init
...
PR-URL: https://github.com/nodejs/node/pull/8198
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Trevor Norris <trev.norris@gmail.com >
2016-08-26 03:52:19 +08:00
Nikolai Vavilov
f2fe5583c4
buffer: runtime deprecation of calling Buffer without new
...
PR-URL: https://github.com/nodejs/node/pull/8169
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-25 11:08:19 -07:00
Luigi Pinca
379d9162a2
doc: add added: information for dgram
...
PR-URL: https://github.com/nodejs/node/pull/8196
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2016-08-25 10:56:28 -07:00