OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
45,625 Commits 30 Branches 683 Tags
af00e02e35927f2fd7490d5869b478f7544bd255
Commit Graph

45625 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Antoine du Hamel
af00e02e35 tools: add some options and comments to shell.nix 
PR-URL: https://github.com/nodejs/node/pull/60911
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-12-07 20:28:47 +00:00
Mohit Raj Saxena
7674f989aa doc: add File modes cross-references in fs methods 
Adds links to the File modes section from fsPromises.open(),
fsPromises.mkdir(), and fs.mkdir() to improve discoverability
of file permission documentation.

PR-URL: https://github.com/nodejs/node/pull/60286
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2025-12-07 10:02:14 +00:00
mag123c
37d9cfcd3a esm: improve error messages for ambiguous module syntax 
PR-URL: https://github.com/nodejs/node/pull/60376
Fixes: https://github.com/nodejs/node/issues/60322
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-12-05 23:51:23 +00:00
Rafael Gonzaga
cbe02339b6 test: improve config-file permission test coverage 
Refs: https://github.com/nodejs/node/pull/60746#pullrequestreview-3470430664
PR-URL: https://github.com/nodejs/node/pull/60929
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-12-05 11:58:29 +00:00
Chengzhong Wu
253b16fe14 doc: add note about rust toolchain version requirement 
PR-URL: https://github.com/nodejs/node/pull/60942
Refs: https://github.com/nodejs/node/pull/60897
Refs: https://github.com/nodejs/node/issues/58730
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-12-05 11:25:51 +00:00
Chengzhong Wu
a004535617 build: add temporal to linux GHA build 
PR-URL: https://github.com/nodejs/node/pull/60942
Refs: https://github.com/nodejs/node/pull/60897
Refs: https://github.com/nodejs/node/issues/58730
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-12-05 11:25:51 +00:00
Livia Medeiros
e77694631f http2,zlib: prefer call() over apply() if argument list is not array 
PR-URL: https://github.com/nodejs/node/pull/60834
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-12-04 14:36:16 +00:00
Mert Can Altin
f65b0bc81a src: implement Windows-1252 encoding support and update related tests 
PR-URL: https://github.com/nodejs/node/pull/60893
Fixes: https://github.com/nodejs/node/issues/60888
Fixes: https://github.com/nodejs/node/issues/59515
Fixes: https://github.com/nodejs/node/issues/56542
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2025-12-04 14:23:01 +00:00
dependabot[bot]
025ade6997 tools: bump mdast-util-to-hast from 13.2.0 to 13.2.1 in /tools/doc 
Bumps [mdast-util-to-hast](https://github.com/syntax-tree/mdast-util-to-hast) from 13.2.0 to 13.2.1.
- [Release notes](https://github.com/syntax-tree/mdast-util-to-hast/releases)
- [Commits](https://github.com/syntax-tree/mdast-util-to-hast/compare/13.2.0...13.2.1)

---
updated-dependencies:
- dependency-name: mdast-util-to-hast
  dependency-version: 13.2.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/60930
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-12-04 03:57:52 +00:00
Jan Olaf Martin
e8c9c43336 module: allow subpath imports that start with #/ 
It's a common ecosystem pattern to map a source root directory to
`@/` but it requires special tooling support. This turns `#/*` into
a more realistic alternative for that pattern.

PR-URL: https://github.com/nodejs/node/pull/60864
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
 2025-12-04 02:27:04 +00:00
dependabot[bot]
cb0eb58144 meta: bump actions/setup-python from 6.0.0 to 6.1.0 
Bumps [actions/setup-python](https://github.com/actions/setup-python)
from 6.0.0 to 6.1.0.

- [Release notes](https://github.com/actions/setup-python/releases)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-version: 6.1.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/60927
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2025-12-03 20:39:07 +00:00
dependabot[bot]
a7805e2da8 meta: bump github/codeql-action from 4.31.3 to 4.31.6 
Bumps [github/codeql-action](https://github.com/github/codeql-action)
from 4.31.3 to 4.31.6.

- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-version: 4.31.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/60926
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2025-12-03 20:38:56 +00:00
dependabot[bot]
861ef97bf1 meta: bump actions/checkout from 5.0.1 to 6.0.0 
Bumps [actions/checkout](https://github.com/actions/checkout) from 5.0.1
to 6.0.0.

- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 6.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/60925
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2025-12-03 20:38:44 +00:00
dependabot[bot]
4f5ab59b6d meta: bump peter-evans/create-pull-request from 7.0.8 to 7.0.9 
---
updated-dependencies:
- dependency-name: peter-evans/create-pull-request
  dependency-version: 7.0.9
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/60924
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-12-03 20:38:33 +00:00
Chengzhong Wu
746c3c2ec2 util: assert getCallSites does not invoke Error.prepareStackTrace 
PR-URL: https://github.com/nodejs/node/pull/60922
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
 2025-12-03 17:53:07 +00:00
Antoine du Hamel
5879e9b257 tools: ignore more paths in GHA CI 
PR-URL: https://github.com/nodejs/node/pull/60920
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2025-12-03 14:55:28 +00:00
Antoine du Hamel
987740399d tools: enforce trailing commas in test/es-module 
PR-URL: https://github.com/nodejs/node/pull/60891
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-12-03 14:18:40 +01:00
Antoine du Hamel
441027af47 tools: enforce trailing commas in test/sequential 
PR-URL: https://github.com/nodejs/node/pull/60892
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
 2025-12-03 14:17:37 +01:00
René
ecdf6a8c53 stream: fix isErrored/isWritable for WritableStreams 
PR-URL: https://github.com/nodejs/node/pull/60905
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2025-12-03 13:08:34 +00:00
Antoine du Hamel
5b4b031da4 tools: run tests --without-amaro on test-shared macOS 
PR-URL: https://github.com/nodejs/node/pull/60902
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-12-03 13:08:23 +00:00
semimikoh
470ef988f6 benchmark: fix incorrect base64 input in byteLength benchmark 
PR-URL: https://github.com/nodejs/node/pull/60841
Fixes: https://github.com/nodejs/node/issues/60836
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
 2025-12-03 07:19:16 +00:00
Deokjin Kim
80e0779a81 doc: add missing zstd to mjs example of zlib 
cjs example already has `zstd` as compression encoding.

Refs: https://github.com/nodejs/node/pull/52100
PR-URL: https://github.com/nodejs/node/pull/60915
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2025-12-03 01:42:20 +00:00
Michaël Zasso
c14e4e4b31 tools: replace deprecated eslint-plugin-markdown 
PR-URL: https://github.com/nodejs/node/pull/60908
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2025-12-02 18:42:17 +00:00
Michaël Zasso
75744b11cf tools: remove deprecated ESLint plugins 
Syntax for explicit resource management and import attributes syntax
are supported without it.

PR-URL: https://github.com/nodejs/node/pull/60908
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2025-12-02 18:42:16 +00:00
Michaël Zasso
b013e6e32d tools: update ESLint dependencies 
- Update all dependencies to their latest version and regenerate lock
  file.
- Fixup deprecated field of `@stylistic/eslint-plugin` config.
- Disable `assignmentOperator` indent rule (we are inconsistent, so
  there's no valid config for it).
- Disable jsdoc rules that we do not follow.

PR-URL: https://github.com/nodejs/node/pull/60908
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2025-12-02 18:42:16 +00:00
Livia Medeiros
4ea921bdbf test: skip SEA inspect test if inspector is not available 
PR-URL: https://github.com/nodejs/node/pull/60872
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-12-02 11:46:50 +00:00
Joyee Cheung
6432765a9c src: fix off-thread cert loading in bundled cert mode 
https://redirect.github.com/nodejs/node/pull/59856 had an typo/mistake
in the skip conditions so that it is skipping when --use-openssl-ca
or --openssl-system-ca-path (configure time) are NOT used, even
though they should be skipped only when those ARE used (which is
not the default for default builds). This change fixes that so
that the perf numbers in that PR is true for the default build.

PR-URL: https://github.com/nodejs/node/pull/60764
Reviewed-By: Aditi Singh <aditisingh1400@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-12-02 09:51:06 +00:00
Michaël Zasso
8cfcf52db8 tools: refloat 10 Node.js patches to cpplint.py 
Cherry-pick 12c8b4d154
Original commit message:
    This commit is a suggestion for adding a rule for NULL usages in the
    code base. This will currently report a number of errors which could be
    ignored using // NOLINT (readability/null_usage)

    PR-URL: https://github.com/nodejs/node/pull/17373
    Reviewed-By: Jon Moss <me@jonathanmoss.me>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Timothy Gu <timothygu99@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
    Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Refs: 12c8b4d154

Cherry-pick fc81e80191
Original commit message:

    Update cpplint.py to check for inline headers when the corresponding
    header is already included.

    PR-URL: https://github.com/nodejs/node/pull/21521
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: fc81e80191

Cherry-pick cbc3dd997e
Original commit message:

    src, tools: add check for left leaning pointers

    This commit adds a rule to cpplint to check that pointers in the code
    base lean to the left and not right, and also fixes the violations
    reported.

    PR-URL: https://github.com/nodejs/node/pull/21010
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Anna Henningsen <anna@addaleax.net>
    Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
    Reviewed-By: James M Snell <jasnell@gmail.com>

Refs: cbc3dd997e

Cherry-pick 902998190a
Original commit message:

    tools: fix cpplint.py header rules

    THIS COMMIT SHOULD GO WITH THE NEXT. IT WILL FIND NEW LINT.

    PR-URL: https://github.com/nodejs/node/pull/26306
    Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

Refs: 902998190a

Cherry-pick 0a25ace9c3
Original commit message:

    tools: move cpplint configuration to .cpplint

    PR-URL: https://github.com/nodejs/node/pull/27098
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

Refs: 0a25ace9c3

Cherry-pick afa9a7206c
Original commit message:

    tools: refloat update link to google styleguide for cpplint

    This commit updates two old links to Google's C++ styleguide which
    currently result in a 404 when accessed.

    PR-URL: https://github.com/nodejs/node/pull/30876
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>

Refs: afa9a7206c

Cherry-pick e23bf8f771
Original commit message:

    tools,src: refloat forbid usage of v8::Persistent

    `v8::Persistent` comes with the surprising catch that it requires
    manual cleanup. `v8::Global` doesn’t, making it easier to use,
    and additionally provides move semantics. New code should always
    use `v8::Global`.

    PR-URL: https://github.com/nodejs/node/pull/31018
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: David Carlier <devnexen@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    Reviewed-By: Gus Caplan <me@gus.host>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
    Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

Backport 3d954dcf81
Original commit message:

    tools: remove readability/fn_size rule

    PR-URL: https://github.com/nodejs/node/pull/54663
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Refs: 3d954dcf81

Cherry-pick c7d7ec7cda
Original commit message:

    tools: check for std::vector<v8::Local> in lint

    PR-URL: https://github.com/nodejs/node/pull/58497
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
    Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>

Refs: c7d7ec7cda

Cherry-pick e6d94ef106
Original commit message:

    tools: add C++ lint rule to avoid using `String::Utf8Value`

    We should be using our own helpers for this instead.

    PR-URL: https://github.com/nodejs/node/pull/60244
    Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
    Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
    Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
    Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
    Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
    Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>

Refs: e6d94ef106
PR-URL: https://github.com/nodejs/node/pull/60901
Fixes: https://github.com/nodejs/node/issues/60771
 2025-12-02 08:03:25 +00:00
Michaël Zasso
11813f9c75 tools: update cpplint to 2.0.2 
PR-URL: https://github.com/nodejs/node/pull/60901
Fixes: https://github.com/nodejs/node/issues/60771
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
 2025-12-02 08:03:25 +00:00
Michaël Zasso
fc85c7afd3 tools: disable some new cpplint rules before update 
PR-URL: https://github.com/nodejs/node/pull/60901
Fixes: https://github.com/nodejs/node/issues/60771
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
 2025-12-02 08:03:24 +00:00
Michaël Zasso
09c4f6f41c deps,src: prepare for cpplint update 
Disable linting where there are false positives or clashes whith the C++
formatter.

PR-URL: https://github.com/nodejs/node/pull/60901
Fixes: https://github.com/nodejs/node/issues/60771
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
 2025-12-02 08:03:23 +00:00
Node.js GitHub Bot
85852a3221 tools: update nixpkgs-unstable to 59b6c96beacc898566c9be1052ae806f383 
PR-URL: https://github.com/nodejs/node/pull/60900
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2025-12-02 01:06:11 +00:00
Node.js GitHub Bot
b9a1af95f8 deps: update sqlite to 3.51.1 
PR-URL: https://github.com/nodejs/node/pull/60899
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com>
 2025-12-02 01:06:01 +00:00
Node.js GitHub Bot
644fb8821b deps: update zlib to 1.3.1-63d7e16 
PR-URL: https://github.com/nodejs/node/pull/60898
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-12-02 01:05:52 +00:00
Node.js GitHub Bot
abe7de96ef test: update WPT for WebCryptoAPI to 1e4933113d 
PR-URL: https://github.com/nodejs/node/pull/60896
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-12-02 00:39:47 +00:00
Chengzhong Wu
28142a6106 build: run embedtest with node_g when BUILDTYPE=Debug 
PR-URL: https://github.com/nodejs/node/pull/60850
Refs: https://github.com/nodejs/node/pull/60806
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
 2025-12-01 15:23:30 +00:00
Richard Lau
90ff75f432 tools: don't fetch V8 deps in the source tree 
The Node.js source tree already includes several V8 DEPS under
`deps/v8/third_party` that are needed to build Node.js. Exclude these
in `tools/v8/fetch_deps.py` to prevent "Conflicting directory" warnings
when running the V8 CI.

PR-URL: https://github.com/nodejs/node/pull/60883
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2025-12-01 15:12:10 +00:00
Joyee Cheung
f9f343fb8d src: handle DER decoding errors from system certificates 
When decoding certificates from the system store, it's not actually
guaranteed to succeed. In case the system returns a certificate
that cannot be decoded (might be related to SSL implementation issues),
skip them.

PR-URL: https://github.com/nodejs/node/pull/60787
Refs: https://github.com/microsoft/vscode/issues/277064
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Aditi Singh <aditisingh1400@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
 2025-12-01 07:26:03 +00:00
Yagiz Nizipli
b1e941e7b2 util: improve textencoder encodeInto performance 
Co-authored-by: Erik Corry <ecorry@cloudflare.com>
Co-authored-by: Daniel Lemire <daniel@lemire.me>
PR-URL: https://github.com/nodejs/node/pull/60843
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2025-12-01 01:17:44 +00:00
Rafael Gonzaga
6f7f51b8f1 doc: clarify fileURLToPath security considerations 
Add clarification that fileURLToPath() decodes encoded
dot-segments (%2e%2e) which are normalized as path traversal.
Applications must perform their own path validation to
prevent directory traversal attacks.

Also applies to fileURLToPathBuffer().

PR-URL: https://github.com/nodejs/node/pull/60887
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2025-11-30 22:02:12 +00:00
Filip Skokan
94cd600542 crypto: fix DOMException name for non-extractable key error 
PR-URL: https://github.com/nodejs/node/pull/60830
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-11-30 21:45:27 +00:00
René
209a4fe812 test: lint more assert(regexp.test(...)) cases 
PR-URL: https://github.com/nodejs/node/pull/60878
Refs: https://github.com/nodejs/node/pull/60832
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2025-11-30 18:39:38 +00:00
Michaël Zasso
10837e33b0 lib,test: fix jsdoc comments 
To prepare for eslint-plugin-jsdoc update.

Refs: https://github.com/nodejs/node/pull/60535
PR-URL: https://github.com/nodejs/node/pull/60870
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-11-30 19:14:12 +01:00
schliepa
d0c102495a doc: show the use of string expressions in the SQLTagStore example 
If a users attempts to escape strings with quotes in SQLTagStore
template strings (`'${expression}'`), as is usually required for
SQL query strings, the queries would fail. This change shows an
example on the correct use (`${expression}`).

PR-URL: https://github.com/nodejs/node/pull/60873
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2025-11-30 13:31:56 +00:00
René
6274eb78fb test: use assert.match for non-literal regexp tests 
PR-URL: https://github.com/nodejs/node/pull/60879
Refs: https://github.com/nodejs/node/pull/60832
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2025-11-30 13:06:30 +00:00
Node.js GitHub Bot
6a1a3ba045 deps: update corepack to 0.34.5 
PR-URL: https://github.com/nodejs/node/pull/60842
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2025-11-30 08:37:59 +01:00
Deokjin Kim
6a80d0558a doc: replace column with columnNumber in example of util.getCallSites 
`column` is deprecated in favor of `columnNumber`.

Refs: https://github.com/nodejs/node/pull/56584
PR-URL: https://github.com/nodejs/node/pull/60881
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-11-30 02:36:26 +00:00
Rich Trott
e42c6c899d doc: correct spelling in BUILDING.md 
PR-URL: https://github.com/nodejs/node/pull/60875
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2025-11-29 17:57:55 +00:00
Vladimir Morozov
768f3ba32a test: fix embedtest in debug windows 
PR-URL: https://github.com/nodejs/node/pull/60806
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-11-29 10:40:39 +00:00
Michaël Zasso
d1ab5ef4ba src: use static_cast instead of C-style cast 
PR-URL: https://github.com/nodejs/node/pull/60868
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2025-11-29 06:50:41 +00:00