OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
45,708 Commits 30 Branches 683 Tags
a385bb1d701c95b5d647666f9e5c12ca548dc124
Commit Graph

45708 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Michaël Zasso
a385bb1d70 tools: unpin ngtcp2 version updates 
It was pinned to 1.15.1 in https://github.com/nodejs/node/pull/59946
without any explanation.

PR-URL: https://github.com/nodejs/node/pull/61155
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-12-23 14:39:44 +01:00
Node.js GitHub Bot
55600e6153 deps: update timezone to 2025c 
PR-URL: https://github.com/nodejs/node/pull/61138
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2025-12-23 01:09:13 +00:00
Node.js GitHub Bot
c5d3f5f9c8 tools: update nixpkgs-unstable to 7d853e518814cca2a657b72eeba67ae20eb 
PR-URL: https://github.com/nodejs/node/pull/61137
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2025-12-23 01:09:02 +00:00
Antoine du Hamel
fb2a02f1d1 deps: nghttp2: revert 7784fa979d0b 
This commit reverts "Make error handling robust".
Without this revert, we are getting timeouts, crashes, and different
error codes in `parallel/test-http2-*`.

Refs: 7784fa979d
Refs: https://github.com/nodejs/node/issues/60661
PR-URL: https://github.com/nodejs/node/pull/61136
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
 2025-12-23 01:08:49 +00:00
nodejs-github-bot
1d54921552 deps: update nghttp2 to 1.68.0 
PR-URL: https://github.com/nodejs/node/pull/61136
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
 2025-12-23 01:08:49 +00:00
Node.js GitHub Bot
76c4bee978 test: update WPT for urlpattern to a2e15ad405 
PR-URL: https://github.com/nodejs/node/pull/61134
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2025-12-23 00:41:49 +00:00
Ruben Bridgewater
9120924de1 util: fix nested proxy inspection 
Fixes: https://github.com/nodejs/node/issues/61061
PR-URL: https://github.com/nodejs/node/pull/61077
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
 2025-12-22 22:22:04 +00:00
Chengzhong Wu
799feac6f5 deps: remove independent temporal 
Remove independent `temporal_rs` dependency and use the cargo vendored
one.

PR-URL: https://github.com/nodejs/node/pull/61072
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2025-12-22 20:32:02 +00:00
Chengzhong Wu
8f66a5c8c8 deps: apply cargo vendor 
PR-URL: https://github.com/nodejs/node/pull/61072
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2025-12-22 20:32:01 +00:00
Chengzhong Wu
493ce19486 deps: add vendor depenency crate 
Add cargo config to support building a unified cargo static lib to
include multiple crate dependencies to be used by Node.js.

This also allows additional crate dependencies to be added, like amaro.

PR-URL: https://github.com/nodejs/node/pull/61072
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2025-12-22 20:32:00 +00:00
Ruben Bridgewater
6157c81f4b assert: use a set instead of an array for faster lookup 
This is a very small improvement for error creation.

PR-URL: https://github.com/nodejs/node/pull/61076
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-12-22 19:30:36 +00:00
Ruben Bridgewater
fc1d6d6b4c assert,util: fix deep comparing invalid dates skipping properties 
The property comparison of invalid dates regressed when starting
to handle invalid dates as being equal.

PR-URL: https://github.com/nodejs/node/pull/61076
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-12-22 19:30:35 +00:00
Ruben Bridgewater
a968e4e672 assert,util: improve deep comparison performance 
PR-URL: https://github.com/nodejs/node/pull/61076
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-12-22 19:30:34 +00:00
Efe
416db75e42 events: remove eventtarget custom inspect branding 
PR-URL: https://github.com/nodejs/node/pull/61128
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2025-12-22 16:14:56 +00:00
Xavier Stouder
472f586840 os: freeze signals constant 
Remove the ability to mutate signals constant as doing so can lead to
unexpected behavior, notably when spawning child process.

Fixes: https://github.com/nodejs/node/issues/44749
PR-URL: https://github.com/nodejs/node/pull/61038
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Aviv Keller <me@aviv.sh>
 2025-12-22 16:14:46 +00:00
Joyee Cheung
28f468a615 module: fix sync resolve hooks for require with node: prefixes 
Previously, when require()-ing builtins with the node: prefix,
the sync resolve hooks were not properly invoked, and load hooks
could not override the builtin's format. This fixes the
handling and enables redirecting prefixed built-ins to on-disk
files and overriding them with other module types via hooks.

PR-URL: https://github.com/nodejs/node/pull/61088
Fixes: https://github.com/nodejs/node/issues/60005
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2025-12-22 14:35:45 +00:00
Ruben Bridgewater
26b7fd2009 util: limit inspect to only show own properties 
`Error`'s `cause` and `errors` properties would be visible even if these
were not own properties. This is changed to align with all other
parts of the `inspect` handling.

Fixes: https://github.com/nodejs/node/issues/60717
PR-URL: https://github.com/nodejs/node/pull/61032
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-12-22 14:06:14 +01:00
Tobias Nießen
d7e4108bc1 src: remove redundant CHECK 
The function `SetAuthTag()` returns early (before reaching this line) if
`!cipher->IsAuthenticatedMode()`, which expands to the exact same
condition that is being `CHECK()`ed here.

PR-URL: https://github.com/nodejs/node/pull/61130
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2025-12-21 23:53:06 +00:00
Node.js GitHub Bot
b8db64c18d deps: update simdjson to 4.2.4 
PR-URL: https://github.com/nodejs/node/pull/61056
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2025-12-21 23:25:58 +00:00
Antoine du Hamel
607a741941 tools: only report commit validation failure on Slack 
PR-URL: https://github.com/nodejs/node/pull/61124
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-12-21 10:45:18 +00:00
Node.js GitHub Bot
9d27d9a393 deps: patch V8 to 14.3.127.17 
Refs: https://github.com/v8/v8/compare/14.3.127.16...14.3.127.17
PR-URL: https://github.com/nodejs/node/pull/61058
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-12-21 11:41:24 +01:00
Antoine du Hamel
01ebb475a4 tools: use sparse-checkout in linter jobs 
We can reduce out usage by avoiding to download files we don't need.

PR-URL: https://github.com/nodejs/node/pull/61123
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-12-21 10:14:59 +00:00
Gürgün Dayıoğlu
a65421a679 process: preserve AsyncLocalStorage in queueMicrotask only when needed 
PR-URL: https://github.com/nodejs/node/pull/60913
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
 2025-12-21 01:12:15 +00:00
René
ed6ec9626e test: make buffer sizes 32bit-aware in test-internal-util-construct-sab 
PR-URL: https://github.com/nodejs/node/pull/61026
Fixes: https://github.com/nodejs/node/issues/61025
Refs: https://github.com/nodejs/node/pull/60497
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-12-20 22:20:21 +00:00
Tobias Nießen
dff46c07c3 crypto: move DEP0182 to End-of-Life 
This commit moves support for implicitly short GCM authentication tags
to End-of-Life status, thus requiring applications to explicitly specify
the `authTagLength` for authentication tags shorter than 128 bits.

There is quite a bit of refactoring to be done in the C++ source code.
This commit does not do that; instead, it implements a minimal change
only in order to avoid excessive divergence across git branches due to
this being a semver-major change.

Fixes: https://github.com/nodejs/node/issues/52327
Refs: https://github.com/nodejs/node/issues/17523
PR-URL: https://github.com/nodejs/node/pull/61084
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2025-12-20 22:02:29 +00:00
René
3b7477c4d5 test_runner: fix lazy test.assert accessor 
PR-URL: https://github.com/nodejs/node/pull/61097
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Aviv Keller <me@aviv.sh>
 2025-12-20 18:54:32 +00:00
Node.js GitHub Bot
79d695356a deps: update googletest to 065127f1e4b46c5f14fc73cf8d323c221f9dc68e 
PR-URL: https://github.com/nodejs/node/pull/61055
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-12-20 18:54:21 +00:00
Dario Piotrowicz
aad8c05595 repl: fix getters triggering side effects during completion 
PR-URL: https://github.com/nodejs/node/pull/61043
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Aviv Keller <me@aviv.sh>
 2025-12-20 18:54:12 +00:00
Filip Skokan
41c507f56d build: update test-wpt-report to use NODE instead of OUT_NODE 
PR-URL: https://github.com/nodejs/node/pull/61024
Refs: https://openjs-foundation.slack.com/archives/C03BJP63CH0/p1765400746909869
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2025-12-20 18:54:01 +00:00
Efe
038cb75012 doc: fix test settime docs 
PR-URL: https://github.com/nodejs/node/pull/61117
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
 2025-12-20 18:11:05 +00:00
Ruben Bridgewater
dc97b507d0 util: mark proxied objects as such when inspecting them 
Fixes: https://github.com/nodejs/node/issues/60964
PR-URL: https://github.com/nodejs/node/pull/61029
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2025-12-20 17:02:17 +00:00
Dario Piotrowicz
e5b6f89328 test: remove unneccessary repl magic_mode tests 
PR-URL: https://github.com/nodejs/node/pull/61053
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2025-12-20 15:54:07 +00:00
Stewart X Addison
6338e643a8 test: skip sea tests on riscv64 
Signed-off-by: Stewart X Addison <sxa@ibm.com>
PR-URL: https://github.com/nodejs/node/pull/61111
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
 2025-12-20 15:49:08 +00:00
JJ
5ea56f448b doc: correct invalid collaborator profile 
PR-URL: https://github.com/nodejs/node/pull/61091
Reviewed-By: Aviv Keller <me@aviv.sh>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-12-20 13:40:38 +00:00
Joyee Cheung
1a345922e4 doc: add a tip about developer mode on Windows 
On Windows, creating symlinks requires Developer Mode to be
enabled or running the command as Administrator. Tests that
rely on creating symlinks may fail with EPERM errors if
symlink creation is not permitted. Add a tip about this
for the docs about running tests on Windows.

PR-URL: https://github.com/nodejs/node/pull/61112
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
 2025-12-20 12:28:30 +00:00
Matteo Collina
0a5418088f doc: exclude compile-time flag features from security policy 
Add a new section to the security model clarifying that experimental
features behind compile-time flags are not covered by the vulnerability
reporting policy. These features are intended for development only and
are not enabled in official releases.

PR-URL: https://github.com/nodejs/node/pull/61109
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2025-12-20 10:21:03 +00:00
Michaël Zasso
9a6e55ab3d src: remove unused private field in SQLTagStore 
PR-URL: https://github.com/nodejs/node/pull/61027
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2025-12-20 06:22:38 +00:00
Aviv Keller
4e1f39b678 doc: add @avivkeller to collaborators 
Fixes: https://github.com/nodejs/node/issues/60937
PR-URL: https://github.com/nodejs/node/pull/61115
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2025-12-18 16:00:35 +00:00
Antoine du Hamel
25947d6504 tools: simplify notify-on-push 
Now that we have the repo setup to reject commits that do not contain
any metadata, we can remove the custom logic that was trying to catch
commits merged using the default commit message.

PR-URL: https://github.com/nodejs/node/pull/61050
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-12-18 15:12:23 +00:00
Tobias Nießen
e20175993a doc: warn about short GCM tags visibly 
As was pointed out by Félix Charette (@Sideni), the existing runtime
deprecation warning may not provide enough visibility of the underlying
issue. This commit adds a (not so pretty) warning to the documentation
of the relevant API function `setAuthTag()`. The warning will be removed
when `DEP0182` will be moved to End-of-Life status, presumably with the
next major release.

Refs: https://github.com/nodejs/node/issues/52327
Refs: https://github.com/nodejs/node/issues/17523
PR-URL: https://github.com/nodejs/node/pull/61082
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
 2025-12-18 11:34:25 +00:00
Chengzhong Wu
b1c01fc8b3 build: skip build-ci on actions with a separate test step 
When run `make run-ci` with CONFIG_FLAGS only set in prior
`make build-ci`, `make run-ci` will try to rebuild everything, instead
of re-use the built result from prior `make build-ci`.

PR-URL: https://github.com/nodejs/node/pull/61073
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-12-17 13:22:24 +00:00
Gürgün Dayıoğlu
240382451d doc: add gurgunday to collaborators 
PR-URL: https://github.com/nodejs/node/pull/61094
Fixes: https://github.com/nodejs/node/issues/60921
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-12-17 13:42:42 +01:00
Livia Medeiros
2e597ded4b doc: update MDN links 
PR-URL: https://github.com/nodejs/node/pull/61062
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2025-12-16 20:31:28 +00:00
Node.js GitHub Bot
dcb9573d0f tools: update nixpkgs-unstable to f997fa0f94fb1ce55bccb97f60d41412ae8 
PR-URL: https://github.com/nodejs/node/pull/61057
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2025-12-16 01:08:28 +00:00
Richard Lau
05f8772096 tools: fix update-nghttp2 signature verification 
Detached signatures must be passed to `gpgv` as a filename before
the datafile (which can be stdin but the detached signature file
cannot be stdin and cannot be piped in).

PR-URL: https://github.com/nodejs/node/pull/61035
Refs: https://github.com/nodejs/node/pull/60113
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-12-14 15:01:11 +00:00
Antoine du Hamel
6322071efe tools: improve log output of create-release-proposal 
PR-URL: https://github.com/nodejs/node/pull/61028
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2025-12-14 11:26:36 +00:00
Joyee Cheung
4f24aff94a module: preserve URL in the parent created by createRequire() 
Previously, createRequire() does not preserve the URL it gets
passed in the mock parent module created, which can be
observable if it's used together with module.registerHooks().
This patch adds preservation of the URL if createRequire()
is invoked with one.

PR-URL: https://github.com/nodejs/node/pull/60974
Fixes: https://github.com/nodejs/node/issues/60973
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
 2025-12-13 07:36:20 +00:00
Joyee Cheung
28b11396fe doc: mark sync module hooks as release candidate 
PR-URL: https://github.com/nodejs/node/pull/60960
Refs: https://github.com/nodejs/node/issues/56241
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
 2025-12-12 17:12:13 +00:00
Joyee Cheung
7f78002f03 doc: reorganize docs of module customization hooks 
This reorganizes the documentation of module customization hooks
to promote the synchronous variant as it has fewer caveats.
Previously the documentation was organized as follows:

To do something:
1. For asynchronous hooks, do this, which may have these caveats
2. For synchronous hooks, do this, which does not have the caveats

To do something else:
1. For asynchronous hooks, do this, which may have these caveats
2. For synchronous hooks, do this, which does not have the caveats

It's now organized as follows:

Synchronous hooks:
To do something, do this.
To do something else, do this.
(No mention that it doesn't have caveats, because users are not supposed
to burden themselves with caveats in the other API that they do not
use).

Asynchronous hooks:
They have these caveats, if they are too complex to deal with, consider
use the synchronous variant.

To do something, do this, which may have these caveats.
To do something, do this, which may have these caveats.

PR-URL: https://github.com/nodejs/node/pull/60960
Refs: https://github.com/nodejs/node/issues/56241
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
 2025-12-12 17:12:12 +00:00
Antoine du Hamel
81e05e124f lib: enforce use of URLParse 
There's no reason to use the user-mutable `URL.parse` in  core.

PR-URL: https://github.com/nodejs/node/pull/61016
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-12-12 12:34:21 +00:00