OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity
15,668 Commits 30 Branches 683 Tags
a0a6ff2ea5afc93c5d6b592ebecc17ff5b4ffa6a
Commit Graph

15668 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jeremiah Senkpiel
a0a6ff2ea5 doc: add some info on tty#setRawMode() 
Partially taken from https://linux.die.net/man/3/cfmakeraw

A very simple test script:

```
if (process.argv[2] === 'raw')
  process.stdin.setRawMode(true)

process.stdin.on('data', (chunk) => {
  console.log(chunk)
  console.log(chunk.toString())
})
```

Refs: https://github.com/nodejs/node/pull/10037
PR-URL: https://github.com/nodejs/node/pull/10147
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-08 13:39:45 -05:00
Luca Maraschi
df3978421b http: verify client method is a string 
Prior to this commit, it was possible to pass a truthy non-string
value as the HTTP method to the HTTP client, resulting in an
exception being thrown. This commit adds validation to the method.

PR-URL: https://github.com/nodejs/node/pull/10111
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2016-12-08 09:51:07 -05:00
Kyle Corsi
6967ed45ac test: refactor test-net-keepalive.js 
- Replace require() vars with const.
- Replace assert.equal() with assert.strictEqual().
- Add common.mustCall() to the setTimeout() callback.

PR-URL: https://github.com/nodejs/node/pull/9995
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-08 09:43:43 -05:00
anoff
2d0ce510e8 doc: update path.format description and examples 
* removed pseudo-code
* added info on which properties have priority
* modified examples to show ignored properties

PR-URL: https://github.com/nodejs/node/pull/10046
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
 2016-12-07 22:54:33 -08:00
eudaimos
1e4b9a1450 test: refactor test-crypto-hmac 
* replace assert.equals with assert.strictEquals
* use template strings where appropriate

PR-URL: https://github.com/nodejs/node/pull/9958
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2016-12-07 21:08:37 -08:00
Bruce Lai
68488e9c75 test: fix error in test-cluster-worker-death.js 
Replaced calls to assert.equal with assert.strictEqual in order
to fix the following error:
"Please use assert.strictEqual() instead of assert.strictEqual()"

PR-URL: https://github.com/nodejs/node/pull/9981
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-08 01:48:31 +01:00
anoff
deb9cc0cde test: use assert.strictEqual 
* use `assert.strictEqual`

PR-URL: https://github.com/nodejs/node/pull/9975
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-08 01:43:21 +01:00
Aileen
558fa1cf10 test: change assert.equal to assert.strictEqual 
PR-URL: https://github.com/nodejs/node/pull/9946
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-08 01:40:11 +01:00
vazina robertson
e6a0c39bf7 test: changed assert.equal to assert.strictEqual 
PR-URL: https://github.com/nodejs/node/pull/10015
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-08 01:36:00 +01:00
Jared Young
57f993d0f5 test: renamed assert.Equal to assert.strictEqual 2016-12-08 01:26:22 +01:00
Paul Graham
fd6999ef6c test: improves test-tls-client-verify 
Swaps var -> const/let
assert.equal becomes assert.strictEqual
common.mustCall on single-use functions

PR-URL: https://github.com/nodejs/node/pull/10051
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-08 01:20:11 +01:00
Diego Paez
83d9cd80bf test: refactor test-https-agent-session-reuse 
Use const and let instead of var and assert.strictEqual() instead of
assert.equal()

PR-URL: https://github.com/nodejs/node/pull/10105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-08 01:14:25 +01:00
Rob Adelmann
89603835b3 test: refactor test-beforeexit-event 
- replaced var with const/let.
- removed all console.log() statements.
- removed deaths and revivals vars.
- wrapped beforexit listener callbacks with
  common.mustCall().
- removed exit event listener.

PR-URL: https://github.com/nodejs/node/pull/10121
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
 2016-12-07 22:26:36 +01:00
Italo A. Casas
c6eae5afff doc: adding missing - in README 
PR-URL: https://github.com/nodejs/node/pull/10170
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2016-12-07 15:52:34 -05:00
Jenna Vuong
29b2e88e69 test: improve test-fs-read-stream.js 
var -> const
assert.equal() -> assert.strictEqual()

PR-URL: https://github.com/nodejs/node/pull/9629
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
 2016-12-07 12:19:37 -08:00
Italo A. Casas
586b787f1e doc: removing extra space in README 
PR-URL: https://github.com/nodejs/node/pull/10168
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2016-12-07 13:07:47 -05:00
Daniel Sims
b0c10a24a6 test: refactor test-domain-from-timer 
In this change, the setTimeout needed a second argument, so I set that
value to 1. In addition, I changed the assertion to be a strictEquals
instead of equals.

I changed the var declarations to const in this test.

PR-URL: https://github.com/nodejs/node/pull/9889
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2016-12-07 09:42:13 -08:00
Ethan Arrowood
ac78812f7f test: refactor test-domain-exit-dispose-again 
setTimeout at 49:5 requires two arguments.

On lines 72 and 73 changed assert.equal() to assert.strictEqual().

PR-URL: https://github.com/nodejs/node/pull/10003
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2016-12-07 09:32:30 -08:00
Timothy Gu
61d6293033 url: improve URLSearchParams spec compliance 
- Make URLSearchParams constructor spec-compliant
- Strip leading `?` in URL#search's setter
- Spec-compliant iterable interface
- More precise handling of update steps as mandated by the spec
- Add class strings to URLSearchParams objects and their prototype
- Make sure `this instanceof URLSearchParams` in methods

Also included are relevant tests from W3C's Web Platform Tests
(https://github.com/w3c/web-platform-tests/tree/master/url).

Fixes: https://github.com/nodejs/node/issues/9302
PR-URL: https://github.com/nodejs/node/pull/9484
Reviewed-By: James M Snell <jasnell@gmail.com>
 2016-12-07 12:19:23 -05:00
CodeVana
1b25214001 test: use const and strictEqual in test-os-homedir-no-envvar 
PR-URL: https://github.com/nodejs/node/pull/9899
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2016-12-07 08:59:46 -08:00
Ben Noordhuis
a2441476cc test: check result of uv_loop_init and uv_write 
Silence coverity warnings about the return value not being checked.

PR-URL: https://github.com/nodejs/node/pull/10126
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2016-12-07 17:51:53 +01:00
Daniel Bevenius
22e2c47f42 build: fix node_g target 
Currently when running make node_g the following error is displayed:
if [ ! -r node -o ! -L  ]; then ln -fs out/Debug/node node_g; fi
/bin/sh: line 0: [: argument expected

It looks like there was a typo for the NODE_EXE where node became
lowercase instead of uppercase.

Ref: https://github.com/nodejs/node/pull/9827
PR-URL: https://github.com/nodejs/node/pull/10153
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
 2016-12-07 16:58:58 +01:00
Michael-Bryant Choa
da077ee58a test: refactor test-dgram-bind-default-address 
- changes var to const/let
- changes assert.equal to assert.strictEqual

PR-URL: https://github.com/nodejs/node/pull/9947
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2016-12-07 10:42:00 -05:00
Rich Trott
cdeb85efc2 test: move long-running test to sequential 
test-buffer-creation-regression is flaky on some SmartOS hosts in CI,
timing out. Move to sequential so it does not compete with other tests
for resources. Reduce three test cases to just the one needed to
identify the regression.

PR-URL: https://github.com/nodejs/node/pull/10161
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
 2016-12-07 07:35:29 -08:00
Chris Bystrek
7d26c2799b test: assert.throws() should include a RegExp 
PR-URL: https://github.com/nodejs/node/pull/9976
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-07 07:33:43 -08:00
Sam Shull
4f486aa661 test: invalid package.json causes error when require()ing in directory 
Requiring a file from a directory that contains an invalid package.json
file should throw an error.

PR-URL: https://github.com/nodejs/node/pull/10044
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2016-12-07 10:00:11 -05:00
Richard Karmazin
00ea286800 test: refactor test-listen-fd-ebadf 
Replace var with const and assert.equal with assert.strictEqual.

PR-URL: https://github.com/nodejs/node/pull/10034
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
 2016-12-07 06:45:23 -06:00
Rodrigo Palma
ee8848ddb6 test: refactor test-event-emitter-method-names 
Improved test by using strictEqual instead of equal.

PR-URL: https://github.com/nodejs/node/pull/10027
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
 2016-12-07 06:41:07 -06:00
Yojan Shrestha
0c4c225b43 test: refactor tls-ticket-cluster 
- changes var to const/let
- changes assert.equal to assert.strictEqual
- changes `notEqual` to `notStrictEqual`

PR-URL: https://github.com/nodejs/node/pull/10023
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2016-12-07 09:19:53 +01:00
Chris Henney
25dfb8e570 test: refactor test-domain-exit-dispose 
change equal to strictEqual, fix setTimeout

PR-URL: https://github.com/nodejs/node/pull/9938
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
 2016-12-06 20:56:53 -08:00
amrios
e4b88d10b7 test: refactor test-stdin-from-file.js 
change var to const/let
wrap common.mustCall on childProcess.exec callback
remove unneeded fs.unlinkSync()
refactor assert.equal to assert.strictEqual

PR-URL: https://github.com/nodejs/node/pull/10012
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
 2016-12-06 20:30:34 -08:00
Eugene Ostroukhov
42da740ed8 inspector: split HTTP/WS server from the inspector 
Both our team experiments and some embedder request indicate a potential
in implementing alternative transport for inspector - e.g. IPC pipes or
custom embedder APIs. This change moves all HTTP specific code into a
separate class and is a first attempt at defining a boundary between the
inspector agent and transport. This API will be refined as new
transports are implemented.
Note that even without considering alternative transports, this change
enables better testing of the HTTP server (Valgrind made it possible to
identify and fix some existing memory leaks).

PR-URL: https://github.com/nodejs/node/pull/9630
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2016-12-06 14:47:49 -08:00
Jeremiah Senkpiel
8ab8363677 2016-12-06, Version 7.2.1 (Current) 
Notable changes:

* buffer:
  - Reverted the runtime deprecation of calling `Buffer()` without
`new`. (Anna Henningsen) https://github.com/nodejs/node/pull/9529
  - Fixed `buffer.transcode()` for single-byte character
encodings to `UCS2`. (Anna Henningsen)
https://github.com/nodejs/node/pull/9838
* promise: `--trace-warnings` now produces useful stacktraces for
Promise warnings. (Anna Henningsen)
https://github.com/nodejs/node/pull/9525
* repl: Fixed a bug preventing correct parsing of generator functions.
(Teddy Katz) https://github.com/nodejs/node/pull/9852
* V8: Fixed a significant `instanceof` performance regression.
(Franziska Hinkelmann) https://github.com/nodejs/node/pull/9730

PR-URL: https://github.com/nodejs/node/pull/10127
 2016-12-06 17:40:56 -05:00
Eugene Ostroukhov
2f3865d5f5 inspector: check if connected before waiting 
Fixes: https://github.com/nodejs/node/issues/10093
PR-URL: https://github.com/nodejs/node/pull/10094
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2016-12-06 14:28:20 -08:00
Jason Humphrey
a1bd070f87 test: use ES6 to update let & const 
Also updating assertStrict and moving the assert required.

PR-URL: https://github.com/nodejs/node/pull/9917
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
 2016-12-06 13:03:39 -08:00
joyeecheung
a3a3937d76 test: fix test for buffer regression #649 
pass a regexp to assert.throws()

PR-URL: https://github.com/nodejs/node/pull/9924
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2016-12-06 13:00:28 -08:00
Axel Monroy
1be73e828d url: add a got host pattern in url.js 
Add a hostPattern variable for readable purposes

PR-URL: https://github.com/nodejs/node/pull/9653
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
 2016-12-06 12:37:24 -08:00
Myles Borins
6ade6dedab 2016-12-06, Version 4.7.0 'Argon' (LTS) 
This LTS release comes with 108 commits. This includes 30 which are doc
related, 28 which are test related, 16 which are build / tool related,
and 4 commits which are updates to dependencies.

Notable Changes:

The SEMVER-MINOR changes include:

* build:
  - export openssl symbols on Windows making it possible to build
    addons linked against the bundled version of openssl (Alex Hultman)
    https://github.com/nodejs/node/pull/7576
* debugger:
  - make listen address configurable in the debugger server
    (Ben Noordhuis) https://github.com/nodejs/node/pull/3316
* dgram:
  - generalized send queue to handle close fixing a potential throw
    when dgram socket is closed in the listening event handler.
    (Matteo Collina) https://github.com/nodejs/node/pull/7066
* http:
  - Introduce the 451 status code "Unavailable For Legal Reasons"
    (Max Barinov) https://github.com/nodejs/node/pull/4377
* tls:
  - introduce `secureContext` for `tls.connect` which is useful for
    caching client certificates, key, and CA certificates.
    (Fedor Indutny) https://github.com/nodejs/node/pull/4246

Notable SEMVER-PATCH changes include:

* build:
  - introduce the configure --shared option for embedders (sxa555)
    https://github.com/nodejs/node/pull/6994
* gtest:
  - the test reporter now outputs tap comments as yamlish
    (Johan Bergström) https://github.com/nodejs/node/pull/9262
* src:
  - node no longer aborts when c-ares initialization fails
    (Ben Noordhuis) https://github.com/nodejs/node/pull/8710
* tls:
  - fix memory leak when writing data to TLSWrap instance during
    handshake (Fedor Indutny)
    https://github.com/nodejs/node/pull/9586

PR-URL: https://github.com/nodejs/node/pull/9736
 2016-12-06 14:58:36 -05:00
Myles Borins
c4391f4664 2016-12-06, Version 6.9.2 'Boron' (LTS) Release 
This LTS release comes with 144 commits. This includes 47 that are docs
related, 46 that are test related, 15 which are build / tools related,
and 9 commits which are updates to dependencies

Notable Changes:

* buffer:
  - coerce slice parameters consistently
    (Sakthipriyan Vairamani (thefourtheye))
    https://github.com/nodejs/node/pull/9101
* deps:
    - *npm*:
      - upgrade npm to 3.10.9 (Kat Marchán)
       https://github.com/nodejs/node/pull/9286
    - *V8*:
      - Various fixes to destructuring edge cases
        - cherry-pick 3c39bac from V8 upstream (Cristian Cavalli)
          https://github.com/nodejs/node/pull/9138
        - cherry pick 7166503 from upstream v8 (Cristian Cavalli)
          https://github.com/nodejs/node/pull/9173
* gtest:
  - the test reporter now outputs tap comments as yamlish
    (Johan Bergström) https://github.com/nodejs/node/pull/9262
* inspector:
  - inspector now prompts user to use 127.0.0.1 rather than localhost
    (Eugene Ostroukhov) https://github.com/nodejs/node/pull/9451
* tls:
  - fix memory leak when writing data to TLSWrap instance during
    handshake (Fedor Indutny)
    https://github.com/nodejs/node/pull/9586

PR-URL: https://github.com/nodejs/node/pull/9735
 2016-12-06 14:32:30 -05:00
Vse Mozhet Byt
898c25aa64 doc: fix a wrong note in the buffer.md 
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-06 19:20:46 +01:00
Vse Mozhet Byt
dede04c686 doc: remove an extraneous word in the buffer.md 
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-06 19:20:43 +01:00
Vse Mozhet Byt
0d0028935b doc: fix examples in buffer.md to avoid confusion 
On some systems, some first bytes of allocated buffer can be zeroed
by default, so the example doesn't work well - the buffer looks zeroed
even before the fill.

Fixes: https://github.com/nodejs/node/issues/9786
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-06 19:20:12 +01:00
Vse Mozhet Byt
ae2b19687b doc: remove a wrong remark in the buffer.md 
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-06 19:20:09 +01:00
Vse Mozhet Byt
39ed512d8a doc: add a variable declaration in the buffer.md 
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-06 19:20:02 +01:00
Vse Mozhet Byt
b20cb6f469 doc: repeat a remark as needed in the buffer.md 
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-06 19:19:59 +01:00
Vse Mozhet Byt
96e5017449 doc: fix copy-paste artifacts in the buffer.md 
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-06 19:19:56 +01:00
Vse Mozhet Byt
6050bbe60a doc: fix wrong function arguments in the buffer.md 
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-06 19:19:54 +01:00
Vse Mozhet Byt
8fbcf78d85 doc: fix a syntax error in the buffer.md 
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-06 19:19:51 +01:00
Vse Mozhet Byt
69a34e4a07 doc: var => const/let in the buffer.md 
PR-URL: https://github.com/nodejs/node/pull/9795
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2016-12-06 19:18:50 +01:00
BethGriggs
8951d3e0e5 doc: remove repeated info onboarding.md 
COLLABORATOR_GUIDE.md and onboarding.md cover some of the same
information. The aim of this commit is to remove duplicated
information.

PR-URL: https://github.com/nodejs/node/pull/9635
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
 2016-12-06 09:41:45 -08:00