OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
32,526 Commits 30 Branches 683 Tags
997f2fcbbc9d807dde4e2e62e76feab0a175cbc0
Commit Graph

32526 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Antoine du Hamel
997f2fcbbc events: refactor to use more primordials 
PR-URL: https://github.com/nodejs/node/pull/36304
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-12-25 18:10:56 +00:00
ExE Boss
88fb8e45ee doc: document "http: lazy create IncomingMessage.headers" 
Refs: https://github.com/nodejs/node/pull/35281
Refs: https://github.com/nodejs/node/issues/36550

Co-authored-by: raisinten <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/36601
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2020-12-25 06:40:53 -08:00
Maksym Baranovskyi
f441c8bb17 doc: fix bugs in _construct() example 
PR-URL: https://github.com/nodejs/node/pull/36509
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2020-12-25 05:57:18 -08:00
Rich Trott
e068eec783 tools: correct usage message for genv8constants.py 
PR-URL: https://github.com/nodejs/node/pull/36606
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-12-25 04:28:35 -08:00
Rich Trott
18fc50f983 tools: call close() explicitly in genv8constants.py 
PR-URL: https://github.com/nodejs/node/pull/36606
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-12-25 04:28:32 -08:00
Rich Trott
36c17e2f51 tools: use is None consistently in Python 
We use `is None` instead of `== None` everywhere (which mostly just
means test.py) except in one place in genv8constants.py. Switch to `is
None` in genv8constants.py. This is slightly more efficient, although I
can't imagine that makes a measurable difference here.

PR-URL: https://github.com/nodejs/node/pull/36606
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-12-25 04:28:27 -08:00
Benjamin Gruenbaum
73a21e4c06 child_process: support AbortSignal in fork 
PR-URL: https://github.com/nodejs/node/pull/36603
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-12-24 20:33:15 +00:00
Benjamin Coe
33d99b6f23 deps: V8: cherry-pick dfcdf7837e23 
Original commit message:

    [coverage] fix greedy nullish coalescing

    The SourceRangeScope helper was consuming too many characters, instead
    explicitly create SourceRange, based on scanner position.

    Bug: v8:11231
    Change-Id: I852d211227abacf867e8f1ab3e3ab06dbdba2a9b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2576006
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71765}

Refs: dfcdf7837e

PR-URL: https://github.com/nodejs/node/pull/36573
Fixes: https://github.com/nodejs/node/issues/36619
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2020-12-24 18:06:58 +00:00
Daniel Bevenius
3b0ecfc866 test: redirect stderr EnvironmentWithNoESMLoader 
This commit adds a suggestion to redirect stderr for
EnvironmentTest.EnvironmentWithNoESMLoader.

The motivation for this is that currently this tests prints the
following error (which is expected):

vm:module(0):1
globalThis.importResult = import("")
^

Error: Not supported
 at vm:module(0):1:1
 at SourceTextModule.evaluate (node:internal/vm/module:229:23)
 at node:embedder_main_12:1:328
 at processTicksAndRejections (node:internal/process/task_queues:93:5)

It might not be obvious which test caused this error just by looking at
the output above and it would be nice if it was not displayed.

PR-URL: https://github.com/nodejs/node/pull/36548
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2020-12-24 07:18:05 -08:00
ZiJian Liu
2d40e3fc4c lib: fix diagnostics_channel hasSubscribers error 
Fixes: https://github.com/nodejs/node/issues/36598

PR-URL: https://github.com/nodejs/node/pull/36599
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-12-24 07:11:01 -08:00
Rich Trott
2c8751cb85 doc: remove replication of GitHub template 
The pull-request template was replicated in the pull-requests.md which
is a maintenance annoyance when changing the template. Replace the
replication with a link to the raw template.

PR-URL: https://github.com/nodejs/node/pull/36590
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
 2020-12-23 05:33:46 -08:00
Rich Trott
576a1b547b doc: remove "Related Issues" from pull request template 
We don't require an issue for a pull request, so this section usually
ends up displaying confusing default content.

PR-URL: https://github.com/nodejs/node/pull/36590
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
 2020-12-23 05:33:40 -08:00
Michael Dawson
e22b751cce doc: expand openssl instructions 
Refs: https://github.com/nodejs/node/pull/36541

Expand the instructions to cover what is needed when
updates are required across all active release lines

PR-URL: https://github.com/nodejs/node/pull/36554
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2020-12-22 16:57:15 -05:00
Antoine du Hamel
6091a65986 v8: refactor to use more primordials 
PR-URL: https://github.com/nodejs/node/pull/36527
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
 2020-12-22 19:39:31 +00:00
Michaël Zasso
80d2fbeb0c 2020-12-22, Version 15.5.0 (Current) 
Notable changes:

    child_process:
      * (SEMVER-MINOR) add signal support to spawn (Benjamin Gruenbaum) https://github.com/nodejs/node/pull/36432
    doc:
      * add PoojaDurgad to collaborators (Pooja D P) https://github.com/nodejs/node/pull/36511
    lib:
      * (SEMVER-MINOR) support BigInt in querystring.stringify (raisinten) https://github.com/nodejs/node/pull/36499
    src:
      * (SEMVER-MINOR) add way to get IsolateData and allocator from Environment (Anna Henningsen) https://github.com/nodejs/node/pull/36441
      * (SEMVER-MINOR) allow preventing SetPrepareStackTraceCallback (Shelley Vohr) https://github.com/nodejs/node/pull/36447
    stream:
      * (SEMVER-MINOR) support abortsignal in constructor (Benjamin Gruenbaum) https://github.com/nodejs/node/pull/36431

PR-URL: https://github.com/nodejs/node/pull/36597
 2020-12-22 19:56:09 +01:00
Benjamin Gruenbaum
f0a0e3c6b3 child_process: clean event listener correctly 
I was working on AbortSignal for spawn and noticed there is a leak in
the current code for AbortSignal support in child_process since it
removes the wrong listener. I used the new signal as argument feature
to make removing the listener easier and added a test.

PR-URL: https://github.com/nodejs/node/pull/36424
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-12-22 17:53:00 +02:00
raisinten
1623aff55c lib: refactor to use more primordials in internal/histogram.js 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/36455
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-12-22 07:32:19 -08:00
Rich Trott
083abe20b9 tools: revise line in configure.py for clarity 
* Replace unused identifier with Python convention `_`.
* Remove unneeded parentheses.
* Remove line-wrapping.

I confirmed that this doesn't change the output by running `./configure
--shared-zlib` and confirming that it created the same `common.gypi`
with and without these changes. The code changed here doesn't run unless
there is a `--shared-*` flag.

PR-URL: https://github.com/nodejs/node/pull/36551
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
 2020-12-22 07:11:02 -08:00
Michaël Zasso
2723d2db7e doc: fix AbortSignal example for stream.Readable 
PR-URL: https://github.com/nodejs/node/pull/36596
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2020-12-22 14:50:11 +01:00
ExE Boss
d90fa196c5 v8: fix native serdes constructors 
Fixes: https://github.com/nodejs/node/issues/13326
Refs: https://github.com/nodejs/node/pull/13541
PR-URL: https://github.com/nodejs/node/pull/36549
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2020-12-22 14:13:56 +01:00
Momtchil Momtchev
656ce920a3 errors: eliminate all overhead for hidden calls 
Eliminate all overhead for function calls that are to be
hidden from the stack traces at the expense of
reduced performance for the error case

Fixes: https://github.com/nodejs/node/issues/35386

PR-URL: https://github.com/nodejs/node/pull/35644
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2020-12-22 11:09:55 +01:00
Moshe vilner
67b9ba9afe test: increase abort logic coverage 
PR-URL: https://github.com/nodejs/node/pull/36586
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-12-22 09:36:23 +00:00
Daniel Bevenius
fc8fcb084d src: remove unnecessary ToLocalChecked node_errors 
PR-URL: https://github.com/nodejs/node/pull/36547
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-12-22 09:28:23 +01:00
Richard Lau
21f2e8859d tools: fix make-v8.sh 
V8's `tools/dev/v8gen.py` does not like being passed an empty string
(`""`).

PR-URL: https://github.com/nodejs/node/pull/36594
Refs: https://github.com/nodejs/node/pull/36099
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2020-12-22 01:09:42 +00:00
ZiJian Liu
4d22dd329b test: increase coverage for stream 
1. test addAbortSignal with invalid signal
Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L17

2. test addAbortSignal with invalid stream
Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L28

3. test addAbortSignalNoValidate with invalid signal
Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L34

4. test addAbortSignalNoValidate with aborted signal
Refs:  https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L40

5. test Readable.from with invalid args
Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/from.js.html#L31

PR-URL: https://github.com/nodejs/node/pull/36538
Refs: https://coverage.nodejs.org/coverage-a1509261770cb645/lib/internal/streams/add-abort-signal.js.html#L40
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2020-12-21 13:23:40 -05:00
Michaël Zasso
aadb0bdc73 build: do not run GitHub actions for draft PRs 
PR-URL: https://github.com/nodejs/node/pull/35910
Fixes: https://github.com/nodejs/node/issues/35899
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
 2020-12-21 15:34:39 +01:00
Michaël Zasso
ce658bd2c8 doc: update and run license-builder for Babel 
PR-URL: https://github.com/nodejs/node/pull/36504
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-12-21 15:07:13 +01:00
FrankQiu
bea2252554 doc: add remark about Collaborators discussion page 
PR-URL: https://github.com/nodejs/node/pull/36420
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-12-21 06:04:45 -08:00
raisinten
1eb228eafd lib: support BigInt in querystring.stringify 
Fixes: https://github.com/nodejs/node/issues/36080

PR-URL: https://github.com/nodejs/node/pull/36499
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2020-12-21 15:03:58 +01:00
ZiJian Liu
54e763ddc9 fs: refactor to use optional chaining 
PR-URL: https://github.com/nodejs/node/pull/36524
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-12-21 14:55:30 +01:00
Antoine du Hamel
6c25870073 tools: fix release script sign function 
PR-URL: https://github.com/nodejs/node/pull/36556
Refs: https://github.com/nodejs/node/pull/36540
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2020-12-21 14:47:22 +01:00
Rich Trott
b5fdb9e65a doc: simplify worker_threads.md text 
PR-URL: https://github.com/nodejs/node/pull/36545
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2020-12-21 05:45:06 -08:00
Ruy Adorno
ffc11c6015 deps: upgrade npm to 7.3.0 
PR-URL: https://github.com/nodejs/node/pull/36572
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-12-21 14:29:20 +01:00
zhangyongsheng
eefb424c60 tools: update ESLint to 7.16.0 
PR-URL: https://github.com/nodejs/node/pull/36579
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-12-21 14:24:53 +01:00
zhangyongsheng
775ce40c99 tools: fix update-eslint.sh 
PR-URL: https://github.com/nodejs/node/pull/36579
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-12-21 14:24:51 +01:00
Rich Trott
fee3b89a2b benchmark: reduce code duplication 
Merge duplicate case code in child-process-params.js.

PR-URL: https://github.com/nodejs/node/pull/36568
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-12-21 13:43:30 +01:00
Anna Henningsen
2070d5b524 src: use correct microtask queue for checkpoints 
I missed in c6c8337402 that we should not just use that queue for
enqueuing microtasks, but also for running them.

Refs: https://github.com/nodejs/node/pull/36482

PR-URL: https://github.com/nodejs/node/pull/36581
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
 2020-12-21 13:28:51 +01:00
Anna Henningsen
82dd23f5ec repl: disable blocking completions by default 
It’s not okay for the REPL to be blocked for multiple seconds after
entering `require('` because the completion is performing blocking
fs operations on potentially huge directories. Turning the REPL
completion function asynchronous would be the right thing to do here,
but unfortunately the way the code is structured doesn’t play well
with that (in particular, it breaks the preview feature).
Therefore, disable these blocking calls by default.

Refs: https://github.com/nodejs/node/pull/33282#issuecomment-733646794

PR-URL: https://github.com/nodejs/node/pull/36564
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2020-12-21 12:52:02 +01:00
Robert Nagy
ab895bd587 stream: fix pipe deadlock when starting with needDrain 
Fixes: https://github.com/nodejs/node/issues/36544

PR-URL: https://github.com/nodejs/node/pull/36563
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-12-20 10:27:35 +01:00
Michaël Zasso
daa132260d build: run some workflows only on nodejs/node 
This updates the close-stalled, comment-stalled and license-builder
workflows to skip them on repositories that are not nodejs/node.

PR-URL: https://github.com/nodejs/node/pull/36507
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-12-18 12:38:18 -08:00
ZiJian Liu
565663e046 test: increase coverage for worker 
test new Worker() with invalid NODE_OPTIONS
Refs: https://coverage.nodejs.org/coverage-743ee9d2c05efefe/lib/internal/worker.js.html#L179

PR-URL: https://github.com/nodejs/node/pull/36491
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2020-12-18 15:32:52 -05:00
Momtchil Momtchev
36581f1d4e doc: add two tips for speeding the dev builds 
Add two important tips for novice Node.js contributors

PR-URL: https://github.com/nodejs/node/pull/36452
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-12-18 11:46:06 -08:00
Beth Griggs
b49145f795 2020-12-17, Version 14.15.3 'Fermium' (LTS) 
Notable Changes:

Node.js v14.15.2 included a commit that has caused reported breakages
when cloning request objects. This release reverts the commit that
introduced the behaviour change.

See https://github.com/nodejs/node/issues/36550 for more details.

PR-URL: https://github.com/nodejs/node/pull/36555
 2020-12-17 23:22:59 +00:00
Tobias Nießen
6255973a05 doc: add note about timingSafeEqual for TypedArray 
PR-URL: https://github.com/nodejs/node/pull/36323
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2020-12-18 00:14:21 +01:00
Antoine du Hamel
f28715d95d tools: fix release script 
PR-URL: https://github.com/nodejs/node/pull/36540
Refs: https://github.com/nodejs/node/pull/36123
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2020-12-17 16:03:48 +00:00
Rich Trott
32d58d7271 tools: remove unused variable in configure.py 
PR-URL: https://github.com/nodejs/node/pull/36525
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2020-12-17 05:20:06 -08:00
Rich Trott
bc50577b36 doc: move Derek Lewis to emeritus 
Derek informed me that he intends to take a break from
collaborator-ship.

PR-URL: https://github.com/nodejs/node/pull/36514
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
 2020-12-17 05:05:40 -08:00
Daniele Belardi
8154e47e2b http: add test for incomingmessage destroy 
Test uncaught exceptions when destroying IncomingMessage.

PR-URL: https://github.com/nodejs/node/pull/33035
Refs: https://github.com/nodejs/node/issues/30625
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-12-17 10:31:10 +00:00
Daniele Belardi
a6bf74eac0 http: use standard args order in IncomingMEssage onError 
PR-URL: https://github.com/nodejs/node/pull/33035
Refs: https://github.com/nodejs/node/issues/30625
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-12-17 10:31:10 +00:00
Daniele Belardi
f20a88fb86 http: remove trailing space 
PR-URL: https://github.com/nodejs/node/pull/33035
Refs: https://github.com/nodejs/node/issues/30625
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-12-17 10:31:09 +00:00