OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
34,341 Commits 30 Branches 683 Tags
937bbc5571073d1fbeffd2d9e18949b3b4dcf09b
Commit Graph

34341 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Voltrex
937bbc5571 lib: use helper for readability 
Used an extra `checkReusedHandle()` helper function to
increase readability.

PR-URL: https://github.com/nodejs/node/pull/39649
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-08-12 14:52:01 -07:00
Antoine du Hamel
1c7a19b22b doc: fix fs.rmdir recursive option deprecation history 
PR-URL: https://github.com/nodejs/node/pull/39728
Refs: https://github.com/nodejs/node/pull/35579
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-12 14:50:18 -07:00
Anna Henningsen
1bd1a7ede5 src: fix crash in AfterGetAddrInfo 
Remove invalid usage of `Check()`. This addresses:

    FATAL ERROR: v8::FromJust Maybe value is Nothing.
     1: 0x101311bf5 node::Abort() (.cold.1) [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node]
     2: 0x1000ade29 node::Abort() [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node]
     3: 0x1000adf8f node::OnFatalError(char const*, char const*) [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node]
     4: 0x1001f42d0 v8::V8::FromJustIsNothing() [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node]
     5: 0x1000268e2 node::cares_wrap::(anonymous namespace)::AfterGetAddrInfo(uv_getaddrinfo_s*, int, addrinfo*)::$_2::operator()(bool, bool) const [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node]
     6: 0x10002657c node::cares_wrap::(anonymous namespace)::AfterGetAddrInfo(uv_getaddrinfo_s*, int, addrinfo*) [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node]
     7: 0x1009fb388 uv__work_done [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node]
     8: 0x100a00453 uv__async_io [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node]
     9: 0x100a140cc uv__io_poll [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node]
    10: 0x100a009c1 uv_run [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node]
    11: 0x10014aca0 node::worker::Worker::Run() [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node]
    12: 0x10014e56f node::worker::Worker::StartThread(v8::FunctionCallbackInfo<v8::Value> const&)::$_3::__invoke(void*) [/Users/xxx/.nvm/versions/node/v14.17.4/bin/node]
    13: 0x7fff703d42eb _pthread_body [/usr/lib/system/libsystem_pthread.dylib]
    14: 0x7fff703d7249 _pthread_start [/usr/lib/system/libsystem_pthread.dylib]
    15: 0x7fff703d340d thread_start [/usr/lib/system/libsystem_pthread.dylib]

PR-URL: https://github.com/nodejs/node/pull/39735
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-12 14:48:57 -07:00
Richard Lau
3b1e6f202e build: run coverage for inspector protocol changes 
The inspector protocol currently lives in `tools`.

PR-URL: https://github.com/nodejs/node/pull/39725
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-12 14:45:50 -07:00
Richard Lau
8c954103ab tools: fix more build warnings in inspector_protocol 
PR-URL: https://github.com/nodejs/node/pull/39725
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-12 14:45:48 -07:00
Darshan Sen
a48b9c330a tools: cherry-pick ffb34b6d5d 
Original commit message:

    tools: fix compiler warning in inspector_protocol

    error: comparison of integer expressions of different signedness:
    ‘int’ and ‘uint64_t’ {aka ‘long unsigned int’} [-Werror=sign-compare]
     2562 |           if (!success || std::numeric_limits<int32_t>::max() <
          |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
     2563 |                               token_start_internal_value_) {
          |                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~

    PR-URL: https://github.com/nodejs/node/pull/37573
    Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
    Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/39725
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-12 14:45:46 -07:00
ashish maurya
13029cff31 doc: fixed variable names in queueMicrotask example 
fixed variable name in queueMicrotask where url variable was used
instead of key

PR-URL: https://github.com/nodejs/node/pull/39634
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-08-12 14:42:22 -07:00
Voltrex
2108f76b32 lib: use validators 
Used more validators for the sake of consistency.

PR-URL: https://github.com/nodejs/node/pull/39663
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-08-12 14:41:20 -07:00
Darshan Sen
284f164962 src: return Maybe<bool> from InitializeContextRuntime() 
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: https://github.com/nodejs/node/pull/39695
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-12 13:53:37 -07:00
Voltrex
c3b4d3f043 lib: use validator 
Used the `validateArray()` validator for array validation
for consistency. (Refs: #39536)

PR-URL: https://github.com/nodejs/node/pull/39547
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-08-12 13:51:56 -07:00
Voltrex
fce2786754 lib: use validateObject 
Used the validateObject() validator to keep consistency instead of a
custom validator which was only used to validate objects.
Refs: #39595

PR-URL: https://github.com/nodejs/node/pull/39605
Refs: https://github.com/nodejs/node/pull/39595
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-12 13:51:08 -07:00
James M Snell
31d1d0c4c1 url,buffer: implement URL.createObjectURL 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/39693
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
 2021-08-12 07:23:15 -07:00
James M Snell
793c08b8d1 test: enable blob.prototype.stream tests 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/39693
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
 2021-08-12 07:23:12 -07:00
James M Snell
0bb2605f85 buffer: add Blob.prototype.stream method and other cleanups 
Adds the `stream()` method to get a `ReadableStream` for the `Blob`.
Also makes some other improvements to get the implementation closer
to the API standard definition.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/39693
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
 2021-08-12 07:23:10 -07:00
bcoe
87d6fd7e69 fs: add recursive cp method 
Introduces recursive cp method, based on fs-extra implementation.

PR-URL: https://github.com/nodejs/node/pull/39372
Fixes: https://github.com/nodejs/node/issues/35880
Refs: https://github.com/nodejs/tooling/issues/98
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ian Sutherland <ian@iansutherland.ca>
 2021-08-11 19:53:32 -07:00
Stephen Belanger
4ece669c62 deps: V8: cherry-pick 81814ed44574 
Original commit message:

    [promise] Avoid stack overflow with context promise hooks in C++

    This was handled in JS but not in C++.

    Bug: chromium:236703, v8:11025
    Change-Id: Ic9adc4ceb4d2af2614427fec459c3e950654572f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3074460
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Reviewed-by: Victor Gomes <victorgomes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76125}

Refs: 81814ed445

PR-URL: https://github.com/nodejs/node/pull/39719
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2021-08-11 17:44:13 +00:00
Michaël Zasso
45420013ee test: update WPT abort tests 
PR-URL: https://github.com/nodejs/node/pull/39697
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-11 17:02:09 +00:00
Michaël Zasso
24673ace8a test: update WPT common and resources 
PR-URL: https://github.com/nodejs/node/pull/39697
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-11 17:02:09 +00:00
Beth Griggs
ea47d83640 2021-08-11, Version 16.6.2 (Current) 
This is a security release.

Notable Changes:

- CVE-2021-3672/CVE-2021-22931:
    Improper handling of untypical characters in domain names (High)
- CVE-2021-22930:
    Use after free on close http2 on stream canceling (High)
- CVE-2021-22939:
    Incomplete validation of rejectUnauthorized parameter (Low)

PR-URL: https://github.com/nodejs-private/node-private/pull/280
 2021-08-11 16:22:15 +01:00
Beth Griggs
02b145083e 2021-08-11, Version 14.17.5 'Fermium' (LTS) 
This is a security release.

Notable Changes:

- CVE-2021-3672/CVE-2021-22931:
    Improper handling of untypical characters in domain names (High)
- CVE-2021-22930:
    Use after free on close http2 on stream canceling (High)
- CVE-2021-22939:
    Incomplete validation of rejectUnauthorized parameter (Low)

PR-URL: https://github.com/nodejs-private/node-private/pull/279
 2021-08-11 16:22:15 +01:00
Beth Griggs
e973b55c86 2021-08-11, Version 12.22.5 'Erbium' (LTS) 
This is a security release.

Notable Changes:

- CVE-2021-3672/CVE-2021-22931:
    Improper handling of untypical characters in domain names (High)
- CVE-2021-22930:
    Use after free on close http2 on stream canceling (High)
- CVE-2021-22939:
    Incomplete validation of rejectUnauthorized parameter (Low)

PR-URL: https://github.com/nodejs-private/node-private/pull/278
 2021-08-11 16:22:15 +01:00
Matteo Collina
635463cb92 tls: validate "rejectUnauthorized: undefined" 
Incomplete validation of rejectUnauthorized parameter (Low)

If the Node.js https API was used incorrectly and "undefined" was passed
in for the "rejectUnauthorized" parameter, no error was returned and
connections to servers with an expired certificate would have been
accepted.

CVE-ID: CVE-2021-22939
Refs: https://nvd.nist.gov/vuln/detail/CVE-2021-22939
Refs: https://hackerone.com/reports/1278254
PR-URL: https://github.com/nodejs-private/node-private/pull/276
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Akshay K <iit.akshay@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2021-08-11 16:22:15 +01:00
Matteo Collina
33f9b7f80b bootstrap: call _undestroy() inside _destroy for stdout and stderr 
This change makes `process.stdout` and `process.stderr` to be
automatically undestroyed when ended/destrouyed, therefore making
it always possible to write/console.log to stdout.

Fixes: https://github.com/nodejs/node/issues/39447

PR-URL: https://github.com/nodejs/node/pull/39685
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2021-08-11 15:27:50 +02:00
Beth Griggs
3914354cd7 deps: update c-ares to 1.17.2 
Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_17_2

PR-URL: https://github.com/nodejs/node/pull/39724
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-08-10 23:07:29 +01:00
Rich Trott
f8ed7555cd meta: consolidate AUTHORS entries for ooHmartY 
PR-URL: https://github.com/nodejs/node/pull/39705
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-10 16:56:09 +00:00
Rich Trott
a6d1284dcd meta: consolidate AUTHORS entries for homosaur 
PR-URL: https://github.com/nodejs/node/pull/39705
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-10 16:56:08 +00:00
Rich Trott
4b565eb680 meta: consolidate AUTHORS entries for Ayase-252 
PR-URL: https://github.com/nodejs/node/pull/39705
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-10 16:56:07 +00:00
Rich Trott
a9ace0e0d6 meta: consolidate AUTHORS entries for robin-drexler 
PR-URL: https://github.com/nodejs/node/pull/39705
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-10 16:56:06 +00:00
Rich Trott
9ed0675091 meta: consolidate AUTHORS entries for samshull 
PR-URL: https://github.com/nodejs/node/pull/39705
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-10 16:56:05 +00:00
Rich Trott
2ff59160b6 meta: update AUTHORS 
PR-URL: https://github.com/nodejs/node/pull/39705
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-10 16:56:04 +00:00
Rich Trott
54559b8c0e meta: consolidate email addresses for MarshallOfSound 
PR-URL: https://github.com/nodejs/node/pull/39651
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-10 16:55:53 +00:00
Rich Trott
d5bb019b1b meta: consolidate email addresses for tadjik1 
PR-URL: https://github.com/nodejs/node/pull/39651
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-10 16:55:52 +00:00
Rich Trott
ea88a0e8cc meta: consolidate email addresses for szmarczak 
PR-URL: https://github.com/nodejs/node/pull/39651
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-10 16:55:51 +00:00
Rich Trott
a1fac5b9a5 tools: update inspector_protocol to e8ba1a7 
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log

PR-URL: https://github.com/nodejs/node/pull/39694
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-09 18:56:05 +00:00
Rich Trott
74c4f82282 tools: update inspector_protocol to 39ca567 
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log

PR-URL: https://github.com/nodejs/node/pull/39694
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-09 18:56:04 +00:00
Rich Trott
0187474535 tools: update inspector_protocol to 97d3146 
To apply the diff cleanly, ffb34b6 had to be reverted.

Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log

PR-URL: https://github.com/nodejs/node/pull/39694
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-09 18:56:03 +00:00
Rich Trott
585d4efd7c Revert "tools: fix compiler warning in inspector_protocol" 
This reverts commit ffb34b6d5d.

PR-URL: https://github.com/nodejs/node/pull/39694
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-09 18:56:02 +00:00
Rich Trott
9bc2a5976c tools: update inspector_protocol to a53e96d31a2755eb16ca37 
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log

PR-URL: https://github.com/nodejs/node/pull/39694
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-09 18:56:01 +00:00
Rich Trott
c3df329889 tools: update inspector_protocol to fe0467fd105a 
Refs: https://chromium.googlesource.com/deps/inspector_protocol/+log

PR-URL: https://github.com/nodejs/node/pull/39694
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-09 18:56:00 +00:00
Richard Lau
602fe4e83a test: fix test-debugger-heap-profiler for workers 
Fix `sequential/test-debugger-heap-profiler` so that it can be run
in a worker thread. `process.chdir()` is not allowed in worker threads
but passing a current working directory into a spawned child process
is allowed.

PR-URL: https://github.com/nodejs/node/pull/39687
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-09 10:11:56 +00:00
Tobias Nießen
6145113fe5 doc: change "Version 4 UUID" to "version 4 UUID" 
Refs: https://www.rfc-editor.org/rfc/rfc4122.txt

PR-URL: https://github.com/nodejs/node/pull/39682
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-08-08 18:49:49 +00:00
Michaël Zasso
df25424b91 build: fix V8 build with pointer compression 
Refs: https://github.com/nodejs/TSC/issues/790#issuecomment-893457655

PR-URL: https://github.com/nodejs/node/pull/39664
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
 2021-08-07 20:27:17 +02:00
bcoe
5a01efdcb2 test: increase memory for coverage action 
PR-URL: https://github.com/nodejs/node/pull/39690
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-07 15:51:30 +00:00
Rich Trott
822f9ff4e6 doc: update debugger.md description and examples 
The console captures in debugger.md are out of date, showing the
wrapper:

  function (exports, require, module, __filename, __dirname) {

That wrapper is no longer shown in debug sessions.

This also shortens and simplifies the description of the debugger in the
lede.

PR-URL: https://github.com/nodejs/node/pull/39661
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-07 02:57:31 +00:00
James M Snell
c52410710e stream: utility consumers for web and node.js streams 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/39594
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-08-06 15:42:58 -07:00
XadillaX
e4b1fb5e64 lib: expose DOMException as global 
Refs: https://github.com/nodejs/node/issues/39098

PR-URL: https://github.com/nodejs/node/pull/39176
Fixes: https://github.com/nodejs/node/issues/39098
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-06 12:45:14 -07:00
Darshan Sen
0a7f850123 src: return Maybe from a couple of functions 
Functions affected:
* InitializeContext()
* InitializeContextForSnapshot()
* InitializePrimordials()

Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: https://github.com/nodejs/node/pull/39603
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-06 12:43:49 -07:00
Rich Trott
26632c96a6 doc: fix color contrast issue in light mode 
There is a color contrast issue with links in light mode on the API
highlight background. This only appears in modules.md. This change fixes
it without introducing other contrast issues in either light or dark
mode. Previously, the color contrast for some text on modules.html was
failing WCAG AA in light mode.

PR-URL: https://github.com/nodejs/node/pull/39660
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
 2021-08-06 17:30:15 +00:00
Akshay K
b00d1ae5ba http2: add tests for cancel event while client is paused reading 
PR-URL: https://github.com/nodejs/node/pull/39622
Refs: https://github.com/nodejs/node/pull/39423
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
 2021-08-06 14:40:02 +01:00
Akshay K
60fd5d4be1 http2: update handling of rst_stream with error code NGHTTP2_CANCEL 
The PR updates the handling of rst_stream frames and adds all streams
to the pending list on receiving rst frames with the error code
NGHTTP2_CANCEL.

The changes will remove dependency on the stream state that may allow
bypassing the checks in certain cases. I think a better solution is to
delay streams in all cases if rst_stream is received for the cancel
events.

The rst_stream frames can be received for protocol/connection error as
well it should be handled immediately. Adding streams to the pending
list in such cases may cause errors.

PR-URL: https://github.com/nodejs/node/pull/39622
Refs: https://github.com/nodejs/node/pull/39423
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
 2021-08-06 14:39:55 +01:00