OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
33,503 Commits 30 Branches 683 Tags
8e80fc7ff84bb477eb05ddcd59ac492d9fbf5c8d
Commit Graph

8949 Commits

Author SHA1 Message Date
Antoine du Hamel
09c9e5dea4 lib: avoid mutating Error.stackTraceLimit when it is not writable 
PR-URL: https://github.com/nodejs/node/pull/38215
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2021-04-15 00:17:16 +02:00
Simon Knott
f1a21e5c91 typings: add JSDoc types to lib/path 
PR-URL: https://github.com/nodejs/node/pull/38186
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-04-14 17:07:26 +02:00
Michaël Zasso
cb2bdc632a typings: add types for internalBinding('fs') 
PR-URL: https://github.com/nodejs/node/pull/38198
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-04-14 12:24:23 +02:00
Antoine du Hamel
7b2bad4005 module: clarify CJS global-like variables not defined error message 
Fixes: https://github.com/nodejs/node/issues/33741

PR-URL: https://github.com/nodejs/node/pull/37852
Reviewed-By: Guy Bedford <guybedford@gmail.com>
 2021-04-13 19:06:48 +02:00
Anna Henningsen
e7391967c2 repl: fix error message printing 
The REPL implementation would strip away the first and last character
of a formatted error message if it ended with `]` (but with the
obviously missing check for a starting `]`), leading to things like
`Uncaught rror: foo[a` being printed for input like `Error: foo[a]`.

Refs: https://github.com/nodejs/node/pull/22436

PR-URL: https://github.com/nodejs/node/pull/38209
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-04-13 09:48:06 -07:00
Antoine du Hamel
23d2c54bab lib: add globalThis to primordials 
PR-URL: https://github.com/nodejs/node/pull/38211
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-13 18:33:57 +02:00
eladkeyshawn
802171057f util: add getSystemErrorMap() impl 
PR-URL: https://github.com/nodejs/node/pull/38101
Fixes: https://github.com/nodejs/node/issues/37951
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-13 08:44:26 -07:00
ExE Boss
78343bbdc5 lib: add WeakRef and FinalizationRegistry to primordials 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/37263
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-04-13 12:36:56 +02:00
Qingyu Deng
993ed19f9c crypto: reduce range of size to int max 
Refs: https://github.com/nodejs/node/issues/38090

PR-URL: https://github.com/nodejs/node/pull/38096
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-04-12 14:49:13 -07:00
Bradley Farias
8dd06850ae esm: use correct URL for error decoration 
PR-URL: https://github.com/nodejs/node/pull/37854
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
 2021-04-12 16:47:57 -05:00
Michaël Zasso
6bbe28552c fs: use byteLength to handle ArrayBuffer views 
Unlike TypedArray, DataView doesn't have a length property.

PR-URL: https://github.com/nodejs/node/pull/38187
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-04-12 14:39:13 -07:00
Nitzan Uziely
3da003cc1c tls: fix session and keylog add listener segfault 
Fix an issue where adding a session or keylog listener on a tlsSocket
after it was destroyed caused a segfault.

fixes: https://github.com/nodejs/node/issues/38133
fixes: https://github.com/nodejs/node/issues/38135

PR-URL: https://github.com/nodejs/node/pull/38180
Fixes: https://github.com/nodejs/node/issues/38133
Fixes: https://github.com/nodejs/node/issues/38135
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-04-12 14:30:29 -07:00
Filip Skokan
896dc39951 crypto: fix webcrypto derive(Bits|Key) resolve values and docs 
fixes #38115

PR-URL: https://github.com/nodejs/node/pull/38148
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-12 23:27:51 +02:00
James M Snell
eb20447407 tls: extract out SecureContext configuration 
In preparation for re-introducing quic, refactor out a reusable
piece of the SecureContext configuration that will also be used
by the quic impl.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/38116
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-04-12 08:39:16 -07:00
cjihrig
8e76397fab fs: validate encoding to binding.writeString() 
The binding layer performs some validation of the encoding and
data passed to WriteString(). This commit adds similar validation
to the JS layer for better error handling.

PR-URL: https://github.com/nodejs/node/pull/38183
Fixes: https://github.com/nodejs/node/issues/38168
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
 2021-04-11 23:57:29 -04:00
Fedor Indutny
6a1986d50a deps: update llhttp to 5.1.0 
PR-URL: https://github.com/nodejs/node/pull/38146
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Daniele Belardi <dwon.dnl@gmail.com>
 2021-04-10 14:31:34 -07:00
James M Snell
40ace47396 http: fixup perf regression 
Only call into hrtime if there's an observer

Also, fix up some previously missed changes from the original refactor

Signed-off-by: James M Snell <jasnell@gmail.com>
Refs: https://github.com/nodejs/node/issues/37937
Refs: https://github.com/nodejs/node/pull/37136

PR-URL: https://github.com/nodejs/node/pull/38110
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2021-04-09 16:58:58 -07:00
James M Snell
d2f116c6bb crypto: fixup randomFill size and offset handling 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/38138
Fixes: https://github.com/nodejs/node/issues/38137
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-04-09 15:35:39 -07:00
Bradley Farias
656fb4657a lib: add tsconfig for code completions 
PR-URL: https://github.com/nodejs/node/pull/38042
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-04-08 08:35:09 -05:00
Arkerone
b16e79e05b tls: fix typo 
`byteLenth` -> `byteLength`.

PR-URL: https://github.com/nodejs/node/pull/38129
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-04-08 10:35:38 +02:00
Luigi Pinca
7869761c2e net: fix typo 
`construtor` -> `constructor`.

Fixes: https://github.com/nodejs/node/issues/38125

PR-URL: https://github.com/nodejs/node/pull/38127
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-04-08 10:33:09 +02:00
Filip Skokan
e8cb6446ef crypto: reconcile oneshot sign/verify sync and async implementations 
PR-URL: https://github.com/nodejs/node/pull/37816
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-04-08 10:08:26 +02:00
legendecas
d86132488d lib: properly process JavaScript exceptions on async_hooks fatal error 
JavaScript exceptions could be arbitrary values.

PR-URL: https://github.com/nodejs/node/pull/38106
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-08 08:58:09 +02:00
Rich Trott
038608d401 tools: relax max-len lint rule for template strings 
Splitting template strings across multiple lines can make them harder to
read.

PR-URL: https://github.com/nodejs/node/pull/38097
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-07 04:16:35 -07:00
Nitzan Uziely
6986fa07eb worker: fix exit code for error thrown in handler 
Change worker exit code when the unhandled exception
handler throws from 0 to 7

fixes: https://github.com/nodejs/node/issues/37996

PR-URL: https://github.com/nodejs/node/pull/38012
Fixes: https://github.com/nodejs/node/issues/37996
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-06 15:01:46 -07:00
Rich Trott
1e4a2bcbee crypto: remove check for condition that is always true 
The value of `key` will always be `!= null` because earlier in the
function, `ERR_CRYPTO_SIGN_KEY_REQUIRED` is thrown if `key` is falsy.
Remove condition that subsequently checks that `key != null`.

PR-URL: https://github.com/nodejs/node/pull/38072
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-06 14:58:46 -07:00
Darshan Sen
24fd791184 fs: move constants to internal/fs/utils.js 
Refs: https://github.com/nodejs/node/pull/38004#discussion_r604951958

PR-URL: https://github.com/nodejs/node/pull/38061
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Nitzan Uziely <linkgoron@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-06 12:24:15 -07:00
Michaël Zasso
8dd5dd8a4b process: do not lazily load AsyncResource 
It doesn't seem necessary.

PR-URL: https://github.com/nodejs/node/pull/38041
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-06 07:46:45 -07:00
Brian White
e38d62a8c9 path: fix POSIX path.resolve() perf regression 
PR-URL: https://github.com/nodejs/node/pull/38064
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2021-04-06 00:00:20 -07:00
Akhil Marsonya
a9332e84bf lib: refactor to use primordials in lib/internal/cli_table 
PR-URL: https://github.com/nodejs/node/pull/38046
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-04-05 18:20:38 -07:00
HiroyukiYagihashi
49580910db fs: add support for async iterators to fsPromises.writeFile 
Fixes: https://github.com/nodejs/node/issues/37391

PR-URL: https://github.com/nodejs/node/pull/37490
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-04 12:24:53 +02:00
Filip Skokan
c81d0fa9bc crypto: use correct webcrypto RSASSA-PKCS1-v1_5 algorithm name 
PR-URL: https://github.com/nodejs/node/pull/38029
Refs: https://www.w3.org/TR/WebCryptoAPI/#rsassa-pkcs1
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-04-04 00:08:37 +02:00
Antoine du Hamel
46062a0d2c module: improve error message for invalid data URL 
Fixes: https://github.com/nodejs/node/issues/37647

PR-URL: https://github.com/nodejs/node/pull/37701
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
 2021-04-03 20:06:05 +02:00
Tobias Nießen
5dae7d6758 crypto: add buffering to randomInt 
PR-URL: https://github.com/nodejs/node/pull/35110
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-04-03 15:37:53 +02:00
Darshan Sen
e9ed113052 fs: fix chown abort 
This syncs the type assertion introduced in the referenced PR in the C++
side. Since chown, lchown, and fchown can accept -1 as a value for uid
and gid, we should also accept signed integers from the JS side.

Fixes: https://github.com/nodejs/node/issues/37995
Refs: https://github.com/nodejs/node/pull/31694

PR-URL: https://github.com/nodejs/node/pull/38004
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-04-02 21:43:23 -07:00
Rich Trott
b0d5e036d8 path: fix posix.relative() on Windows 
Fixes: https://github.com/nodejs/node/issues/13683

PR-URL: https://github.com/nodejs/node/pull/37747
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-04-02 19:30:43 -07:00
James M Snell
e79471deb7 net: allow net.BlockList to use net.SocketAddress objects 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/37917
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-04-02 06:16:42 -07:00
James M Snell
0b90d35294 net: add SocketAddress class 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/37917
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-04-02 06:16:40 -07:00
James M Snell
fb9257f659 net: make net.BlockList cloneable 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/37917
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-04-02 06:16:38 -07:00
James M Snell
f0bf373176 perf_hooks: make performance a global 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/37970
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
 2021-04-01 13:14:10 -07:00
Akhil Marsonya
e0eb515afc lib: change wording in lib/domain.js comment 
Change the wording to make the language more Inclusive.

PR-URL: https://github.com/nodejs/node/pull/37933
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2021-04-01 13:12:48 -07:00
Akhil Marsonya
08f051fc92 lib: change wording in lib/internal/child_process comment 
Change the wording to make the language more Inclusive.

PR-URL: https://github.com/nodejs/node/pull/37903
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-01 12:52:06 -07:00
Nitzan Uziely
dbab2893ef readline: fix pre-aborted signal question handling 
fix pre-aborted question handling

PR-URL: https://github.com/nodejs/node/pull/37929
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-01 12:45:26 -07:00
Nitzan Uziely
54c525ef0e readline: add AbortSignal support to interface 
Add abort signal support to Interface

PR-URL: https://github.com/nodejs/node/pull/37932
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-01 12:43:54 -07:00
Nitzan Uziely
f87c4d126d net,tls: add abort signal support to connect 
Add documentation for net.connect AbortSignal,
and add the support to tls.connect as well

PR-URL: https://github.com/nodejs/node/pull/37735
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-04-01 12:40:49 -07:00
Anna Henningsen
9d07c0a20b http2: add specific error code for custom frames 
As suggested in
https://github.com/nodejs/node/issues/37849#issuecomment-805049586
improve the error presented when encountering a large number of
invalid frames by giving this situation a specific error code (which we
should have had from the beginning).

PR-URL: https://github.com/nodejs/node/pull/37936
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
 2021-04-01 12:34:55 -07:00
James M Snell
25e30005b8 lib: runtime deprecate access to process.binding('http_parser') 
The internal HTTP Parser constructor and methods list are available
via `require('_http_parser')`, there's no need for the ecosystem to
access via `process.binding()`

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/37813
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
 2021-04-01 11:37:29 -07:00
James M Snell
8bb4e048af lib: runtime deprecate access to process.binding('url') 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/37799
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2021-04-01 11:36:35 -07:00
Akhil Marsonya
3ef95627cc path: refactor to use more primordials 
PR-URL: https://github.com/nodejs/node/pull/37893
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-04-01 17:11:21 +08:00
Matteo Collina
2fa7d33e74 Revert "net: add support for finished after .destroy()" 
This reverts commit 2da36112d1.

PR-URL: https://github.com/nodejs/node/pull/37964
Refs: https://github.com/nodejs/node/issues/37937
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-03-31 19:06:53 +02:00