Michaël Zasso
8e80fc7ff8
deps: patch V8 to 9.0.257.17
...
Refs: https://github.com/v8/v8/compare/9.0.257.16...9.0.257.17
PR-URL: https://github.com/nodejs/node/pull/38237
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-14 16:51:35 -07:00
Rich Trott
b4363f726c
doc: revise TLS minVersion/maxVersion text
...
Minor changes mostly to improve compliance with our style guide.
PR-URL: https://github.com/nodejs/node/pull/38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-04-14 16:29:27 -07:00
Rich Trott
18c9913ce1
test: add tests for missing https agent options
...
Add test that minVersion and maxVersion options are accepted. This
should complete coverage for lib/https.js.
Refs: ec0dcd720e/lib/https.js
PR-URL: https://github.com/nodejs/node/pull/38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-04-14 16:29:21 -07:00
Rich Trott
4ad8e83a3d
test: fix test-https-agent-additional-options.js
...
`value` was always being assigned to an `undefined` property of an
Array. Thus, the assertions that depended on `value` being defined were
never being checked. Assign `value` the correct...er...value.
PR-URL: https://github.com/nodejs/node/pull/38202
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-04-14 16:28:40 -07:00
Antoine du Hamel
09c9e5dea4
lib: avoid mutating Error.stackTraceLimit when it is not writable
...
PR-URL: https://github.com/nodejs/node/pull/38215
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2021-04-15 00:17:16 +02:00
Ash Cripps
98c2067f13
doc: update BUILDING.md for Apple Silicon
...
PR-URL: https://github.com/nodejs/node/pull/38227
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
2021-04-14 16:42:36 +01:00
Michaël Zasso
5b358d57e1
deps: patch V8 to 9.0.257.16
...
Refs: https://github.com/v8/v8/compare/9.0.257.13...9.0.257.16
PR-URL: https://github.com/nodejs/node/pull/38218
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
2021-04-14 17:09:27 +02:00
Simon Knott
f1a21e5c91
typings: add JSDoc types to lib/path
...
PR-URL: https://github.com/nodejs/node/pull/38186
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2021-04-14 17:07:26 +02:00
Michaël Zasso
05df701e70
test: remove common.disableCrashOnUnhandledRejection
...
Use the --unhandled-rejections=none CLI flag instead.
PR-URL: https://github.com/nodejs/node/pull/38210
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-14 16:42:10 +02:00
Michaël Zasso
3377eb9641
typings: add types for internalBinding('util')
...
PR-URL: https://github.com/nodejs/node/pull/38200
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
2021-04-14 12:32:26 +02:00
Michaël Zasso
cb2bdc632a
typings: add types for internalBinding('fs')
...
PR-URL: https://github.com/nodejs/node/pull/38198
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-04-14 12:24:23 +02:00
Michaël Zasso
ee669a0d29
deps: update ICU to 69.1
...
Refs: https://github.com/unicode-org/icu/releases/tag/release-69-1
PR-URL: https://github.com/nodejs/node/pull/38178
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-14 09:07:29 +00:00
luyahan
1d21a8d140
build: add riscv64 configure
...
v8 had been add riscv64 backend, so i open this
pr to add riscv64 configure.
Refs: https://github.com/nodejs/node/issues/37856
PR-URL: https://github.com/nodejs/node/pull/37980
Fixes: https://github.com/nodejs/node/issues/37856
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
2021-04-14 07:06:29 +00:00
Bradley Farias
8d9d8236b7
bootstrap: mksnapshot should show JS error
...
PR-URL: https://github.com/nodejs/node/pull/38174
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-13 14:59:32 -05:00
Antoine du Hamel
7b2bad4005
module: clarify CJS global-like variables not defined error message
...
Fixes: https://github.com/nodejs/node/issues/33741
PR-URL: https://github.com/nodejs/node/pull/37852
Reviewed-By: Guy Bedford <guybedford@gmail.com >
2021-04-13 19:06:48 +02:00
Anna Henningsen
e7391967c2
repl: fix error message printing
...
The REPL implementation would strip away the first and last character
of a formatted error message if it ended with `]` (but with the
obviously missing check for a starting `]`), leading to things like
`Uncaught rror: foo[a` being printed for input like `Error: foo[a]`.
Refs: https://github.com/nodejs/node/pull/22436
PR-URL: https://github.com/nodejs/node/pull/38209
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-04-13 09:48:06 -07:00
Antoine du Hamel
23d2c54bab
lib: add globalThis to primordials
...
PR-URL: https://github.com/nodejs/node/pull/38211
Reviewed-By: Bradley Farias <bradley.meck@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-13 18:33:57 +02:00
eladkeyshawn
802171057f
util: add getSystemErrorMap() impl
...
PR-URL: https://github.com/nodejs/node/pull/38101
Fixes: https://github.com/nodejs/node/issues/37951
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-13 08:44:26 -07:00
Rich Trott
4def7c4418
doc: standardize on pseudorandom
...
Our docs use both _pseudo-random_ and _pseudorandom_. Standardize on
_pseudorandom_.
PR-URL: https://github.com/nodejs/node/pull/38196
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-04-13 19:10:28 +05:30
Ferdi
f1027ecf29
doc: standardize command flag notes
...
remove italic styling from command flag notes
PR-URL: https://github.com/nodejs/node/pull/38199
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-04-13 18:59:33 +05:30
Tobias Nießen
8f4850d5c7
test: fix typo in comment in binding.c
...
PR-URL: https://github.com/nodejs/node/pull/38220
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Beth Griggs <bgriggs@redhat.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-04-13 18:57:17 +05:30
ExE Boss
78343bbdc5
lib: add WeakRef and FinalizationRegistry to primordials
...
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/37263
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-04-13 12:36:56 +02:00
Ikko Ashimine
9498e97015
test: fix typo in gtest-all.cc
...
separater -> separator
PR-URL: https://github.com/nodejs/node/pull/38224
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2021-04-13 09:43:39 +02:00
cjihrig
13c931a9dc
process: add range validation to debugPort
...
This commit adds validation to the process.debugPort setter.
Fixes: https://github.com/nodejs/node/issues/38037
PR-URL: https://github.com/nodejs/node/pull/38205
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-04-12 15:05:08 -07:00
Qingyu Deng
756d2e48d8
doc: update buffer.constants.MAX_LENGTH
...
Fixes: https://github.com/nodejs/node/issues/38093
PR-URL: https://github.com/nodejs/node/pull/38109
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-12 14:52:03 -07:00
Qingyu Deng
993ed19f9c
crypto: reduce range of size to int max
...
Refs: https://github.com/nodejs/node/issues/38090
PR-URL: https://github.com/nodejs/node/pull/38096
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2021-04-12 14:49:13 -07:00
Bradley Farias
8dd06850ae
esm: use correct URL for error decoration
...
PR-URL: https://github.com/nodejs/node/pull/37854
Reviewed-By: Guy Bedford <guybedford@gmail.com >
Reviewed-By: Jan Krems <jan.krems@gmail.com >
2021-04-12 16:47:57 -05:00
Nitzan Uziely
c8bbd83ab2
test: add undefined fatalException exit code test
...
Add a test that checks the exit code when _fatalException
is undefined
PR-URL: https://github.com/nodejs/node/pull/38119
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2021-04-12 14:44:15 -07:00
Michaël Zasso
6bbe28552c
fs: use byteLength to handle ArrayBuffer views
...
Unlike TypedArray, DataView doesn't have a length property.
PR-URL: https://github.com/nodejs/node/pull/38187
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2021-04-12 14:39:13 -07:00
Nitzan Uziely
474fbb5f6e
doc: clarify child_process close event
...
clarify the 'close' event description in the child_process docs.
fixes: https://github.com/nodejs/node/issues/37998
PR-URL: https://github.com/nodejs/node/pull/38181
Fixes: https://github.com/nodejs/node/issues/37998
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-12 14:37:43 -07:00
Ferdi
eee2c331ef
doc: add command flag to import.meta.resolve
...
import.meta.resolve is only available under
--experimental-import-meta-resolve cli flag.
Source:
e46c680bf2/lib/internal/modules/esm/translators.js (L132)
PR-URL: https://github.com/nodejs/node/pull/38171
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-12 14:36:22 -07:00
Antoine du Hamel
2468e4ed3e
deps: V8: backport d59db06bf542
...
Original commit message:
[weakrefs] Remove --no-harmony-weak-refs flag
Bug: v8:8179
Change-Id: I7f699073807d1874d0c10a4f1641de6bfb0efe6f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2741582
Commit-Queue: Shu-yu Guo <syg@chromium.org >
Reviewed-by: Shu-yu Guo <syg@chromium.org >
Reviewed-by: Adam Klein <adamk@chromium.org >
Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org >
Cr-Commit-Position: refs/heads/master@{#73871}
Refs: d59db06bf5
PR-URL: https://github.com/nodejs/node/pull/38162
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-12 14:32:52 -07:00
Nitzan Uziely
3da003cc1c
tls: fix session and keylog add listener segfault
...
Fix an issue where adding a session or keylog listener on a tlsSocket
after it was destroyed caused a segfault.
fixes: https://github.com/nodejs/node/issues/38133
fixes: https://github.com/nodejs/node/issues/38135
PR-URL: https://github.com/nodejs/node/pull/38180
Fixes: https://github.com/nodejs/node/issues/38133
Fixes: https://github.com/nodejs/node/issues/38135
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2021-04-12 14:30:29 -07:00
Brian White
0180fc5b9b
benchmark: improve compare.R output
...
PR-URL: https://github.com/nodejs/node/pull/38118
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-04-12 14:28:46 -07:00
Filip Skokan
896dc39951
crypto: fix webcrypto derive(Bits|Key) resolve values and docs
...
fixes #38115
PR-URL: https://github.com/nodejs/node/pull/38148
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-12 23:27:51 +02:00
Tobias Nießen
f46d29360c
doc: advise against using randomFill on floats
...
Refs: https://github.com/nodejs/node/issues/38137
PR-URL: https://github.com/nodejs/node/pull/38150
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2021-04-12 14:22:48 -07:00
James M Snell
6c9b19a7af
src: refactor SecureContext Initialization
...
Extracts out SecureContext::GetConstructorFunction, adds
SecureContext::HasInstance and SecureContext::Create in
preparation for re-adding QUIC
Signed-off-by: James M Snell <jasnell@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/38116
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2021-04-12 08:39:18 -07:00
James M Snell
eb20447407
tls: extract out SecureContext configuration
...
In preparation for re-introducing quic, refactor out a reusable
piece of the SecureContext configuration that will also be used
by the quic impl.
Signed-off-by: James M Snell <jasnell@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/38116
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2021-04-12 08:39:16 -07:00
Michaël Zasso
5823fc79ba
doc: update links in ICU guide
...
PR-URL: https://github.com/nodejs/node/pull/38177
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2021-04-12 13:21:27 +02:00
cjihrig
8e76397fab
fs: validate encoding to binding.writeString()
...
The binding layer performs some validation of the encoding and
data passed to WriteString(). This commit adds similar validation
to the JS layer for better error handling.
PR-URL: https://github.com/nodejs/node/pull/38183
Fixes: https://github.com/nodejs/node/issues/38168
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com >
2021-04-11 23:57:29 -04:00
cjihrig
28bca33f28
tools: update ESLint to 7.24.0
...
Update ESLint to 7.24.0
PR-URL: https://github.com/nodejs/node/pull/38179
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-04-11 23:55:09 -04:00
Xu Meng
db9cf52dcf
test: check the different error code on IBM i
...
Fixes: https://github.com/nodejs/node/issues/36925
PR-URL: https://github.com/nodejs/node/pull/38159
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2021-04-11 21:28:22 -05:00
Antoine du Hamel
548cbf0625
perf_hooks: fix loop delay resolution validation
...
Fixes: https://github.com/nodejs/node/issues/38160
PR-URL: https://github.com/nodejs/node/pull/38166
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2021-04-11 23:15:47 +02:00
Serkan Özel
993a1da47c
doc: mention cryptographic prng in description of randomUUID
...
PR-URL: https://github.com/nodejs/node/pull/38074
Refs: https://github.com/nodejs/node/pull/36729
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-04-11 13:39:56 -07:00
Rich Trott
95ca351fd8
test: skip fs.watch() test on IBMi
...
We've added pummel tests to CI, so we need to add a skip for IBMi for
the fs.watch() test there as we have for all the fs.watch() tests
elsewhere.
PR-URL: https://github.com/nodejs/node/pull/38192
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2021-04-11 06:42:38 -07:00
ycjcl868
f5eea1744d
build: don't run test workflow on doc dir on macOS
...
Leaving it in the Linux workflow because addons tests are affected by
changes to addons.md example code. So we need to keep that running
somewhere for docs changes, but one platform seems sufficient.
PR-URL: https://github.com/nodejs/node/pull/37999
Reviewed-By: Rich Trott <rtrott@gmail.com >
2021-04-10 16:51:10 -07:00
Rich Trott
2853b76e20
build: add pummel tests to ci runs
...
PR-URL: https://github.com/nodejs/node/pull/34289
Reviewed-By: Richard Lau <rlau@redhat.com >
2021-04-10 15:18:10 -07:00
Rich Trott
24426cd8c4
build: prepare Windows coverage GitHub Action for pummel tests
...
The pummel tests result in the Windows coverage runs in CI to exhaust
memory, so we need to bump up the heap size.
PR-URL: https://github.com/nodejs/node/pull/34289
Reviewed-By: Richard Lau <rlau@redhat.com >
2021-04-10 15:18:04 -07:00
Rich Trott
8cee28465c
test: fix test-dh-regr for OpenSSL 3
...
PR-URL: https://github.com/nodejs/node/pull/34289
Reviewed-By: Richard Lau <rlau@redhat.com >
2021-04-10 15:17:56 -07:00
Rich Trott
213ae4f4c6
test: skip test-vm-memleak in ASAN
...
ASAN increases memory usage, which in turn messes up the memory leak
test. Skip the test on ASAN.
PR-URL: https://github.com/nodejs/node/pull/34289
Reviewed-By: Richard Lau <rlau@redhat.com >
2021-04-10 15:17:51 -07:00