Commit Graph

45210 Commits

Author SHA1 Message Date
Christian Clauss
8bc7dfd16f build: test on Python 3.14 release candidate 3
Python v3.14 -- October 7th
* https://www.python.org/download/pre-releases
* https://www.python.org/downloads/release/python-3140rc3

PR-URL: https://github.com/nodejs/node/pull/59983
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
2025-10-13 14:56:33 +00:00
SeokHun
4bfa387f6d lib: fix constructor in _errnoException stack tree
Fixes the constructor name in the stack tree for _errnoException.

PR-URL: https://github.com/nodejs/node/pull/60156
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2025-10-13 14:25:09 +00:00
Tobias Nießen
5cf3c3e24c http2: rename variable to additionalPseudoHeaders
PR-URL: https://github.com/nodejs/node/pull/60208
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
2025-10-13 08:31:02 +00:00
Antoine du Hamel
822a8c3244 perf_hooks: fix stack overflow error
PR-URL: https://github.com/nodejs/node/pull/60084
Fixes: https://github.com/nodejs/node/issues/54768
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2025-10-13 10:05:45 +02:00
Luigi Pinca
985e2fb383 Revert "test: ensure message event fires in worker message port test"
This reverts commit 9790315e15.

Refs: https://github.com/nodejs/node/pull/59952
PR-URL: https://github.com/nodejs/node/pull/60126
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-10-13 06:48:18 +00:00
Steven
1cd16e5355 doc: improve code snippet alternative of url.parse() using WHATWG URL
PR-URL: https://github.com/nodejs/node/pull/60209
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-10-13 01:50:34 +00:00
Antoine du Hamel
da9cd745c8 test: ensure assertions are reachable in test/client-proxy
PR-URL: https://github.com/nodejs/node/pull/60175
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2025-10-12 20:43:10 +00:00
Richard Lau
2216a3b1d5 deps: V8: cherry-pick 1e190bbb0396
Original commit message:

    [segmented-table] Disable segments pool if pages can be too large

    The segments pool can only be used if we have 16Kb allocation
    granularity. On OSs where the page size can be configured larger we have
    to disable it, since it is currently not runtime configurabe.

    Fixed: 425634685
    Change-Id: If77e46b034fc2e324d7eabf19eff54958ea6f7cb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6973467
    Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    Auto-Submit: Olivier Flückiger <olivf@chromium.org>
    Commit-Queue: Olivier Flückiger <olivf@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#102700}

Refs: 1e190bbb03
PR-URL: https://github.com/nodejs/node/pull/60206
Fixes: https://github.com/nodejs/build/issues/4172
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2025-10-12 18:39:19 +00:00
Anna Henningsen
3ac88a7a66 src: use string_view in WriteReport()
Since 075936b413, `TriggerNodeReport()` takes `std::string_view`
arguments directly.

PR-URL: https://github.com/nodejs/node/pull/60201
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2025-10-12 15:42:54 +00:00
Chengzhong Wu
1986ee4b65 vm: hint module identifier in instantiate errors
PR-URL: https://github.com/nodejs/node/pull/60199
Fixes: https://github.com/nodejs/node/issues/60157
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2025-10-12 14:28:56 +00:00
Aviv Keller
d54e6aec9e doc: createSQLTagStore -> createTagStore
PR-URL: https://github.com/nodejs/node/pull/60182
Refs: https://discord.com/channels/425824580918181889/425824580918181891/1425966053242048584
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-10-11 22:16:14 +00:00
npm CLI robot
1b22f6049a deps: upgrade npm to 11.6.2
PR-URL: https://github.com/nodejs/node/pull/60168
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-10-11 21:22:44 +00:00
Rafael Gonzaga
aef3fc37eb doc: use markdown when branch-diff major release
PR-URL: https://github.com/nodejs/node/pull/60179
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-10-11 18:33:52 +00:00
theanarkh
f9fcc746f3 v8: add cpu profile
PR-URL: https://github.com/nodejs/node/pull/59807
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-10-11 17:20:57 +00:00
James M Snell
a1244f04de src: make additional cleanups in node locks impl
* Track memory held by the Lock instance
* Clean up some Utf8/TwoByteString handling

PR-URL: https://github.com/nodejs/node/pull/60061
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-10-11 15:11:31 +00:00
James M Snell
fdb6e66227 src: update locks to use DictionaryTemplate
...and other minor cleanups

PR-URL: https://github.com/nodejs/node/pull/60061
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-10-11 15:11:31 +00:00
Richard Lau
a1b73fe430 deps: V8: cherry-pick 2abc61361dd4
Original commit message:

    Fix scratch registers passed to mtvsrdd

    `ra` cannot be r0 as it will be interpreted as Operand(0)

    Change-Id: Idce58191f9d3578dc91dc4aa3872a0bf2939d8b3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6936113
    Commit-Queue: Milad Farazmand <mfarazma@ibm.com>
    Reviewed-by: Junliang Yan <junyan1@ibm.com>
    Cr-Commit-Position: refs/heads/main@{#102388}

Refs: 2abc61361d
PR-URL: https://github.com/nodejs/node/pull/60177
Refs: https://github.com/nodejs/undici/pull/4530
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2025-10-11 14:16:36 +00:00
Bart Louwers
a2f088d516 doc: update teams in collaborator-guide.md and add links
PR-URL: https://github.com/nodejs/node/pull/60065
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-10-11 13:55:58 +00:00
Michaël Zasso
367bcce6a6 src: fix usage of deprecated V8 API
Some checks failed
V8 patch update / v8-update (push) Has been cancelled
OpenSSL update / openssl-update (push) Has been cancelled
Timezone update / timezone_update (push) Has been cancelled
License update / update_license (push) Has been cancelled
Find inactive collaborators / find (push) Has been cancelled
Scorecard supply-chain security / Scorecard analysis (push) Has been cancelled
Find inactive TSC voting members / find (push) Has been cancelled
Namely `GetContinuationPreservedEmbedderData` and
`SetContinuationPreservedEmbedderData` for their "V2" variants.

Refs: da41db36ec
PR-URL: https://github.com/nodejs/node/pull/60174
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
2025-10-11 07:57:15 +00:00
Michaël Zasso
2e675c4fa3 benchmark: use non-deprecated WriteUtf8V2 method
PR-URL: https://github.com/nodejs/node/pull/60173
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-10-11 07:57:05 +00:00
방진혁
bab752d4db typings: add buffer internalBinding typing
PR-URL: https://github.com/nodejs/node/pull/60163
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-10-10 22:37:01 +00:00
René
75a6fff6be doc: disambiguate top-level worker_threads module exports
PR-URL: https://github.com/nodejs/node/pull/59890
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-10-10 12:17:12 +00:00
SRAVANI GUNDEPALLI
e105e821e9 test: skip quic tests that IBM i does not support
PR-URL: https://github.com/nodejs/node/pull/60160
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2025-10-10 06:15:13 +00:00
SeokHun
4daeec11b9 lib: fix typo in QuicSessionStats
Corrects the misspelling of "privateSynbol" to "privateSymbol".

PR-URL: https://github.com/nodejs/node/pull/60155
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-10-10 04:16:56 +00:00
Antoine du Hamel
bfc81ca228 test: ensure assertions are reachable in test/async-hooks
PR-URL: https://github.com/nodejs/node/pull/60150
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2025-10-09 21:57:24 +00:00
SRAVANI GUNDEPALLI
712cee951c test: skip tests that cause timeouts on IBM i
PR-URL: https://github.com/nodejs/node/pull/60148
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2025-10-09 18:24:59 +00:00
Asaf Federman
ad2c1bf62e test,doc: skip --max-old-space-size-percentage on 32-bit platforms
PR-URL: https://github.com/nodejs/node/pull/60144
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2025-10-09 16:23:51 +00:00
Joyee Cheung
db0121bedd module: fix directory option in the enableCompileCache() API
The option name should be `directory` to be consistent with the
returned result. It should also allow environment variable
overrides.

This also adds documentation for the new options and improves it.

PR-URL: https://github.com/nodejs/node/pull/59931
Reviewed-By: Aditi Singh <aditisingh1400@gmail.com>
2025-10-09 07:55:31 +00:00
Luigi Pinca
f8a43f6f34 test: deflake test-fs-promises-watch-iterator
Add a delay before writing the files to ensure that the watcher receives
the notifications.

Fixes: https://github.com/nodejs/node/issues/60051
Refs: https://github.com/nodejs/node/issues/52601
PR-URL: https://github.com/nodejs/node/pull/60060
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2025-10-09 05:33:33 +00:00
Moshe Atlow
6dbf7086bb test_runner: fix suite timeout
PR-URL: https://github.com/nodejs/node/pull/59853
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2025-10-09 04:40:05 +00:00
René
535efea962 http2: do not crash on mismatched ping buffer length
PR-URL: https://github.com/nodejs/node/pull/60135
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-10-08 23:23:34 +00:00
Node.js GitHub Bot
642a7c0d46 2025-10-08, Version 24.10.0 (Current)
Notable changes:

console:
  * (SEMVER-MINOR) allow per-stream `inspectOptions` option (Anna Henningsen) https://github.com/nodejs/node/pull/60082
lib:
  * (SEMVER-MINOR) remove util.getCallSite (Rafael Gonzaga) https://github.com/nodejs/node/pull/59980
sqlite:
  * (SEMVER-MINOR) create authorization api (Guilherme Araújo) https://github.com/nodejs/node/pull/59928

PR-URL: https://github.com/nodejs/node/pull/60136
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
2025-10-08 19:44:10 -03:00
Joyee Cheung
4eb6e6fd79 deps: V8: cherry-pick 87356585659b
Original commit message:

    [flags] Ignore memory tuning flags when computing hash for code caching

    Change-Id: Ia9aa5b1da8d9b1356bea281cde91bca9ea0b4071
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6938261
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#102443}

Refs: 8735658565
PR-URL: https://github.com/nodejs/node/pull/60069
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2025-10-08 19:05:00 +00:00
Rafael Gonzaga
20dc4b514a tools: use cooldown property correctly
PR-URL: https://github.com/nodejs/node/pull/60134
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2025-10-08 17:43:06 +00:00
sangwook
f0aa073907 test_runner: add junit file attribute support
Add file attribute to JUnit testcase elements when file information
is available in test event data.

PR-URL: https://github.com/nodejs/node/pull/59432
Fixes: https://github.com/nodejs/node/issues/59422
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
2025-10-08 12:27:36 +00:00
sangwook
1f95d39997 test: prepare junit file attribute normalization
Add file attribute normalization in JUnit test output transform to
support upcoming file attribute feature in JUnit XML reporter.

PR-URL: https://github.com/nodejs/node/pull/59432
Fixes: https://github.com/nodejs/node/issues/59422
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
2025-10-08 12:27:35 +00:00
Gürgün Dayıoğlu
15278252bb lib: remove redundant destroyHook checks
PR-URL: https://github.com/nodejs/node/pull/60120
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
2025-10-08 12:11:43 +00:00
Christian Clauss
0fb040603b build: upgrade Python linter ruff, add rules ASYNC,PERF
PR-URL: https://github.com/nodejs/node/pull/59984
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
2025-10-08 07:37:31 +00:00
Dario Piotrowicz
200fe9e7f4 repl: move completion logic to internal module
PR-URL: https://github.com/nodejs/node/pull/59889
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2025-10-08 07:37:22 +00:00
Rahul
b13f24c2da build, src: fix include paths for vtune files
PR-URL: https://github.com/nodejs/node/pull/59999
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2025-10-07 19:04:32 +00:00
James M Snell
d52cd04591 quic: continue working on quic api bits
PR-URL: https://github.com/nodejs/node/pull/60123
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
2025-10-07 14:04:53 +00:00
Antoine du Hamel
ec26b1c01a tools: add lint rule to ensure assertions are reached
PR-URL: https://github.com/nodejs/node/pull/60125
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
2025-10-07 12:40:05 +00:00
Rafael Gonzaga
b757a8f2b4 lib: remove util.getCallSite
This API has been replaced by util.getCallSites().

It was previously experimental with a warning about
its usage and its removal in a semver-minor PR. Here it
is.

PR-URL: https://github.com/nodejs/node/pull/59980
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2025-10-06 18:14:18 +00:00
Augustin Mauroy
6797c6e1f8 doc: add automated migration info to deprecations
PR-URL: https://github.com/nodejs/node/pull/60022
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-10-06 14:32:39 +00:00
Chengzhong Wu
d9b8a3558e inspector: improve batch diagnostic channel subscriptions
PR-URL: https://github.com/nodejs/node/pull/60009
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-10-06 13:48:33 +00:00
James M Snell
23fa18444f src: fix small compile warning in quic/streams.cc
Fixes: https://github.com/nodejs/node/issues/60110
PR-URL: https://github.com/nodejs/node/pull/60118
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2025-10-06 13:37:17 +00:00
Olivier Flückiger
3db2f58693 deps: V8: cherry-pick f93055fbd5aa
Original commit message:

    [runtime] Fastcase for empty getOwnPropertySymbols()

    Since symbols are not enumerable we can rule them out in case all
    properties are in the enum cache.

    Bug: 447154198
    Change-Id: Ib2d58b67e5058d98323fcebaef3daba88c6304b5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6983286
    Commit-Queue: Olivier Flückiger <olivf@chromium.org>
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Auto-Submit: Olivier Flückiger <olivf@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#102878}

Refs: f93055fbd5
PR-URL: https://github.com/nodejs/node/pull/60105
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2025-10-06 15:11:05 +02:00
James M Snell
4a7fbb64e6 src: update contextify to use DictionaryTemplate
PR-URL: https://github.com/nodejs/node/pull/60059
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2025-10-06 09:26:25 +00:00
iknoom
81b71190c6 src: remove AnalyzeTemporaryDtors option from .clang-tidy
PR-URL: https://github.com/nodejs/node/pull/60008
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-10-06 11:12:43 +02:00
Angelo Gazzola
db56020f50 doc: fix typo on child_process.md
This note on `options.stdio` mentions that it's not recommended to pass
`stdin` as a writable stream and `stdout/stderr` as readable, but then
proceeds to say to always check that `stdin` is writable and
`stdout/stderr` are readable.

Going by the examples and the fact that `process.stdin` is readable and
`process.stdout/process.stderr` are writable, I'm assuming that the
types in the recommendation got swapped.

PR-URL: https://github.com/nodejs/node/pull/60114
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-10-06 09:11:55 +00:00