OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
39,806 Commits 30 Branches 683 Tags
85c09f178ce186e1f5ce290a7bb36247cc48b3ab
Commit Graph

39806 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Tierney Cyren
85c09f178c doc: update Collaborator pronouns 
Signed-off-by: Tierney Cyren <hello@bnb.im>
PR-URL: https://github.com/nodejs/node/pull/50005
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-10-01 20:07:21 +00:00
Robert Nagy
5de25deeb9 stream: avoid tick in writable hot path 
PR-URL: https://github.com/nodejs/node/pull/49966
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-10-01 20:07:12 +00:00
Rich Trott
099e2f7bce doc: update link to Abstract Modules Records spec 
The current link in the docs go to a page that does not
have the Abstract Module Records information. Update the
link to an official source that does.

PR-URL: https://github.com/nodejs/node/pull/49961
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-10-01 18:41:51 +00:00
Yagiz Nizipli
05be31d5de esm: improve getFormatOfExtensionlessFile speed 
PR-URL: https://github.com/nodejs/node/pull/49965
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-10-01 18:32:07 +00:00
Claudio W
47b2883673 doc: updated building docs for windows 
PR-URL: https://github.com/nodejs/node/pull/49767
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-10-01 14:22:58 +00:00
Antoine du Hamel
aadfea4979 esm: improve JSDoc annotation of internal functions 
Co-authored-by: Geoffrey Booth <webadmin@geoffreybooth.com>
PR-URL: https://github.com/nodejs/node/pull/49959
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-10-01 09:26:56 +02:00
Deokjin Kim
092fb9f541 tls: use validateFunction for options.checkServerIdentity 
If user uses invalid type for `options.checkServerIdentity`
in tls.connect(), it's not internal issue of Node.js. So
validateFunction() is more proper than assert().

Fixes: https://github.com/nodejs/node/issues/49839
PR-URL: https://github.com/nodejs/node/pull/49896
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-09-30 22:38:10 +00:00
Vinicius Lourenço
e6e320ecc7 perf_hooks: reduce overhead of new resource timings 
PR-URL: https://github.com/nodejs/node/pull/49837
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-09-30 21:44:02 +00:00
Aras Abbasi
0ee9c83ffc errors: improve performance of determine-specific-type 
PR-URL: https://github.com/nodejs/node/pull/49696
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-09-30 21:43:40 +00:00
Yagiz Nizipli
b903a710f4 src: use exact return value for uv_os_getenv 
PR-URL: https://github.com/nodejs/node/pull/49149
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
 2023-09-30 21:43:30 +00:00
Khafra
fa250fdec1 lib: make fetch sync and return a Promise 
update test

PR-URL: https://github.com/nodejs/node/pull/49936
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2023-09-30 18:48:36 +00:00
Richard Lau
6c9625dca4 test: update skip for moved test-wasm-web-api 
`test-wasm-web-api` was moved from `test/parallel` to `test/es-modules`.
Update the status files for parallel and es-modules accordingly.

Refs: https://github.com/nodejs/node/pull/49869
Refs: https://github.com/nodejs/node/pull/47299
Refs: https://github.com/nodejs/node/issues/47297
PR-URL: https://github.com/nodejs/node/pull/49958
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-09-30 18:10:14 +00:00
Luigi Pinca
f05d6d090c Revert "test: mark test-runner-output as flaky" 
This reverts commit 717e233cd9.

Refs: https://github.com/nodejs/node/commit/fef7927cc3a7
PR-URL: https://github.com/nodejs/node/pull/49905
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-09-30 15:43:14 +00:00
Node.js GitHub Bot
49cf182e30 deps: update ada to 2.6.9 
PR-URL: https://github.com/nodejs/node/pull/49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2023-09-30 15:35:07 +00:00
Node.js GitHub Bot
ceb6df0f22 deps: update ada to 2.6.8 
PR-URL: https://github.com/nodejs/node/pull/49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2023-09-30 15:35:06 +00:00
Node.js GitHub Bot
b73e18b5dc deps: update ada to 2.6.7 
PR-URL: https://github.com/nodejs/node/pull/49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2023-09-30 15:35:05 +00:00
Node.js GitHub Bot
baf2256617 deps: update ada to 2.6.5 
PR-URL: https://github.com/nodejs/node/pull/49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2023-09-30 15:35:03 +00:00
Node.js GitHub Bot
a20a328a9b deps: update ada to 2.6.3 
PR-URL: https://github.com/nodejs/node/pull/49340
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2023-09-30 15:35:02 +00:00
Geoffrey Booth
51f4ff2450 module: move helpers out of cjs loader 
PR-URL: https://github.com/nodejs/node/pull/49912
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-09-30 02:24:14 +00:00
Daniel Lemire
2990390359 inspector: simplify dispatchProtocolMessage 
PR-URL: https://github.com/nodejs/node/pull/49780
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-09-30 01:58:09 +00:00
Joyee Cheung
813713f211 fs: throw errors from sync branches instead of separate implementations 
Previously to throw errors from C++ land, sync versions of the fs
were created by copying C++ code from the original implementation
and moving JS code to a separate file. This can lead to several
problems:

1. By moving code to a new file for the sake of moving, it would
  be harder to use git blame to trace changes and harder to backport
  changes to older branches.
2. Scattering the async and sync versions of fs methods in
  different files makes it harder to keep them in sync and
  share code in the prologues and epilogues.
3. Having two copies of code doing almost the same thing results
  in duplication and can be prone to out-of-sync problems when the
  prologue and epilogue get updated.
4. There is a minor cost to startup in adding an additional file.
  This can add up even with the help of snapshots.

This patch moves the JS code back to lib/fs.js to stop 1, 2 & 4
and introduces C++ helpers SyncCallAndThrowIf() and
SyncCallAndThrowOnError() so that the original implementations
can be easily tweaked to allow throwing from C++ and stop 3.

PR-URL: https://github.com/nodejs/node/pull/49913
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-09-30 01:17:00 +00:00
Michael Dawson
d37b0d267f wasi: updates required for latest uvwasi version 
Signed-off-by: Michael Dawson <midawson@redhat.com>

PR-URL: https://github.com/nodejs/node/pull/49908
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-09-29 15:16:51 -04:00
Node.js GitHub Bot
3227d7327c deps: update uvwasi to 0.0.19 
PR-URL: https://github.com/nodejs/node/pull/49908
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-09-29 15:16:48 -04:00
Richard Lau
6322d4f587 build: fix IBM i build with Python 3.9 
Python 3.9 on IBM i returns "os400" for `sys.platform`.

PR-URL: https://github.com/nodejs/node/pull/48056
Refs: https://github.com/nodejs/node/pull/46739
Refs: https://github.com/nodejs/build/pull/3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-09-29 18:26:28 +00:00
Richard Lau
035e06317a test: disambiguate AIX and IBM i 
When built with Python 3.9 on IBM i, `process.platform` will return
`os400` instead of `aix`. In preparation for this, make `common.isAIX`
only return true for AIX and update the tests to add checks for
`common.isIBMi` where they were missing.

PR-URL: https://github.com/nodejs/node/pull/48056
Refs: https://github.com/nodejs/node/pull/46739
Refs: https://github.com/nodejs/build/pull/3358
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-09-29 18:26:27 +00:00
Robert Nagy
53b5545672 stream: writable state bitmap 
PR-URL: https://github.com/nodejs/node/pull/49899
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-09-29 18:13:44 +00:00
Joyee Cheung
7b624c30b2 doc: update CHANGELOG_V20 about vm fixes 
Jest users might need additional changes to unblock upgrade from
v16.

PR-URL: https://github.com/nodejs/node/pull/49951
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2023-09-29 16:20:46 +00:00
Joyee Cheung
4d0aeed4a6 test: deflake test-perf-hooks.js 
Previously when checking the initial timing we did a lot of checks
after accessing and copying timing.duration and before we check
that timing.duration is roughly the same as performance.now(),
which can lead to flakes if the overhead of the checking is
big enough. Update the test to check timing.duration against
performance.now() as soon as possible when it's copied instead
of computed.
:#

PR-URL: https://github.com/nodejs/node/pull/49892
Refs: https://github.com/nodejs/reliability/issues/676
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2023-09-29 18:14:01 +02:00
MatteoBax
16ac5e1ca8 zlib: fix discovery of cpu-features.h for android 
Fixed cpu-features.h not found issue.

Co-Authored-By: Luigi Pinca <luigipinca@gmail.com>
Fixes: https://github.com/nodejs/node/issues/49766
PR-URL: https://github.com/nodejs/node/pull/49828
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2023-09-29 11:52:46 -04:00
Sam Verschueren
1b96975f27 lib: fix primordials typings 
PR-URL: https://github.com/nodejs/node/pull/49895
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-09-29 13:58:42 +00:00
Tobias Nießen
1dc0667aa6 doc: document dangerous symlink behavior 
Much earlier, a design decision was made that the permission model
should not prevent following symbolic links to presumably inaccessible
locations. Recently, after some back and forth, it had been decided that
it is indeed a vulnerability that symbolic links, which currently point
to an accessible location, can potentially be re-targeted to point to a
presumably inaccessible location. Nevertheless, months later, no
solution has been found and the issue is deemed unfixable in the context
of the current permission model implementation, so it was decided to
disclose the vulnerability and to shift responsibiliy onto users who are
now responsible for ensuring that no potentially dangerous symlinks
exist in any directories that they grant access to.

I believe that this design issue might be surprising and that it comes
with significant security implications for users, so it should be
documented.

Original vulnerability report: https://hackerone.com/reports/1961655

PR-URL: https://github.com/nodejs/node/pull/49154
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-09-29 11:31:51 +00:00
Jungku Lee
6aa7101960 lib: update params in jsdoc for HTTPRequestOptions 
PR-URL: https://github.com/nodejs/node/pull/49872
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2023-09-29 13:14:24 +02:00
Colin Ihrig
c935d4c8fa test_runner: replace spurious if with else 
There is an `if` statement that likely should have been
an `else` in the original PR.

Refs: https://github.com/nodejs/node/pull/48915
PR-URL: https://github.com/nodejs/node/pull/49943
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
 2023-09-29 11:04:58 +00:00
Jungku Lee
43500fa646 src: move const variable in node_file.h to node_file.cc 
PR-URL: https://github.com/nodejs/node/pull/49688
Refs: https://github.com/nodejs/node/pull/48325
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-09-29 11:04:48 +00:00
Aras Abbasi
4f84a3d200 errors: improve formatList in errors.js 
PR-URL: https://github.com/nodejs/node/pull/49642
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-09-29 11:04:38 +00:00
Tim Perry
17b9925393 crypto: return clear errors when loading invalid PFX data 
PR-URL: https://github.com/nodejs/node/pull/49566
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2023-09-29 10:56:33 +00:00
Deokjin Kim
7ace5aba75 events: validate options of on and once 
Check whether options is object or not to avoid passing
invalid type as options to `on` and `once`.

Refs: https://nodejs.org/dist/latest-v19.x/docs/api/events.html#eventsonceemitter-name-options
PR-URL: https://github.com/nodejs/node/pull/46018
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-09-29 10:56:20 +00:00
Livia Medeiros
b3ec13d449 fs: adjust position validation in reading methods 
This prohibits invalid values (< -1 and non-integers) and
allows `filehandle.read()` to handle position up to `2n ** 63n - 1n`

PR-URL: https://github.com/nodejs/node/pull/42835
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2023-09-29 10:56:07 +00:00
Antoine du Hamel
7f0e36af52 esm: fix cache collision on JSON files using file: URL 
PR-URL: https://github.com/nodejs/node/pull/49887
Fixes: https://github.com/nodejs/node/issues/49724
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-09-29 08:46:32 +00:00
Geoffrey Booth
85301803e1 esm: --experimental-default-type flag to flip module defaults 
PR-URL: https://github.com/nodejs/node/pull/49869
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-09-29 06:18:44 +00:00
Ruy Adorno
5570c29780 2023-09-28, Version 20.8.0 (Current) 
Notable changes:

deps:
  * add v8::Object::SetInternalFieldForNodeCore() (Joyee Cheung) https://github.com/nodejs/node/pull/49874
doc:
  * deprecate `fs.F_OK`, `fs.R_OK`, `fs.W_OK`, `fs.X_OK` (Livia Medeiros) https://github.com/nodejs/node/pull/49683
  * deprecate `util.toUSVString` (Yagiz Nizipli) https://github.com/nodejs/node/pull/49725
  * deprecate calling `promisify` on a function that returns a promise (Antoine du Hamel) https://github.com/nodejs/node/pull/49647
esm:
  * set all hooks as release candidate (Geoffrey Booth) https://github.com/nodejs/node/pull/49597
module:
  * fix the leak in SourceTextModule and ContextifySript (Joyee Cheung) https://github.com/nodejs/node/pull/48510
  * fix leak of vm.SyntheticModule (Joyee Cheung) https://github.com/nodejs/node/pull/48510
  * use symbol in WeakMap to manage host defined options (Joyee Cheung) https://github.com/nodejs/node/pull/48510
src:
  * (SEMVER-MINOR) allow embedders to override NODE_MODULE_VERSION (Cheng Zhao) https://github.com/nodejs/node/pull/49279
stream:
  * use bitmap in writable state (Raz Luvaton) https://github.com/nodejs/node/pull/49834
  * use bitmap in readable state (Benjamin Gruenbaum) https://github.com/nodejs/node/pull/49745
  * improve webstream readable async iterator performance (Raz Luvaton) https://github.com/nodejs/node/pull/49662
test_runner:
  * (SEMVER-MINOR) accept `testOnly` in `run` (Moshe Atlow) https://github.com/nodejs/node/pull/49753
  * (SEMVER-MINOR) add junit reporter (Moshe Atlow) https://github.com/nodejs/node/pull/49614

PR-URL: https://github.com/nodejs/node/pull/49932
 2023-09-28 23:14:36 -04:00
Rich Trott
0fe673c7e6 meta: update website team with new name 
Pings for the website team aren't working because the team name
changed but it did not get updated in CODEOWNERS.

PR-URL: https://github.com/nodejs/node/pull/49883
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-09-28 14:23:34 -07:00
Rich Trott
7f06c270c6 tools: add navigation ARIA landmark to generated API ToC 
As an accessibility improvement, specify the navigation landmark for
the element of our docs that contains the table of contents generated
for the specific API page.

Ref: https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/
Ref: https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA20.html
PR-URL: https://github.com/nodejs/node/pull/49882
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
 2023-09-28 14:08:53 -07:00
Rich Trott
bc056c2426 doc: add main ARIA landmark to API docs 
As an accessibility improvement, specify the main landmark for
the column in our docs that contains the main content.

Ref: https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/
Ref: https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA20.html
PR-URL: https://github.com/nodejs/node/pull/49882
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
 2023-09-28 14:08:52 -07:00
Rich Trott
f416a0f555 doc: add navigation ARIA landmark to doc ToC 
As an accessibility improvement, specify the navigation landmark for
the column in our docs that contains the table of contents.

Ref: https://www.w3.org/WAI/ARIA/apg/practices/landmark-regions/
Ref: https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA20.html
PR-URL: https://github.com/nodejs/node/pull/49882
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
 2023-09-28 14:08:51 -07:00
Ulises Gascon
e97d25687b tools: use osx notarytool for future releases 
Signed-off-by: Ulises Gascon <UlisesGascon@users.noreply.github.com>

Refs: https://github.com/nodejs/build/issues/3385
PR-URL: https://github.com/nodejs/node/pull/48701
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-09-28 16:51:37 -04:00
Node.js GitHub Bot
3f1936f698 tools: update github_reporter to 1.5.3 
PR-URL: https://github.com/nodejs/node/pull/49877
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-09-28 13:01:41 +00:00
Khafra
e28dbe1c2b lib: add WebSocket client 
fixup

add test

lint

fixup

update doc/node.1

PR-URL: https://github.com/nodejs/node/pull/49830
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2023-09-28 13:01:30 +00:00
Michaël Zasso
a4fdb1abe0 lib,test: do not hardcode Buffer.kMaxLength 
V8 will soon support typed arrays as large as the maximum array buffer
length. This patch replaces hardcoded values related to
Buffer.kMaxLength with the actual constant.
It also fixes a test that was passing by accident.

Refs: 44b2995900
PR-URL: https://github.com/nodejs/node/pull/49876
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-09-28 12:50:20 +00:00
Aras Abbasi
cc725a653a errors: improve performance of instantiation 
PR-URL: https://github.com/nodejs/node/pull/49654
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
 2023-09-28 09:57:38 +00:00