OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
39,622 Commits 30 Branches 683 Tags
8103a6418eafc50ea574439b2c7fed121738cffb
Commit Graph

39622 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Antoine du Hamel
8103a6418e doc: rename possibly confusing variable and CSS class 
A "selector" usually refers to a CSS selector, when here it refers to a
checkbox.

PR-URL: https://github.com/nodejs/node/pull/49536
Reviewed-By: Claudio Wunder <cwunder@gnome.org>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-09-08 17:03:57 +02:00
Raz Luvaton
7bf29b52b3 benchmark: fix webstream pipe-to 
PR-URL: https://github.com/nodejs/node/pull/49552
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-09-08 12:53:40 +00:00
Cheng Zhao
3163f8d680 gyp: put cctest filenames in variables 
PR-URL: https://github.com/nodejs/node/pull/49178
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
 2023-09-08 11:26:00 +00:00
Joyee Cheung
7db6e189d6 src: set ModuleWrap internal fields only once 
There is no need to initialize the internal fields to undefined
and then initialize them to something else in the caller. Simply
pass the internal fields into the constructor to initialize
them just once.

PR-URL: https://github.com/nodejs/node/pull/49391
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2023-09-08 11:08:09 +00:00
Phil Nash
015e27bd08 src: don't overwrite environment from .env file 
This commit adds a check to see if an environment variable that is
found in the .env file is already set in the environment. If it is,
then the value from the .env file is not used.

PR-URL: https://github.com/nodejs/node/pull/49424
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-09-08 06:44:36 +00:00
Mustafa Ateş Uzun
0bce573bd4 src: fix fs_type_to_name default value 
PR-URL: https://github.com/nodejs/node/pull/49239
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: theanarkh <theratliter@gmail.com>
 2023-09-07 19:14:33 +00:00
Antoine du Hamel
cd49408ff1 doc: update outdated history info 
PR-URL: https://github.com/nodejs/node/pull/49530
Refs: https://github.com/nodejs/node/pull/48842
Refs: https://github.com/nodejs/node/pull/47999
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-09-07 18:30:00 +00:00
Joyee Cheung
e0fb3f7cb8 test: split test-crypto-dh to avoid timeout on slow machines in the CI 
Locally this speeds up running test-crypto-dh* from 7s to 2s. This was
previously timing out in CI (took more than 2 minutes) so should see
a bigger gap in the CI.

PR-URL: https://github.com/nodejs/node/pull/49492
Refs: https://github.com/nodejs/node/issues/49202
Refs: https://github.com/nodejs/reliability/issues/655
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-09-07 14:43:29 +00:00
Ulises Gascón
b3c4f66328 doc: add release key for Ulises Gascon 
PR-URL: https://github.com/nodejs/node/pull/49196
Refs: https://github.com/nodejs/Release/issues/892
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-09-07 12:44:14 +00:00
Sébastien Règne
e6fce823b7 doc: close a parenthesis 
PR-URL: https://github.com/nodejs/node/pull/49525
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-09-07 12:28:59 +00:00
Cheng Zhao
def014dff3 tools: allow passing absolute path of config.gypi in js2c 
PR-URL: https://github.com/nodejs/node/pull/49162
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2023-09-07 09:20:38 +00:00
rogertyang
c86e700b3e src: fix comment on StreamResource 
PR-URL: https://github.com/nodejs/node/pull/49193
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-09-07 11:11:35 +02:00
Joyee Cheung
941ad8b843 src: do not rely on the internal field being default to undefined 
It's an undocumented V8 behavior that is subject to change. Instead
just check if the internal field is set to a promise. There is also
no need to check IsEmpty() since the object is guaranteed to be
constructed by the FileHandle constructor with enough internal
fields.

PR-URL: https://github.com/nodejs/node/pull/49413
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/4707972/comment/be9285cc_a49aad88/
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-09-07 08:59:38 +00:00
Livia Medeiros
f0ebb774a5 test: make test-dotenv-node-options locale-independent 
PR-URL: https://github.com/nodejs/node/pull/49470
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-09-07 08:51:19 +00:00
Node.js GitHub Bot
9c7b7bec8e deps: update googletest to 8a6feab 
PR-URL: https://github.com/nodejs/node/pull/49463
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-09-07 08:51:10 +00:00
Joyee Cheung
a33a4979a4 doc: cast GetInternalField() return type to v8::Value in addons.md 
For the breaking change in
https://chromium-review.googlesource.com/c/v8/v8/+/4707972

PR-URL: https://github.com/nodejs/node/pull/49439
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-09-07 08:51:00 +00:00
Michaël Zasso
c9019ccdac tools: configure never-stale label correctly 
Feature requests are issues, not PRs.

PR-URL: https://github.com/nodejs/node/pull/49498
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-09-07 07:09:45 +00:00
dependabot[bot]
8024a9a0ba meta: bump github/codeql-action from 2.21.2 to 2.21.5 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 2.21.2 to 2.21.5.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](0ba4244466...00e563ead9)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/49438
Refs: 00e563ead9
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-09-07 06:43:18 +00:00
dependabot[bot]
65f63d49c1 meta: bump rtCamp/action-slack-notify from 2.2.0 to 2.2.1 
Bumps [rtCamp/action-slack-notify](https://github.com/rtcamp/action-slack-notify) from 2.2.0 to 2.2.1.
- [Release notes](https://github.com/rtcamp/action-slack-notify/releases)
- [Commits](12e36fc18b...b24d75fe0e)

---
updated-dependencies:
- dependency-name: rtCamp/action-slack-notify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/49437
Refs: b24d75fe0e
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-09-07 06:43:07 +00:00
Geoffrey Booth
63c3846d0a esm: refactor test-esm-loader-resolve-type 
PR-URL: https://github.com/nodejs/node/pull/49493
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-09-06 22:30:09 +00:00
Geoffrey Booth
a927adef9e esm: refactor test-esm-named-exports 
PR-URL: https://github.com/nodejs/node/pull/49493
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-09-06 22:30:08 +00:00
Ariel Weiss
6b135a1a20 doc: fix documentation for input option in child_process 
PR-URL: https://github.com/nodejs/node/pull/49481
Fixes: https://github.com/nodejs/node/issues/49417
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-09-06 21:08:18 +00:00
npm CLI robot
306de763f2 deps: upgrade npm to 10.0.0 
PR-URL: https://github.com/nodejs/node/pull/49423
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
 2023-09-06 19:54:44 +00:00
Oshri Asulin
6919d72416 doc: fix missing imports in test.run code examples 
The script was missing necessary imports for the `run`
function and the `path` module, causing it to fail.
This commit adds the missing imports and resolves the issue.

- Import `run` from the appropriate module.
- Import `path` to resolve file paths.

The script should now run without errors.

PR-URL: https://github.com/nodejs/node/pull/49489
Fixes: https://github.com/nodejs/node/issues/49488
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-09-06 18:17:54 +00:00
Antoine du Hamel
fdc65d9769 esm: fix loading of CJS modules from ESM 
PR-URL: https://github.com/nodejs/node/pull/49500
Fixes: https://github.com/nodejs/node/issues/49497
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-09-06 10:12:14 +00:00
Milan Burda
cfe4166f0f lib: check SharedArrayBuffer availability in freeze_intrinsics.js 
PR-URL: https://github.com/nodejs/node/pull/49482
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-09-06 09:19:29 +00:00
Mert Can Altın
d8eb8d05f9 doc: fix documentation for fs.createWriteStream highWaterMark option 
PR-URL: https://github.com/nodejs/node/pull/49456
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
 2023-09-06 06:57:21 +00:00
Jithil P Ponnan
54021850f9 process: add custom dir support for heapsnapshot-signal 
PR-URL: https://github.com/nodejs/node/pull/47854
Refs: https://github.com/nodejs/node/issues/47842
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
 2023-09-05 15:13:01 -07:00
Erick Wendel
a61bc9d933 test_runner: fix invalid timer call 
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/49477
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-09-05 21:17:28 +00:00
Livia Medeiros
21759bdfed test: add test for urlstrings usage in node:fs 
PR-URL: https://github.com/nodejs/node/pull/49471
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-09-05 21:07:21 +00:00
Claudio W
e79ef81289 doc: updated releasers instructions for node.js website 
PR-URL: https://github.com/nodejs/node/pull/49427
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-09-05 18:29:01 +00:00
Erick Wendel
f139cc3ee8 test_runner: add jsdocs to MockTimers 
Signed-off-by: Erick Wendel <erick.workspace@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/49476
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
 2023-09-05 16:53:07 +00:00
Node.js GitHub Bot
5b31ff1127 tools: update doc dependencies 
Updated to rehype-raw@7.0.0 rehype-stringify@10.0.0 unified@11.0.2

PR-URL: https://github.com/nodejs/node/pull/49467
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-09-05 06:13:53 +00:00
Geoffrey Booth
6a5394ea7d esm: refactor mocking test 
PR-URL: https://github.com/nodejs/node/pull/49465
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-09-05 01:13:40 +00:00
Node.js GitHub Bot
56dfcaebcf deps: update corepack to 0.20.0 
PR-URL: https://github.com/nodejs/node/pull/49464
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-09-05 00:43:59 +00:00
Antoine du Hamel
e11c7b7599 doc: edit import.meta.resolve documentation 
PR-URL: https://github.com/nodejs/node/pull/49247
Refs: https://github.com/nodejs/node/pull/49028
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
 2023-09-05 00:23:02 +00:00
Joyee Cheung
7f001c2299 test: make test-worker-prof more robust 
Use a JS workload instead of repeating FS operations and use a
timer to make it less flaky on machines with little resources.

PR-URL: https://github.com/nodejs/node/pull/49274
Refs: https://github.com/nodejs/node/issues/26401
Refs: https://github.com/nodejs/reliability/issues/640
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-09-04 21:53:59 +00:00
Moshe Atlow
47c5152545 test_runner: fix typescript coverage 
PR-URL: https://github.com/nodejs/node/pull/49406
Fixes: https://github.com/nodejs/node/issues/49398
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2023-09-04 21:45:07 +00:00
Joyee Cheung
0028fd12b7 build: add --write-snapshot-as-array-literals to configure.py 
This makes it easier to locate indeterminism in the snapshot, with
the following command:

$ ./configure --write-snapshot-as-array-literals
$ make V=
$ mv out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc
$ make V=
$ diff out/Release/obj/gen/node_snapshot.cc ./node_snapshot.cc

PR-URL: https://github.com/nodejs/node/pull/49312
Refs: https://github.com/nodejs/build/issues/3043
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2023-09-04 23:44:23 +02:00
Joyee Cheung
4d0f930183 bootstrap: only use the isolate snapshot when compiling code cache 
We do not actually need to deserialize the context and the whole
environment to compile the code cache, since code cache are not
context-dependent anyway, deserializing just the isolate snapshot is
enough.

PR-URL: https://github.com/nodejs/node/pull/49288
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2023-09-04 23:35:27 +02:00
Ulises Gascón
12354260db 2023-09-04, Version 20.6.0 (Current) 
Notable changes:

deps:
  * V8: cherry-pick 93275031284c (Joyee Cheung) #48660
doc:
  * add new TSC members (Michael Dawson) #48841
  * add rluvaton to collaborators (Raz Luvaton) #49215
esm:
  * unflag import.meta.resolve (Guy Bedford) #49028
  * add `initialize` hook, integrate with `register` (Izaak Schroeder) #48842
  * unflag `Module.register` and allow nested loader `import()` (Izaak Schroeder) #48559
inspector:
  * (SEMVER-MINOR) open add `SymbolDispose` (Chemi Atlow) #48765
module:
  * implement `register` utility (João Lenon) #46826
  * make CJS load from ESM loader (Antoine du Hamel) #47999
src:
  * add built-in `.env` file support (Yagiz Nizipli) #48890
  * initialize cppgc (Daryl Haresign and Joyee Cheung) #48660 and #45704
test_runner:
  * (SEMVER-MINOR) expose location of tests (Colin Ihrig) #48975

PR-URL: https://github.com/nodejs/node/pull/49185
 2023-09-04 15:01:52 -05:00
Deokjin Kim
c8628ed1cf tls: remove redundant code in onConnectSecure() 
Remove redundant code by moving it to outside of `if/else`.

PR-URL: https://github.com/nodejs/node/pull/49457
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
 2023-09-04 10:55:34 +00:00
dependabot[bot]
8dfe4248ca meta: bump step-security/harden-runner from 2.5.0 to 2.5.1 
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.5.0 to 2.5.1.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](cba0d00b1f...8ca2b8b2ec)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/49435
Refs: 8ca2b8b2ec
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-09-03 19:50:47 +00:00
dependabot[bot]
f777f3f53f meta: bump actions/checkout from 3.5.3 to 3.6.0 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.3 to 3.6.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](c85c95e3d7...f43a0e5ff2)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/49436
Refs: f43a0e5ff2
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-09-03 19:25:35 +00:00
dependabot[bot]
b98d2e2397 meta: bump actions/setup-node from 3.7.0 to 3.8.1 
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 3.7.0 to 3.8.1.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](e33196f742...5e21ff4d9b)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/49434
Refs: 5e21ff4d9b
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-09-03 19:25:17 +00:00
Erick Wendel
8e82cfcbb3 test_runner: preserve original property descriptor 
PR-URL: https://github.com/nodejs/node/pull/49433
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-09-03 19:08:26 +00:00
Deokjin Kim
0add7a8f0c tls: refactor to use validateFunction 
Use validateFunction to remove duplicate implementation.
Plus, remove `assert()` statement because validateFunction
has the same purpose.

PR-URL: https://github.com/nodejs/node/pull/49422
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-09-02 16:10:09 +00:00
Jungku Lee
ea32c3ceae test: fix warning for comment in embedtest 
PR-URL: https://github.com/nodejs/node/pull/49416
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
 2023-09-02 10:53:52 +00:00
Benjamin Gruenbaum
12ee988e95 meta: remove modules team from CODEOWNERS 
Currently the modules team is inactive and the
loaders team functions as the team in charge of
these files/areas.

cc @nodejs/modules in case anyone wants to join
the @nodejs/loaders team since the modules may be
removed.

PR-URL: https://github.com/nodejs/node/pull/49412
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
 2023-09-01 20:28:26 +00:00
pluris
ce11e00dbc src: modify code for empty string 
PR-URL: https://github.com/nodejs/node/pull/49336
Refs: https://github.com/nodejs/node/pull/49097
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-09-01 23:52:36 +05:30