OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
25,808 Commits 30 Branches 683 Tags
7f0c515fed92ffd5fdfb003f99f808968101d7da
Commit Graph

25808 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Anna Henningsen
7f0c515fed worker: do not add removed methods to MessagePort 
Do not put the `.stop()` and `.drain()` methods on the
`MessagePort` prototype if we are going to remove them
later on anyway.

PR-URL: https://github.com/nodejs/node/pull/26109
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-17 17:41:12 +01:00
gengjiawen
3fbf55a87c src: remove unused macro in node_file.cc 
PR-URL: https://github.com/nodejs/node/pull/26073
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-17 10:43:30 +05:30
Rich Trott
5bb7764b68 doc: consolidate N-API material in Collaborator Guide 
Consolidate the N-API material in the Collaborator Guide to be succinct
and direct.

PR-URL: https://github.com/nodejs/node/pull/26094
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
 2019-02-16 15:30:45 -08:00
Colin Ihrig
bc72470788 doc: fix changelog entry 
PR-URL: https://github.com/nodejs/node/pull/26114
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
 2019-02-16 09:04:14 -05:00
Anna Henningsen
1ae07acfc7 inspector: make sure timer handles are cleaned up 
It is not obvious that timer handles are cleaned up properly
when the current `Environment` exits, nor that the `Environment`
knows to keep track of the closing handles.

This change may not be necessary, because timer handles
close without non-trivial delay (i.e. at the end of the current
event loop term), and JS-based inspector sessions (which are
the only ones we can easily test) are destroyed when cleaning up,
closing the timers as a result. I don’t know what happens
for other kinds of inspector sessions, though.

PR-URL: https://github.com/nodejs/node/pull/26088
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
 2019-02-16 14:35:34 +01:00
Kai
e74019fa8b doc: fix notable changes list format for 11.9.0 & 11.10.0 
PR-URL: https://github.com/nodejs/node/pull/26129
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
 2019-02-16 11:42:29 +02:00
Gireesh Punathil
006947be98 worker: remove duplicate call 
`Environment::RunCleanup` is invoked twice in a row,
remove one.

PR-URL: https://github.com/nodejs/node/pull/26104
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2019-02-16 12:38:23 +05:30
Rich Trott
a8c3adfbda worker: switch to internal assert module 
PR-URL: https://github.com/nodejs/node/pull/26091
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2019-02-15 21:51:30 -08:00
Daniel Bevenius
611043cc66 test: silence compiler warning in openssl-binding 
Currently, this test generated the following compiler warning:
../binding.cc:33:30: warning:
'TLSv1_2_server_method' is deprecated [-Wdeprecated-declarations]
  const SSL_METHOD* method = TLSv1_2_server_method();
                             ^
/node/deps/openssl/openssl/include/openssl/ssl.h:1877:1:
note: 'TLSv1_2_server_method' has been explicitly marked deprecated here
DEPRECATEDIN_1_1_0(__owur const SSL_METHOD *TLSv1_2_server_method(void))
^
1 warning generated.

This commit adds -Wno-deprecated-declarations to silence this warning
for this test.

PR-URL: https://github.com/nodejs/node/pull/26067
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
 2019-02-16 00:19:10 +01:00
Joyee Cheung
0eb71d4213 process: delay setup of global exception handlers 
Since bootstrap/node.js performs the setup synchronously,
the process exception handlers do not have to setup so early in
the bootstrap process - any fatal errors thrown before user code
execution should simply crash the process, and we do not care
about any clean up at that point. We don't care about emitting any
events if the process crash upon bootstrap either.

PR-URL: https://github.com/nodejs/node/pull/26061
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gus Caplan <me@gus.host>
 2019-02-16 00:16:11 +01:00
gengjiawen
66942d7d86 src: use same parameter name in node_report.cc 
PR-URL: https://github.com/nodejs/node/pull/26046
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2019-02-16 00:15:27 +01:00
Anna Henningsen
6a2dde579c test,worker: add more tests for worker.ref()/.unref() 
PR-URL: https://github.com/nodejs/node/pull/26083
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-02-15 23:21:33 +01:00
Anna Henningsen
5adda2c447 worker: use fake MessageEvent for port.onmessage 
Instead of passing the payload for Workers directly to `.onmessage`,
perform something more similar to what the browser API provides,
namely create an event object with a `.data` property.

This does not make `MessagePort` implement the `EventTarget` API, nor
does it implement the full `MessageEvent` API, but it would make
such extensions non-breaking changes if we desire them at
some point in the future.

(This would be a breaking change if Workers were not experimental.
Currently, this method is also undocumented and only exists with
the idea of enabling some degree of Web compatibility.)

PR-URL: https://github.com/nodejs/node/pull/26082
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
 2019-02-15 23:16:16 +01:00
Ali Ijaz Sheikh
a02e3e2d5f lib: improve error message for MODULE_NOT_FOUND 
Include the require stack in the reported error message.

PR-URL: https://github.com/nodejs/node/pull/25690
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-15 12:52:05 -08:00
Ali Ijaz Sheikh
05cd1a0929 lib: requireStack property for MODULE_NOT_FOUND 
Include the stack of requires that led to a MODULE_NOT_FOUND error.

PR-URL: https://github.com/nodejs/node/pull/25690
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-15 12:51:53 -08:00
Thang Tran
128170f5c6 build: fixed clang's warning when building openssl 
clang doesn't seem to support 'Wno-old-style-declaration', this
is a work-around.

Fixes: https://github.com/nodejs/node/issues/25550
Refs: https://github.com/nodejs/node-v0.x-archive/issues/4186

PR-URL: https://github.com/nodejs/node/pull/25954
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-15 06:34:36 -05:00
Richard Lau
51d20b6a8f fs, src, lib: fix blksize & blocks on Windows 
libuv returns values for `blksize` and `blocks` on stat calls so
do not coerce them into `undefined` on Windows.

PR-URL: https://github.com/nodejs/node/pull/26056
Fixes: https://github.com/nodejs/node/issues/25913
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-15 01:55:58 -05:00
Rich Trott
8e68dc53b3 test: increase coverage for assertion_error.js 
Add a test for long strings and assert.notDeepEqual() to cover code that
truncates output when it is longer than 1024 characters.

PR-URL: https://github.com/nodejs/node/pull/26065
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
 2019-02-14 19:28:38 -08:00
Refael Ackermann
fe58bef7e2 test: add arg to narrow http benchmark test 
PR-URL: https://github.com/nodejs/node/pull/26101
Reviewed-By: Weijia Wang <starkwang@126.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-02-14 19:09:36 -05:00
Michaël Zasso
82ee0ff1b8 2018-02-14, Version 11.10.0 (Current) 
Notable changes:

deps:
  * Updated libuv to 1.26.0.
  * Updated npm to 6.7.0.
http, http2:
  * `response.writeHead` now returns the response object.
perf_hooks:
  * Implemented a histogram based API.
process:
  * Exposed `process.features.inspector`.
repl:
  * Added `repl.setupHistory` for programmatic repl.
tls:
  * Introduced client "session" event.

PR-URL: https://github.com/nodejs/node/pull/26098
 2019-02-14 23:55:48 +01:00
Refael Ackermann
2ffd20bb91 build,win: emit MSBuild summary 
PR-URL: https://github.com/nodejs/node/pull/25931
Reviewed-By: João Reis <reis@janeasystems.com>
 2019-02-14 15:14:47 -05:00
Refael Ackermann
ff4adab78c build,win: always build with PCH 
PR-URL: https://github.com/nodejs/node/pull/25931
Reviewed-By: João Reis <reis@janeasystems.com>
 2019-02-14 15:14:46 -05:00
Refael Ackermann
6ac80f0e2b build,src: add PCH to node.gypi 
PR-URL: https://github.com/nodejs/node/pull/25931
Reviewed-By: João Reis <reis@janeasystems.com>
 2019-02-14 15:14:44 -05:00
Refael Ackermann
4698757610 build,deps: remove cygwin configuration which is not supported 
PR-URL: https://github.com/nodejs/node/pull/25931
Reviewed-By: João Reis <reis@janeasystems.com>
 2019-02-14 15:14:43 -05:00
Refael Ackermann
cd5c7bf240 build,deps: use PCH also for v8_initializers 
* rename files to represent reuse

PR-URL: https://github.com/nodejs/node/pull/25931
Reviewed-By: João Reis <reis@janeasystems.com>
 2019-02-14 15:14:42 -05:00
Refael Ackermann
82b798907d build,tools: add more headers to V8 PCH file 
* Use relative path for easy reuse in other projects

PR-URL: https://github.com/nodejs/node/pull/25931
Reviewed-By: João Reis <reis@janeasystems.com>
 2019-02-14 15:14:41 -05:00
Refael Ackermann
20a917c571 build: move optimizing link directives to node.exe target 
* ASCIIbetize directives
* Merge duplicate directives from 'conditions'

PR-URL: https://github.com/nodejs/node/pull/25931
Reviewed-By: João Reis <reis@janeasystems.com>
 2019-02-14 15:14:40 -05:00
Kelvin Jin
582c0d5a09 trace_events: fix trace events JS API writing 
The Trace Events JS API isn't functional if none of
--trace-events-enabled or --trace-event-categories is passed as a CLI
argument. This commit fixes that.

In addition, we currently don't test the trace_events JS API in the
casewhere no CLI args are provided. This commit adds that test.

Fixes https://github.com/nodejs/node/issues/24944

PR-URL: https://github.com/nodejs/node/pull/24945
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
 2019-02-14 12:10:09 -08:00
jasnell
7d60b6b21b meta: moving jasnell temporarily to TSC emeritus 
Moving myself temporarily to TSC emertus status. Expecting to
take a two month hiatus from TSC duties while I focus on some
NearForm internal business.

PR-URL: https://github.com/nodejs/node/pull/26106
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2019-02-14 11:17:52 -08:00
Gireesh Punathil
e7f499681b src: use more stable cast where possible 
PR-URL: https://github.com/nodejs/node/pull/26052
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
 2019-02-14 20:13:20 +05:30
Rich Trott
3f9beabe05 doc: edit N-API introductory material in Collaborator Guide 
Use shorter, clearer sentences. Remove passive voice and personal
pronouns.

PR-URL: https://github.com/nodejs/node/pull/26051
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2019-02-13 23:36:14 -08:00
Sam Roberts
69a8e34003 doc: clarify effect of stream.destroy() on write() 
PR-URL: https://github.com/nodejs/node/pull/25973
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
 2019-02-14 04:50:57 +01:00
gengjiawen
f4ce330f8f src: remove redundant cast in node_http2.h 
PR-URL: https://github.com/nodejs/node/pull/25978
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-14 01:28:30 +01:00
Pushkal B
1833782bb1 test: replaced anonymous fn with arrow syntax 
PR-URL: https://github.com/nodejs/node/pull/26029
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-14 00:06:05 +01:00
Luigi Pinca
2b090c1bd0 test: use emitter.listenerCount() in test-http-connect 
Use `emitter.listenerCount()` instead of the `length` property of the
array returned by `emitter.listeners()`.

PR-URL: https://github.com/nodejs/node/pull/26031
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2019-02-14 00:04:59 +01:00
MaleDong
1411f7c8b3 lib: merge 'undefined' into one 'break' branch 
We don't need to split this alone, but just merge it into the 'break'
switch branch together.

PR-URL: https://github.com/nodejs/node/pull/26039
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-14 00:03:02 +01:00
Rich Trott
4aa04f57c3 cluster: migrate round_robin_handle to internal assert 
Use smaller internal assert module for round_robin_handle.js.

PR-URL: https://github.com/nodejs/node/pull/26047
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-14 00:00:51 +01:00
Rich Trott
ce65034e63 assert: add internal assert.fail() 
PR-URL: https://github.com/nodejs/node/pull/26047
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-14 00:00:50 +01:00
Thang Tran
1c66ad408b doc: renamed remote's name 
To keep consistency through-out the guide.

Fixes: https://github.com/nodejs/node/issues/26045

PR-URL: https://github.com/nodejs/node/pull/26050
Reviewed-By: Yuta Hiroto <hello@hiroppy.me>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Masashi Hirano <shisama07@gmail.com>
 2019-02-13 23:57:38 +01:00
Anna Henningsen
a80b29b38a worker: set stack size for worker threads 
This is so we can inform V8 about a known limit for the stack.

Otherwise, on some systems recursive functions may lead to
segmentation faults rather than “safe” failures.

PR-URL: https://github.com/nodejs/node/pull/26049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-02-13 21:36:24 +01:00
Weijia Wang
da0dc51e39 http: improve performance for incoming headers 
PR-URL: https://github.com/nodejs/node/pull/26041
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
 2019-02-13 21:25:20 +08:00
cjihrig
8ecf313324 os,report: use UV_MAXHOSTNAMESIZE 
UV_MAXHOSTNAMESIZE was introduced in libuv 1.26.0. Use this
instead of including multiple header files, adding fallback
ifdef logic, and remembering to add one to the buffer size
for the terminating nul character with MAXHOSTNAMELEN.

PR-URL: https://github.com/nodejs/node/pull/26038
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-13 08:19:41 -05:00
cjihrig
0109e121d3 deps: upgrade to libuv 1.26.0 
Notable changes:
- A bug that could result in 100% CPU utilization in Node
  has been fixed (https://github.com/libuv/libuv/issues/2162)
- Node's report module will now include the entire Windows
  product name (https://github.com/libuv/libuv/pull/2170)

PR-URL: https://github.com/nodejs/node/pull/26037
Fixes: https://github.com/nodejs/node/issues/26013
Fixes: https://github.com/nodejs/node/issues/25875
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
 2019-02-13 08:15:42 -05:00
MaleDong
ec76f7cf8f lib: simplify 'umask' 
Just check: if 'mask' is not undefined, just call 'validateMode' and
then return the unmask value, we don't need split them into two returns.

PR-URL: https://github.com/nodejs/node/pull/26035
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-13 13:45:38 +01:00
MaleDong
048b977d8e lib: fix the typo error 
Fix a typo error ('the' before 'any').

PR-URL: https://github.com/nodejs/node/pull/26032
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-13 05:22:58 +01:00
Sam Roberts
666beb0421 tls: renegotiate should take care of its own state 
In the initial version of this test there were two zero-length writes to
force tls state to cycle. The second is not necessary, at least not now,
but the first was. The renegotiate() API should ensure that packet
exchange takes place, not its users, so move the zero-length write into
tls.

See: https://github.com/nodejs/node/pull/14239
See: https://github.com/nodejs/node/commit/b1909d3a70f9

PR-URL: https://github.com/nodejs/node/pull/25997
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2019-02-13 05:14:32 +01:00
Joyee Cheung
006e78cecb process: refactor lib/internal/bootstrap/node.js 
- Use `deprecate` from `internal/util` instead of from `util`
- Split `setupGlobalVariables()` into `setupGlobalProxy()` and
  `setupBuffer()`, and move out manipulation of the process object.

PR-URL: https://github.com/nodejs/node/pull/26033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-13 06:11:48 +08:00
Joyee Cheung
e5da922668 process: use primordials in bootstrap/node.js 
PR-URL: https://github.com/nodejs/node/pull/26033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-13 06:11:46 +08:00
Joyee Cheung
fda80e3c99 lib: save a copy of Symbol in primordials 
PR-URL: https://github.com/nodejs/node/pull/26033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-13 06:11:44 +08:00
Joyee Cheung
008074fc38 process: document the bootstrap process in node.js 
PR-URL: https://github.com/nodejs/node/pull/26033
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2019-02-13 06:11:43 +08:00