OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
45,010 Commits 30 Branches 683 Tags
5ed1a47bab5ea0979db34b64bf65ff2e6eef20df
Commit Graph

45010 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bruno Rodrigues
5ed1a47bab benchmark: calibrate config dgram multi-buffer 
PR-URL: https://github.com/nodejs/node/pull/59696
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2025-09-14 00:39:40 +00:00
Mikhail
1442023134 url: replaced slice with at 
PR-URL: https://github.com/nodejs/node/pull/59181
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2025-09-14 00:39:32 +00:00
yusheng chen
85db70b2cf doc: type improvement of file http.md 
`outgoingMessage.setHeader` and `outgoingMessage.getHeader` section

PR-URL: https://github.com/nodejs/node/pull/58189
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2025-09-14 00:39:24 +00:00
Ruben Bridgewater
60c1fbcf65 util: inspect objects with throwing Symbol.toStringTag 
`util.inspect()` should handle all kinds of input, even if it is
not well defined. Throwing is something that is meant to be worked
around in all known cases. This fixes issues inspecting objects
where accessing the Symbol.toStringTag would cause an error. The
symbol is just ignored in that case.

Refs: https://github.com/nodejs/node/issues/55539
Refs: https://github.com/nodejs/node/pull/55544
PR-URL: https://github.com/nodejs/node/pull/59860
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2025-09-14 00:07:06 +00:00
Ruben Bridgewater
0319ba51d8 util: fix debuglog.enabled not being present with callback logger 
The method returned by the callback is missing the .enabled property.
This is added in a consistent way that it also verifies that it's a
getter.

Fixes: https://github.com/nodejs/node/issues/56676
PR-URL: https://github.com/nodejs/node/pull/59858
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2025-09-14 00:06:57 +00:00
Ruben Bridgewater
49f79b8e93 repl: fix cpu overhead pasting big strings to the REPL 
Pasting input should not trigger any completions and other
calculations. This is now handled by just writing the string to the
terminal in case the user is pasting. As soon as pasting is done,
the completions will be re-enabled.

Fixes: https://github.com/nodejs/node/issues/40626
Fixes: https://github.com/nodejs/node/issues/43343
PR-URL: https://github.com/nodejs/node/pull/59857
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2025-09-14 00:06:47 +00:00
Filip Skokan
d079d8f380 doc,crypto: update subtle.generateKey and subtle.importKey 
PR-URL: https://github.com/nodejs/node/pull/59851
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2025-09-13 08:55:17 +00:00
Anna Henningsen
4984b15a94 src: create strings in FIXED_ONE_BYTE_STRING as internalized 
These string keys can generally be assumed to be long-lived.

PR-URL: https://github.com/nodejs/node/pull/59826
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-09-12 16:53:49 +00:00
Anna Henningsen
100c255c99 src: remove std::array overload of FIXED_ONE_BYTE_STRING 
This overload was only used in one place, in a cold path, and in
particular in a place where the compiler would be able to generate
the exact same code using just a call to `.size()`.

PR-URL: https://github.com/nodejs/node/pull/59826
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-09-12 16:53:48 +00:00
Jeetu Suthar
af4eac574b node-api: make napi_delete_reference use node_api_basic_env 
PR-URL: https://github.com/nodejs/node/pull/59684
Refs: https://github.com/nodejs/node/issues/59583
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
 2025-09-12 15:58:57 +00:00
Renegade334
8869210dd8 crypto: use return await when returning Promises from async functions 
This offers _some_ resistance to `%Promise.prototype%` pollution.

Refs: https://github.com/nodejs/node/issues/59699
PR-URL: https://github.com/nodejs/node/pull/59841
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2025-09-12 14:21:50 +00:00
Renegade334
7a205d0ac0 crypto: use async functions for non-stub Promise-returning functions 
These were intended to mimic simple async functions, but exceptions
thrown in the function body would be returned synchronously, not
wrapped in a rejected Promise.

PR-URL: https://github.com/nodejs/node/pull/59841
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2025-09-12 14:21:49 +00:00
Renegade334
33e3e423d9 crypto: avoid calls to promise.catch() 
This avoids explicit calls to the user-mutable
`%Promise.prototype%.catch`, and by association, implicit calls to the
user-mutable `%Promise.prototype%.then`.

PR-URL: https://github.com/nodejs/node/pull/59841
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2025-09-12 14:21:49 +00:00
Nam Yooseong
e511344152 benchmark: calibrate config cluster/echo.js 
PR-URL: https://github.com/nodejs/node/pull/59836
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
 2025-09-12 12:59:37 +00:00
simon-id
95ab4eb6ad url: add type checking to urlToHttpOptions() 
PR-URL: https://github.com/nodejs/node/pull/59753
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
 2025-09-12 12:59:26 +00:00
Livia Medeiros
fd6cc1db2b doc: deprecate closing fs.Dir on garbage collection 
PR-URL: https://github.com/nodejs/node/pull/59839
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-09-12 11:31:22 +00:00
Aditi
94422e8a40 src: add an option to make compile cache portable 
Adds an option (NODE_COMPILE_CACHE_PORTABLE) for
the built-in compile cache to encode the hashes with
relative file paths. On enabling the option,
the source directory along with cache directory can be
bundled and moved, and the cache continues to work.

When enabled, paths encoded in hash are relative to
compile cache directory.

PR-URL: https://github.com/nodejs/node/pull/58797
Fixes: https://github.com/nodejs/node/issues/58755
Refs: https://github.com/nodejs/node/issues/52696
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2025-09-12 11:00:39 +00:00
Jordan Harband
22a864a275 build: remove corepack from release tarballs 
Closes #57763.

Refs:
     - https://github.com/nodejs/TSC/pull/1697#issuecomment-2737093616
     - https://github.com/nodejs/node/pull/57617
     - https://github.com/nodejs/node/pull/57763
PR-URL: https://github.com/nodejs/node/pull/59835
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-09-12 06:40:34 +00:00
Nam Yooseong
071414dac8 doc: rephrase dynamic import() description 
The description is updated to clarify that dynamic import() is
asynchronous, dynamic, and works in both CJS and ESM contexts.
The new phrasing also avoids implying it is the only method for
loading ES modules in CommonJS.

Fixes: https://github.com/nodejs/node/issues/59077
PR-URL: https://github.com/nodejs/node/pull/59224
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2025-09-12 06:40:24 +00:00
Rafael Gonzaga
29738c7b42 src,permission: add --allow-inspector ability 
Refs: https://github.com/nodejs/node/issues/48534
PR-URL: https://github.com/nodejs/node/pull/59711
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2025-09-11 20:10:02 +00:00
Node.js GitHub Bot
ac131bdc01 deps: update undici to 7.16.0 
PR-URL: https://github.com/nodejs/node/pull/59830
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2025-09-11 17:21:54 +00:00
Anna Henningsen
220baad8ba src: ensure v8::Eternal is empty before setting it 
V8 does not check this for us, but this is a requirement of the API.

PR-URL: https://github.com/nodejs/node/pull/59825
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2025-09-11 14:07:36 +00:00
Chengzhong Wu
c742220be9 lib,src: cache ModuleWrap.hasAsyncGraph 
`v8::Module::IsGraphAsync()` traverses the dependencies to find if they
contain TLA each time. `ModuleWrap.hasAsyncGraph` caches the result
and exposes the property to JS land so that the presence of the property
`module.hasAsyncGraph` can be consistent.

This also allows C++ access of cached `hasAsyncGraph`.

This merges the `intantiateSync`/`instantiate` and
`getNamespaceSync`/`getNamespace` as they are always sync.

PR-URL: https://github.com/nodejs/node/pull/59703
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2025-09-11 12:54:24 +00:00
Chengzhong Wu
f1b56d6200 lib: add source map support for assert messages 
Map source lines in assert messages with cached source maps.

PR-URL: https://github.com/nodejs/node/pull/59751
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2025-09-11 10:37:46 +00:00
Chengzhong Wu
d35bd2088e lib,src: refactor assert to load error source from memory 
The source code is available from V8 API and assert can avoid reading
the source file from the filesystem and parse the file again.

PR-URL: https://github.com/nodejs/node/pull/59751
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2025-09-11 10:37:45 +00:00
Michaël Zasso
a2a77b2b66 tools: skip test-internet workflow for draft PRs 
PR-URL: https://github.com/nodejs/node/pull/59817
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2025-09-11 07:05:18 +00:00
Moonki Choi
01bc7286fb src: remove unnecessary Environment::GetCurrent() calls 
PR-URL: https://github.com/nodejs/node/pull/59814
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
 2025-09-11 06:45:38 +00:00
Antoine du Hamel
6a46f31144 build: do not include custom ESLint rules testing in tarball 
PR-URL: https://github.com/nodejs/node/pull/59809
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-09-11 00:27:23 +02:00
Antoine du Hamel
8756a5a687 tools: copyedit build-tarball.yml 
PR-URL: https://github.com/nodejs/node/pull/59808
Refs: https://www.shellcheck.net/wiki/SC2006
Refs: https://www.shellcheck.net/wiki/SC2086
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-09-10 20:49:13 +00:00
Node.js GitHub Bot
33966adc65 2025-09-10, Version 24.8.0 (Current) 
Notable changes:

crypto:
  * (SEMVER-MINOR) support Ed448 and ML-DSA context parameter in node:crypto (Filip Skokan) https://github.com/nodejs/node/pull/59570
  * (SEMVER-MINOR) support Ed448 and ML-DSA context parameter in Web Cryptography (Filip Skokan) https://github.com/nodejs/node/pull/59570
  * (SEMVER-MINOR) add KMAC Web Cryptography algorithms (Filip Skokan) https://github.com/nodejs/node/pull/59647
  * (SEMVER-MINOR) add Argon2 Web Cryptography algorithms (Filip Skokan) https://github.com/nodejs/node/pull/59544
  * (SEMVER-MINOR) support SLH-DSA KeyObject, sign, and verify (Filip Skokan) https://github.com/nodejs/node/pull/59537
inspector:
  * add http2 tracking support (Darshan Sen) https://github.com/nodejs/node/pull/59611
worker:
  * (SEMVER-MINOR) add cpu profile APIs for worker (theanarkh) https://github.com/nodejs/node/pull/59428

PR-URL: https://github.com/nodejs/node/pull/59816
 2025-09-10 21:36:47 +02:00
Aras Abbasi
861d62445f inspector: undici as shared-library should pass tests 
PR-URL: https://github.com/nodejs/node/pull/59837
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-09-10 13:12:28 +00:00
James M Snell
8ec29f24fc src: use DictionaryTemplate for node_url_pattern 
Improved API and better performance:

```
url/urlpattern-parse.js n=100000 ... ***  11.59 %  ±0.96% ±1.28% ±1.66%
url/urlpattern-parse.js n=100000 ... ***   9.28 %  ±0.94% ±1.25% ±1.63%
url/urlpattern-parse.js n=100000 ... ***   6.97 %  ±0.97% ±1.29% ±1.70%
url/urlpattern-parse.js n=100000 ... ***   7.56 %  ±0.92% ±1.22% ±1.59%
url/urlpattern-test.js n=100000  ... ***   2.84 %  ±1.50% ±2.00% ±2.61%
url/urlpattern-test.js n=100000  ... ***   4.13 %  ±2.14% ±2.84% ±3.70%
url/urlpattern-test.js n=100000  ... ***   4.76 %  ±1.43% ±1.91% ±2.49%
url/urlpattern-test.js n=100000  ... ***   4.44 %  ±1.26% ±1.68% ±2.19%
```

PR-URL: https://github.com/nodejs/node/pull/59802
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2025-09-10 05:34:54 +00:00
Robert Nagy
7d0f6be9d1 http: unbreak keepAliveTimeoutBuffer 
Adds a guard.

PR-URL: https://github.com/nodejs/node/pull/59784
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2025-09-09 19:23:09 +00:00
Rafael Gonzaga
09b5b2ba34 doc: stabilize --disable-sigusr1 
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
PR-URL: https://github.com/nodejs/node/pull/59707
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2025-09-09 17:06:08 +00:00
Anna Henningsen
234c26cca3 src: store Local for CallbackScope on stack 
This is a requirement of the V8 API, but requires a separate
semver-major change (as it is ABI-breaking) to address.

(There's also a similar requirement for `napi_open_callback_scope`
that would not be easily addressable without breaking ABI compatibility
there as well. In real-world situations, it seems extremely unlikely
that the `CallbackScope` would be the only reference to the resource
object.)

PR-URL: https://github.com/nodejs/node/pull/59705
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-09-09 15:00:42 +00:00
Yaksh Bariya
d58343ec48 src: correctly report memory changes to V8 
Call `V8::ExternalMemoryAccounter::Update` instead of
`V8::ExternalMemoryAccounter::Increase` to report memory difference to
V8

Calling `V8::ExternalMemoryAccounter::Increase` with a signed integer on
32-bit platforms causes instances where GC inside GC takes place leading
to a crash in certain cases.

During GC, native objects are destructed. In destructor for
`CompressionStream` class used by zlib, memory release information is
passed onto `V8::ExternalMemoryAccounter::Increase()` instead of
`V8::ExternalMemoryAccounter::Decrease()` which triggers V8's memory
limits, thus triggering GC inside GC which leads to crash.

Bug initially introduced in commit
1d5d7b6eedb2274c9ad48b5f378598a10479e4a7

For full report see https://hackerone.com/reports/3302484

PR-URL: https://github.com/nodejs/node/pull/59623
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-09-09 12:17:47 +00:00
hotpineapple
96a749b7b3 tools: print appropriate output when test aborted 
distinguish test abort from all tests passed.

PR-URL: https://github.com/nodejs/node/pull/59794
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-09-09 06:30:41 +00:00
James M Snell
cc89e4cff8 src: fixup node_messaging error handling 
Replace ToLocalChecked uses

PR-URL: https://github.com/nodejs/node/pull/59792
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2025-09-09 03:30:43 +00:00
Node.js GitHub Bot
4302d247ad deps: update uvwasi to 0.0.23 
PR-URL: https://github.com/nodejs/node/pull/59791
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2025-09-09 01:03:59 +00:00
Haram Jeong
402a02fe2b assert: cap input size in myersDiff to avoid Int32Array overflow 
PR-URL: https://github.com/nodejs/node/pull/59578
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
 2025-09-09 00:36:14 +00:00
sangwook
670d7ab7f2 util: fix numericSeparator with negative fractional numbers 
Fix util.inspect() formatting bug where negative fractional numbers
between -1 and 0 lost their minus sign when numericSeparator was true.
Fixed formatNumber function to preserve sign by using original string
representation. Also corrected test expectations for scientific notation
to not apply numeric separators.
Fixes: https://github.com/nodejs/node/issues/59376

PR-URL: https://github.com/nodejs/node/pull/59379
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2025-09-08 20:10:50 +00:00
Lee Jiho
26607a650e path: refactor path joining logic for clarity and performance 
PR-URL: https://github.com/nodejs/node/pull/59781
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2025-09-08 18:44:18 +00:00
방진혁
9d1c9c789b typings: add typing for 'uv' 
PR-URL: https://github.com/nodejs/node/pull/59606
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
 2025-09-08 16:13:05 +00:00
Lee Jiho
e23105794c typings: add missing properties in ConfigBinding 
PR-URL: https://github.com/nodejs/node/pull/59585
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
 2025-09-08 16:12:56 +00:00
René
745e6c2012 diagnostics_channel: revoke DEP0163 
PR-URL: https://github.com/nodejs/node/pull/59758
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
 2025-09-08 15:34:52 +00:00
Antoine du Hamel
2a99210ff7 tools: use sparse checkout in build-tarball.yml 
PR-URL: https://github.com/nodejs/node/pull/59788
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
 2025-09-08 15:08:55 +00:00
Antoine du Hamel
df59e21352 tools: remove unused actions from build-tarball.yml 
PR-URL: https://github.com/nodejs/node/pull/59787
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2025-09-08 14:59:41 +00:00
Joyee Cheung
916929863d esm: populate separate cache for require(esm) in imported CJS 
Otherwise if the ESM happens to be cached separately by the ESM loader
before it gets loaded with `require(esm)` from within an imported
CJS file (which uses a re-invented require() with a couple of quirks,
including a separate cache), it won't be able to load the esm properly
from the cache.

PR-URL: https://github.com/nodejs/node/pull/59679
Refs: https://github.com/nodejs/node/issues/59666
Refs: https://github.com/nodejs/node/issues/52697
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2025-09-08 14:59:31 +00:00
Antoine du Hamel
ed68b26ca3 tools: do not attempt to compress tgz archive 
Refs: https://github.com/actions/upload-artifact?tab=readme-ov-file#altering-compressions-level-speed-v-size
PR-URL: https://github.com/nodejs/node/pull/59785
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com>
 2025-09-08 14:51:37 +00:00
Anna Henningsen
6cf64af44d repl: do not cause side effects in tab completion 
A number of recent changes to the REPL tab completion logic have
introduced the ability for completion to cause side effects,
specifically, calling arbitrary functions or variable
assignments/updates.

This was first introduced in 07220230d9 and the problem exacerbated in
8ba66c5e7b. Our team noticed this because our tests started failing
when attempting to update to Node.js 20.19.5.

Some recent commits, such as 1093f38c43 or 69453378fc, have
messages or PR descriptions that imply the intention to avoid side
effects, which I can can generally be agreed upon is in line with the
expectations that a user has of autocomplete functionality.
However, some of the tests introduced in those commts specifically
verify that side effects *can* happen under specific circunmstances.
I am assuming here that this is unintentional, and the corresponding
tests have been removed/replaced in this commit.

Fixes: https://github.com/nodejs/node/issues/59731
Fixes: https://github.com/nodejs/node/issues/58903
Refs: https://github.com/nodejs/node/pull/58709
Refs: https://github.com/nodejs/node/pull/58775
Refs: https://github.com/nodejs/node/pull/57909
Refs: https://github.com/nodejs/node/pull/58891
PR-URL: https://github.com/nodejs/node/pull/59774
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
 2025-09-08 13:54:45 +00:00