OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
32,735 Commits 30 Branches 683 Tags
59af4e6acdd140b672dd809bfd754b7d87bda137
Commit Graph

32735 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
ZiJian Liu
59af4e6acd perf_hooks: throw ERR_INVALID_ARG_VALUE if histogram.percentile param is NaN 
Fixes: https://github.com/nodejs/node/issues/36936

PR-URL: https://github.com/nodejs/node/pull/36937
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-01-18 13:32:27 -08:00
raisinten
9a18bf2f8c repl: refactor to avoid unsafe array iteration 
PR-URL: https://github.com/nodejs/node/pull/36663
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-01-18 13:29:43 -08:00
James M Snell
408e9d3a3a doc: add performance notes for fs.readFile 
Issue https://github.com/nodejs/node/issues/25741 discusses a number of
performance considerations for fs.readFile, which was changed in Node.js
10.x to split discreet chunk reads over multiple event loop turns. While
the fs.readFile() operation is certainly slower than it was pre 10.x,
it's unlikely to be faster. Document the performance consideration and
link back to the issue for more in depth analysis.

Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: https://github.com/nodejs/node/issues/25741

PR-URL: https://github.com/nodejs/node/pull/36880
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-01-18 13:00:46 -08:00
Antoine du Hamel
88153dc175 module: simplify tryStatSync with throwIfNoEntry option 
PR-URL: https://github.com/nodejs/node/pull/36971
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-01-18 11:04:14 -08:00
Pooja D P
090f0cd7b6 doc: clarify maxSockets option of http.Agent 
PR-URL: https://github.com/nodejs/node/pull/36941
Fixes: https://github.com/nodejs/node/issues/36463
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-01-18 10:59:23 -08:00
Rich Trott
a8d8ca3089 doc: remove pull-requests.md preamble 
Refs: https://github.com/nodejs/TSC/issues/864#issuecomment-628646560

PR-URL: https://github.com/nodejs/node/pull/36960
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-01-18 10:56:12 -08:00
ZiJian Liu
06c46934c1 events: remove error listener on signal abort 
Fixes: https://github.com/nodejs/node/issues/36949

PR-URL: https://github.com/nodejs/node/pull/36969
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-01-18 10:53:03 -08:00
Antoine du Hamel
9d7fb229db doc: fix module.isPreloading documentation 
Fixes: https://github.com/nodejs/node/issues/36775

PR-URL: https://github.com/nodejs/node/pull/36944
Refs: https://github.com/nodejs/node/pull/36263
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-01-18 10:37:52 -08:00
Benjamin Coe
afd911c38c deps: V8: cherry-pick fe191e8d05cc 
Original commit message:

    [coverage] optional chaining coverage

    Implement coverage tracking for optional chains.

    Bug: v8:10060
    Change-Id: I4f29eda64b6d859939f5f58f4fabead649905795
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2573013
    Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: Gus Caplan <snek@chromium.org>
    Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Benjamin Coe <bencoe@google.com>
    Cr-Commit-Position: refs/heads/master@{#72075}

Refs: fe191e8d05

PR-URL: https://github.com/nodejs/node/pull/36956
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-01-18 19:06:56 +01:00
James M Snell
bd899bc656 crypto: experimental (Ed/X)25519/(Ed/X)448 support 
Implements initial experimental support for Curve25519 and
Curve448 support for both ECDH and sign/verify in Web Crypto.

Introduced as a Node.js-specific extension to Web Crypto.

Signed-off-by: James M Snell <jasnell@gmail.com>
Fixes: https://github.com/nodejs/node/issues/36076

PR-URL: https://github.com/nodejs/node/pull/36879
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2021-01-18 08:12:08 -08:00
Filip Skokan
51e77b3ee8 doc: fix crypto.generateKeySync aes allowed length list 
PR-URL: https://github.com/nodejs/node/pull/36928
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-01-18 15:19:06 +01:00
Dan Dascalescu
75a73c4fb1 doc: fix grammar and link to QUIC in changelog 
PR-URL: https://github.com/nodejs/node/pull/36959
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
 2021-01-18 15:05:21 +01:00
cjihrig
568b26ac6e tools: update ESLint to 7.18.0 
Update ESLint to 7.18.0

PR-URL: https://github.com/nodejs/node/pull/36955
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-01-18 12:12:05 +01:00
Ruy Adorno
1f287b04a2 deps: upgrade npm to 7.4.2 
PR-URL: https://github.com/nodejs/node/pull/36953
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-01-18 12:10:57 +01:00
Filip Skokan
f8ab632d56 buffer: add base64url encoding option 
PR-URL: https://github.com/nodejs/node/pull/36952
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2021-01-18 12:08:20 +01:00
Juan José Arboleda
9e7d1a1c24 test: improve coverage for Module getters 
PR-URL: https://github.com/nodejs/node/pull/36950
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-01-18 12:05:51 +01:00
raisinten
b0036430bb doc: fix percentile range in perf_hooks.md 
The value accepted by histogram.percentile may be below 1 too.

PR-URL: https://github.com/nodejs/node/pull/36938
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-01-18 12:04:16 +01:00
Ruy Adorno
887f199dd1 test: skip internet for test-npm-install 
Disabling any internet-required features (namely audit and
update-notifer) in order for the test to work without an internet
connection.

- Fixes: https://github.com/nodejs/node/issues/36895

PR-URL: https://github.com/nodejs/node/pull/36933
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-01-18 12:01:42 +01:00
Guy Bedford
ac2c8c530d doc: fixup http.IncomingMessage deprecation code 
PR-URL: https://github.com/nodejs/node/pull/36917
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-01-18 11:58:56 +01:00
Juan José Arboleda
068efba973 test: improve coverage on worker threads 
PR-URL: https://github.com/nodejs/node/pull/36910
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-01-18 11:56:20 +01:00
Juan José Arboleda
d58b83d61f doc: improve perf_hooks docs 
PR-URL: https://github.com/nodejs/node/pull/36909
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-01-18 11:52:54 +01:00
ZiJian Liu
95660832d1 url: align url format behavior with browsers 
Fixes: https://github.com/nodejs/node/issues/36887

PR-URL: https://github.com/nodejs/node/pull/36903
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
 2021-01-18 11:50:04 +01:00
Juan José Arboleda
146f0fc495 test: improve coverage at lib/internal/vm/module.js 
PR-URL: https://github.com/nodejs/node/pull/36898
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2021-01-18 11:47:47 +01:00
Rod Vagg
5716130d1e Revert "test: mark test-cluster-bind-privileged-port flaky on arm" 
This reverts commit a45a404197.

Solved by marking ports <1024 as privileged on Docker containers.

Ref: https://github.com/nodejs/node/pull/36850
Ref: https://github.com/nodejs/node/issues/36847
Ref: https://github.com/nodejs/build/pull/2521

PR-URL: https://github.com/nodejs/node/pull/36884
Refs: https://github.com/nodejs/node/pull/36850
Refs: https://github.com/nodejs/node/issues/36847
Refs: https://github.com/nodejs/build/pull/2521
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Ash Cripps <acripps@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2021-01-18 11:46:03 +01:00
Antoine du Hamel
983e9222ca lib: expose primordials object 
Expose the internal `primordials` object to help with Node.js core
development.

```console
$ node --expose-internals -r internal/test/binding lib/fs.js
(node:5299) internal/test/binding: These APIs are for internal testing
only. Do not use them.
(Use `node --trace-warnings ...` to show where the warning was created)
```

PR-URL: https://github.com/nodejs/node/pull/36872
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-01-18 11:43:32 +01:00
ExE Boss
78ca54ce15 lib: refactor primordials.makeSafe to use more primordials 
PR-URL: https://github.com/nodejs/node/pull/36865
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-01-18 11:37:56 +01:00
zhangyongsheng
7efada695f url: expose urlToHttpOptions utility 
PR-URL: https://github.com/nodejs/node/pull/35960
Fixes: https://github.com/nodejs/node/issues/34349
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-01-17 17:06:22 +08:00
Rich Trott
f658bd1e8f doc: fix invalid HTML in doc template 
Move the script tag for dark mode support inside the body tag.

PR-URL: https://github.com/nodejs/node/pull/36930
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-01-16 19:11:58 -08:00
James M Snell
433afd9e39 test: fixup flaky test-crypto-x509 on windows 
PR-URL: https://github.com/nodejs/node/pull/36966
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-01-17 00:19:36 +01:00
Robert Nagy
e39a3f86bf http: refactor ClientRequest destroy 
PR-URL: https://github.com/nodejs/node/pull/36863
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2021-01-16 17:07:35 +01:00
Robert Nagy
963dec304d http: cleanup ClientRequest oncreate 
PR-URL: https://github.com/nodejs/node/pull/36862
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Daniele Belardi <dwon.dnl@gmail.com>
 2021-01-16 16:32:13 +01:00
Rich Trott
f64ad30c35 doc: remove issue template duplication from contributing docs 
The replicated issue template is out of date. There isn't much reason to
replicate it here anyway, so let's remove it and describe what the user
should do briefly.

PR-URL: https://github.com/nodejs/node/pull/36908
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-01-15 21:24:24 -08:00
Rich Trott
2afbfb0ac2 doc: remove resolving-a-bug-report from contributing docs 
This section isn't particularly useful in this context and contributes
to making the document longer and less effective. This is part of a
larger effort to make the contributing docs brief, informative, and
friendly.

Refs: https://github.com/nodejs/TSC/issues/864#issuecomment-628646560

PR-URL: https://github.com/nodejs/node/pull/36905
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-01-15 21:22:03 -08:00
Antoine du Hamel
88a5426e9c doc: use ESM syntax for WASI example 
PR-URL: https://github.com/nodejs/node/pull/36848
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
 2021-01-16 00:32:41 +01:00
Antoine du Hamel
49f900e42d tools: add support for top-level await syntax in linter 
PR-URL: https://github.com/nodejs/node/pull/36911
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-01-16 00:31:43 +01:00
Ian Sutherland
9237280559 doc: add iansu to collaborators 
PR-URL: https://github.com/nodejs/node/pull/36951
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
 2021-01-15 12:48:19 -07:00
James M Snell
cd37535d2c doc: fixup typo in metadata entry 
PR-URL: https://github.com/nodejs/node/pull/36947
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-01-15 19:25:43 +01:00
Antoine du Hamel
0fd9bbbb24 http2: refactor to avoid unsafe array iteration 
PR-URL: https://github.com/nodejs/node/pull/36700
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-01-15 19:23:32 +01:00
Tobias Nießen
d7b18662c6 test: check mustCall errors in test-fs-read-type 
PR-URL: https://github.com/nodejs/node/pull/36914
Refs: https://github.com/nodejs/node/pull/36190
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-01-15 18:13:25 +01:00
Tobias Nießen
ccc6776527 test: fix variable name for non-RSA keys 
PR-URL: https://github.com/nodejs/node/pull/36912
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-01-15 18:11:43 +01:00
Filip Skokan
0f57902118 doc: add alternative version links to the packages page 
PR-URL: https://github.com/nodejs/node/pull/36915
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
 2021-01-15 17:16:24 +01:00
Milad Fa
d22f16d6e7 doc: add miladfarca to collaborators 
PR-URL: https://github.com/nodejs/node/pull/36934
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Pooja D P <Pooja.D.P@ibm.com>
 2021-01-15 09:28:16 -05:00
Mateusz Krawczuk
8cf5281da2 tls: use recently added matching SecureContext in default SNICallback 
PR-URL: https://github.com/nodejs/node/pull/36072
Fixes: https://github.com/nodejs/node/issues/34110
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2021-01-15 04:48:41 -08:00
Danielle Adams
0f789488d4 2021-01-14, Version 15.6.0 (Current) 
PR-URL: https://github.com/nodejs/node/pull/36889

Notable changes:

* child_process:
  * add 'overlapped' stdio flag (Thiago Padilha) (https://github.com/nodejs/node/pull/29412)
  * support AbortSignal in fork (Benjamin Gruenbaum) (https://github.com/nodejs/node/pull/36603)
* crypto:
  * implement basic secure heap support (James M Snell) (https://github.com/nodejs/node/pull/36779)
  * fixup bug in keygen error handling (James M Snell) (https://github.com/nodejs/node/pull/36779)
  * introduce X509Certificate API (James M Snell) (https://github.com/nodejs/node/pull/36804)
  * implement randomuuid (James M Snell) (https://github.com/nodejs/node/pull/36729)
* doc:
  * update release key for Danielle Adams (Danielle Adams) (https://github.com/nodejs/node/pull/36793)
  * add dnlup to collaborators (Daniele Belardi) (https://github.com/nodejs/node/pull/36849)
  * add panva to collaborators (Filip Skokan) (https://github.com/nodejs/node/pull/36802)
  * add yashLadha to collaborator (Yash Ladha) (https://github.com/nodejs/node/pull/36666)
* http:
  * set lifo as the default scheduling strategy in Agent (Matteo Collina) (https://github.com/nodejs/node/pull/36685)
* net:
  * support abortSignal in server.listen (Nitzan Uziely) (https://github.com/nodejs/node/pull/36623)
* process:
  * add direct access to rss without iterating pages (Adrien Maret) (https://github.com/nodejs/node/pull/34291)
* v8:
  * fix native  constructors (ExE Boss) (https://github.com/nodejs/node/pull/36549)
 2021-01-14 19:58:43 -05:00
Michael Dawson
00cc39ec44 doc: update tls test to use better terminology 
Given the effort to change the master branch to main,
this may make sense as part of removing other references
to the offending wording as well.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/36851
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-01-14 18:30:08 -05:00
Tobias Nießen
4db9854d6e crypto: fix randomInt bias 
Co-authored-by: Andrey Pechkurov <apechkurov@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/36894
Refs: https://github.com/nodejs/node/pull/34600
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-01-14 22:21:55 +01:00
Rich Trott
9886d5ebf9 doc: remove unnecessary contributing.md section 
Remove "How to Contribute in Issues". This is not Node.js-specific and
is likely to cause many readers to tune out. If we want to include this
kind of how-all-issue-trackers-are-intended-to-work information, let's
link to an external source. But I think it's OK to simply remove it.

Refs: https://github.com/nodejs/TSC/issues/864#issuecomment-628646560

PR-URL: https://github.com/nodejs/node/pull/36891
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2021-01-14 09:03:54 -08:00
Mattia Pontonio
2ba8728b9f doc: wrap TOC in a <details> tag 
PR-URL: https://github.com/nodejs/node/pull/36896
Fixes: https://github.com/nodejs/node/issues/36885
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-01-14 16:35:59 +01:00
Filip Skokan
1772ae7029 crypto: add keyObject.asymmetricKeyDetails for asymmetric keys 
This API exposes key details. It is conceptually different from the
previously discussed keyObject.fields property since it does not give
access to information that could compromise the security of the key, and
the obtained information cannot be used to uniquely identify a key.

The intended purpose is to determine "security properties" of keys, e.g.
to generate a new key pair with the same parameters, or to decide
whether a key is secure enough.

closes #30045

PR-URL: https://github.com/nodejs/node/pull/36188
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-01-14 14:24:48 +01:00
Andrew Casey
8f327338d3 doc: update fs.l/statSync API history for throwIfNoEntry 
PR-URL: https://github.com/nodejs/node/pull/36882
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-01-13 16:09:58 -08:00