OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
41,937 Commits 30 Branches 683 Tags
552df3edabbf1a30c8fbee165e090fceb92e466e
Commit Graph

41937 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
dependabot[bot]
552df3edab meta: bump step-security/harden-runner from 2.8.1 to 2.9.0 
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner) from 2.8.1 to 2.9.0.
- [Release notes](https://github.com/step-security/harden-runner/releases)
- [Commits](17d0e2bd7d...0d381219dd)

---
updated-dependencies:
- dependency-name: step-security/harden-runner
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/54169
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2024-08-06 07:45:01 +02:00
dependabot[bot]
6edbc04a3b meta: bump actions/setup-node from 4.0.2 to 4.0.3 
Bumps [actions/setup-node](https://github.com/actions/setup-node) from 4.0.2 to 4.0.3.
- [Release notes](https://github.com/actions/setup-node/releases)
- [Commits](60edb5dd54...1e60f620b9)

---
updated-dependencies:
- dependency-name: actions/setup-node
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/54170
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-08-06 07:44:12 +02:00
dependabot[bot]
e55eb45d34 meta: bump github/codeql-action from 3.25.11 to 3.25.15 
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.11 to 3.25.15.
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](b611370bb5...afb54ba388)

---
updated-dependencies:
- dependency-name: github/codeql-action
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/54168
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-08-06 07:43:19 +02:00
dependabot[bot]
28adfbe746 meta: bump ossf/scorecard-action from 2.3.3 to 2.4.0 
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.3 to 2.4.0.
- [Release notes](https://github.com/ossf/scorecard-action/releases)
- [Changelog](https://github.com/ossf/scorecard-action/blob/main/RELEASE.md)
- [Commits](dc50aa9510...62b2cac7ed)

---
updated-dependencies:
- dependency-name: ossf/scorecard-action
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/54171
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2024-08-06 01:59:22 +02:00
sendoru
a5200da1d0 doc: move onread option from socket.connect() to new net.socket() 
Fixes: https://github.com/nodejs/node/issues/53792
PR-URL: https://github.com/nodejs/node/pull/54194
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>
 2024-08-05 23:36:20 +00:00
James M Snell
926503b669 src: shift more crypto impl details to ncrypto 
PR-URL: https://github.com/nodejs/node/pull/54028
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2024-08-05 14:01:21 -07:00
Joyee Cheung
c6aeddf140 sea: don't set code cache flags when snapshot is used 
When both useCodeCache and useSnapshot are set, we generate the
snapshot and skip the generation of the code cache since the
snapshot already includes the code cache. But we previously still
persist the code cache setting in the flags that got serialized
into the SEA, so the resulting executable would still try to read
the code cache even if it's not added to the SEA, leading to a flaky
crash caused by OOB on some platforms.

This patch fixes the crash by ignoring the code cache setting when
generating the flag if both snapshot and code cache is configured.

PR-URL: https://github.com/nodejs/node/pull/54120
Fixes: https://github.com/nodejs/node/issues/50740
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2024-08-05 16:48:12 +00:00
Aviv Keller
981b5e3279 doc, meta: replace command with link to keys 
PR-URL: https://github.com/nodejs/node/pull/53745
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2024-08-05 16:39:58 +00:00
Node.js GitHub Bot
b95eac5061 deps: update amaro to 0.0.6 
PR-URL: https://github.com/nodejs/node/pull/54199
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2024-08-05 17:13:42 +02:00
Node.js GitHub Bot
ec7ee6c95e deps: update amaro to 0.0.5 
PR-URL: https://github.com/nodejs/node/pull/54199
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2024-08-05 17:13:37 +02:00
Richard Lau
bc6f895030 doc: move release key for Myles Borins 
Myles has stepped down as a releaser. Move his key in `README.md`
to the "Other keys used to sign some previous releases" section.

PR-URL: https://github.com/nodejs/node/pull/54059
Refs: https://github.com/nodejs/Release/pull/1024
Refs: https://github.com/nodejs/Release/blob/main/GOVERNANCE.md#offboarding-releasers
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
 2024-08-05 15:07:42 +00:00
James M Snell
cf21220893 src: move spkac methods to ncrypto 
PR-URL: https://github.com/nodejs/node/pull/53985
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2024-08-05 07:37:31 -07:00
Michaël Zasso
046343ea9d build: warn for GCC versions earlier than 12.2 
Update the warning threshold for GCC to 12.2 starting from Node.js 23.
Builds can still proceed with earlier versions of GCC, but are not
guaranteed to work.

PR-URL: https://github.com/nodejs/node/pull/54081
Refs: https://github.com/nodejs/build/issues/3806
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2024-08-05 13:25:44 +00:00
Kohei Ueno
3616ace637 inspector: provide detailed info to fix DevTools frontend errors 
PR-URL: https://github.com/nodejs/node/pull/54156
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2024-08-05 12:30:45 +00:00
jakecastelli
fafc845089 stream: make checking pendingcb on WritableStream backward compatible 
PR-URL: https://github.com/nodejs/node/pull/54142
Fixes: https://github.com/nodejs/node/issues/54131
Refs: https://github.com/nodejs/node/issues/54131
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2024-08-05 12:30:29 +00:00
Marek Piechut
a8166880f1 watch: reload changes in contents of --env-file 
Make sure we watch and reload on env file changes.

Ignore env file in parent process, so child process can reload
current vars when we recreate it.

Fixes: https://github.com/nodejs/node/issues/54001
PR-URL: https://github.com/nodejs/node/pull/54109
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-08-05 10:41:33 +00:00
Marco Ippolito
b3013e120a tools: add strip-types to label system 
PR-URL: https://github.com/nodejs/node/pull/54185
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2024-08-05 07:14:55 +00:00
Colin Ihrig
ca2ed88f94 test_runner: remove outdated comment 
Network imports were removed, so remove the comment.

Refs: https://github.com/nodejs/node/pull/53822
PR-URL: https://github.com/nodejs/node/pull/54146
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-08-05 14:54:52 +09:30
YoonSoo_Shin
e6ee6e2901 lib: fix typos in comments within internal/streams 
fixed typos in comments within the internal/streams directory.

PR-URL: https://github.com/nodejs/node/pull/54093
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2024-08-05 01:58:40 +00:00
Roberto Simonini
a3cd290f24 buffer: add JSDoc to blob bytes method 
PR-URL: https://github.com/nodejs/node/pull/54117
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2024-08-05 00:29:07 +00:00
Liran Tal
c6cf313bca doc: refresh instructions for building node from source 
- Organize the prerequisites sub-header properly
- Add a note about memory limit

PR-URL: https://github.com/nodejs/node/pull/53768
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2024-08-04 22:35:41 +00:00
Colin Ihrig
67f713731c test_runner: run after hooks even if test is aborted 
If a test is run, but aborted, any after hooks should still be
run, as they may need to perform cleanup.

PR-URL: https://github.com/nodejs/node/pull/54151
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
 2024-08-04 15:56:04 +00:00
jaexxin
76d10a10fb doc: add documentation for blob.bytes() method 
PR-URL: https://github.com/nodejs/node/pull/54114
Fixes: https://github.com/nodejs/node/issues/54105
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
 2024-08-05 00:25:32 +09:30
Rafael Gonzaga
ea5e77b1a5 benchmark: use assert.ok instead of assert 
PR-URL: https://github.com/nodejs/node/pull/54176
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-08-04 13:29:34 +00:00
Sonny
bd42e4c6a7 test: fix typo in test 
PR-URL: https://github.com/nodejs/node/pull/54137
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
 2024-08-04 07:03:24 +00:00
Sonny
d172da8d01 test: add initial pull delay and prototype pollution prevention tests 
Refs : https://github.com/nodejs/node/blob/main/lib/internal/webstreams/readablestream.js#L522-L536
PR-URL: https://github.com/nodejs/node/pull/54061
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-08-03 19:52:44 +00:00
Marco Ippolito
5d6c76adee module: fix strip-types interaction with detect-module 
PR-URL: https://github.com/nodejs/node/pull/54164
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2024-08-03 17:15:11 +00:00
Robert Nagy
acbd0be0da buffer: faster type check 
Also add support for any TypedArray as target.

PR-URL: https://github.com/nodejs/node/pull/54088
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2024-08-03 17:15:03 +00:00
Rafael Gonzaga
358ff748ea lib,permission: support Buffer to permission.has 
PR-URL: https://github.com/nodejs/node/pull/54104
Fixes: https://github.com/nodejs/node/issues/54100
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2024-08-03 16:46:57 +00:00
Eddie Abbondanzio
492032f34c doc: add missing new lines to custom test reporter examples 
PR-URL: https://github.com/nodejs/node/pull/54152
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
 2024-08-03 01:41:55 +00:00
Stephen Belanger
d1229eeca4 lib: rewrite AsyncLocalStorage without async_hooks 
PR-URL: https://github.com/nodejs/node/pull/48528
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
 2024-08-02 19:44:20 +00:00
jakecastelli
0c1877a82a test: add coverage for webstorage quota 
PR-URL: https://github.com/nodejs/node/pull/53964
Refs: https://github.com/nodejs/node/issues/53871
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2024-08-02 22:58:36 +09:30
Thomas Hunter II
13ca021da3 doc: fix worker threadId/destination typo 
PR-URL: https://github.com/nodejs/node/pull/53933
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
 2024-08-02 10:45:49 +00:00
Antoine du Hamel
1e3a3470a5 build: add --without-amaro build flag 
PR-URL: https://github.com/nodejs/node/pull/54136
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2024-08-02 10:37:36 +00:00
Antoine du Hamel
2f7a354f14 doc: update list of Triagers on the README.md 
PR-URL: https://github.com/nodejs/node/pull/54138
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-08-02 10:27:47 +00:00
Robert Nagy
76c8ba9d9b buffer: use native copy impl 
PR-URL: https://github.com/nodejs/node/pull/54087
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
 2024-08-02 09:19:41 +00:00
Jungku Lee
8e1e3a8dea typings: add missing binding function writeFileUtf8() 
PR-URL: https://github.com/nodejs/node/pull/54110
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2024-08-01 16:21:57 +00:00
Michaël Zasso
00c0644747 module: remove outdated comment 
Refs: https://github.com/nodejs/node/pull/53822
PR-URL: https://github.com/nodejs/node/pull/54118
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2024-08-01 12:41:00 +02:00
Rich Trott
e2b7e41e23 child_process: remove unused internal event 
Tests pass without this event being emitted. Remove it.

PR-URL: https://github.com/nodejs/node/pull/53793
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2024-08-01 03:07:10 +00:00
jakecastelli
1fd170a7fc stream: throw TypeError when criteria fulfilled in getIterator 
PR-URL: https://github.com/nodejs/node/pull/53825
Fixes: https://github.com/nodejs/node/issues/53819
Refs: https://github.com/nodejs/node/issues/53819
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2024-08-01 02:00:47 +00:00
Yelim Koo
7941b4b333 doc: remove unused imports from worker_threads.md 
PR-URL: https://github.com/nodejs/node/pull/54147
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-07-31 17:11:13 +00:00
Shelley Vohr
67bc6a4a3e src: account for OpenSSL unexpected version 
PR-URL: https://github.com/nodejs/node/pull/54038
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2024-07-31 14:52:39 +00:00
Marco Ippolito
4d1d88118b meta: add typescript team to codeowners 
PR-URL: https://github.com/nodejs/node/pull/54101
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2024-07-31 12:44:01 +00:00
Liran Tal
49a9ba43cf doc: expand troubleshooting section 
Update the troubleshooting section with regards to
memory requirements and potential errors. This error
specifically happened to me on an Ubuntu host with
2GB of RAM which wasn't enough and g++ error'ed
during Node.js compilation step.

PR-URL: https://github.com/nodejs/node/pull/53808
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2024-07-31 09:42:02 +00:00
Yelim Koo
f212674452 doc: clarify useCodeCache setting for cross-platform SEA generation 
PR-URL: https://github.com/nodejs/node/pull/53994
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2024-07-31 09:01:38 +00:00
Early Riser
b4fd1fd63f url: improve resolveObject with ObjectAssign 
PR-URL: https://github.com/nodejs/node/pull/54092
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
 2024-07-31 06:17:59 +00:00
Robert Nagy
e7edcf38cd buffer: use faster integer argument check 
PR-URL: https://github.com/nodejs/node/pull/54089
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Lemire <daniel@lemire.me>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2024-07-30 22:29:51 +00:00
Benjamin Pasero
f9f9a421a8 path: use the correct name in validateString 
The parameter was renamed from `ext` to `suffix`
but not in the `validateString` call.

PR-URL: https://github.com/nodejs/node/pull/53669
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2024-07-30 16:59:47 +02:00
Node.js GitHub Bot
4d1cc7618e tools: update eslint to 9.8.0 
PR-URL: https://github.com/nodejs/node/pull/54073
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2024-07-30 16:56:04 +02:00
Node.js GitHub Bot
8f9c660d92 deps: update corepack to 0.29.3 
PR-URL: https://github.com/nodejs/node/pull/54072
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
 2024-07-30 16:54:52 +02:00