OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
34,390 Commits 30 Branches 683 Tags
46598b88bfaecbad92492b03758c3dcc69d5e4d0
Commit Graph

34390 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Maël Nison
46598b88bf deps: add corepack 
Corepack provides shims for Yarn and pnpm in order to soften the
developer experience when working on Node projects.

Refs: https://github.com/nodejs/node/issues/15244
Refs: https://github.com/nodejs/TSC/issues/904

PR-URL: https://github.com/nodejs/node/pull/39608
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-08-25 07:55:32 -07:00
Brian White
f581f6da94 url: fix performance regression 
PR-URL: https://github.com/nodejs/node/pull/39778
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
 2021-08-25 16:40:29 +02:00
Shelley Vohr
eeb86fbbfa src: remove extra semicolons outside fns 
PR-URL: https://github.com/nodejs/node/pull/39800
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-08-25 09:48:25 +02:00
Felix Yan
2d503ed3ff deps: V8: backport 239898ef8c77 
Original commit message:

    [PATCH] [riscv64] Fix node.js build failed

    Change-Id: I0a614fa6c381770f56037f0401db008a37c71dca
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2966209
    Auto-Submit: Yahan Lu <yahan@iscas.ac.cn>
    Commit-Queue: Ji Qiu <qiuji@iscas.ac.cn>
    Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
    Cr-Commit-Position: refs/heads/master@{#75199}

Refs: 239898ef8c

PR-URL: https://github.com/nodejs/node/pull/39827
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-08-25 09:45:44 +02:00
Rich Trott
cee024a87e tools: update workflow to open a pull request 
Now that find-inactive-collaborators.mjs automates the README.md changes
to move the inactive collaborators to the emeriti section, update the
GitHub Actions workflow to open a pull request.

PR-URL: https://github.com/nodejs/node/pull/39825
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-25 04:22:25 +00:00
Rich Trott
67f96dd85e tools: use find-inactive-collaborators to modify README.md 
Update find-inactive-collaborators to move inactive collaborators to the
emeriti section of README.md.

PR-URL: https://github.com/nodejs/node/pull/39825
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-25 04:22:24 +00:00
Mestery
0d88c141cb build: fix update authors commit 
Refs: https://github.com/nodejs/node/pull/39855#issuecomment-904387651

PR-URL: https://github.com/nodejs/node/pull/39858
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-08-24 13:53:45 +00:00
Daniel Bevenius
a2115450eb doc: add duplicate CVE check in sec. release doc 
This commit adds a note about only creating a CVE for Node.js
vulnerabilities.

The motivation for this is a recent HackerOne report where I created a
CVE for a c-ares issue. This CVE should have been created by the c-ares
project, and it was later, but we never updated our HackerOne report to
use their CVE number. Hopefully this extra note in the release doc will
help us check for this situaion and avoid this in the future.

PR-URL: https://github.com/nodejs/node/pull/39845
Refs: https://hackerone.com/reports/1178337
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-24 05:58:16 +02:00
Tierney Cyren
02c5120d2a build: add authors.yml 
PR-URL: https://github.com/nodejs/node/pull/35831
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2021-08-23 17:12:02 -07:00
Michaël Zasso
0df6f4edd2 doc: improve description of the triagers team 
PR-URL: https://github.com/nodejs/node/pull/39833
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-23 14:42:28 +00:00
Darshan Sen
3b4ad54fbe deps: V8: cherry-pick 00bb1a77c03e 
Original commit message:

    [date] Fix Date#getMinutes() test failures

    After building V8 using Clang (./out/x64.release/v8_build_config.json
    says that "is_clang" is true), I could reproduce the referenced bug
    report locally. Replacing the getMinutes() calls with getUTCMinutes()
    calls fixed the test failure.

    Signed-off-by: Darshan Sen <raisinten@gmail.com>
    Bug: v8:11200
    Change-Id: Ia36be481f2c8728380d550ead856ef8e51b1069c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3093362
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76367}

Refs: 00bb1a77c0
Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: https://github.com/nodejs/node/pull/39829
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-08-23 14:31:29 +00:00
Michael Dawson
15f92ee837 doc: update instructions for cc 
- update intructions on adding cc for email to
  nodejs-sec mailing list as UI does not allow it
  to be done directly.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/39674
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-08-23 09:23:46 -04:00
Jiawen Geng
28113ed92e tools: update gyp-next to v0.9.5 
PR-URL: https://github.com/nodejs/node/pull/39818
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2021-08-23 07:48:13 +00:00
Luigi Pinca
0073831482 doc: move util.toUSVString() outside of deprecated group 
Refs: https://github.com/nodejs/node/pull/39814/files#r693445849

PR-URL: https://github.com/nodejs/node/pull/39840
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-08-22 08:08:48 +00:00
Robert Nagy
82ae00cae4 util: expose toUSVString 
Expose toUSVString so it can be used by user libraries.

PR-URL: https://github.com/nodejs/node/pull/39814
Refs: https://github.com/nodejs/undici/pull/986
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-22 07:08:00 +02:00
Rich Trott
11109470b7 tools: fix markdown linting 
This updates remark-preset-lint-node to 3.0.1, which actually works
unlike the 3.0.0 version we're using. (Sorry about 3.0.0 not actually
linting!)

It also updates rollup and the rollup config. So this uses the
latest everything as of this writing.

PR-URL: https://github.com/nodejs/node/pull/39832
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-08-22 04:13:32 +00:00
cjihrig
1deafcd653 fs: combine require() and destructure 
This commit combines two require() calls and subsequent
destructuring operations.

PR-URL: https://github.com/nodejs/node/pull/39806
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-21 15:37:00 +00:00
Antoine du Hamel
af45be715a tools: update markdown linter dependencies and move to ESM 
PR-URL: https://github.com/nodejs/node/pull/39801
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-21 06:16:34 -07:00
Darshan Sen
e58592e49f src: call overload ctor from the original ctor 
Call the new constructor overload from the original constructor to
reduce code duplication.

Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: https://github.com/nodejs/node/pull/39768
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
 2021-08-21 06:53:50 +00:00
Darshan Sen
16853c9d55 src: add a constructor overload for CallbackScope 
This overload accepts the current Environment* as an argument, unlike
the other constructor, which accepts an Isolate*. This is useful because
we can pass the current Environment* directly instead of recomputing it
from the Isolate* inside the constructor.

Signed-off-by: Darshan Sen <darshan.sen@postman.com>

PR-URL: https://github.com/nodejs/node/pull/39768
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
 2021-08-21 06:53:50 +00:00
npm team
248f4c3764 deps: upgrade npm to 7.21.0 
PR-URL: https://github.com/nodejs/node/pull/39813
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2021-08-20 14:53:49 +02:00
mary marchini
279162cf98 meta: add gyp as owner of gyp files and tools/gyp 
Co-authored-by: Jiawen Geng <technicalcute@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/34847
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-20 20:51:52 +08:00
Rich Trott
f6ee27fe67 tools: update rollup to latest version in markdown linter 
PR-URL: https://github.com/nodejs/node/pull/39797
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-08-20 02:25:25 +00:00
Bradley Farias
90e2e78763 policy: canonicalize before resolving specifiers 
PR-URL: https://github.com/nodejs/node/pull/37863
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Co-authored-by: James M Snell <jasnell@gmail.com>

Reviewed-By: Guy Bedford <guybedford@gmail.com>
 2021-08-19 12:43:21 -05:00
Don Jayamanne
3fe92a2554 repl: fix tla function hoisting 
PR-URL: https://github.com/nodejs/node/pull/39745
Fixes: https://github.com/nodejs/node/issues/39744
Reviewed-By: Guy Bedford <guybedford@gmail.com>
 2021-08-19 09:14:31 -07:00
Danielle Adams
7ca38f05a0 2021-08-17, Version 16.7.0 (Current) 
Notable changes:

* fs:
  * experimental: add recursive cp method (Benjamin Coe) https://github.com/nodejs/node/pull/39372

PR-URL: https://github.com/nodejs/node/pull/39782
 2021-08-17 21:09:13 -04:00
Antoine du Hamel
f41893ee85 doc: deprecate type coercion for dns.lookup options 
PR-URL: https://github.com/nodejs/node/pull/38906
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-08-17 10:20:06 -07:00
Antoine du Hamel
58a45e3c91 doc: deprecate using non-boolean values in the verbatim option 
PR-URL: https://github.com/nodejs/node/pull/38906
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-08-17 10:20:04 -07:00
Cheng Zhao
fae352a0f5 build: add option to hide console window 
Adds a Environment flag to allow embedders to set CREATE_NO_WINDOW
property when spawning processes, which is useful for GUI programs
that do not want to show console windows when running terminal
commands.

PR-URL: https://github.com/nodejs/node/pull/39712
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Shelley Vohr <shelley.vohr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-17 10:17:16 -07:00
Rich Trott
f42d7a4552 doc: fix malformed changelog entries 
PR-URL: https://github.com/nodejs/node/pull/39791
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2021-08-17 07:49:12 -07:00
Rich Trott
71abf54750 doc: fix lint errors in packages.md 
Code samples that use CJS-only syntax need to use the cjs markdown
identifiers.

PR-URL: https://github.com/nodejs/node/pull/39792
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2021-08-17 07:10:46 -07:00
Rich Trott
f7a2aec650 tools: update markdown lint dependencies 
PR-URL: https://github.com/nodejs/node/pull/39770
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2021-08-17 13:31:28 +00:00
Jesús Leganés-Combarro 'piranna
fe4d562dd9 doc: add example of self-reference in scoped packages 
PR-URL: https://github.com/nodejs/node/pull/37630
Fixes: https://github.com/nodejs/node/issues/37618
Refs: https://github.com/nodejs/node/issues/37618#issuecomment-791888177
Co-authored-by: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
 2021-08-17 11:19:22 +02:00
Himadri Ganguly
0e55a75ccd doc: add himadriganguly as a triager 
I would like to apply for the role of a triager in this project.
My motivation to become a triager is to help manage issues, as well as
learn deeper concepts of Node.js, and eventually become a collaborator!
I hereby declare that I have read and understood the Code of Conduct
and will adhere to that.

PR-URL: https://github.com/nodejs/node/pull/39757
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-17 02:36:52 +00:00
James M Snell
966060df0e worker: add brand checks for detached properties/methods 
Add proper brand-checking for detached property and method
accesses. Also adds a note about non-standard APIs and
makes the standard accessors enumerable.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/39763
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2021-08-16 07:09:35 -07:00
Raz Luvaton
e087d78472 doc: correct cjs code to match mjs code 
PR-URL: https://github.com/nodejs/node/pull/39509
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
 2021-08-16 15:49:47 +02:00
Justin
802ceea905 doc: fix typo in hmac.paramNames default 
PR-URL: https://github.com/nodejs/node/pull/39766
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-16 12:29:32 +02:00
Tobias Nießen
fdce138e1d policy: fix integrity when DEFAULT_ENCODING is set 
PR-URL: https://github.com/nodejs/node/pull/39750
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2021-08-15 11:10:12 -07:00
voltrexmaster
b24ab473d5 test: use simplfied validator 
The validators test should use the simplified `validateArray()`
validator.

PR-URL: https://github.com/nodejs/node/pull/39753
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-08-15 11:08:49 -07:00
Voltrex
f037d29abe dgram: use simplified validator 
The `dgram` lib module should use the simplified `validatePort()`
validator.

PR-URL: https://github.com/nodejs/node/pull/39753
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-08-15 11:08:47 -07:00
Voltrex
7b64e16916 lib: simplify validators 
Some of the validators can be simplified by removing unnecessary
object parameters and using validators in another validators to keep
consistency.

PR-URL: https://github.com/nodejs/node/pull/39753
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-08-15 11:08:45 -07:00
James M Snell
e1e669b109 url: throw invalid this on detached accessors 
Previously, using Reflect.get/set or calling a member
method like toString() detached from the instance would
result in an obscure internal error. This adds a proper
brand check and throws `ERR_INVALID_THIS` when appropriate.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/39752
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2021-08-15 07:26:52 -07:00
Rich Trott
75bd4da553 tools: bump remark-preset-lint-node to 3.0.0 
PR-URL: https://github.com/nodejs/node/pull/39755
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
 2021-08-15 12:53:13 +00:00
James M Snell
fcf8ba4269 buffer: add endings option, remove Node.js specific encoding option 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/39708
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-08-14 07:23:54 -07:00
James M Snell
ca19775d0e stream: ensure text() stream consumer flushes correctly 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/39737
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-08-13 15:16:48 -07:00
James M Snell
394c99118d src: fix TextDecoder final flush size calculation 
Flushing a TextDecoder with a zero-sized input and pending
incomplete characters was failing when fatal: false.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/39737
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2021-08-13 15:16:46 -07:00
Rich Trott
1150cfe6eb tools: update path-parse in markdown linter package-lock file 
Refs: https://github.com/advisories/GHSA-hj48-42vr-x3v9

PR-URL: https://github.com/nodejs/node/pull/39729
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2021-08-13 05:56:38 +00:00
Voltrex
ae0cfc95d5 lib: cleanup validation 
Used the `validateInteger()` validator to cleanup validation and keep
consistency.

PR-URL: https://github.com/nodejs/node/pull/39652
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-08-12 15:49:53 -07:00
Voltrex
0b69ac7851 lib: cleanup instance validation 
Cleaned up the `URLSearchParams`'s `this` validation to increase
readability by moving them to an extra helper function.

PR-URL: https://github.com/nodejs/node/pull/39656
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-08-12 14:52:42 -07:00
Voltrex
937bbc5571 lib: use helper for readability 
Used an extra `checkReusedHandle()` helper function to
increase readability.

PR-URL: https://github.com/nodejs/node/pull/39649
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2021-08-12 14:52:01 -07:00