Chengzhong Wu
4211ab56cc
src,build: add no user defined deduction guides of CTAD check
...
PR-URL: https://github.com/nodejs/node/pull/56071
Refs: https://google.github.io/styleguide/cppguide.html#CTAD
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-12-06 09:44:11 +00:00
Node.js GitHub Bot
9cd9f43460
deps: update ngtcp2 to 1.9.1
...
PR-URL: https://github.com/nodejs/node/pull/56095
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2024-12-06 06:53:17 +00:00
Taejin Kim
56c8360f87
lib: add validation for options in compileFunction
...
PR-URL: https://github.com/nodejs/node/pull/56023
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2024-12-06 06:53:06 +00:00
Luigi Pinca
7904bc0976
test: remove test-fs-utimes flaky designation
...
The issue is likely the same as other tests that time out.
Refs: https://github.com/nodejs/node/issues/54918
Refs: https://github.com/nodejs/node/pull/54844
Refs: https://github.com/nodejs/node/pull/54802
PR-URL: https://github.com/nodejs/node/pull/56052
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2024-12-06 06:42:07 +00:00
theanarkh
f26a1da909
net: support blocklist in net.connect
...
PR-URL: https://github.com/nodejs/node/pull/56075
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-12-06 04:36:24 +00:00
Ruy Adorno
660d5335b8
doc: mention -a flag for the release script
...
Document that running `./tools/release.sh` script using the recently
added `-a` CLI flag enables the previously-default interactive interface
to select the correct PGP key.
PR-URL: https://github.com/nodejs/node/pull/56124
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2024-12-05 21:43:08 +00:00
Antoine du Hamel
60e9c6f441
tools: update create-release-proposal workflow
...
PR-URL: https://github.com/nodejs/node/pull/56054
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2024-12-05 20:33:44 +00:00
Rafael Gonzaga
53356c37b7
lib: fix fs.readdir recursive async
...
Fixes: https://github.com/nodejs/node/issues/56006
PR-URL: https://github.com/nodejs/node/pull/56041
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2024-12-05 21:25:25 +01:00
Joyee Cheung
d7fdbb994c
module: mark evaluation rejection in require(esm) as handled
...
Previously the implemention of require(esm) only converted the
rejected promise from module evaluation into an error, but the
rejected promise was still treated as a pending unhandled
rejection by the promise rejection callback, because the promise
is created by V8 internals and we don't get a chance to mark
it as handled, so the rejection incorrectly marked as unhandled
would still go through unhandled rejection handling (if no
global listener is set, the default handling would print a warning
and make the Node.js instance exit with 1).
This patch fixes it by calling into the JS promise rejection
callback to mark the evalaution rejection handled so that
it doesn't go through unhandled rejection handling.
PR-URL: https://github.com/nodejs/node/pull/56122
Fixes: https://github.com/nodejs/node/issues/56115
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
2024-12-05 16:12:50 +00:00
npm CLI robot
839ad8bd08
deps: upgrade npm to 10.9.2
...
PR-URL: https://github.com/nodejs/node/pull/56135
Reviewed-By: Luke Karrys <luke@lukekarrys.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2024-12-05 15:24:47 +00:00
Antoine du Hamel
556f1aece2
test: ensure cli.md is in alphabetical order
...
Co-authored-by: RedYetiDev <redyetidev@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/56025
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-12-05 14:47:14 +01:00
Jordan Harband
c4aa34aa4d
doc: add LJHarb to collaborators
...
Fixes: https://github.com/nodejs/node/issues/55918
PR-URL: https://github.com/nodejs/node/pull/56132
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com >
2024-12-04 11:30:37 -08:00
James M Snell
3c2da4b849
net: add SocketAddress.parse
...
Adds a new `net.SocketAddress.parse(...)` API.
```js
const addr = SocketAddress.parse('123.123.123.123:1234');
console.log(addr.address); // 123.123.123.123
console.log(addr.port); 1234
```
PR-URL: https://github.com/nodejs/node/pull/56076
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2024-12-04 09:29:30 -08:00
James M Snell
c7de0ec86c
net: add net.BlockList.isBlockList(value)
...
PR-URL: https://github.com/nodejs/node/pull/56078
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: theanarkh <theratliter@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
2024-12-04 07:48:30 -08:00
Node.js GitHub Bot
09d5be0cc8
test: update WPT for WebCryptoAPI to 3e3374efde
...
PR-URL: https://github.com/nodejs/node/pull/56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Jason Zhang <xzha4350@gmail.com >
2024-12-04 14:44:35 +00:00
Node.js GitHub Bot
398c9414c8
test: update WPT for WebCryptoAPI to 76dfa54e5d
...
PR-URL: https://github.com/nodejs/node/pull/56093
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Jason Zhang <xzha4350@gmail.com >
2024-12-04 14:44:34 +00:00
Filip Skokan
4e44322413
crypto: ensure CryptoKey usages and algorithm are cached objects
...
PR-URL: https://github.com/nodejs/node/pull/56108
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-12-04 10:46:27 +00:00
Alex Yang
7bedcfd4a2
doc: fix typo
...
PR-URL: https://github.com/nodejs/node/pull/56125
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2024-12-04 02:35:30 +00:00
dependabot[bot]
fe12b01bf4
meta: bump github/codeql-action from 3.27.0 to 3.27.5
...
Bumps [github/codeql-action](https://github.com/github/codeql-action ) from 3.27.0 to 3.27.5.
- [Release notes](https://github.com/github/codeql-action/releases )
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md )
- [Commits](662472033e...f09c1c0a94 )
---
updated-dependencies:
- dependency-name: github/codeql-action
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
PR-URL: https://github.com/nodejs/node/pull/56103
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-12-03 20:03:02 +00:00
dependabot[bot]
b24a8e029f
meta: bump actions/checkout from 4.1.7 to 4.2.2
...
Bumps [actions/checkout](https://github.com/actions/checkout ) from 4.1.7 to 4.2.2.
- [Release notes](https://github.com/actions/checkout/releases )
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md )
- [Commits](https://github.com/actions/checkout/compare/v4.1.7...11bd71901bbe5b1630ceea73d27597364c9af683 )
---
updated-dependencies:
- dependency-name: actions/checkout
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
PR-URL: https://github.com/nodejs/node/pull/56102
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-12-03 20:02:26 +00:00
dependabot[bot]
34174bc3ac
meta: bump step-security/harden-runner from 2.10.1 to 2.10.2
...
Bumps [step-security/harden-runner](https://github.com/step-security/harden-runner ) from 2.10.1 to 2.10.2.
- [Release notes](https://github.com/step-security/harden-runner/releases )
- [Commits](91182cccc0...0080882f6c )
---
updated-dependencies:
- dependency-name: step-security/harden-runner
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
PR-URL: https://github.com/nodejs/node/pull/56101
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-12-03 20:02:11 +00:00
dependabot[bot]
f601984be9
meta: bump actions/setup-node from 4.0.3 to 4.1.0
...
Bumps [actions/setup-node](https://github.com/actions/setup-node ) from 4.0.3 to 4.1.0.
- [Release notes](https://github.com/actions/setup-node/releases )
- [Commits](https://github.com/actions/setup-node/compare/v4.0.3...39370e3970a6d050c480ffad4ff0ed4d3fdee5af )
---
updated-dependencies:
- dependency-name: actions/setup-node
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
PR-URL: https://github.com/nodejs/node/pull/56100
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Tierney Cyren <hello@bnb.im >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-12-03 20:01:57 +00:00
Ruy Adorno
7924ea3518
2024-12-03, Version 22.12.0 'Jod' (LTS)
...
Notable changes:
assert:
* (SEMVER-MINOR) make assertion_error use Myers diff algorithm (Giovanni Bucci) https://github.com/nodejs/node/pull/54862
buffer:
* (SEMVER-MINOR) make Buffer work with resizable ArrayBuffer (James M Snell) https://github.com/nodejs/node/pull/55377
crypto:
* update root certificates to NSS 3.104 (Richard Lau) https://github.com/nodejs/node/pull/55681
doc:
* enforce strict policy to semver-major releases (Rafael Gonzaga) https://github.com/nodejs/node/pull/55732
* add jazelly to collaborators (Jason Zhang) https://github.com/nodejs/node/pull/55531
esm:
* mark import attributes and JSON module as stable (Nicolò Ribaudo) https://github.com/nodejs/node/pull/55333
http:
* (SEMVER-MINOR) add diagnostic channel `http.client.request.created` (Marco Ippolito) https://github.com/nodejs/node/pull/55586
lib:
* (SEMVER-MINOR) add UV_UDP_REUSEPORT for udp (theanarkh) https://github.com/nodejs/node/pull/55403
module:
* (SEMVER-MINOR) unflag --experimental-require-module (Joyee Cheung) https://github.com/nodejs/node/pull/55085
net:
* (SEMVER-MINOR) add UV_TCP_REUSEPORT for tcp (theanarkh) https://github.com/nodejs/node/pull/55408
sqlite:
* (SEMVER-MINOR) add support for SQLite Session Extension (Bart Louwers) https://github.com/nodejs/node/pull/54181
tools:
* fix root certificate updater (Richard Lau) https://github.com/nodejs/node/pull/55681
PR-URL: https://github.com/nodejs/node/pull/56040
2024-12-03 14:44:27 -05:00
James M Snell
b915124e49
src: use spaceship operator in SocketAddress
...
PR-URL: https://github.com/nodejs/node/pull/56059
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2024-12-03 07:15:14 -08:00
Shelley Vohr
3b6da7ce76
build: allow overriding clang usage
...
PR-URL: https://github.com/nodejs/node/pull/56016
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2024-12-03 14:17:48 +00:00
Yagiz Nizipli
ebc179d68b
src: add missing qualifiers to env.cc
...
PR-URL: https://github.com/nodejs/node/pull/56062
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2024-12-03 14:05:50 +00:00
Rafael Gonzaga
742ea1c85f
doc: add create-release-action to process
...
PR-URL: https://github.com/nodejs/node/pull/55993
Reviewed-By: Ruy Adorno <ruy@vlt.sh >
2024-12-03 13:22:48 +00:00
Mert Can Altin
20bcaa081b
util: add fast path for Latin1 decoding
...
PR-URL: https://github.com/nodejs/node/pull/55275
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Daniel Lemire <daniel@lemire.me >
2024-12-03 11:32:01 +00:00
Node.js GitHub Bot
5ef4985175
deps: update sqlite to 3.47.1
...
PR-URL: https://github.com/nodejs/node/pull/56094
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2024-12-03 01:04:38 +00:00
Geoffrey Booth
94c327c753
module: remove --experimental-default-type
...
PR-URL: https://github.com/nodejs/node/pull/56092
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Jacob Smith <jacob@frende.me >
2024-12-02 22:43:55 +00:00
Node.js GitHub Bot
47b80c293d
deps: update undici to 7.0.0
...
PR-URL: https://github.com/nodejs/node/pull/56070
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2024-12-02 20:59:24 +00:00
theanarkh
d5d1e80763
net: support blocklist for net.Server
...
PR-URL: https://github.com/nodejs/node/pull/56079
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2024-12-02 15:21:31 +00:00
Yagiz Nizipli
8bd9a848d7
src: use std::string_view for process emit fns
...
PR-URL: https://github.com/nodejs/node/pull/56086
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2024-12-02 15:08:33 +00:00
theanarkh
61e4ad5352
dgram: check udp buffer size to avoid fd leak
...
PR-URL: https://github.com/nodejs/node/pull/56084
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-12-02 04:48:53 +00:00
Gerhard Stöbich
384fa62569
src: remove dead code in async_wrap
...
The silent option for AsyncWrap and AsyncReset is not used anywhere.
Seems like a leftover from times PromiseWrap was used.
PR-URL: https://github.com/nodejs/node/pull/56065
Refs: https://github.com/nodejs/node/pull/39135
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2024-12-01 18:50:15 +00:00
Gerhard Stöbich
58982d712b
src: add async context frame to AsyncResource
...
Add member to hold the async context frame to AsyncResource to avoid
the need for the async_resource_context_frames_ map in env.
Semver major because it changes ABI.
PR-URL: https://github.com/nodejs/node/pull/56082
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2024-12-01 18:28:25 +00:00
Yagiz Nizipli
de5f91db8b
src: avoid copy on getV8FastApiCallCount
...
PR-URL: https://github.com/nodejs/node/pull/56081
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-12-01 17:27:16 +00:00
Luigi Pinca
3f9c6c0f60
test: move test-worker-arraybuffer-zerofill to parallel
...
Move `test/sequential/test-worker-arraybuffer-zerofill.js` back to
`test/parallel/test-worker-arraybuffer-zerofill.js` and remove the
flaky designation.
The original issue is likely the same as other tests that time out.
Refs: https://github.com/nodejs/node/issues/54918
Refs: https://github.com/nodejs/node/pull/54839
Refs: https://github.com/nodejs/node/pull/54802
PR-URL: https://github.com/nodejs/node/pull/56053
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
2024-12-01 07:13:10 +00:00
Tobias Nießen
3fb2ea8689
doc: rename file to advocacy-ambassador-program.md
...
PR-URL: https://github.com/nodejs/node/pull/56046
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
2024-11-30 18:41:06 +00:00
Rafael Gonzaga
03ec900e07
build: remove defaults for create-release-proposal
...
To prevent users from executing the workflow via CLI
without passing the desired inputs.
PR-URL: https://github.com/nodejs/node/pull/56042
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2024-11-30 02:14:00 +00:00
Rafael Gonzaga
1c81dbbf87
meta: add releasers as CODEOWNERS to proposal action
...
PR-URL: https://github.com/nodejs/node/pull/56043
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-11-29 21:04:28 +00:00
Yagiz Nizipli
4ee87b8bc3
zlib: deprecate classes usage without new
...
PR-URL: https://github.com/nodejs/node/pull/55718
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
2024-11-29 20:55:03 +00:00
Alex Yang
22792b852c
sqlite: deps include sqlite3ext.h
...
PR-URL: https://github.com/nodejs/node/pull/56010
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2024-11-29 18:10:40 +00:00
Michaël Zasso
61b077d346
tools: fix update-undici script
...
The `build:node` npm script now expects esbuild to be installed and
bin-linked.
Closes: https://github.com/nodejs/node/issues/56061
PR-URL: https://github.com/nodejs/node/pull/56069
Fixes: https://github.com/nodejs/node/issues/56061
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2024-11-29 09:09:04 +00:00
Node.js GitHub Bot
4efb7ae454
deps: update zlib to 1.3.0.1-motley-82a5fec
...
PR-URL: https://github.com/nodejs/node/pull/55980
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2024-11-29 06:47:40 +00:00
Antoine du Hamel
b5eb77fd5d
tools: allow dispatch of tools.yml from forks
...
PR-URL: https://github.com/nodejs/node/pull/56008
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2024-11-28 23:52:37 +00:00
Antoine du Hamel
0a9524bd35
tools: fix nghttp3 updater script
...
PR-URL: https://github.com/nodejs/node/pull/56007
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2024-11-28 23:52:23 +00:00
James M Snell
4cf6fabce2
quic: update more QUIC implementation
...
Signed-off-by: James M Snell <jasnell@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/55986
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
2024-11-28 09:53:50 -08:00
theanarkh
aa7c8ccd45
src: fix check fd
...
PR-URL: https://github.com/nodejs/node/pull/56000
Fixes: https://github.com/nodejs/node/issues/55983
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Jason Zhang <xzha4350@gmail.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
2024-11-28 16:26:17 +00:00
Node.js GitHub Bot
d09458f3f0
test: update WPT for url to 67880a4eb83ca9aa732eec4b35a1971ff5bf37ff
...
PR-URL: https://github.com/nodejs/node/pull/55999
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Jason Zhang <xzha4350@gmail.com >
2024-11-28 13:55:51 +00:00