Commit Graph

45574 Commits

Author SHA1 Message Date
Richard Lau
3c92ee1008 build: enable maglev for Linux on s390x
PR-URL: https://github.com/nodejs/node/pull/60863
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
2025-11-28 18:09:19 +00:00
Yuki Okita
d09c3ffb7c test: skip failing tests when compiled without amaro
When compiled without amaro, this conflicts with
--experimental-strip-types defaulting to true. To avoid that,
we need to skip relevant failing tests.

Fixes: https://github.com/nodejs/node/issues/60640
PR-URL: https://github.com/nodejs/node/pull/60815
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-11-28 15:37:42 +00:00
Riddhi
1b3a64deb4 doc: correct 'event handle' to 'event handler' in Utf8Stream drop event
PR-URL: https://github.com/nodejs/node/pull/60692
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
2025-11-28 10:43:07 +00:00
Rich Trott
01d5a38a60 doc: fix typos in changelogs
I know we can't fix the parts that are commit messages, but I believe
the rest of the text is editable. Am I misremembering?

PR-URL: https://github.com/nodejs/node/pull/60855
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2025-11-28 04:24:42 +00:00
npm CLI robot
1de8d7f21a deps: upgrade npm to 11.6.4
PR-URL: https://github.com/nodejs/node/pull/60853
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2025-11-27 20:46:00 +00:00
Michaël Zasso
08d966cb65 src: handle indexed properties in process.env
Closes: https://github.com/nodejs/node/issues/60795
PR-URL: https://github.com/nodejs/node/pull/60826
Fixes: https://github.com/nodejs/node/issues/60795
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2025-11-27 13:10:35 +00:00
Mika Fischer
bff6ea49b8 node-api: fix data race and use-after-free in napi_threadsafe_function
Other threads can still hold a valid handle to the tsfn after
finalization if finalization was triggered by
- release with napi_tsfn_abort, or
- environment shutdown

Handle this by:
- protecting finalization itself with the mutex
- if necessary, delay deletion after finalization to when thread_count
  drops to 0
- releasing all resources as soon as possible before deletion

Fixes: https://github.com/nodejs/node/issues/55706
PR-URL: https://github.com/nodejs/node/pull/55877
Co-Authored-By: Gabriel Schulhof <gabrielschulhof@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2025-11-27 11:30:06 +00:00
Yves M.
ca5956cb7a util: safely inspect getter errors whose message throws
PR-URL: https://github.com/nodejs/node/pull/60684
Fixes: https://github.com/nodejs/node/issues/60683
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-11-27 11:06:24 +00:00
Chengzhong Wu
ce29481a52 doc: mark module.register as active development
PR-URL: https://github.com/nodejs/node/pull/60849
Refs: https://github.com/nodejs/node/pull/60302
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
2025-11-27 10:36:29 +00:00
Vladimir Morozov
e825de8e02 test: fix debug test crashes caused by sea tests
PR-URL: https://github.com/nodejs/node/pull/60807
Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2025-11-27 10:22:58 +00:00
Antoine du Hamel
634dc26605 test: ensure assertions are reached on all tests
PR-URL: https://github.com/nodejs/node/pull/60845
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2025-11-27 09:35:25 +00:00
Antoine du Hamel
0392f0caea lib: add lint rules for reflective function calls
PR-URL: https://github.com/nodejs/node/pull/60825
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
2025-11-27 10:24:09 +01:00
Michaël Zasso
0177491df2 doc: restore REPLACEME on assert change
The change was semver-major and didn't land on v25.x

Refs: https://github.com/nodejs/node/pull/60774
PR-URL: https://github.com/nodejs/node/pull/60848
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-11-27 08:45:00 +00:00
Chengzhong Wu
430db0d310 src: simply uint32 to string as it must not fail
PR-URL: https://github.com/nodejs/node/pull/60846
Refs: https://github.com/nodejs/node/pull/53959
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2025-11-27 07:22:14 +00:00
Michaël Zasso
6706b22e35 src: mark unused private field as such
Refs: https://github.com/nodejs/node/pull/59828
PR-URL: https://github.com/nodejs/node/pull/60802
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2025-11-26 11:18:32 +00:00
René
9c2500295e events: repurpose events.listenerCount() to accept EventTargets
PR-URL: https://github.com/nodejs/node/pull/60214
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2025-11-26 11:09:07 +00:00
Antoine du Hamel
4451309e99 test: add lint rule to forbid use of assert.ok(/regex/.test(…))
PR-URL: https://github.com/nodejs/node/pull/60832
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2025-11-25 21:25:47 +01:00
PaulyBearCoding
90980932a4 doc: add fullName property to SuiteContext
Add documentation for the missing fullName property in SuiteContext.
This property returns the name of the suite and each of its ancestors,
separated by '>'.

The property has been available since v22.3.0 but was missing from the
documentation.

Fixes: https://github.com/nodejs/node/issues/60757
PR-URL: https://github.com/nodejs/node/pull/60762
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2025-11-25 19:34:19 +00:00
Aditya Chopra
23c58f01e5 test: replace deprecated regex test assertions in http trailers test
PR-URL: https://github.com/nodejs/node/pull/60831
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-11-25 18:53:23 +00:00
Chengzhong Wu
7955ef126f tools: add temporal updater
PR-URL: https://github.com/nodejs/node/pull/60828
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
2025-11-25 15:59:21 +00:00
Marco Ippolito
ae62b36d44 2025-11-25, Version 20.19.6 'Iron' (LTS)
Notable changes:

crypto:
  * update root certificates to NSS 3.114 (Node.js GitHub Bot) https://github.com/nodejs/node/pull/59571
doc:
  * update the instruction on how to verify releases (Antoine du Hamel) https://github.com/nodejs/node/pull/59113
  * deprecate HTTP/2 priority signaling (Matteo Collina) https://github.com/nodejs/node/pull/58313

PR-URL: https://github.com/nodejs/node/pull/60784
2025-11-25 13:25:23 +01:00
Node.js GitHub Bot
bfc729cf19 deps: patch V8 to 14.3.127.16
Refs: https://github.com/v8/v8/compare/14.3.127.14...14.3.127.16
PR-URL: https://github.com/nodejs/node/pull/60819
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2025-11-25 01:03:06 +00:00
Node.js GitHub Bot
1e7eb90b39 tools: update nixpkgs-unstable to a8d610af3f1a5fb71e23e08434d8d61a466
PR-URL: https://github.com/nodejs/node/pull/60818
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2025-11-25 01:02:59 +00:00
Antoine du Hamel
fc203b36f4 test: ensure assertions are reached on more tests
PR-URL: https://github.com/nodejs/node/pull/60763
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2025-11-24 23:51:26 +01:00
Antoine du Hamel
4a4fdcf390 test: ensure assertions are reached on more tests
PR-URL: https://github.com/nodejs/node/pull/60761
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2025-11-24 23:47:52 +01:00
Antoine du Hamel
411ce7ed2e test: ensure assertions are reached on more tests
PR-URL: https://github.com/nodejs/node/pull/60760
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2025-11-24 22:44:48 +00:00
Antoine du Hamel
d539d6e99f test: ensure assertions are reached on more tests
PR-URL: https://github.com/nodejs/node/pull/60759
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2025-11-24 22:36:53 +00:00
sangwook
b011cc53ee test: prefer major GC in cppgc-object teardown
PR-URL: https://github.com/nodejs/node/pull/60672
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2025-11-24 16:20:18 +00:00
Augustin Mauroy
bed8e2aa74 doc: add additional codemods for deprecation
PR-URL: https://github.com/nodejs/node/pull/60811
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2025-11-24 09:44:56 +00:00
Antoine du Hamel
8dc2bddbd5 test: use RegExp.escape to improve test reliability
PR-URL: https://github.com/nodejs/node/pull/60803
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2025-11-23 19:25:36 +00:00
Aliaksandr
d255fc7bae test_runner: fix line feed escaping in JUnit
Replaces line feed characters with the correct character reference in
XML attribute values.

PR-URL: https://github.com/nodejs/node/pull/60274
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
2025-11-23 18:39:24 +00:00
Gürgün Dayıoğlu
7fe8085727 url: remove array.reduce usage
PR-URL: https://github.com/nodejs/node/pull/60748
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2025-11-23 17:13:58 +00:00
Chengzhong Wu
482b191727 build: ignore built-in temporal when building with shared lib
Co-Authored-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/60703
Refs: https://github.com/nodejs/node/issues/58730
Refs: https://github.com/nodejs/node/pull/60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-11-23 15:41:32 +00:00
Chengzhong Wu
e8a5a82ca4 test: add basic temporal presence check
PR-URL: https://github.com/nodejs/node/pull/60703
Refs: https://github.com/nodejs/node/issues/58730
Refs: https://github.com/nodejs/node/pull/60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-11-23 15:41:31 +00:00
Chengzhong Wu
342e87f746 build: add temporal_capi gyp
PR-URL: https://github.com/nodejs/node/pull/60703
Refs: https://github.com/nodejs/node/issues/58730
Refs: https://github.com/nodejs/node/pull/60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-11-23 15:41:31 +00:00
Chengzhong Wu
4947af957f deps: add temporal_rs 0.1.0
PR-URL: https://github.com/nodejs/node/pull/60703
Refs: https://github.com/nodejs/node/issues/58730
Refs: https://github.com/nodejs/node/pull/60693
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-11-23 15:41:30 +00:00
Node.js GitHub Bot
189a0a71de deps: update sqlite to 3.51.0
PR-URL: https://github.com/nodejs/node/pull/60614
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-11-23 13:26:54 +00:00
Botato
aa948fdbd0 doc: keep sidebar module visible when navigating docs
PR-URL: https://github.com/nodejs/node/pull/60410
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-11-23 14:20:07 +01:00
Marco Ippolito
1758b74829 src: implicitly enable namespace in config
PR-URL: https://github.com/nodejs/node/pull/60798
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2025-11-23 09:39:59 +00:00
Marco Ippolito
49e56bfc55 doc: fix webstorage config file property
PR-URL: https://github.com/nodejs/node/pull/60798
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2025-11-23 09:39:58 +00:00
Marco Ippolito
72dd0fa5cd src: add permission flag to config file
PR-URL: https://github.com/nodejs/node/pull/60798
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2025-11-23 09:39:57 +00:00
Marco Ippolito
dbe47043dd src: add test flag to config file
PR-URL: https://github.com/nodejs/node/pull/60798
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2025-11-23 09:39:57 +00:00
Marco Ippolito
8b769cff60 src: rename config file testRunner to test
PR-URL: https://github.com/nodejs/node/pull/60798
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
2025-11-23 09:39:56 +00:00
Livia Medeiros
46dc5d7c9f lib: prefer call() over apply() if argument list is not array
PR-URL: https://github.com/nodejs/node/pull/60796
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-11-23 08:45:46 +00:00
Chengzhong Wu
7fd36886b4 tools: dump config.gypi as json
This helps js2c processing the node.gypi correctly when a string
contains a quote.

PR-URL: https://github.com/nodejs/node/pull/60794
Refs: https://github.com/nodejs/node/pull/60703
Reviewed-By: Richard Lau <richard.lau@ibm.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2025-11-22 16:37:32 +00:00
René
fb6b83c9ef tools: lint Temporal global
PR-URL: https://github.com/nodejs/node/pull/60793
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
2025-11-22 12:56:28 +01:00
npm CLI robot
45eeb6f88c deps: upgrade npm to 11.6.3
PR-URL: https://github.com/nodejs/node/pull/60785
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-11-21 21:07:32 +00:00
Sebastian Beltran
93c25815ee http: move writeHeader to end-of-life
PR-URL: https://github.com/nodejs/node/pull/60635
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2025-11-21 19:49:23 +00:00
Node.js GitHub Bot
00a8377e50 deps: update brotli to 1.2.0
PR-URL: https://github.com/nodejs/node/pull/60540
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2025-11-21 18:57:52 +00:00
dependabot[bot]
b8b4350ed3 tools: bump js-yaml from 4.1.0 to 4.1.1 in /tools/lint-md
Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.0 to 4.1.1.
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nodeca/js-yaml/compare/4.1.0...4.1.1)

---
updated-dependencies:
- dependency-name: js-yaml
  dependency-version: 4.1.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
PR-URL: https://github.com/nodejs/node/pull/60781
Reviewed-By: Xuguang Mei <meixuguang@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2025-11-20 22:13:20 +00:00