Michael Dawson
30ff0ff6c9
deps: MacOS - fix location of OpenSSL config file
...
- Restore the location were the OpenSSL config file is
loaded by default on MacOS back to where it was on earlier versions
- Remove warnings about OPENSSLDIR being multiply defined
Signed-off-by: Michael Dawson <mdawson@devrus.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
PR-URL: https://github.com/nodejs-private/node-private/pull/345
CVE-ID: CVE-2022-32222
2022-09-23 12:32:51 -03:00
RafaelGSS
b358fb27a4
src: fix IPv4 non routable validation
...
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
PR-URL: https://github.com/nodejs-private/node-private/pull/337
CVE-ID: CVE-2022-32212, CVE-2018-7160
2022-09-23 12:32:45 -03:00
Michael Dawson
eead3e9ac8
doc: update guidance for adding new modules
...
- updated based on decision to use node: prefix in
https://github.com/nodejs/TSC/pull/1206
- updated based on agreement in TSC meeting
on adding /promises to existing modules as per
minutes - https://github.com/nodejs/TSC/pull/1281
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/44576
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2022-09-23 10:08:25 -04:00
“Pooja
269aa6ebba
test: change promise to async/await in debugger-watcher
...
PR-URL: https://github.com/nodejs/node/pull/44687
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-09-23 06:42:13 -07:00
Daeyeon Jeong
e213deabe5
stream: handle a pending pull request from a released reader
...
In order to meet the specification, this includes mainly the followings:
- Adding the 'release steps' to ReadableStreamController
- Responding to a pull request from a released reader in
ReadableByteStreamController
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: https://github.com/nodejs/node/pull/44702
Refs: https://streams.spec.whatwg.org/#abstract-opdef-readablebytestreamcontroller-releasesteps
Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-in-readable-state
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
2022-09-23 12:01:52 +00:00
Keeley Hammond
76364215d4
doc: add registry number for Electron 22
...
PR-URL: https://github.com/nodejs/node/pull/44748
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-09-23 09:46:50 +00:00
Adam Majer
456591829b
test: fix addon tests compilation with OpenSSL 1.1.1
...
openssl/provider.h header is not part of OpenSSL 1.1.1 so do not
include it when building with an older instance.
Fixes: https://github.com/nodejs/node/issues/44722
PR-URL: https://github.com/nodejs/node/pull/44725
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-09-22 23:19:44 +00:00
Jordan Harband
098eac7f27
util: increase robustness with primordials
...
PR-URL: https://github.com/nodejs/node/pull/41212
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-09-22 14:22:18 +00:00
Filip Skokan
5f8182981a
doc,crypto: cleanup removed pbkdf2 behaviours
...
PR-URL: https://github.com/nodejs/node/pull/44733
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
2022-09-22 13:51:44 +00:00
Evan Lucas
962b9abbe3
benchmark: fix startup benchmark
...
This allows the misc/startup benchmark to run again
after the renaming of the C++ `native_module` to `builtins`
PR-URL: https://github.com/nodejs/node/pull/44727
Refs: https://github.com/nodejs/node/pull/44135
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
2022-09-21 22:14:55 +00:00
Lucas Santos
62e182c89c
doc: include code examples for webstreams consumers
...
Add missing examples for webstreams consumers
Doc URL: https://nodejs.org/api/webstreams.html#streamconsumerstextstream
PR-URL: https://github.com/nodejs/node/pull/44387
Reviewed-By: Erick Wendel <erick.workspace@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com >
2022-09-21 15:05:22 -07:00
Santiago Gimeno
d2cf01d756
src: avoid using v8 on Isolate termination
...
Fix multiple instances of those uncovered while running the tests on
debug builds.
Fixes: https://github.com/nodejs/node-v8/issues/227
PR-URL: https://github.com/nodejs/node/pull/44669
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
2022-09-21 13:35:25 +00:00
Filip Skokan
46dcfb3c7b
doc,crypto: update webcrypto docs for global access
...
PR-URL: https://github.com/nodejs/node/pull/44723
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-09-21 13:12:31 +00:00
chexiongsheng
6c8c3d89b0
gyp: libnode for ios app embedding
...
PR-URL: https://github.com/nodejs/node/pull/44210
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
2022-09-21 18:02:40 +08:00
RafaelGSS
68a3618bb4
doc: mention where to push security commits
...
PR-URL: https://github.com/nodejs/node/pull/44691
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
2022-09-20 16:32:34 -03:00
Connor Burton
50329ae22d
doc: remove extra space on threadpool usage
...
PR-URL: https://github.com/nodejs/node/pull/44734
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-09-20 19:17:41 +00:00
Chengzhong Wu
9b369824cb
node-api: add deprecation code of uncaught exception
...
Deprecation should reference a valid deprecation code.
PR-URL: https://github.com/nodejs/node/pull/44624
Refs: https://github.com/nodejs/node/pull/36510
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2022-09-21 00:02:14 +08:00
Moshe Atlow
96f072231d
test: deflake watch mode tests
...
PR-URL: https://github.com/nodejs/node/pull/44621
Fixes: https://github.com/nodejs/node/issues/44655
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2022-09-20 10:37:42 +03:00
Jacob Smith
e2e5b2eaf1
esm,loader: tidy ESMLoader internals
...
PR-URL: https://github.com/nodejs/node/pull/44701
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-09-19 20:55:09 +00:00
Rich Trott
e62e99d983
meta: add mailmap entry for dnlup
...
This updates dnlup's name to their preferred email per their last pull
request.
This will also prevent duplicate entries for dnlup when the
update-authors job runs.
It also moves one unrelated line in .mailmap so that all lines are
sorted in lexical order.
PR-URL: https://github.com/nodejs/node/pull/44716
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com >
Reviewed-By: Darshan Sen <raisinten@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-09-19 16:50:37 +00:00
Paolo Insogna
66531d51e9
tools: add update-llhttp.sh
...
PR-URL: https://github.com/nodejs/node/pull/44652
Reviewed-By: Michael Dawson <midawson@redhat.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com >
Co-authored-by: Tobias Nießen <tniessen@tnie.de >
Co-authored-by: Luigi Pinca <luigipinca@gmail.com >
2022-09-19 16:00:52 +02:00
Node.js GitHub Bot
a2a32d8bee
meta: update AUTHORS
...
PR-URL: https://github.com/nodejs/node/pull/44705
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-09-18 19:25:51 +00:00
Tobias Nießen
5e3d003113
src: remove <unistd.h> from node_os.cc
...
The file does not use sysconf() and its use of gethostname() has been
removed, so including <unistd.h> appears to be unnecessary.
PR-URL: https://github.com/nodejs/node/pull/44668
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-09-18 12:17:45 +00:00
Tobias Nießen
7621d56a1b
deps: update to ngtcp2 0.8.1 and nghttp3 0.7.0
...
Refs: https://github.com/nodejs/node/pull/44619
Co-authored-by: James M Snell <jasnell@gmail.com >
PR-URL: https://github.com/nodejs/node/pull/44622
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-09-18 12:06:09 +00:00
Maël Nison
bf47abe5f3
module: open stat/readPackage to mutations
...
PR-URL: https://github.com/nodejs/node/pull/44537
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-09-18 10:50:52 +00:00
Node.js GitHub Bot
ac13dd29a2
deps: update corepack to 0.14.1
...
PR-URL: https://github.com/nodejs/node/pull/44704
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-09-18 10:50:40 +00:00
Tobias Nießen
66ceb4f30b
deps: update ngtcp2 update instructions
...
Prefer tagged versions over the latest commit on the development branch,
and a few other minor improvements.
PR-URL: https://github.com/nodejs/node/pull/44619
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-09-18 12:43:55 +02:00
sidwebworks
91020db933
http: throw error on content-length mismatch
...
PR-URL: https://github.com/nodejs/node/pull/44378
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Robert Nagy <ronagy@icloud.com >
2022-09-18 12:39:37 +02:00
dnlup
84000f18ba
meta: move dnlup to emeriti
...
PR-URL: https://github.com/nodejs/node/pull/44667
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
2022-09-18 09:04:55 +00:00
Rich Trott
7a3bd28bbf
doc: make legacy banner slightly less bright
...
PR-URL: https://github.com/nodejs/node/pull/44665
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-09-17 18:56:58 +00:00
npm CLI robot
5909beaee2
deps: upgrade npm to 8.19.2
...
PR-URL: https://github.com/nodejs/node/pull/44632
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Myles Borins <myles.borins@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
2022-09-17 18:46:30 +00:00
Antoine du Hamel
2849283c4c
crypto: remove non-standard webcrypto.Crypto.prototype.CryptoKey
...
`CryptoKey` is already available on the global object.
PR-URL: https://github.com/nodejs/node/pull/42083
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2022-09-17 15:54:36 +02:00
Antoine du Hamel
6de2673a9f
lib: enable global WebCrypto by default
...
Enables `--experimental-global-webcrypto` by default, and ensures that
the classic `node:crypto` core module is still available in `--eval` or
`--print` contexts.
PR-URL: https://github.com/nodejs/node/pull/42083
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2022-09-17 15:54:33 +02:00
Yagiz Nizipli
572d55645c
dns: remove unnecessary parameter from validateOneOf
...
PR-URL: https://github.com/nodejs/node/pull/44635
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
2022-09-17 11:44:02 +00:00
Brian Muenzenmeyer
ccd4c31360
doc: improve building doc for Windows Powershell
...
PR-URL: https://github.com/nodejs/node/pull/44625
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com >
2022-09-16 20:40:37 -07:00
Tobias Nießen
44643bd64b
doc: maintain only one list of MODP groups
...
There are two lists of MODP groups, one of which is redundant and does
not mark weak groups as deprecated. Remove said list and refer readers
to the first list instead.
Refs: https://github.com/nodejs/node/pull/43986
Refs: https://github.com/nodejs/node/pull/44588
PR-URL: https://github.com/nodejs/node/pull/44644
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-09-17 01:00:35 +00:00
smitley
0928897798
test: fix test-performance-measure
...
Refs: https://github.com/nodejs/node/issues/42949
Looking at the documentation for setTimeout
(https://nodejs.org/api/timers.html#settimeoutcallback-delay-args )
there is no guarantee that setTimeout won't complete early.
From the failure of https://github.com/nodejs/node/issues/42949 this
is likely what happened.
I have updated the assert.ok test to allow some variation in
the test.
PR-URL: https://github.com/nodejs/node/pull/44637
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2022-09-16 16:51:06 -04:00
Michael Dawson
325f54966e
doc: add legendecas to TSC list
...
Refs: https://github.com/nodejs/TSC/issues/1282
Signed-off-by: Michael Dawson <mdawson@devrus.com >
PR-URL: https://github.com/nodejs/node/pull/44662
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-09-16 16:40:38 -04:00
Luigi Pinca
5d92ddc8b1
tools: fix typo in update-nghttp2.sh
...
PR-URL: https://github.com/nodejs/node/pull/44664
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2022-09-16 13:28:04 +00:00
Lenvin Gonsalves
85b46e1cab
tools: add timezone update workflow
...
Fixes: https://github.com/nodejs/node/issues/43134
PR-URL: https://github.com/nodejs/node/pull/43988
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com >
2022-09-16 00:03:40 +02:00
MURAKAMI Masahiko
1f19f0c389
test: improve lib/readline.js coverage
...
PR-URL: https://github.com/nodejs/node/pull/42686
Refs: https://coverage.nodejs.org/coverage-a0461255c05c79cf/lib/readline.js.html#L105
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2022-09-15 21:58:39 +00:00
legendecas
261e267b51
doc,inspector: document changes of inspector.close
...
Retrospectively document the changes history of the `inspector.close`
API.
PR-URL: https://github.com/nodejs/node/pull/44628
Refs: https://github.com/nodejs/node/pull/44489
Refs: https://github.com/nodejs/node/pull/13228
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com >
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com >
2022-09-16 01:44:23 +08:00
Tobias Nießen
a47c2c58ae
tls: fix out-of-bounds read in ClientHelloParser
...
ClientHelloParser::ParseHeader(data, avail) potentially accesses data
beyond avail bytes because it trusts the client to transmit a valid
frame length. Sending an impossibly small frame length causes the TLS
server to read beyond the buffer provided by the caller.
Guard against this by calling End() on the ClientHelloParser when the
client transmits an impossibly small frame length.
The test is designed to reliable cause a segmentation fault on Linux and
Windows when the buffer overrun occurs, and to trigger a spatial safety
violation when compiled with an address sanitizer enabled or when
running under valgrind.
PR-URL: https://github.com/nodejs/node/pull/44580
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com >
2022-09-15 17:27:04 +00:00
Tobias Nießen
b8581c7399
lib,test: fix bug in InternalSocketAddress
...
InternalSocketAddress must set [kDetails] in order for the inherited
properties to function correctly.
Co-authored-by: Tobias Nießen <tniessen@tnie.de >
PR-URL: https://github.com/nodejs/node/pull/44618
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2022-09-15 16:13:03 +00:00
Taha-Chaudhry
aa64ff6a37
doc: remove comma in README.md
...
Grammar edit
PR-URL: https://github.com/nodejs/node/pull/44599
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
2022-09-15 08:34:40 +00:00
Shrujal Shah
e039549d1f
meta: update test_runner in label-pr-config
...
PR-URL: https://github.com/nodejs/node/pull/44615
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2022-09-15 08:06:58 +00:00
Node.js GitHub Bot
572a35f522
tools: update eslint to 8.23.1
...
PR-URL: https://github.com/nodejs/node/pull/44639
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2022-09-15 03:42:22 +00:00
Daeyeon Jeong
7f4e9ecb52
doc: use serial comma in report docs
...
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com
PR-URL: https://github.com/nodejs/node/pull/44608
Reviewed-By: theanarkh <theratliter@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2022-09-15 02:42:20 +00:00
Node.js GitHub Bot
5a0aed3726
tools: update lint-md-dependencies to @rollup/plugin-node-resolve@14.1.0
...
PR-URL: https://github.com/nodejs/node/pull/44638
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2022-09-15 02:42:09 +00:00
Antoine du Hamel
5a40d2e6cb
test: fix test-repl not validating leaked globals properly
...
PR-URL: https://github.com/nodejs/node/pull/44640
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2022-09-15 00:24:28 +02:00