OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
38,527 Commits 30 Branches 683 Tags
29d7aecf42772e64f2202f854b51bbbee2f0f080
Commit Graph

38527 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Chemi Atlow
29d7aecf42 test_runner: expose reporter for use in run api 
PR-URL: https://github.com/nodejs/node/pull/47238
Fixes: https://github.com/nodejs/node/issues/47231
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-03-28 12:10:34 +00:00
Node.js GitHub Bot
67200dca0f deps: update timezone to 2023b 
PR-URL: https://github.com/nodejs/node/pull/47256
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-03-28 00:49:57 +00:00
npm CLI robot
a4808b6c3b deps: upgrade npm to 9.6.2 
PR-URL: https://github.com/nodejs/node/pull/47108
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-03-27 14:41:08 -04:00
Stefan Stojanovic
13767a4675 test: fix test-child-process-exec-cwd 
Refs: https://github.com/nodejs/node/pull/47020
Refs: https://github.com/nodejs/build/issues/3046
PR-URL: https://github.com/nodejs/node/pull/47235
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-03-27 11:20:08 +00:00
Tobias Nießen
f84ff93d96 doc: use serial comma in cli docs 
Refs: https://github.com/nodejs/node/pull/11321
Refs: https://github.com/nodejs/node/pull/17384
PR-URL: https://github.com/nodejs/node/pull/47262
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
 2023-03-27 09:27:08 +00:00
Julian Dax
38e6ac7b44 doc: improve example for Error.captureStackTrace() 
Change the `MyError` example so that instances of `MyError`are
`instanceof Error` and also  native errors when checked with
`util.types.isNativeError()`.

Co-authored-by: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: https://github.com/nodejs/node/pull/46886
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-03-26 20:38:27 +00:00
Zach Bjornson
f0ade7084d doc: clarify http error events after calling destroy() 
PR-URL: https://github.com/nodejs/node/pull/46903
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-03-26 20:30:05 +00:00
Tobias Nießen
9374700d7a crypto: remove DEFAULT_ENCODING 
Citing 76b0bdf720 from 2012, "only use
this as a temporary measure."

Getting or setting DEFAULT_ENCODING has emitted a warning ever since
Node.js 10, so it seems appropriate to remove it in Node.js 20 five
years later. The last Node.js version that did not emit a warning
reached its end-of-life status at the end of 2019.

This commit only removes the public API so that the change can land in
time for Node.js 20.

Refs: https://github.com/nodejs/node-v0.x-archive/pull/4179
Refs: https://github.com/nodejs/node/pull/18333
PR-URL: https://github.com/nodejs/node/pull/47182
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-03-26 18:03:58 +00:00
Node.js GitHub Bot
106aa47639 tools: update lint-md-dependencies to rollup@3.20.2 
PR-URL: https://github.com/nodejs/node/pull/47255
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-03-26 06:34:09 +00:00
Tobias Nießen
6311de3322 tools: upgrade Windows digital signature to SHA256 
signtool still defaults to SHA1, which is vulnerable to certain
collisions. This switches to SHA256, which is stronger and which also
matches the hash function used by the signing certificate.

Technically, `/fd certHash` would be a better choice, but I don't know
if it is widely supported.

PR-URL: https://github.com/nodejs/node/pull/47206
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-03-25 18:27:46 +00:00
Marco Ippolito
38b6ecc12e tools: standardize update-llhttp.sh 
PR-URL: https://github.com/nodejs/node/pull/47198
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Tierney Cyren <hello@bnb.im>
 2023-03-25 14:26:01 +00:00
Deokjin Kim
6ed64e784a doc: update output of example in AbortController 
Actual output of example in AbortController is mismatched.
Plus, make `reason` parameter as optional in JSDoc.

Refs: https://github.com/nodejs/node/blob/main/doc/api/globals.md#abortcontrollerabortreason
Refs: https://github.com/nodejs/node/blob/main/doc/api/globals.md#static-method-abortsignalabortreason
PR-URL: https://github.com/nodejs/node/pull/47227
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-03-25 22:46:05 +09:00
Michaël Zasso
06c91af1b4 meta: update link to collaborators discussion page 
Refs: https://github.com/nodejs/TSC/issues/1340
PR-URL: https://github.com/nodejs/node/pull/47211
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2023-03-25 11:56:49 +00:00
Filip Skokan
a0ca15ed3f test,crypto: update WebCryptoAPI WPT 
PR-URL: https://github.com/nodejs/node/pull/47222
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-03-25 11:48:21 +00:00
jakecastelli
94ec71d385 tools: add button to copy code example to clipboard 
PR-URL: https://github.com/nodejs/node/pull/46928
Refs: https://github.com/nodejs/node/issues/46894
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-03-25 08:41:43 +00:00
Marco Ippolito
a64469dcf1 tools: standardize update-nghttp2.sh 
PR-URL: https://github.com/nodejs/node/pull/47197
Refs: https://github.com/nodejs/security-wg/issues/828
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2023-03-25 08:24:55 +00:00
Vladimir Morozov
5e4f5e122c node-api: deprecate napi_module_register 
PR-URL: https://github.com/nodejs/node/pull/46319
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-03-24 14:00:40 -04:00
Joyee Cheung
f5239795b5 deps: V8: cherry-pick 215ccd593edb 
Original commit message:

    Use FlagValue::value() in SLOW_DCHECK

    Previously SLOW_DCHECK used the non-constexpr bool() operator
    of FlagValue, which cannot be used in constexpr. Switch to
    FlagValue::value() instead for make it compile in constexpr.

    Change-Id: I3e4f70d82c0027cf56999b6c4639479606151696
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4341495
    Reviewed-by: Jakob Linke <jgruber@chromium.org>
    Commit-Queue: Joyee Cheung <joyee@igalia.com>
    Cr-Commit-Position: refs/heads/main@{#86611}

Refs: 215ccd593e
PR-URL: https://github.com/nodejs/node/pull/47212
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2023-03-24 17:30:56 +00:00
Rafael Gonzaga
5e72051456 doc: drop one-week branch sync on major releases 
PR-URL: https://github.com/nodejs/node/pull/47149
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2023-03-24 15:11:18 +00:00
Mohammed Keyvanzadeh
545b594b19 doc: fix grammar in the collaborator guide 
PR-URL: https://github.com/nodejs/node/pull/47245
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com>
 2023-03-24 13:31:19 +00:00
Raz Luvaton
c588145810 doc: update stream.reduce concurrency note 
PR-URL: https://github.com/nodejs/node/pull/47166
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2023-03-24 11:27:55 +00:00
Debadree Chatterjee
8e203f1b03 deps: V8: cherry-pick 975ff4dbfd1b 
Original commit message:

    fix GetPropertyNames for proxys with ownKeys trap

    Added checks to FilterProxyKeys function for when skip_indices is
    enabled.

    Bug: v8:13728
    Change-Id: Id096e32ef8e6c2344be9682e8222aea8790bd66d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4333698
    Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#86548}

Refs: 975ff4dbfd
PR-URL: https://github.com/nodejs/node/pull/47209
Fixes: https://github.com/nodejs/node/issues/41714
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
 2023-03-24 07:20:31 +00:00
Robert Nagy
8c60add65b stream: expose stream symbols 
This is required for streams interop with e.g.
readable-stream. Currently readable-stream helpers
will not work with normal node streams which is
confusing and bad for the ecosystem.

PR-URL: https://github.com/nodejs/node/pull/45671
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-03-24 07:20:18 +00:00
Danielle Adams
d6126135a8 meta: automate description requests when notable change label is added 
PR-URL: https://github.com/nodejs/node/pull/47078
Fixes: https://github.com/nodejs/Release/issues/821
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2023-03-24 05:27:16 +00:00
Antoine du Hamel
946f0ca29b tools: fix Slack notification action 
PR-URL: https://github.com/nodejs/node/pull/47237
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-03-23 21:17:55 +00:00
Yagiz Nizipli
27335cd870 url: add pending-deprecation to url.parse() 
PR-URL: https://github.com/nodejs/node/pull/47203
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Beth Griggs <bethanyngriggs@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2023-03-23 19:45:21 +00:00
HinataKah0
2e8f8eb4e3 test_runner: report failing tests after summary 
Re-output failing tests after summary has been printed.
This behavior follows other popular test runners
(e.g. jest, mocha, etc...).

Updated SpecReporter:
1. When there is a 'test:fail' event, the test will be
stored.
2. After no more input, all the failed tests will be
flushed.
3. Extract the logic for formatting a test report
into a re-usable function.

Fixes: https://github.com/nodejs/node/issues/47110
PR-URL: https://github.com/nodejs/node/pull/47164
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2023-03-23 18:45:53 +00:00
Debadree Chatterjee
73645d6227 fs: invalidate blob created from empty file when written to 
Fixes: https://github.com/nodejs/node/issues/47161
PR-URL: https://github.com/nodejs/node/pull/47199
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-03-23 18:28:43 +00:00
Yagiz Nizipli
f51c152f60 util: reduce javascript call for ToUSVString 
PR-URL: https://github.com/nodejs/node/pull/47192
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2023-03-23 15:01:31 +00:00
Antoine du Hamel
820030491f tools: notify on Slack when invalid commit lands 
PR-URL: https://github.com/nodejs/node/pull/47178
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2023-03-23 09:38:17 +00:00
Tobias Nießen
002b30eaa5 doc: remove use of DEFAULT_ENCODING in PBKDF2 docs 
There is no point in documenting this legacy behavior, which will emit a
warning when used.

PR-URL: https://github.com/nodejs/node/pull/47181
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-03-23 00:50:05 +00:00
Node.js GitHub Bot
a2c3061c15 meta: move TSC voting member(s) to regular member(s) 
PR-URL: https://github.com/nodejs/node/pull/47180
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2023-03-23 00:49:56 +00:00
Stefan Stojanovic
0b66df61ef msi: migrate to WiX4 
To be able to build x86, x64, and ARM64 MSI installers with the same WiX
version, migration to WiX4 is required.

PR-URL: https://github.com/nodejs/node/pull/45943
Refs: https://github.com/nodejs/build/issues/2540
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2023-03-22 22:16:57 +00:00
Khafra
f2651a0812 url: implement URL.canParse 
PR-URL: https://github.com/nodejs/node/pull/47179
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-03-22 19:44:44 +00:00
Khafra
7bc0e6a4e7 buffer: graduate File from experimental and expose as global 
PR-URL: https://github.com/nodejs/node/pull/47153
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-03-22 19:28:12 +00:00
Filip Skokan
202a9fa482 tools: update daily wpt actions summary 
PR-URL: https://github.com/nodejs/node/pull/47138
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-03-22 15:02:53 +00:00
Tobias Nießen
1a18b44028 src: replace impossible THROW with CHECK 
The JS layer already verifies that divisor_bits is either a non-negative
32-bit signed integer or null/undefined, in which case it passes -1 to
the C++ layer. In either case, the C++ layer receives a 32-bit signed
integer greater than or equal to -1.

PR-URL: https://github.com/nodejs/node/pull/47168
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-03-22 11:41:15 +00:00
Tobias Nießen
7d84d67364 crypto: unify validation of checkPrime checks 
Previously, the JS layer would validate that the value of the 'checks'
option was an unsigned 32-bit integer, otherwise throwing an appropriate
error but with a slightly misleading error message. Then the C++ layer
would validate that the value was an unsigned 31-bit integer, otherwise
throwing an appropriate error, but with a different (and even less
helpful) error message.

Instead, make the JS layer aware of the 31-bit restriction so that no
validation in C++ is necessary and so that the error message always
matches the exact requirement.

PR-URL: https://github.com/nodejs/node/pull/47165
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2023-03-22 11:41:06 +00:00
Stefan Stojanovic
f08655532b test: skip broken tests win arm64 
PR-URL: https://github.com/nodejs/node/pull/47020
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-03-22 10:54:49 +00:00
Joyee Cheung
434bdde974 inspector: log response and requests in the inspector for debugging 
Logs the raw messages from the inspector when NODE_DEBUG_NATIVE
is set to inspector_server to facilitate debugging.

PR-URL: https://github.com/nodejs/node/pull/46941
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-03-22 09:28:02 +00:00
Gabriel Schulhof
b4365c161c node-api: extend type-tagging to externals 
Since externals behave as JavaScript objects on the JavaScript side,
allow them to be type-tagged.

Signed-off-by: Gabriel Schulhof <gabrielschulhof@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/47141
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2023-03-22 04:47:08 +00:00
Raz Luvaton
22537f34a4 stream: dont wait for next item in take when finished 
PR-URL: https://github.com/nodejs/node/pull/47132
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
 2023-03-22 04:46:58 +00:00
Moshe Atlow
f5eedf480c tools: allow test tap output to include unicode characters 
PR-URL: https://github.com/nodejs/node/pull/47175
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
 2023-03-21 17:27:53 +00:00
Tobias Nießen
1640aeb680 crypto: remove obsolete SSL_OP_* constants 
None of these constants have any effect in recent OpenSSL versions, not
even in Node.js release lines that still use OpenSSL 1.1.1.

It is likely rare that these options are still used (intentionally), and
removing them is unlikely to break any existing applications. These
constants can only be passed to the secureOptions option of
tls.createSecureContext() and related APIs, and a value of undefined
will be ignored. Similarly, if a bitwise combination of multiple options
is used, undefined constants will not change the behavior because
(a | undefined | b) === (a | b) for (small) integers a and b.

Refs: https://github.com/nodejs/node/pull/46954
Refs: https://github.com/nodejs/node/pull/47066
PR-URL: https://github.com/nodejs/node/pull/47073
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-03-21 10:47:49 +00:00
Moshe Atlow
d1eaded0d1 test_runner: count nested tests 
PR-URL: https://github.com/nodejs/node/pull/47094
Fixes: https://github.com/nodejs/node/issues/46762
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-03-21 08:16:38 +00:00
Shubham Sharma
965ea9d586 doc: fix typos in async_context.md 
PR-URL: https://github.com/nodejs/node/pull/47155
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Deokjin Kim <deokjin81.kim@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
 2023-03-20 22:21:03 +00:00
Khafra
252a069007 buffer: use private properties for brand checks in File 
PR-URL: https://github.com/nodejs/node/pull/47154
Refs: https://github.com/nodejs/node/pull/46904
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-03-20 22:01:41 +00:00
Node.js GitHub Bot
bc0aa35938 meta: move TSC voting member to regular membership 
PR-URL: https://github.com/nodejs/node/pull/46985
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-03-20 16:24:07 +00:00
Chengzhong Wu
2984cc38da node-api: document node-api shutdown finalization 
As status quo, the cleanup hooks are invoked before the `napi_finalize`
callbacks at the exit of Node.js environments. This gives addons a
chance to release their resource in a proper order manually.

Document this behavior explicitly to advocate the usage on cleanup
hooks instead of relying on the implied invocation of `napi_finalize`
callbacks at shutdown.

PR-URL: https://github.com/nodejs/node/pull/45903
Fixes: https://github.com/nodejs/node/issues/45088
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-03-20 09:58:31 +00:00
Rich Trott
321387e2cb doc: update collaborator guide to reflect TSC changes 
Ref: https://github.com/nodejs/TSC/pull/1350
PR-URL: https://github.com/nodejs/node/pull/47126
Refs: https://github.com/nodejs/TSC/pull/1350
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2023-03-20 05:08:03 +00:00