Aviv Keller
1c5fe040a0
meta: remove license for hljs
...
PR-URL: https://github.com/nodejs/node/pull/53970
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2024-07-22 16:54:32 +00:00
Yagiz Nizipli
88027e84d8
fs: optimize fs.cpSync js calls
...
PR-URL: https://github.com/nodejs/node/pull/53614
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-22 16:00:39 +00:00
Richard Lau
7fb65f6bd0
build, tools: drop leading / from r2dir
...
The script is commented as removing `/home/dist/` part but the `cut`
command is off by one and end up including the `/` character (so that
the resulting string starts with `/`). When this is substituted into
`s3://${cloudflare_bucket}/${r2dir}/${shafile}.asc` we end up with
`//` (one from the template and one from the `r2dir`) which appears
to cause Cloudflare to create an extra top level `/` directory in the
bucket.
PR-URL: https://github.com/nodejs/node/pull/53951
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-22 13:21:35 +00:00
Aviv Keller
96a614d63a
meta: make more bug-report information required
...
PR-URL: https://github.com/nodejs/node/pull/53718
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2024-07-22 13:21:27 +00:00
Tobias Nießen
ad0a2db975
src,test: disallow unsafe integer coercion in SQLite
...
Currently, by default (i.e., when use_big_ints_ has not explicitly been
set to true), reading a SQLite integer value that is not a safe integer
in JavaScript is likely to yield an incorrect number.
Instead, err on the side of caution and throw if the stored integer is
not a safe integer in JavaScript and if use_big_ints_ has not been set
to true.
PR-URL: https://github.com/nodejs/node/pull/53851
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2024-07-22 12:22:17 +00:00
Abdirahim Musse
c83af17ff9
test: skip --title check on IBM i
...
Similar to SmartOS IBM i does not return the process.title
PR-URL: https://github.com/nodejs/node/pull/53952
Fixes: https://github.com/nodejs/node/issues/53852
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-22 11:39:04 +00:00
Michaël Zasso
1c1c9bf33a
deps: V8: cherry-pick 9812cb486e2b
...
Original commit message:
[api] Remove template id from Local constructor
According to GCC version 14, this is deprecated in C++20.
Change-Id: Iaab14c2db56b3787e391e4d50a9099015169d63f
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5713754
Reviewed-by: Michael Lippautz <mlippautz@chromium.org >
Auto-Submit: Michaël Zasso <mic.besace@gmail.com >
Reviewed-by: Camillo Bruni <cbruni@chromium.org >
Commit-Queue: Camillo Bruni <cbruni@chromium.org >
Cr-Commit-Position: refs/heads/main@{#95084}
Refs: 9812cb486e
PR-URL: https://github.com/nodejs/node/pull/53966
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
2024-07-22 09:53:44 +00:00
Cheng
097a52848e
src: do not save c_str of a temp string
...
PR-URL: https://github.com/nodejs/node/pull/53941
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-22 07:15:03 +00:00
Benjamin Gruenbaum
259163802c
test: validate promise-version setTimeout behavior with NaN
...
PR-URL: https://github.com/nodejs/node/pull/53622
Refs: https://github.com/nodejs/node/pull/46678
Reviewed-By: Debadree Chatterjee <debadree333@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-22 07:52:57 +02:00
Colin Ihrig
ea837a0db9
test_runner: refactor coverage to pass in config options
...
This commit updates the test runner's code coverage so that
coverage options are explicitly passed in instead of pulled
from command line options.
PR-URL: https://github.com/nodejs/node/pull/53931
Refs: https://github.com/nodejs/node/issues/53924
Refs: https://github.com/nodejs/node/issues/53867
Refs: https://github.com/nodejs/node/pull/53866
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-22 04:26:43 +00:00
Rafael Gonzaga
532767b71d
src: cache invariant code motion
...
PR-URL: https://github.com/nodejs/node/pull/53879
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Tim Perry <pimterry@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2024-07-21 23:18:57 +00:00
Tobias Nießen
7022e69b2e
src: avoid strcmp in ImportJWKAsymmetricKey
...
Use std::string_view and its operator== instead of calling strcmp on a
const char*.
PR-URL: https://github.com/nodejs/node/pull/53813
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2024-07-21 22:23:45 +00:00
Aviv Keller
85fded51df
doc: update boxstarter README
...
PR-URL: https://github.com/nodejs/node/pull/53785
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-07-21 22:23:31 +00:00
Ehsan Khakifirooz
aca31b8e0f
lib: improve cluster/primary code
...
PR-URL: https://github.com/nodejs/node/pull/53756
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2024-07-21 22:23:17 +00:00
Aviv Keller
e8c2acf5de
meta: reword linter messages
...
PR-URL: https://github.com/nodejs/node/pull/53949
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-22 00:21:42 +02:00
James M Snell
eb85db4606
src: switch from ToLocalChecked to ToLocal in node_webstorage
...
PR-URL: https://github.com/nodejs/node/pull/53959
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2024-07-21 22:11:33 +00:00
Liran Tal
47b877993f
child_process: fix incomplete prototype pollution hardening
...
Prior pull request (#48726 ) hardened against prototype pollution
vulnerabilities but effectively missed some use-cases which
opened a window for prototype pollution for some child_process
functions such as spawn(), spawnSync(), and execFileSync().
PR-URL: https://github.com/nodejs/node/pull/53781
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2024-07-21 21:27:04 +00:00
Yagiz Nizipli
1fb23f1897
src: move ToNamespacedPath call of webstorage
...
PR-URL: https://github.com/nodejs/node/pull/53875
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-21 20:49:10 +00:00
Antoine du Hamel
52ba14405b
tools: fix SLACK_TITLE in invalid commit workflow
...
PR-URL: https://github.com/nodejs/node/pull/53912
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-07-21 19:43:40 +00:00
Grigory
acd1d22ff8
doc: add info about prefix-only modules to module.builtinModules
...
PR-URL: https://github.com/nodejs/node/pull/53954
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-07-21 17:51:20 +00:00
Antoine du Hamel
036ff03691
test: reduce flakiness of test-assert-esm-cjs-message-verify
...
PR-URL: https://github.com/nodejs/node/pull/53967
Fixes: https://github.com/nodejs/node/issues/53962
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2024-07-21 17:34:38 +00:00
Antoine du Hamel
d0a6b605fb
test: use PYTHON executable from env in assertSnapshot
...
PR-URL: https://github.com/nodejs/node/pull/53938
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2024-07-21 15:53:07 +00:00
Antoine du Hamel
bc677d1937
doc,tools: enforce use of node: prefix
...
PR-URL: https://github.com/nodejs/node/pull/53950
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com >
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com >
2024-07-21 15:44:27 +00:00
Cloyd Lau
befbe69a0d
doc: remove scroll-behavior: smooth;
...
PR-URL: https://github.com/nodejs/node/pull/53942
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-07-21 11:15:28 +00:00
Aviv Keller
79759fa0ac
meta: store actions secrets in environment
...
PR-URL: https://github.com/nodejs/node/pull/53930
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-20 19:33:29 +00:00
Geoffrey Booth
604ce4cc66
module: unflag detect-module
...
PR-URL: https://github.com/nodejs/node/pull/53619
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2024-07-20 18:30:46 +00:00
Yagiz Nizipli
638d5fd8a5
build: trigger coverage ci when updating codecov
...
PR-URL: https://github.com/nodejs/node/pull/53929
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2024-07-20 18:16:59 +00:00
Yagiz Nizipli
992884a07f
build: update codecov coverage build count
...
PR-URL: https://github.com/nodejs/node/pull/53929
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
2024-07-20 18:16:59 +00:00
Colin Ihrig
dab12a2f01
test_runner: refactor and simplify internals
...
This commit refactors some of the internals of the test runner.
PR-URL: https://github.com/nodejs/node/pull/53921
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-20 16:59:47 +00:00
Colin Ihrig
7702aab336
doc: move --test-coverage-{ex,in}clude to proper location
...
This commit moves the documentation for two CLI flags to the
proper sorted location.
PR-URL: https://github.com/nodejs/node/pull/53926
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2024-07-20 13:26:09 +00:00
Luigi Pinca
50d09bc5f6
test: deflake test-blob-file-backed
...
Avoid race conditions by using a different file for each subtest.
Fixes: https://github.com/nodejs/node/issues/51860
PR-URL: https://github.com/nodejs/node/pull/53920
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Michael Dawson <midawson@redhat.com >
2024-07-20 13:16:23 +00:00
Vinicius Lourenço
cf8e5356d9
lib: improve error message when index not found on cjs
...
PR-URL: https://github.com/nodejs/node/pull/53859
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2024-07-20 00:22:24 +00:00
Aviv Keller
6fc0218e3e
doc: add --experimental-sqlite note
...
PR-URL: https://github.com/nodejs/node/pull/53907
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2024-07-19 19:28:19 +00:00
Michaël Zasso
03f7f8c1b8
build,tools: simplify upload of shasum signatures
...
Use the same prompt for uploads to the web host and Cloudflare R2.
PR-URL: https://github.com/nodejs/node/pull/53892
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2024-07-19 16:31:03 +00:00
Richard Lau
45ff44b987
2024-07-19, Version 22.5.1 (Current)
...
Notable changes:
This release fixes a regression introduced in Node.js 22.5.0. The
problem is known to display the following symptoms:
- Crash with
```
FATAL ERROR: v8::Object::GetCreationContextChecked No creation context available
```
- npm errors with `npm error Exit handler never called!`
- yarn hangs or outputs
```
Usage Error: Couldn't find the node_modules state file - running an install might help (findPackageLocation)
```
PR-URL: https://github.com/nodejs/node/pull/53935
Refs: https://github.com/nodejs/node/issues/53902
Refs: https://github.com/npm/cli/issues/7657
Refs: https://github.com/yarnpkg/berry/issues/6398
2024-07-19 13:41:24 +00:00
Tobias Nießen
cd39578e53
src: use Maybe<void> in SecureContext
...
With recent versions of V8, it is not necessary to use Maybe<bool>
anymore. This changes member functions of SecureContext to use
Maybe<void> instead.
PR-URL: https://github.com/nodejs/node/pull/53883
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-07-19 12:19:12 +00:00
jakecastelli
7fe67b7078
doc,tty: add documentation for ReadStream and WriteStream
...
Co-authored-by: Qingyu Deng <i@ayase-lab.com >
PR-URL: https://github.com/nodejs/node/pull/53567
Fixes: https://github.com/nodejs/node/issues/37780
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Raz Luvaton <rluvaton@gmail.com >
Reviewed-By: Claudio Wunder <cwunder@gnome.org >
2024-07-19 10:53:24 +00:00
Aviv Keller
86f79e6e7c
doc: update api_assets README for new files
...
PR-URL: https://github.com/nodejs/node/pull/53676
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Claudio Wunder <cwunder@gnome.org >
2024-07-19 10:44:56 +00:00
Kohei Ueno
a523c345b1
inspector: add initial support for network inspection
...
PR-URL: https://github.com/nodejs/node/pull/53593
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
2024-07-19 05:00:30 +00:00
James M Snell
8f8f2a482f
src: replace ToLocalChecked uses with ToLocal in node-file
...
PR-URL: https://github.com/nodejs/node/pull/53869
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Anna Henningsen <anna@addaleax.net >
2024-07-18 21:13:10 -07:00
Aviv Keller
c0c7e866dc
Revert "fs: add v8 fast api to closeSync"
...
This reverts commit ed6f45bef8 .
PR-URL: https://github.com/nodejs/node/pull/53904
Refs: https://github.com/yarnpkg/berry/issues/6398
Refs: https://github.com/npm/cli/issues/7657
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Rich Trott <rtrott@gmail.com >
2024-07-18 22:25:20 +00:00
Yagiz Nizipli
05b7bf01a5
src: refactor webstorage implementation
...
PR-URL: https://github.com/nodejs/node/pull/53876
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
2024-07-18 20:41:49 +00:00
Yagiz Nizipli
7168295e7a
fs: move rmSync implementation to c++
...
PR-URL: https://github.com/nodejs/node/pull/53617
Reviewed-By: Daniel Lemire <daniel@lemire.me >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2024-07-18 20:02:49 +00:00
Antoine du Hamel
cafd44dc7e
esm: refactor get_format
...
PR-URL: https://github.com/nodejs/node/pull/53872
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Paolo Insogna <paolo@cowtech.it >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2024-07-18 17:57:40 +00:00
Chengzhong Wu
63d7b4280e
lib: decorate async stack trace in source maps
...
Decorate stack frame with 'async' and 'new' keywords based on the type
of the call site info.
PR-URL: https://github.com/nodejs/node/pull/53860
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2024-07-18 14:45:43 +00:00
Aviv Keller
3d019ce6af
cli: document --inspect port 0 behavior
...
PR-URL: https://github.com/nodejs/node/pull/53782
Reviewed-By: Kohei Ueno <kohei.ueno119@gmail.com >
2024-07-18 14:28:44 +00:00
James M Snell
efe5b81df9
deps: start working on ncrypto dep
...
Start moving src/crypto functionality out to a separate dep that
can be shared with other projects that need to emulate Node.js
crypto behavior.
PR-URL: https://github.com/nodejs/node/pull/53803
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2024-07-18 06:56:53 -07:00
Mattias Buelens
c77424c990
doc: add MattiasBuelens to collaborators
...
PR-URL: https://github.com/nodejs/node/pull/53895
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Richard Lau <rlau@redhat.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-07-18 13:55:58 +00:00
Cheng
014dad5953
deps: fix include_dirs of nbytes
...
PR-URL: https://github.com/nodejs/node/pull/53862
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Jiawen Geng <technicalcute@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2024-07-18 07:39:34 +00:00
Jonas
bcec922e3e
fs: remove unnecessary option argument validation
...
PR-URL: https://github.com/nodejs/node/pull/53861
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br >
2024-07-17 23:29:56 +00:00