OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
36,203 Commits 30 Branches 683 Tags
183447888bcbd1d6bfc433a38c77900ed6199bc2
Commit Graph

36203 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Juan José
183447888b doc: improve commit message example for releases 
PR-URL: https://github.com/nodejs/node/pull/42954
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
 2022-05-06 17:16:28 +01:00
Tobias Nießen
74af116b2e doc: use serial comma in cluster docs 
Refs: https://github.com/nodejs/node/pull/11321
Refs: https://github.com/nodejs/node/pull/17384

PR-URL: https://github.com/nodejs/node/pull/42989
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2022-05-06 15:56:56 +01:00
Sergey Nazaryev
5e9274a3e7 build: fix indeterminacy of icu_locales value 
`icu_locales` is generated by joining values from `set` data structure.
However, `set` doesn't guarantee an order, so the result of
`icu_locales` is not determined. For example, the result value could be
'en,root' or 'root,en'. This fix makes it deterministic.

The main reason of this fix is to restore the reproducibility of the
build because the value of `icu_locales` is embedded into `node` binary.

PR-URL: https://github.com/nodejs/node/pull/42865
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
 2022-05-06 12:20:44 +01:00
Node.js GitHub Bot
cf5afb78e9 meta: move one or more collaborators to emeritus 
PR-URL: https://github.com/nodejs/node/pull/42937
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
 2022-05-05 19:38:59 -07:00
Tobias Nießen
55079bbebf lib,test: enable wasm/webapi/empty-body WPT 
Refs: https://github.com/nodejs/node/pull/42701
Refs: https://github.com/nodejs/undici/pull/1346
Refs: https://github.com/nodejs/node/pull/42939

PR-URL: https://github.com/nodejs/node/pull/42960
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2022-05-05 22:57:31 +01:00
Daeyeon Jeong
deb713e24b test: rename handlewrap.hasref tests 
`HandleWrap.isRefed()` was renamed to `hasRef()`. However, the filename
of related TCs has not been reflected.

Refs: https://github.com/nodejs/node/commit/f31a5ec34a

PR-URL: https://github.com/nodejs/node/pull/42754
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-05-05 14:15:03 +01:00
Darshan Sen
30388fc796 bootstrap: stop delaying instantiation of maps in per-context scripts 
The linked issue, https://bugs.chromium.org/p/v8/issues/detail?id=6593,
is marked as "Fixed", so I think we can revert this now.

This reverts commit 08a9c4a996.

Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/42934
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=9187
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-05-05 12:56:12 +01:00
Livia Medeiros
edcc542996 test: improve observable ICU behaviour coverage 
PR-URL: https://github.com/nodejs/node/pull/42683
Refs: https://github.com/nodejs/node/issues/42440
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-05-05 12:49:20 +01:00
Yoshiki Kurihara
5ef83bab6f test: validate webstream encoder/decoder inspector 
PR-URL: https://github.com/nodejs/node/pull/42747
Refs: https://coverage.nodejs.org/coverage-24adba675179ebba/lib/internal/webstreams/encoding.js.html#L98
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-05-05 12:48:55 +01:00
MURAKAMI Masahiko
a571a3fed1 test: usemustSucceed instead of mustCall with assert.ifError 
PR-URL: https://github.com/nodejs/node/pull/42806
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-05-05 12:48:46 +01:00
MURAKAMI Masahiko
277353c902 test: improve lib/internal/webstreams/readablestream.js coverage 
PR-URL: https://github.com/nodejs/node/pull/42823
Refs: https://coverage.nodejs.org/coverage-3a6b975981092213/lib/internal/webstreams/readablestream.js.html#L421
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2022-05-05 12:48:37 +01:00
Antoine du Hamel
a3ff4bfc66 url: revert "validate ipv4 part length" 
This reverts commit 87d0d7a069.

Refs: https://github.com/nodejs/node/pull/42915

PR-URL: https://github.com/nodejs/node/pull/42940
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-05-05 12:41:35 +01:00
Joyee Cheung
f7d658a888 bootstrap: use a context snapshotted with primordials in workers 
PR-URL: https://github.com/nodejs/node/pull/42867
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-05-05 12:37:01 +01:00
npm-robot
ffa1f84009 deps: upgrade npm to 8.9.0 
PR-URL: https://github.com/nodejs/node/pull/42968
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2022-05-05 10:55:34 +01:00
Darshan Sen
7ff2170f36 src,crypto: remove uses of AllocatedBuffer from crypto_rsa.cc 
Refs: https://github.com/nodejs/node/pull/39941
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/42852
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2022-05-04 21:33:09 +01:00
Livia Medeiros
a5b8730525 crypto: adjust minimum length in generateKey('hmac', ...) 
Also affects generateKeySync('hmac', ...)

PR-URL: https://github.com/nodejs/node/pull/42944
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-05-04 20:31:23 +01:00
Vita Batrla
2454aa0f1f test: fix test-crypto-fips.js under shared OpenSSL 
Fixes: https://github.com/nodejs/node/issues/42827

PR-URL: https://github.com/nodejs/node/pull/42947
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2022-05-04 14:20:59 -04:00
Juan José Arboleda
755721a80c 2022-05-04, Version 14.19.2 'Fermium' (LTS) 
Notable Changes

doc:

* New release key for Bryan English

Learn more at: https://github.com/nodejs/node/pull/42102
Contributed by Bryan English (bengl)

npm:

* Upgrade `npm` to `v6.14.17`.

Learn more at: https://github.com/nodejs/node/pull/42900
Contributed by Ruy Adorno (ruyadorno)

V8:

* V8 had a stack overflow issue affecting the `vm` module,
cherry-picking `cc9a8a37445e`
(cc9a8a3744)
from V8 solves this issue.

Learn more at: https://github.com/nodejs/node/pull/41826
Contributed by Gus Caplan (devsnek)

* Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue,
this is fixed by backporting `367b0c1e7a32`
(367b0c1e7a)
from V8.

Learn more at: https://github.com/nodejs/node/pull/42637
Contributed by Chengzhong Wu (legendecas)

PR-URL: https://github.com/nodejs/node/pull/42899
 2022-05-04 12:05:24 -05:00
Jacob Smith
d859e9e997 esm: add chaining to loaders 
PR-URL: https://github.com/nodejs/node/pull/42623
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-05-04 16:51:12 +01:00
Shogun
c3aa86d678 test: use consistent timeouts 
PR-URL: https://github.com/nodejs/node/pull/42893
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Co-authored-by: Luigi Pinca <luigipinca@gmail.com>
 2022-05-03 15:23:23 +02:00
Shogun
f714a0fa6e http: added connection closing methods 
Fixes: https://github.com/nodejs/node/issues/41578

PR-URL: https://github.com/nodejs/node/pull/42812
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2022-05-03 14:04:07 +02:00
Michaël Zasso
6ebe5a4ff0 2022-05-03, Version 18.1.0 (Current) 
Notable changes:

doc:
  * add @kuriyosh to collaborators (Yoshiki Kurihara) https://github.com/nodejs/node/pull/42824
lib,src:
  * (SEMVER-MINOR) implement WebAssembly Web API (Tobias Nießen) https://github.com/nodejs/node/pull/42701
test_runner:
  * (SEMVER-MINOR) add initial CLI runner (Colin Ihrig) https://github.com/nodejs/node/pull/42658
worker:
  * (SEMVER-MINOR) add hasRef() to MessagePort (Darshan Sen) https://github.com/nodejs/node/pull/42849

PR-URL: https://github.com/nodejs/node/pull/42943
 2022-05-03 13:53:19 +02:00
OneNail
2be596604a doc: fix errors in Web Streams doc 
PR-URL: https://github.com/nodejs/node/pull/42862
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2022-05-03 03:07:43 +01:00
OneNail
f6f95bf61e doc: fix examples in cluster.md 
PR-URL: https://github.com/nodejs/node/pull/42889
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2022-05-02 22:24:13 +01:00
liuxingbaoyu
ce29d2847b src: fix memory leak for v8.serialize 
When Buffer::New passes in existing data,
it cannot be garbage collected in js synchronous execution.

Fixes: https://github.com/nodejs/node/issues/40828
Refs: https://github.com/nodejs/node/issues/38300

PR-URL: https://github.com/nodejs/node/pull/42695
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
 2022-05-02 20:45:47 +01:00
Michael Dawson
961967c1ff doc: add additional step to security release process 
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/42916
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2022-05-02 14:59:38 -04:00
Livia Medeiros
57678e5581 fs: add read(buffer[, options]) versions 
This adds the following:
- `fs.read(fd, buffer[, options], callback)`.
- `filehandle.read(buffer[, options])`.

PR-URL: https://github.com/nodejs/node/pull/42768
Refs: https://github.com/nodejs/node/pull/42601
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-05-02 20:01:27 +02:00
Livia Medeiros
6be94c9443 test: add test for position validation in fs.read() and fs.readSync() 
PR-URL: https://github.com/nodejs/node/pull/42837
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-05-02 19:52:43 +02:00
OneNail
916a13a8a3 http2: compat support for array headers 
PR-URL: https://github.com/nodejs/node/pull/42901
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2022-05-02 18:48:13 +01:00
Joyee Cheung
acffd3d9e6 bootstrap: fix wasm_web_api external reference registration 
The external references were not actually registered.

PR-URL: https://github.com/nodejs/node/pull/42903
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2022-05-02 18:47:08 +01:00
Antoine du Hamel
2b41f5980e assert: make assert.fail less affected by prototype tampering 
PR-URL: https://github.com/nodejs/node/pull/42918
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2022-05-02 18:46:24 +01:00
Antoine du Hamel
52ba02e874 doc: add section regarding property definition in primordials.md 
PR-URL: https://github.com/nodejs/node/pull/42921
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
 2022-05-02 18:46:13 +01:00
Tobias Nießen
75dbb86c58 crypto: clean up parameter validation in HKDF 
PR-URL: https://github.com/nodejs/node/pull/42924
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
 2022-05-02 18:46:04 +01:00
Livia Medeiros
73a8a0ee3c doc: clarify some default values in fs.md 
PR-URL: https://github.com/nodejs/node/pull/42892
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
 2022-05-02 19:40:30 +02:00
Tobias Nießen
0fc455a219 test: reduce impact of flaky HTTP server tests 
Refs: https://github.com/nodejs/node/issues/42741

PR-URL: https://github.com/nodejs/node/pull/42926
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-05-02 19:33:42 +02:00
legendecas
e86a638305 src: add initial shadow realm support 
Add initial shadow realm support behind an off-by-default flag
`--experimental-shadow-realm`.

PR-URL: https://github.com/nodejs/node/pull/42869
Refs: https://github.com/nodejs/node/issues/42528
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-05-02 18:46:31 +02:00
Michaël Zasso
3bd87e1782 deps: update undici to 5.1.1 
PR-URL: https://github.com/nodejs/node/pull/42939
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
 2022-05-02 13:15:50 +01:00
Darshan Sen
1d8a320a04 worker: add hasRef() to MessagePort 
Since we were removing the hasRef() method before exposing the
MessagePort object, the only way of knowing if the handle was keeping
the event loop active was to parse the string returned by
util.inspect(port), which is inconvenient and inconsistent with most of
the other async resources. So this change stops removing hasRef() from
the MessagePort prototype. The reason why this is also being documented
is that while reporting active resources, async_hooks returns the same
MessagePort object as the one that is accessible by users.

Refs: https://github.com/nodejs/node/issues/42091#issuecomment-1104793189
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/42849
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2022-05-02 05:39:39 +01:00
Node.js GitHub Bot
7a53696c8a tools: update lint-md-dependencies 
Update to @rollup/plugin-commonjs@22.0.0 rollup@2.71.1

PR-URL: https://github.com/nodejs/node/pull/42932
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
 2022-05-01 21:39:22 +01:00
Yagiz Nizipli
87d0d7a069 url: validate ipv4 part length 
PR-URL: https://github.com/nodejs/node/pull/42915
Fixes: https://github.com/nodejs/node/issues/42914
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-05-01 13:27:37 -07:00
Himself65
3d0fc13ba3 perf_hooks: return different functions in timerify 
Fixes: https://github.com/nodejs/node/issues/42742

PR-URL: https://github.com/nodejs/node/pull/42854
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Co-authored-by: HE Shi-Jun <hax@heshijun.net>
 2022-05-01 14:47:24 -05:00
Kohei Ueno
d268cf5a22 test: add tests for extracting function name 
PR-URL: https://github.com/nodejs/node/pull/42399
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-05-01 04:51:14 +01:00
Luigi Pinca
02e0c174a4 test: simplify test-gc-{http-client,net}-* 
Instead of sending/creating a fixed number of requests/connections,
detect when GC has started and stop sending requests/creating
connections at that point.

Refs: https://github.com/nodejs/node/commit/47ecf2060343
Refs: https://github.com/nodejs/node/commit/7ce8403ef1a6

PR-URL: https://github.com/nodejs/node/pull/42782
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2022-04-29 21:17:47 +02:00
theanarkh
000a0c853b v8: export cpu_profiler_metadata_size in getHeapCodeStatistics 
PR-URL: https://github.com/nodejs/node/pull/42818
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-04-29 16:21:41 +01:00
Antoine du Hamel
27ecf1d94c esm: fix imports from non-file module 
Fixes: https://github.com/nodejs/node/issues/42860

PR-URL: https://github.com/nodejs/node/pull/42881
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
 2022-04-29 15:04:12 +01:00
Antoine du Hamel
68fb0bf553 test: fix parallel/test-dgram-udp6-link-local-address 
Refs: https://github.com/nodejs/node/pull/41431

PR-URL: https://github.com/nodejs/node/pull/42795
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-04-28 20:00:19 +01:00
Anna Henningsen
d4699c7805 src: turn SSL_CTX_new CHECK/segfault into JS exception 
These operations do not usually fail, but can do so when OpenSSL
is not configured properly (I ran into this while dynamically linking
against OpenSSL with FIPS). JS exceptions are way more useful
than CHECK failures or plain segfaults.

PR-URL: https://github.com/nodejs/node/pull/42799
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2022-04-28 19:59:00 +01:00
LiviaMedeiros
b7cd49fdd5 doc: reword "test directory" 
PR-URL: https://github.com/nodejs/node/pull/42817
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-04-28 18:58:48 +00:00
LiviaMedeiros
85a77b0cbf doc: remove legacy -J test.py option from BUILDING.md 
PR-URL: https://github.com/nodejs/node/pull/42817
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-04-28 18:58:47 +00:00
Daeyeon Jeong
489e2299ed doc: http2.createServer options as optional 
The method might be designed to explicitly take `options`. However,
the implementation and many examples already allow the first parameter
of a function type.

PR-URL: https://github.com/nodejs/node/pull/42832
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
 2022-04-28 19:58:38 +01:00