OSSForks/node
1
0
Fork 0
mirror of https://github.com/zebrajr/node.git synced 2026-01-15 12:15:26 +00:00
Code Issues Actions 8 Packages Projects Releases Wiki Activity
31,069 Commits 30 Branches 683 Tags
1198aebd2db710b22bfed003edcf8cca2db8a174
Commit Graph

31069 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Benjamin Coe
1198aebd2d deps: V8: backport 2d5017a0fc02 
Original commit message:

    [coverage] remove the last continuation range before synthetic return

    Rather than only removing the continuation range for the last return
    statement prior to a synthetic return statement, remove the
    continuation tracking for whatever statement occurs prior to the
    synthetic return.

    Bug: v8:10628
    Change-Id: Ieb8e393479c9811cf1b9756840bbfdbe7f44a1b8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280585
    Commit-Queue: Benjamin Coe <bencoe@google.com>
    Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68719}

Refs: 2d5017a0fc

PR-URL: https://github.com/nodejs/node/pull/34272
Refs: https://github.com/bcoe/c8/issues/229
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
 2020-07-09 13:40:50 -07:00
James M Snell
99f0404646 doc: specify encoding in text/html examples 
Fixes: https://github.com/nodejs/node/issues/29739

PR-URL: https://github.com/nodejs/node/pull/34222
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2020-07-09 08:49:50 -07:00
James M Snell
f98a441bf7 doc: document the ready event for Http2Stream 
Fixes: https://github.com/nodejs/node/issues/22804

PR-URL: https://github.com/nodejs/node/pull/34221
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-07-09 07:36:34 -07:00
James M Snell
a720c0edcc doc: add comment to example about 2xx status codes 
Fixes: https://github.com/nodejs/node/issues/29714

PR-URL: https://github.com/nodejs/node/pull/34223
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-07-09 07:35:37 -07:00
James M Snell
14ac6e4226 doc: document that whitespace is ignored in base64 decoding 
Fixes: https://github.com/nodejs/node/issues/8569

PR-URL: https://github.com/nodejs/node/pull/34227
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-07-09 07:34:30 -07:00
James M Snell
62bdb7e801 doc: add note about multiple sync events and once 
Fixes: https://github.com/nodejs/node/issues/32431

PR-URL: https://github.com/nodejs/node/pull/34220
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-07-09 07:31:54 -07:00
James M Snell
949d1c1f0c doc: document behavior for once(ee, 'error') 
Fixes: https://github.com/nodejs/node/issues/31244

PR-URL: https://github.com/nodejs/node/pull/34225
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-09 07:25:08 -07:00
James M Snell
a95fb930d0 doc: document security issues with url.parse() 
Fixes: https://github.com/nodejs/node/issues/31279

PR-URL: https://github.com/nodejs/node/pull/34226
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-07-09 07:21:04 -07:00
James M Snell
26493c02a2 quic: remove no longer valid CHECK 
PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-09 07:15:44 -07:00
James M Snell
458d243f20 quic: proper custom inspect for QuicStream 
PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-09 07:15:44 -07:00
James M Snell
0860b11655 quic: proper custom inspect for QuicSession 
PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-09 07:15:44 -07:00
James M Snell
b047930d76 quic: proper custom inspect for QuicSocket 
PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-09 07:15:44 -07:00
James M Snell
511f8c1138 quic: proper custom inspect for QuicEndpoint 
PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-09 07:15:43 -07:00
James M Snell
fe11f6bf7c quic: cleanup QuicSocketFlags, used shared state struct 
Some of the flags were no longer being used.

Switched to use an AliasedStruct for shared state to avoid
extraneous expensive JS=>C++ calls.

Removed unused QuicSocket option

PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-09 07:15:43 -07:00
James M Snell
d08e99de24 quic: use getter/setter for stateless reset toggle 
PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-09 07:15:43 -07:00
Anna Henningsen
f2753c7695 quic: unref timers again 
0f97d6066a accidentally removed this.

Refs: https://github.com/nodejs/node/pull/34186

PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-07-09 07:15:27 -07:00
James M Snell
71236097d0 quic: use Number() instead of bigint for QuicSocket stats 
PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-09 07:14:17 -07:00
James M Snell
94372b124a quic: refactor/improve/document QuicSocket listening event 
PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-09 07:14:14 -07:00
James M Snell
afc9390ae5 quic: refactor/improve QuicSocket ready event handling 
PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-09 07:14:12 -07:00
James M Snell
e3813261b8 quic: add tests confirming error handling for QuicSocket close event 
PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-09 07:14:09 -07:00
James M Snell
cc89aac5f7 quic: refactor/improve error handling for busy event 
Also, change setServerBusy into a setter

PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-09 07:14:07 -07:00
James M Snell
edc71ef008 quic: handle errors thrown / rejections in the session event 
Errors thrown within the session event handler will be handled
by destroying the session (allowing a proper connection close
to be sent to the client peer). They will not crash the parent
QuicSocket by default. Instead, a `'sessionError'` event will
be emitted, allowing the error to be logged or handled.

PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-09 07:14:05 -07:00
James M Snell
bcde849be9 quic: remove unnecessary bool conversion 
The argument will always be a boolean already

PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-09 07:14:02 -07:00
James M Snell
c535131627 quic: additional minor cleanups in node_quic_session.h 
PR-URL: https://github.com/nodejs/node/pull/34247
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-09 07:14:00 -07:00
Robert Nagy
e8f57456be http: add note about timer unref 
PR-URL: https://github.com/nodejs/node/pull/34143
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-07-09 09:14:12 +02:00
rickyes
527e2147af stream: add promises version to utility functions 
PR-URL: https://github.com/nodejs/node/pull/33991
Fixes: https://github.com/nodejs/node/issues/33582
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2020-07-09 09:12:19 +02:00
Rich Trott
6ae1b9c457 test: add known issue for fs.open() keeping event loop open 
PR-URL: https://github.com/nodejs/node/pull/34228
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2020-07-08 18:10:42 -07:00
Gabriel Schulhof
c08920b0c4 test: add n-api null checks for conversions 
Add assertions that conversion and coercion N-APIs return appropriate
error statuses when given `NULL`s for parameters they expect to not be
`NULL`.

For `napi_get_value_string_*` this also checks that it returns
`napi_string_expected` when passed a `napi_value` not containing a
string.

PR-URL: https://github.com/nodejs/node/pull/34142
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
 2020-07-08 10:32:16 -07:00
Johannes Schöpp
b99253cfcf Forces Powershell to use tls1.2 
Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2
Tls 1.2 is supported in all current microsoft operating systems and
needed to download chocolatey.

Fixes: https://github.com/nodejs/node/issues/33140

PR-URL: https://github.com/nodejs/node/pull/33609
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2020-07-08 12:24:39 +02:00
rickyes
e0ecde9737 test: add arrayOfStreams to pipeline 
PR-URL: https://github.com/nodejs/node/pull/34156
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-07 23:48:16 +02:00
Xu Meng
7a84e2e071 test: skip an ipv6 test on IBM i 
Due to some unknown system configuration, the code
`socket_ipv6.bind(0, 111::1)` does not throw the
expected error EADDRNOTAVAIL on some IBM i systems.
This issue is still being investigated. To get the
IBM i CI passing, skip it for now.

PR-URL: https://github.com/nodejs/node/pull/34209
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2020-07-07 23:43:55 +02:00
Anna Henningsen
cb67be7f67 test: add regression test for C++-created Buffer transfer 
Add a test for a regression that occurs when transferring some
`Buffer` objects that were created from C++ to a parent thread.

Fixes: https://github.com/nodejs/node/issues/34126

PR-URL: https://github.com/nodejs/node/pull/34140
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
 2020-07-07 23:41:50 +02:00
Anna Henningsen
6bc871f470 src: exit explicitly after printing V8 help 
V8 will not exit the process after handling --help anymore:
https://chromium-review.googlesource.com/c/v8/v8/+/2276276

As a drive-by fix, correctly return in the `print_bash_completion`
case as well.

Refs: https://github.com/nodejs/node/pull/34135
Co-authored-by: Ulan Degenbaev <ulan@chromium.org>

PR-URL: https://github.com/nodejs/node/pull/34136
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2020-07-07 23:41:20 +02:00
Anna Henningsen
2243d79f74 domain: fix unintentional deprecation warning 
646e5a4717 changed the way that the domain hook callback
is called. Previously, the callback was only used in the case that
async_hooks were *not* being used (since domains already integrate
with async hooks the way they should), and the corresponding
deprecation warning also only emitted in that case.

However, that commit didn’t move that condition along when the code
was ported from C++ to JS. As a consequence, the domain hook callback
was used when it wasn’t necessary to use it, and the deprecation
warning emitted accidentally along with it.

Refs: 646e5a4717 (diff-9f21ce1b9d6d46fdd07b969e8a04e140L192)
Refs: 646e5a4717 (diff-e6db408e12db906ead6ddfac3de15a6fR119)
Refs: https://github.com/nodejs/node/pull/33801#issuecomment-654744913

PR-URL: https://github.com/nodejs/node/pull/34245
Fixes: https://github.com/nodejs/node/issues/34069
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
 2020-07-07 22:08:16 +02:00
Daniel Bevenius
30612316e4 src: add encoding_type variable in WritePrivateKey 
This commit adds a local variable named encoding_type which is set to
the value of the Maybe using ToChecked().

The motivation for this is the code for ToChecked() could be executed
multiple times depending on path taken at runtime. I also think this
improves readability, or at least it is as readable as before this
change.

PR-URL: https://github.com/nodejs/node/pull/34181
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
 2020-07-07 06:10:12 +02:00
Rich Trott
772fdb0cd3 test: fix flaky test-fs-stream-construct 
The test is marked flaky on ARM because it times out on Raspberry Pi
devices in CI. Split the single test file into four separate test files
to ease debugging. Add fs.close() to avoid timing out.

Fixes: https://github.com/nodejs/node/issues/33796

PR-URL: https://github.com/nodejs/node/pull/34203
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
 2020-07-06 17:32:24 -07:00
sapics
ee3416b055 lib: replace http to https of comment link urls 
PR-URL: https://github.com/nodejs/node/pull/34158
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-07-06 07:03:08 -07:00
sapics
3975799f26 doc: replace http to https of link urls 
PR-URL: https://github.com/nodejs/node/pull/34158
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-07-06 07:03:05 -07:00
Rich Trott
bf772896fe doc: remove errors that were never released 
Refs: https://github.com/nodejs/node/pull/33764#issuecomment-653667275

PR-URL: https://github.com/nodejs/node/pull/34197
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-07-06 07:02:17 -07:00
Rich Trott
9f0671ebc9 test: replace deprecated function call from test-repl-history-navigation 
test-repl-history-navigation fails with NODE_PENDING_DEPRECATION=1.
Replace deprecated repl.inputStream with repl.input.

PR-URL: https://github.com/nodejs/node/pull/34199
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-07-06 07:01:33 -07:00
Rich Trott
ddfaafa9b0 repl: fix verb conjugation in deprecation message 
PR-URL: https://github.com/nodejs/node/pull/34198
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2020-07-06 07:00:44 -07:00
Daniel Bevenius
67ba825037 src: fix minor comment typo in KeyObjectData 
PR-URL: https://github.com/nodejs/node/pull/34167
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
 2020-07-06 06:39:26 +02:00
Nikola Glavina
82c435d0a0 src: fix unused namespace member 
C++ linter fails because of unused ArrayBuffer namespace member

PR-URL: https://github.com/nodejs/node/pull/34212
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
 2020-07-06 07:56:00 +05:30
Rich Trott
654df09ae0 doc: move ERR_FEATURE_UNAVAILABLE_ON_PLATFORM to current errors 
ERR_FEATURE_UNAVAILABLE_ON_PLATFORM is incorrectly included in the list
of errors that have never been released. It was added in
67e067eb06 and included in every release
in the 14.x line.

PR-URL: https://github.com/nodejs/node/pull/34196
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-07-05 15:05:43 -07:00
Rich Trott
7eb500b538 doc: move digitalinfinity to emeritus 
Had an email exchange with Hitesh where he indicated that it was a fine
time to move him to emeritus.

PR-URL: https://github.com/nodejs/node/pull/34191
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-07-05 15:04:12 -07:00
Rich Trott
8a57788efe doc: move gibfahn to emeritus 
Asked Gibson in email if he should be moved to emeritus and he indicated
it was a good idea.

PR-URL: https://github.com/nodejs/node/pull/34190
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2020-07-05 15:03:33 -07:00
James M Snell
0f97d6066a quic: use TimerWrap for idle and retransmit timers 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/34186
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2020-07-05 14:57:07 -07:00
James M Snell
e19a251824 src: replace InspectorTimer with TimerWrap utility 
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/34186
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2020-07-05 14:57:03 -07:00
James M Snell
d4f69002b4 src: add TimerWrap utility 
Consolidate uv_timer_t boilerplate code into a shared utility.
There are several places throughout the code where we use uv_timer_t
internally (inspector, perf, quic), with some code duplication.
This eliminates the duplicated code, ensures that cleanup occurs
correctly, and simplifies use of the timers.

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/34186
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2020-07-05 14:56:59 -07:00
James M Snell
e7dadd376e doc: specify how fs.WriteStream/ReadStreams are created 
Alternative to https://github.com/nodejs/node/pull/33841

Co-authored-by: zombieleet <zombieleetnca@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/34188
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2020-07-05 14:19:42 -07:00