Pramit Sharma
9c346d22a7
sqlite: improve error messages for tag store
...
When using SQLite tag store functions (sql.get`, sql.run`, etc.),
preparation errors now show descriptive SQLite error messages instead
of the generic 'Failed to prepare statement' message.
The tag store's GetOrCreateStatement function now passes the database
object to THROW_ERR_SQLITE_ERROR, allowing it to retrieve the actual
error message from sqlite3_errmsg(), matching the behavior of the
regular db.prepare() method.
Fixes: https://github.com/nodejs/node/issues/61051
PR-URL: https://github.com/nodejs/node/pull/61096
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-12-27 00:04:05 +00:00
René
5e677d6e7e
stream: do not pass readable.compose() output via Readable.from()
...
PR-URL: https://github.com/nodejs/node/pull/60907
Fixes: https://github.com/nodejs/node/issues/55203
Reviewed-By: Raz Luvaton <rluvaton@gmail.com >
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
2025-12-23 18:52:32 +00:00
sangwook
dc8215b90d
fs: remove broken symlinks in rmSync
...
PR-URL: https://github.com/nodejs/node/pull/61040
Fixes: https://github.com/nodejs/node/issues/61020
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com >
2025-12-23 17:08:31 +00:00
Node.js GitHub Bot
55600e6153
deps: update timezone to 2025c
...
PR-URL: https://github.com/nodejs/node/pull/61138
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2025-12-23 01:09:13 +00:00
Node.js GitHub Bot
76c4bee978
test: update WPT for urlpattern to a2e15ad405
...
PR-URL: https://github.com/nodejs/node/pull/61134
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2025-12-23 00:41:49 +00:00
Ruben Bridgewater
9120924de1
util: fix nested proxy inspection
...
Fixes: https://github.com/nodejs/node/issues/61061
PR-URL: https://github.com/nodejs/node/pull/61077
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day >
2025-12-22 22:22:04 +00:00
Ruben Bridgewater
fc1d6d6b4c
assert,util: fix deep comparing invalid dates skipping properties
...
The property comparison of invalid dates regressed when starting
to handle invalid dates as being equal.
PR-URL: https://github.com/nodejs/node/pull/61076
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2025-12-22 19:30:35 +00:00
Ruben Bridgewater
a968e4e672
assert,util: improve deep comparison performance
...
PR-URL: https://github.com/nodejs/node/pull/61076
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2025-12-22 19:30:34 +00:00
Efe
416db75e42
events: remove eventtarget custom inspect branding
...
PR-URL: https://github.com/nodejs/node/pull/61128
Reviewed-By: Aviv Keller <me@aviv.sh >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2025-12-22 16:14:56 +00:00
Xavier Stouder
472f586840
os: freeze signals constant
...
Remove the ability to mutate signals constant as doing so can lead to
unexpected behavior, notably when spawning child process.
Fixes: https://github.com/nodejs/node/issues/44749
PR-URL: https://github.com/nodejs/node/pull/61038
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Aviv Keller <me@aviv.sh >
2025-12-22 16:14:46 +00:00
Joyee Cheung
28f468a615
module: fix sync resolve hooks for require with node: prefixes
...
Previously, when require()-ing builtins with the node: prefix,
the sync resolve hooks were not properly invoked, and load hooks
could not override the builtin's format. This fixes the
handling and enables redirecting prefixed built-ins to on-disk
files and overriding them with other module types via hooks.
PR-URL: https://github.com/nodejs/node/pull/61088
Fixes: https://github.com/nodejs/node/issues/60005
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2025-12-22 14:35:45 +00:00
Ruben Bridgewater
26b7fd2009
util: limit inspect to only show own properties
...
`Error`'s `cause` and `errors` properties would be visible even if these
were not own properties. This is changed to align with all other
parts of the `inspect` handling.
Fixes: https://github.com/nodejs/node/issues/60717
PR-URL: https://github.com/nodejs/node/pull/61032
Reviewed-By: Jordan Harband <ljharb@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2025-12-22 14:06:14 +01:00
Gürgün Dayıoğlu
a65421a679
process: preserve AsyncLocalStorage in queueMicrotask only when needed
...
PR-URL: https://github.com/nodejs/node/pull/60913
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com >
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de >
2025-12-21 01:12:15 +00:00
René
ed6ec9626e
test: make buffer sizes 32bit-aware in test-internal-util-construct-sab
...
PR-URL: https://github.com/nodejs/node/pull/61026
Fixes: https://github.com/nodejs/node/issues/61025
Refs: https://github.com/nodejs/node/pull/60497
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2025-12-20 22:20:21 +00:00
Tobias Nießen
dff46c07c3
crypto: move DEP0182 to End-of-Life
...
This commit moves support for implicitly short GCM authentication tags
to End-of-Life status, thus requiring applications to explicitly specify
the `authTagLength` for authentication tags shorter than 128 bits.
There is quite a bit of refactoring to be done in the C++ source code.
This commit does not do that; instead, it implements a minimal change
only in order to avoid excessive divergence across git branches due to
this being a semver-major change.
Fixes: https://github.com/nodejs/node/issues/52327
Refs: https://github.com/nodejs/node/issues/17523
PR-URL: https://github.com/nodejs/node/pull/61084
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
2025-12-20 22:02:29 +00:00
Dario Piotrowicz
aad8c05595
repl: fix getters triggering side effects during completion
...
PR-URL: https://github.com/nodejs/node/pull/61043
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
Reviewed-By: Aviv Keller <me@aviv.sh >
2025-12-20 18:54:12 +00:00
Ruben Bridgewater
dc97b507d0
util: mark proxied objects as such when inspecting them
...
Fixes: https://github.com/nodejs/node/issues/60964
PR-URL: https://github.com/nodejs/node/pull/61029
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2025-12-20 17:02:17 +00:00
Dario Piotrowicz
e5b6f89328
test: remove unneccessary repl magic_mode tests
...
PR-URL: https://github.com/nodejs/node/pull/61053
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de >
2025-12-20 15:54:07 +00:00
Stewart X Addison
6338e643a8
test: skip sea tests on riscv64
...
Signed-off-by: Stewart X Addison <sxa@ibm.com >
PR-URL: https://github.com/nodejs/node/pull/61111
Reviewed-By: Richard Lau <richard.lau@ibm.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Xuguang Mei <meixuguang@gmail.com >
2025-12-20 15:49:08 +00:00
Joyee Cheung
4f24aff94a
module: preserve URL in the parent created by createRequire()
...
Previously, createRequire() does not preserve the URL it gets
passed in the mock parent module created, which can be
observable if it's used together with module.registerHooks().
This patch adds preservation of the URL if createRequire()
is invoked with one.
PR-URL: https://github.com/nodejs/node/pull/60974
Fixes: https://github.com/nodejs/node/issues/60973
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
2025-12-13 07:36:20 +00:00
Antoine du Hamel
14f02fc2f7
lib,src,test: fix tests without SQLite
...
PR-URL: https://github.com/nodejs/node/pull/60906
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2025-12-11 23:04:24 +01:00
Robin van Wijngaarden
4db307a4b0
fs: detect dot files when using globstar
...
Using globstar in glob pattern should not prevent dot (hidden) files
from being matched.
PR-URL: https://github.com/nodejs/node/pull/61012
Fixes: https://github.com/nodejs/node/issues/56321
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
2025-12-11 21:12:03 +00:00
Antoine du Hamel
79df8b209b
lib,test: enforce use of assert.fail via a lint rule
...
PR-URL: https://github.com/nodejs/node/pull/61004
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk >
2025-12-11 15:23:33 +01:00
Antoine du Hamel
029ebac19d
test: simplify test-cli-node-options-docs
...
PR-URL: https://github.com/nodejs/node/pull/61006
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Erick Wendel <erick.workspace@gmail.com >
2025-12-11 14:13:35 +00:00
Erick Wendel
e705603a6f
util: add convertProcessSignalToExitCode utility
...
Add convertProcessSignalToExitCode() to convert signal names to POSIX
exit codes (128 + signal number). Exposed in public util API.
Refs: https://github.com/nodejs/node/pull/60720
PR-URL: https://github.com/nodejs/node/pull/60963
Reviewed-By: Anna Henningsen <anna@addaleax.net >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Moshe Atlow <moshe@atlow.co.il >
2025-12-11 13:25:21 +00:00
René
a1f421feb6
sqlite: make SQLTagStore.prototype.size a getter
...
Drive-by: make callback `args` parameter names consistent
PR-URL: https://github.com/nodejs/node/pull/60246
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
2025-12-11 02:29:09 +00:00
azadgupta1
060deae99b
util: fix parseArgs skipping positional arg with --eval and --print
...
PR-URL: https://github.com/nodejs/node/pull/60814
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk >
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com >
2025-12-11 01:09:02 +00:00
Antoine du Hamel
e50cbc1abd
test: enforce better never-settling-promise detection
...
Tests should be explicit regarding whether a promise is expected to
settle, and the test should fail when the behavior does not meet
expectations.
PR-URL: https://github.com/nodejs/node/pull/60976
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Erick Wendel <erick.workspace@gmail.com >
2025-12-10 23:55:36 +00:00
Pietro Marchini
410174c3c4
test_runner: propagate V8 options to child process
...
PR-URL: https://github.com/nodejs/node/pull/60999
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com >
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
Reviewed-By: Jacob Smith <jacob@frende.me >
2025-12-11 00:47:56 +01:00
Stewart X Addison
e28656a617
test: mark stringbytes-external-max flaky on AIX
...
Signed-off-by: Stewart X Addison <sxa@ibm.com >
PR-URL: https://github.com/nodejs/node/pull/60995
Reviewed-By: Richard Lau <richard.lau@ibm.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2025-12-10 17:11:42 +00:00
Joyee Cheung
c0108bfc55
http: add http.setGlobalProxyFromEnv()
...
This adds an API to dynamically enable built-in proxy support
for all of fetch() and http.request()/https.request(), so
that users do not have to be aware of them all and configure them
one by one.
PR-URL: https://github.com/nodejs/node/pull/60953
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Tim Perry <pimterry@gmail.com >
2025-12-10 16:12:28 +00:00
Chengzhong Wu
32ea48d749
lib,src: isInsideNodeModules should test on the first non-internal frame
...
PR-URL: https://github.com/nodejs/node/pull/60991
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Daniel Lemire <daniel@lemire.me >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2025-12-10 13:59:35 +00:00
Rich Trott
83ba6b107a
test: update test426 fixtures
...
Update test426 fixtures for source map tests.
Refs: https://github.com/tc39/source-map-tests
PR-URL: https://github.com/nodejs/node/pull/60982
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-12-09 14:38:02 +00:00
Node.js GitHub Bot
e172be2698
test: update WPT for urlpattern to aed1f3d244
...
PR-URL: https://github.com/nodejs/node/pull/60642
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2025-12-08 18:54:38 +00:00
Livia Medeiros
381be1e8a2
test: deflake test-repl-paste-big-data
...
PR-URL: https://github.com/nodejs/node/pull/60975
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-12-08 13:42:52 +00:00
Antoine du Hamel
6e474c024c
test: skip tests not passing without NODE_OPTIONS support
...
PR-URL: https://github.com/nodejs/node/pull/60912
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2025-12-07 20:28:57 +00:00
mag123c
37d9cfcd3a
esm: improve error messages for ambiguous module syntax
...
PR-URL: https://github.com/nodejs/node/pull/60376
Fixes: https://github.com/nodejs/node/issues/60322
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2025-12-05 23:51:23 +00:00
Rafael Gonzaga
cbe02339b6
test: improve config-file permission test coverage
...
Refs: https://github.com/nodejs/node/pull/60746#pullrequestreview-3470430664
PR-URL: https://github.com/nodejs/node/pull/60929
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-12-05 11:58:29 +00:00
Mert Can Altin
f65b0bc81a
src: implement Windows-1252 encoding support and update related tests
...
PR-URL: https://github.com/nodejs/node/pull/60893
Fixes: https://github.com/nodejs/node/issues/60888
Fixes: https://github.com/nodejs/node/issues/59515
Fixes: https://github.com/nodejs/node/issues/56542
Reviewed-By: Matteo Collina <matteo.collina@gmail.com >
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com >
2025-12-04 14:23:01 +00:00
Jan Olaf Martin
e8c9c43336
module: allow subpath imports that start with #/
...
It's a common ecosystem pattern to map a source root directory to
`@/` but it requires special tooling support. This turns `#/*` into
a more realistic alternative for that pattern.
PR-URL: https://github.com/nodejs/node/pull/60864
Reviewed-By: Guy Bedford <guybedford@gmail.com >
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com >
Reviewed-By: Claudio Wunder <cwunder@gnome.org >
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com >
2025-12-04 02:27:04 +00:00
Chengzhong Wu
746c3c2ec2
util: assert getCallSites does not invoke Error.prepareStackTrace
...
PR-URL: https://github.com/nodejs/node/pull/60922
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Ilyas Shabi <ilyasshabi94@gmail.com >
2025-12-03 17:53:07 +00:00
Antoine du Hamel
987740399d
tools: enforce trailing commas in test/es-module
...
PR-URL: https://github.com/nodejs/node/pull/60891
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2025-12-03 14:18:40 +01:00
Antoine du Hamel
441027af47
tools: enforce trailing commas in test/sequential
...
PR-URL: https://github.com/nodejs/node/pull/60892
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com >
2025-12-03 14:17:37 +01:00
René
ecdf6a8c53
stream: fix isErrored/isWritable for WritableStreams
...
PR-URL: https://github.com/nodejs/node/pull/60905
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com >
2025-12-03 13:08:34 +00:00
Livia Medeiros
4ea921bdbf
test: skip SEA inspect test if inspector is not available
...
PR-URL: https://github.com/nodejs/node/pull/60872
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-12-02 11:46:50 +00:00
Joyee Cheung
6432765a9c
src: fix off-thread cert loading in bundled cert mode
...
https://redirect.github.com/nodejs/node/pull/59856 had an typo/mistake
in the skip conditions so that it is skipping when --use-openssl-ca
or --openssl-system-ca-path (configure time) are NOT used, even
though they should be skipped only when those ARE used (which is
not the default for default builds). This change fixes that so
that the perf numbers in that PR is true for the default build.
PR-URL: https://github.com/nodejs/node/pull/60764
Reviewed-By: Aditi Singh <aditisingh1400@gmail.com >
Reviewed-By: James M Snell <jasnell@gmail.com >
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
2025-12-02 09:51:06 +00:00
Node.js GitHub Bot
abe7de96ef
test: update WPT for WebCryptoAPI to 1e4933113d
...
PR-URL: https://github.com/nodejs/node/pull/60896
Reviewed-By: Michaël Zasso <targos@protonmail.com >
Reviewed-By: Filip Skokan <panva.ip@gmail.com >
Reviewed-By: Jason Zhang <xzha4350@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-12-02 00:39:47 +00:00
Filip Skokan
94cd600542
crypto: fix DOMException name for non-extractable key error
...
PR-URL: https://github.com/nodejs/node/pull/60830
Reviewed-By: Chemi Atlow <chemi@atlow.co.il >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: LiviaMedeiros <livia@cirno.name >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Tobias Nießen <tniessen@tnie.de >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
2025-11-30 21:45:27 +00:00
René
209a4fe812
test: lint more assert(regexp.test(...)) cases
...
PR-URL: https://github.com/nodejs/node/pull/60878
Refs: https://github.com/nodejs/node/pull/60832
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
2025-11-30 18:39:38 +00:00
Michaël Zasso
10837e33b0
lib,test: fix jsdoc comments
...
To prepare for eslint-plugin-jsdoc update.
Refs: https://github.com/nodejs/node/pull/60535
PR-URL: https://github.com/nodejs/node/pull/60870
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com >
Reviewed-By: Chengzhong Wu <legendecas@gmail.com >
Reviewed-By: Colin Ihrig <cjihrig@gmail.com >
Reviewed-By: Luigi Pinca <luigipinca@gmail.com >
2025-11-30 19:14:12 +01:00